[jira] [Commented] (OAK-6055) update to latest apache parent pom (18)

2019-07-04 Thread Julian Reschke (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878709#comment-16878709
 ] 

Julian Reschke commented on OAK-6055:
-

trunk: (1.7.0) [r1790549|http://svn.apache.org/r1790549]
1.6: [r1862558|http://svn.apache.org/r1862558]


> update to latest apache parent pom (18)
> ---
>
> Key: OAK-6055
> URL: https://issues.apache.org/jira/browse/OAK-6055
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Affects Versions: 1.8.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.7.0, 1.8.0, 1.6.18
>
>
> https://svn.apache.org/viewvc/maven/pom/tags/apache-18/pom.xml?view=markup



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Issue Comment Deleted] (OAK-6055) update to latest apache parent pom (18)

2019-07-04 Thread Julian Reschke (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-6055:

Comment: was deleted

(was: trunk: [r1790549|http://svn.apache.org/r1790549]
)

> update to latest apache parent pom (18)
> ---
>
> Key: OAK-6055
> URL: https://issues.apache.org/jira/browse/OAK-6055
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Affects Versions: 1.8.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.7.0, 1.8.0, 1.6.18
>
>
> https://svn.apache.org/viewvc/maven/pom/tags/apache-18/pom.xml?view=markup



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-6055) update to latest apache parent pom (18)

2019-07-04 Thread Julian Reschke (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-6055:

Fix Version/s: 1.6.18

> update to latest apache parent pom (18)
> ---
>
> Key: OAK-6055
> URL: https://issues.apache.org/jira/browse/OAK-6055
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Affects Versions: 1.8.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.7.0, 1.8.0, 1.6.18
>
>
> https://svn.apache.org/viewvc/maven/pom/tags/apache-18/pom.xml?view=markup



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-6055) update to latest apache parent pom (18)

2019-07-04 Thread Julian Reschke (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-6055:

Labels: candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4  (was: 
candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4 candidate_oak_1_6)

> update to latest apache parent pom (18)
> ---
>
> Key: OAK-6055
> URL: https://issues.apache.org/jira/browse/OAK-6055
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Affects Versions: 1.8.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.7.0, 1.8.0
>
>
> https://svn.apache.org/viewvc/maven/pom/tags/apache-18/pom.xml?view=markup



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-7590) RDB*Store: update Tomcat JDBC pool dependency to 8.5.32

2019-07-04 Thread Julian Reschke (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7590:

Priority: Minor  (was: Major)

> RDB*Store: update Tomcat JDBC pool dependency to 8.5.32
> ---
>
> Key: OAK-7590
> URL: https://issues.apache.org/jira/browse/OAK-7590
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: documentmk, rdbmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_6
> Fix For: 1.10.0, 1.9.5, 1.8.8
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-8461) Test failure: FilterImplTest - The mock object was garbage collected

2019-07-04 Thread Marcel Reutegger (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger updated OAK-8461:
--
Description: 
No description is provided

The build Jackrabbit Oak #2261 has failed.
First failed run: [Jackrabbit Oak 
#2261|https://builds.apache.org/job/Jackrabbit%20Oak/2261/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2261/console]

{noformat}
[ERROR] 
testGetPrincipalSupportedRootPath(org.apache.jackrabbit.oak.spi.security.authorization.principalbased.impl.FilterImplTest)
  Time elapsed: 0.113 s  <<< ERROR!
java.lang.IllegalStateException: The mock object was garbage collected. This 
should not happen in normal circumstances when using public API. Typically, the 
test class keeps strong reference to the mock object and it prevents getting 
the mock collected. Mockito internally needs to keep weak references to mock 
objects to avoid memory leaks for certain types of MockMaker implementations. 
If you see this exception using Mockito public API, please file a bug. For more 
information see issue #1313.
at 
org.mockito.internal.invocation.mockref.MockWeakReference.get(MockWeakReference.java:32)
at 
org.mockito.internal.invocation.InterceptedInvocation.getMock(InterceptedInvocation.java:103)
at 
org.mockito.internal.stubbing.InvocationContainerImpl.invokedMock(InvocationContainerImpl.java:157)
at 
org.mockito.internal.stubbing.OngoingStubbingImpl.(OngoingStubbingImpl.java:22)
at 
org.mockito.internal.handler.MockHandlerImpl.handle(MockHandlerImpl.java:83)
at 
org.mockito.internal.handler.NullResultGuardian.handle(NullResultGuardian.java:29)
at 
org.mockito.internal.handler.InvocationNotifierHandler.handle(InvocationNotifierHandler.java:35)
at 
org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:61)
at 
org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:49)
at 
org.mockito.internal.creation.bytebuddy.MockMethodInterceptor$DispatcherDefaultingToRealMethod.interceptAbstract(MockMethodInterceptor.java:126)
at 
org.apache.jackrabbit.oak.spi.security.authorization.principalbased.impl.FilterProviderImpl$Configuration$MockitoMock$967171701.path(Unknown
 Source)
at 
org.apache.jackrabbit.oak.spi.security.authorization.principalbased.impl.AbstractPrincipalBasedTest.createFilterProviderImpl(AbstractPrincipalBasedTest.java:211)
at 
org.apache.jackrabbit.oak.spi.security.authorization.principalbased.impl.AbstractPrincipalBasedTest.getFilterProvider(AbstractPrincipalBasedTest.java:205)
at 
org.apache.jackrabbit.oak.spi.security.authorization.principalbased.impl.FilterImplTest.before(FilterImplTest.java:60)
{noformat}

  was:
No description is provided

The build Jackrabbit Oak #2261 has failed.
First failed run: [Jackrabbit Oak 
#2261|https://builds.apache.org/job/Jackrabbit%20Oak/2261/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2261/console]

Component/s: security
Summary: Test failure: FilterImplTest - The mock object was garbage 
collected  (was: Build Jackrabbit Oak #2261 failed)

> Test failure: FilterImplTest - The mock object was garbage collected
> 
>
> Key: OAK-8461
> URL: https://issues.apache.org/jira/browse/OAK-8461
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration, security
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2261 has failed.
> First failed run: [Jackrabbit Oak 
> #2261|https://builds.apache.org/job/Jackrabbit%20Oak/2261/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2261/console]
> {noformat}
> [ERROR] 
> testGetPrincipalSupportedRootPath(org.apache.jackrabbit.oak.spi.security.authorization.principalbased.impl.FilterImplTest)
>   Time elapsed: 0.113 s  <<< ERROR!
> java.lang.IllegalStateException: The mock object was garbage collected. This 
> should not happen in normal circumstances when using public API. Typically, 
> the test class keeps strong reference to the mock object and it prevents 
> getting the mock collected. Mockito internally needs to keep weak references 
> to mock objects to avoid memory leaks for certain types of MockMaker 
> implementations. If you see this exception using Mockito public API, please 
> file a bug. For more information see issue #1313.
>   at 
> org.mockito.internal.invocation.mockref.MockWeakReference.get(MockWeakReference.java:32)
>   at 
> org.mockito.internal.invocation.InterceptedInvocation.getMock(InterceptedInvocation.java:103)
>   at 
> org.mockito.internal.stubbing.InvocationContainerImpl.invokedMock(InvocationContainerImpl.java:157)
>

[jira] [Closed] (OAK-8414) Update jar-plugin dependency to 3.1.2

2019-07-04 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella closed OAK-8414.
-

bulk close 1.8.14

> Update jar-plugin dependency to 3.1.2
> -
>
> Key: OAK-8414
> URL: https://issues.apache.org/jira/browse/OAK-8414
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_6
> Fix For: 1.10.3, 1.8.14, 1.16.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OAK-8271) Lucene path transformed result doesn't accomodate wildcards in relative path

2019-07-04 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella closed OAK-8271.
-

bulk close 1.8.14

> Lucene path transformed result doesn't accomodate wildcards in relative path
> 
>
> Key: OAK-8271
> URL: https://issues.apache.org/jira/browse/OAK-8271
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 1.10.3, 1.8.14, 1.16.0
>
> Attachments: OAK-8271.patch
>
>
> {{LucenePropertyIndex}} support answering a query with property constraint on 
> a relative path if there's an property (non-relative) is indexed on 
> {{nt:base}}.
> e.g. with an index def such as
> {noformat}
> + /oak:index/fooIndex/indexRules/nt:base/properties
>+ foo
>- propertyIndex=true
> {noformat}
> we can answer queries such as
> {noformat}
> /jcr:root/a//element(*, some:type)[b/foo='bar']
> /jcr:root/a//element(*, some:type)[b/c/foo='bar']
> {noformat}
> In the same spirit it could also support query with wildcard in relative path 
> fragment
> {noformat}
> /jcr:root/a//element(*, some:type)[b/*/foo='bar']
> {noformat}
>  but it doesn't work currently.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OAK-8437) direct children, exact, and parent path restrictions don't work when path transformation takes place

2019-07-04 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella closed OAK-8437.
-

bulk close 1.8.14

> direct children, exact, and parent path restrictions don't work when path 
> transformation takes place
> 
>
> Key: OAK-8437
> URL: https://issues.apache.org/jira/browse/OAK-8437
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Major
> Fix For: 1.10.3, 1.8.14, 1.16.0
>
>
> An index such as:
> {noformat}
> + /oak:index/ntbaseIdx
>- evaluatePathRestrictions = true
>+ indexRules/nt:base/properties
>   + prop
>  - propertyIndex = true
> {noformat}
> attempts to answer a query such as:
> {noformat}
> /jcr:root/path/element(*, some:Type)[par/@prop='bar']
> {noformat}
> but current this query is planned by this index as
> {noformat}
> prop:bar :depth:[2 TO 2] :ancestors:/path
> {noformat}
> which won't get this result. This is because the depth constraint should've 
> been modified to {{:depth:\[3 TO 3]}}
> -Do note that even {{:ancestors}} constraint is wrong (too lenient).-
> So, the correct plan should've looked like:
> {noformat}
> prop:bar :depth:[3 TO 3] :ancestors:/path
> {noformat}
> Similar issue exist for exact and parent path restrictions (these don't need 
> evaluatePathRestriction as well)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OAK-8461) Build Jackrabbit Oak #2261 failed

2019-07-04 Thread Hudson (JIRA)
Hudson created OAK-8461:
---

 Summary: Build Jackrabbit Oak #2261 failed
 Key: OAK-8461
 URL: https://issues.apache.org/jira/browse/OAK-8461
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: continuous integration
Reporter: Hudson


No description is provided

The build Jackrabbit Oak #2261 has failed.
First failed run: [Jackrabbit Oak 
#2261|https://builds.apache.org/job/Jackrabbit%20Oak/2261/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2261/console]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-8448) VersionGC may get stuck at 60s scope

2019-07-04 Thread Julian Reschke (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878453#comment-16878453
 ] 

Julian Reschke commented on OAK-8448:
-

Proposed fix:  [^OAK-8448.diff] 

> VersionGC may get stuck at 60s scope 
> -
>
> Key: OAK-8448
> URL: https://issues.apache.org/jira/browse/OAK-8448
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Attachments: OAK-8448.diff, test.diff
>
>
> It seems that if the VersionGarbageCollector reduces the scope to a 60s 
> interval, it'll never change it back to a bigger interval. This is because 
> the collectLimit gets set to 0:
> {noformat}
> if (scope.getDurationMs() <= options.precisionMs) {
> // If we have narrowed the collect time interval down as much 
> as we can, no
> // longer enforce a limit. We need to get through this.
> collectLimit = 0;
> log.debug("time interval <= precision ({} ms), disabling 
> collection limits", options.precisionMs);
> }
> {noformat}
> ...and later on this is interpreted as "there were no restrictions in the 
> prior run that need to be updated":
> {noformat}
> if (maxCollect <= 0) {
> log.debug("successful run without effective limit, 
> keeping recommendations");
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-8448) VersionGC may get stuck at 60s scope

2019-07-04 Thread Julian Reschke (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8448:

Attachment: OAK-8448.diff

> VersionGC may get stuck at 60s scope 
> -
>
> Key: OAK-8448
> URL: https://issues.apache.org/jira/browse/OAK-8448
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Attachments: OAK-8448.diff, test.diff
>
>
> It seems that if the VersionGarbageCollector reduces the scope to a 60s 
> interval, it'll never change it back to a bigger interval. This is because 
> the collectLimit gets set to 0:
> {noformat}
> if (scope.getDurationMs() <= options.precisionMs) {
> // If we have narrowed the collect time interval down as much 
> as we can, no
> // longer enforce a limit. We need to get through this.
> collectLimit = 0;
> log.debug("time interval <= precision ({} ms), disabling 
> collection limits", options.precisionMs);
> }
> {noformat}
> ...and later on this is interpreted as "there were no restrictions in the 
> prior run that need to be updated":
> {noformat}
> if (maxCollect <= 0) {
> log.debug("successful run without effective limit, 
> keeping recommendations");
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-8449) LastRev check/fix in DocumentNodeStore MBean

2019-07-04 Thread Marcel Reutegger (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878441#comment-16878441
 ] 

Marcel Reutegger commented on OAK-8449:
---

Thanks [~vholani] for the patch. This looks already quite good. I have a few 
suggestions.

- Add a NotNull annotation to the path parameter of 
DocumentNodeStoreMBean.recover()
- Use Guava's Preconditions.checkNotNull() in the implementation to ensure the 
path is not null
- The check for clusterId == 0 and subsequently throwing a NullPointerException 
is strange. It would be good to check the clusterId is greater than 0, 
otherwise throw an IllegalArgumentException
- Add a note to the description of DocumentNodeStoreMBean.recover() that 
recover can only run on inactive clusterIds and what the behaviour is when the 
DocumentNodeStore is read-only.
- The for loop in the recover() implementation throws a DocumentStoreException 
when a document does not exist while traversing up the hierarchy. However, 
there may be valid gaps in the document hierarchy when descendant nodes are 
bundled. See 
https://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html
- Please extend the test or add more tests for cases like a read-only 
DocumentNodeStore and when an attempt is made to recover for an active 
clusterId. I would basically like to see full statement and branch coverage by 
the tests.

> LastRev check/fix in DocumentNodeStore MBean
> 
>
> Key: OAK-8449
> URL: https://issues.apache.org/jira/browse/OAK-8449
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: documentmk
>Reporter: Vinod Holani
>Assignee: Marcel Reutegger
>Priority: Minor
> Attachments: OAK-8449_1.patch
>
>
> There is existing tooling to check _lastRev consistency of documents in the 
> DocumentStore. Some of the tooling is limited to MongoDB because it is 
> implemented as utility functions for the MongoDB shell 
> ([oak-mongo.js|https://jackrabbit.apache.org/oak/docs/oak-mongo-js/oak.html]).
>  The oak-run 
> [recovery|https://github.com/apache/jackrabbit-oak/tree/trunk/oak-run#recovery-mode]
>  command was initially only available on MongoDB as well, but recently RDB 
> support was added (OAK-8004). The recovery command however has some 
> drawbacks. It scans the entire nodes collection, which can be a rather 
> expensive operation and when started in read-write mode.
> This improvement is about adding _lastRev check and fix functionality to the 
> DocumentNodeStore MBean. The scope of the check and fix would be limited to 
> some path(s) in order to keep the runtime of the operation low.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OAK-8449) LastRev check/fix in DocumentNodeStore MBean

2019-07-04 Thread Marcel Reutegger (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger reassigned OAK-8449:
-

Assignee: Marcel Reutegger

> LastRev check/fix in DocumentNodeStore MBean
> 
>
> Key: OAK-8449
> URL: https://issues.apache.org/jira/browse/OAK-8449
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: documentmk
>Reporter: Vinod Holani
>Assignee: Marcel Reutegger
>Priority: Minor
> Attachments: OAK-8449_1.patch
>
>
> There is existing tooling to check _lastRev consistency of documents in the 
> DocumentStore. Some of the tooling is limited to MongoDB because it is 
> implemented as utility functions for the MongoDB shell 
> ([oak-mongo.js|https://jackrabbit.apache.org/oak/docs/oak-mongo-js/oak.html]).
>  The oak-run 
> [recovery|https://github.com/apache/jackrabbit-oak/tree/trunk/oak-run#recovery-mode]
>  command was initially only available on MongoDB as well, but recently RDB 
> support was added (OAK-8004). The recovery command however has some 
> drawbacks. It scans the entire nodes collection, which can be a rather 
> expensive operation and when started in read-write mode.
> This improvement is about adding _lastRev check and fix functionality to the 
> DocumentNodeStore MBean. The scope of the check and fix would be limited to 
> some path(s) in order to keep the runtime of the operation low.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OAK-8460) Build Jackrabbit Oak #2257 failed

2019-07-04 Thread Marcel Reutegger (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger resolved OAK-8460.
---
Resolution: Duplicate

> Build Jackrabbit Oak #2257 failed
> -
>
> Key: OAK-8460
> URL: https://issues.apache.org/jira/browse/OAK-8460
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2257 has failed.
> First failed run: [Jackrabbit Oak 
> #2257|https://builds.apache.org/job/Jackrabbit%20Oak/2257/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2257/console]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OAK-8460) Build Jackrabbit Oak #2257 failed

2019-07-04 Thread Marcel Reutegger (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger closed OAK-8460.
-

> Build Jackrabbit Oak #2257 failed
> -
>
> Key: OAK-8460
> URL: https://issues.apache.org/jira/browse/OAK-8460
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2257 has failed.
> First failed run: [Jackrabbit Oak 
> #2257|https://builds.apache.org/job/Jackrabbit%20Oak/2257/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2257/console]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-8460) Build Jackrabbit Oak #2257 failed

2019-07-04 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-8460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878416#comment-16878416
 ] 

Hudson commented on OAK-8460:
-

Previously failing build now is OK.
 Passed run: [Jackrabbit Oak 
#2259|https://builds.apache.org/job/Jackrabbit%20Oak/2259/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2259/console]

> Build Jackrabbit Oak #2257 failed
> -
>
> Key: OAK-8460
> URL: https://issues.apache.org/jira/browse/OAK-8460
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2257 has failed.
> First failed run: [Jackrabbit Oak 
> #2257|https://builds.apache.org/job/Jackrabbit%20Oak/2257/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2257/console]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-7254) Indexes with excludedPaths, or includedPaths should not be picked for queries without path

2019-07-04 Thread Thomas Mueller (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Mueller updated OAK-7254:

Labels: indexingPatch  (was: )

> Indexes with excludedPaths, or includedPaths should not be picked for queries 
> without path
> --
>
> Key: OAK-7254
> URL: https://issues.apache.org/jira/browse/OAK-7254
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene, query
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Critical
>  Labels: indexingPatch
> Fix For: 1.16.0
>
>
> Queries that don't have a clear path restriction should not use indexes that 
> have excludedPaths or includedPaths set, except in some exceptional cases (to 
> be defined).
> For example, if a query doesn't have a path restriction, say:
> {noformat}
> /jcr:root//element(*, nt:base)[@status='RUNNING']
> {noformat}
> Then an index that has excludedPaths set (for example to /etc) shouldn't be 
> used, at least not if a different index is available. Currently it is used 
> currently, actually in _favor_ of another index, if the property "status" is 
> commonly used in /etc. Because of that, the index that doesn't have 
> excludedPath has a higher cost (as it indexes the property "status" in /etc, 
> and so has more entries for "status", than the index that doesn't index /etc).
> The same for includedPaths, in case queryPaths isn't set to the same value(s).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-8448) VersionGC may get stuck at 60s scope

2019-07-04 Thread Julian Reschke (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878407#comment-16878407
 ] 

Julian Reschke commented on OAK-8448:
-

trunk: [r1862537|http://svn.apache.org/r1862537]

> VersionGC may get stuck at 60s scope 
> -
>
> Key: OAK-8448
> URL: https://issues.apache.org/jira/browse/OAK-8448
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Attachments: test.diff
>
>
> It seems that if the VersionGarbageCollector reduces the scope to a 60s 
> interval, it'll never change it back to a bigger interval. This is because 
> the collectLimit gets set to 0:
> {noformat}
> if (scope.getDurationMs() <= options.precisionMs) {
> // If we have narrowed the collect time interval down as much 
> as we can, no
> // longer enforce a limit. We need to get through this.
> collectLimit = 0;
> log.debug("time interval <= precision ({} ms), disabling 
> collection limits", options.precisionMs);
> }
> {noformat}
> ...and later on this is interpreted as "there were no restrictions in the 
> prior run that need to be updated":
> {noformat}
> if (maxCollect <= 0) {
> log.debug("successful run without effective limit, 
> keeping recommendations");
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OAK-8453) Refactor VersionGarbageCollector to extract Recommendations class

2019-07-04 Thread Julian Reschke (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878009#comment-16878009
 ] 

Julian Reschke edited comment on OAK-8453 at 7/4/19 7:29 AM:
-

trunk: [r1862536|http://svn.apache.org/r1862536] 
[r1862499|http://svn.apache.org/r1862499] 
[r1862465|http://svn.apache.org/r1862465]


was (Author: reschke):
trunk: [r1862499|http://svn.apache.org/r1862499] 
[r1862465|http://svn.apache.org/r1862465]

> Refactor VersionGarbageCollector to extract Recommendations class
> -
>
> Key: OAK-8453
> URL: https://issues.apache.org/jira/browse/OAK-8453
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.16.0
>
> Attachments: OAK-8453.diff
>
>
> ...for easier use in unit tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OAK-8457) Constructor allows creating invalid path

2019-07-04 Thread Marcel Reutegger (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger resolved OAK-8457.
---
   Resolution: Fixed
Fix Version/s: 1.16.0

Fixed in trunk: http://svn.apache.org/r1862535

> Constructor allows creating invalid path
> 
>
> Key: OAK-8457
> URL: https://issues.apache.org/jira/browse/OAK-8457
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Affects Versions: 1.14.0
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.16.0
>
>
> The constructor {{Path(String)}} does not check whether the passed String is 
> in fact a node or rather a path (containing the slash character). The 
> constructor should throw an exception when the String represents a path with 
> more than one element.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-8459) Intermittent issue with MongoStatusTest

2019-07-04 Thread Marcel Reutegger (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger updated OAK-8459:
--
Fix Version/s: 1.10.3

Merged into 1.10 branch: http://svn.apache.org/r1862533

> Intermittent issue with MongoStatusTest
> ---
>
> Key: OAK-8459
> URL: https://issues.apache.org/jira/browse/OAK-8459
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: mongomk
>Reporter: Vinod Holani
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.10.3, 1.16.0
>
>
> Issue is happening while running test cases for a pull request for OAK, below 
> test case fails intermittently.
> Error stacktrace is as below :
> [INFO] Running 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest
>  [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
> 0.137 s <<< FAILURE! - in 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest
>  [ERROR] 
> unauthorized(org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest)
>  Time elapsed: 0.027 s <<< FAILURE!
>  java.lang.AssertionError
>  at org.junit.Assert.fail(Assert.java:86)
>  at org.junit.Assert.assertTrue(Assert.java:41)
>  at org.junit.Assert.assertNotNull(Assert.java:712)
>  at org.junit.Assert.assertNotNull(Assert.java:722)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1.unauthorizedIfServerStatus(MongoStatusTest.java:208)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1.access$000(MongoStatusTest.java:131)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1$1.runCommand(MongoStatusTest.java:155)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatus.getServerStatus(MongoStatus.java:241)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatus.getVersion(MongoStatus.java:149)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest.unauthorized(MongoStatusTest.java:214)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke(Method.java:498)
>  at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>  at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>  at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>  at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>  at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>  at 
> com.arakelian.docker.junit.DockerRule$StatementWithDockerRule.evaluate(DockerRule.java:76)
>  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>  at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>  at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>  at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>  at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>  at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>  at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>  at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
>  at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-8459) Intermittent issue with MongoStatusTest

2019-07-04 Thread Marcel Reutegger (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878365#comment-16878365
 ] 

Marcel Reutegger commented on OAK-8459:
---

Test was introduced with OAK-8122.

> Intermittent issue with MongoStatusTest
> ---
>
> Key: OAK-8459
> URL: https://issues.apache.org/jira/browse/OAK-8459
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: mongomk
>Reporter: Vinod Holani
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.16.0
>
>
> Issue is happening while running test cases for a pull request for OAK, below 
> test case fails intermittently.
> Error stacktrace is as below :
> [INFO] Running 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest
>  [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
> 0.137 s <<< FAILURE! - in 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest
>  [ERROR] 
> unauthorized(org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest)
>  Time elapsed: 0.027 s <<< FAILURE!
>  java.lang.AssertionError
>  at org.junit.Assert.fail(Assert.java:86)
>  at org.junit.Assert.assertTrue(Assert.java:41)
>  at org.junit.Assert.assertNotNull(Assert.java:712)
>  at org.junit.Assert.assertNotNull(Assert.java:722)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1.unauthorizedIfServerStatus(MongoStatusTest.java:208)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1.access$000(MongoStatusTest.java:131)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1$1.runCommand(MongoStatusTest.java:155)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatus.getServerStatus(MongoStatus.java:241)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatus.getVersion(MongoStatus.java:149)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest.unauthorized(MongoStatusTest.java:214)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke(Method.java:498)
>  at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>  at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>  at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>  at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>  at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>  at 
> com.arakelian.docker.junit.DockerRule$StatementWithDockerRule.evaluate(DockerRule.java:76)
>  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>  at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>  at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>  at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>  at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>  at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>  at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>  at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
>  at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OAK-8459) Intermittent issue with MongoStatusTest

2019-07-04 Thread Marcel Reutegger (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger resolved OAK-8459.
---
   Resolution: Fixed
Fix Version/s: 1.16.0

Fixed in trunk: http://svn.apache.org/r1862531

> Intermittent issue with MongoStatusTest
> ---
>
> Key: OAK-8459
> URL: https://issues.apache.org/jira/browse/OAK-8459
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: mongomk
>Reporter: Vinod Holani
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.16.0
>
>
> Issue is happening while running test cases for a pull request for OAK, below 
> test case fails intermittently.
> Error stacktrace is as below :
> [INFO] Running 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest
>  [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
> 0.137 s <<< FAILURE! - in 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest
>  [ERROR] 
> unauthorized(org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest)
>  Time elapsed: 0.027 s <<< FAILURE!
>  java.lang.AssertionError
>  at org.junit.Assert.fail(Assert.java:86)
>  at org.junit.Assert.assertTrue(Assert.java:41)
>  at org.junit.Assert.assertNotNull(Assert.java:712)
>  at org.junit.Assert.assertNotNull(Assert.java:722)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1.unauthorizedIfServerStatus(MongoStatusTest.java:208)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1.access$000(MongoStatusTest.java:131)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1$1.runCommand(MongoStatusTest.java:155)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatus.getServerStatus(MongoStatus.java:241)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatus.getVersion(MongoStatus.java:149)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest.unauthorized(MongoStatusTest.java:214)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke(Method.java:498)
>  at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>  at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>  at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>  at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>  at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>  at 
> com.arakelian.docker.junit.DockerRule$StatementWithDockerRule.evaluate(DockerRule.java:76)
>  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>  at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>  at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>  at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>  at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>  at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>  at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>  at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
>  at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-8459) Intermittent issue with MongoStatusTest

2019-07-04 Thread Marcel Reutegger (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878358#comment-16878358
 ] 

Marcel Reutegger commented on OAK-8459:
---

Thanks for reporting this issue. Just recently, I saw this test failure as well 
when the test was running on a MongoDB replica-set. It appears the MongoDB 
primary address can be null when the replica-set is not yet fully ready. I'll 
change the test to fallback to some default address when there is none 
available. The test doesn't depend on a correct address in the exception.

> Intermittent issue with MongoStatusTest
> ---
>
> Key: OAK-8459
> URL: https://issues.apache.org/jira/browse/OAK-8459
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: mongomk
>Reporter: Vinod Holani
>Assignee: Marcel Reutegger
>Priority: Minor
>
> Issue is happening while running test cases for a pull request for OAK, below 
> test case fails intermittently.
> Error stacktrace is as below :
> [INFO] Running 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest
>  [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
> 0.137 s <<< FAILURE! - in 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest
>  [ERROR] 
> unauthorized(org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest)
>  Time elapsed: 0.027 s <<< FAILURE!
>  java.lang.AssertionError
>  at org.junit.Assert.fail(Assert.java:86)
>  at org.junit.Assert.assertTrue(Assert.java:41)
>  at org.junit.Assert.assertNotNull(Assert.java:712)
>  at org.junit.Assert.assertNotNull(Assert.java:722)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1.unauthorizedIfServerStatus(MongoStatusTest.java:208)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1.access$000(MongoStatusTest.java:131)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1$1.runCommand(MongoStatusTest.java:155)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatus.getServerStatus(MongoStatus.java:241)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatus.getVersion(MongoStatus.java:149)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest.unauthorized(MongoStatusTest.java:214)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke(Method.java:498)
>  at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>  at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>  at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>  at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>  at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>  at 
> com.arakelian.docker.junit.DockerRule$StatementWithDockerRule.evaluate(DockerRule.java:76)
>  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>  at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>  at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>  at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>  at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>  at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>  at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>  at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
>  at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)



--
This message was sent by Atlassian JIRA

[jira] [Updated] (OAK-8459) Intermittent issue with MongoStatusTest

2019-07-04 Thread Marcel Reutegger (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger updated OAK-8459:
--
Summary: Intermittent issue with MongoStatusTest  (was: Intermittent issue 
with org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest)

> Intermittent issue with MongoStatusTest
> ---
>
> Key: OAK-8459
> URL: https://issues.apache.org/jira/browse/OAK-8459
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: mongomk
>Reporter: Vinod Holani
>Assignee: Marcel Reutegger
>Priority: Minor
>
> Issue is happening while running test cases for a pull request for OAK, below 
> test case fails intermittently.
> Error stacktrace is as below :
> [INFO] Running 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest
>  [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
> 0.137 s <<< FAILURE! - in 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest
>  [ERROR] 
> unauthorized(org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest)
>  Time elapsed: 0.027 s <<< FAILURE!
>  java.lang.AssertionError
>  at org.junit.Assert.fail(Assert.java:86)
>  at org.junit.Assert.assertTrue(Assert.java:41)
>  at org.junit.Assert.assertNotNull(Assert.java:712)
>  at org.junit.Assert.assertNotNull(Assert.java:722)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1.unauthorizedIfServerStatus(MongoStatusTest.java:208)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1.access$000(MongoStatusTest.java:131)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1$1.runCommand(MongoStatusTest.java:155)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatus.getServerStatus(MongoStatus.java:241)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatus.getVersion(MongoStatus.java:149)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest.unauthorized(MongoStatusTest.java:214)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke(Method.java:498)
>  at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>  at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>  at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>  at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>  at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>  at 
> com.arakelian.docker.junit.DockerRule$StatementWithDockerRule.evaluate(DockerRule.java:76)
>  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>  at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>  at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>  at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>  at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>  at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>  at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>  at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
>  at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OAK-8459) Intermittent issue with org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest

2019-07-04 Thread Marcel Reutegger (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger reassigned OAK-8459:
-

Assignee: Marcel Reutegger

> Intermittent issue with 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest
> 
>
> Key: OAK-8459
> URL: https://issues.apache.org/jira/browse/OAK-8459
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: mongomk
>Reporter: Vinod Holani
>Assignee: Marcel Reutegger
>Priority: Minor
>
> Issue is happening while running test cases for a pull request for OAK, below 
> test case fails intermittently.
> Error stacktrace is as below :
> [INFO] Running 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest
>  [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
> 0.137 s <<< FAILURE! - in 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest
>  [ERROR] 
> unauthorized(org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest)
>  Time elapsed: 0.027 s <<< FAILURE!
>  java.lang.AssertionError
>  at org.junit.Assert.fail(Assert.java:86)
>  at org.junit.Assert.assertTrue(Assert.java:41)
>  at org.junit.Assert.assertNotNull(Assert.java:712)
>  at org.junit.Assert.assertNotNull(Assert.java:722)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1.unauthorizedIfServerStatus(MongoStatusTest.java:208)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1.access$000(MongoStatusTest.java:131)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest$1$1.runCommand(MongoStatusTest.java:155)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatus.getServerStatus(MongoStatus.java:241)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatus.getVersion(MongoStatus.java:149)
>  at 
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoStatusTest.unauthorized(MongoStatusTest.java:214)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke(Method.java:498)
>  at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>  at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>  at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>  at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>  at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>  at 
> com.arakelian.docker.junit.DockerRule$StatementWithDockerRule.evaluate(DockerRule.java:76)
>  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>  at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>  at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>  at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>  at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>  at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>  at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>  at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
>  at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-8449) LastRev check/fix in DocumentNodeStore MBean

2019-07-04 Thread Vinod Holani (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878333#comment-16878333
 ] 

Vinod Holani commented on OAK-8449:
---

[~mreutegg] please review attached patch

> LastRev check/fix in DocumentNodeStore MBean
> 
>
> Key: OAK-8449
> URL: https://issues.apache.org/jira/browse/OAK-8449
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: documentmk
>Reporter: Vinod Holani
>Priority: Minor
> Attachments: OAK-8449_1.patch
>
>
> There is existing tooling to check _lastRev consistency of documents in the 
> DocumentStore. Some of the tooling is limited to MongoDB because it is 
> implemented as utility functions for the MongoDB shell 
> ([oak-mongo.js|https://jackrabbit.apache.org/oak/docs/oak-mongo-js/oak.html]).
>  The oak-run 
> [recovery|https://github.com/apache/jackrabbit-oak/tree/trunk/oak-run#recovery-mode]
>  command was initially only available on MongoDB as well, but recently RDB 
> support was added (OAK-8004). The recovery command however has some 
> drawbacks. It scans the entire nodes collection, which can be a rather 
> expensive operation and when started in read-write mode.
> This improvement is about adding _lastRev check and fix functionality to the 
> DocumentNodeStore MBean. The scope of the check and fix would be limited to 
> some path(s) in order to keep the runtime of the operation low.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-8449) LastRev check/fix in DocumentNodeStore MBean

2019-07-04 Thread Vinod Holani (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Holani updated OAK-8449:
--
Attachment: OAK-8449_1.patch

> LastRev check/fix in DocumentNodeStore MBean
> 
>
> Key: OAK-8449
> URL: https://issues.apache.org/jira/browse/OAK-8449
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: documentmk
>Reporter: Vinod Holani
>Priority: Minor
> Attachments: OAK-8449_1.patch
>
>
> There is existing tooling to check _lastRev consistency of documents in the 
> DocumentStore. Some of the tooling is limited to MongoDB because it is 
> implemented as utility functions for the MongoDB shell 
> ([oak-mongo.js|https://jackrabbit.apache.org/oak/docs/oak-mongo-js/oak.html]).
>  The oak-run 
> [recovery|https://github.com/apache/jackrabbit-oak/tree/trunk/oak-run#recovery-mode]
>  command was initially only available on MongoDB as well, but recently RDB 
> support was added (OAK-8004). The recovery command however has some 
> drawbacks. It scans the entire nodes collection, which can be a rather 
> expensive operation and when started in read-write mode.
> This improvement is about adding _lastRev check and fix functionality to the 
> DocumentNodeStore MBean. The scope of the check and fix would be limited to 
> some path(s) in order to keep the runtime of the operation low.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)