[jira] [Commented] (OAK-7181) RDBDocumentStore: use try-with-resources for ChangesTracker
[ https://issues.apache.org/jira/browse/OAK-7181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881728#comment-16881728 ] Julian Reschke commented on OAK-7181: - trunk: (1.9.0) [r1821663|http://svn.apache.org/r1821663] 1.8: (1.8.4) [r1832136|http://svn.apache.org/r1832136] 1.6: [r1862847|http://svn.apache.org/r1862847] > RDBDocumentStore: use try-with-resources for ChangesTracker > --- > > Key: OAK-7181 > URL: https://issues.apache.org/jira/browse/OAK-7181 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Labels: candidate_oak_1_4 > Fix For: 1.9.0, 1.10.0, 1.8.4, 1.6.18 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (OAK-7181) RDBDocumentStore: use try-with-resources for ChangesTracker
[ https://issues.apache.org/jira/browse/OAK-7181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7181: Comment: was deleted (was: trunk: [r1821663|http://svn.apache.org/r1821663] 1.8: [r1832136|http://svn.apache.org/r1832136] ) > RDBDocumentStore: use try-with-resources for ChangesTracker > --- > > Key: OAK-7181 > URL: https://issues.apache.org/jira/browse/OAK-7181 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Labels: candidate_oak_1_4 > Fix For: 1.9.0, 1.10.0, 1.8.4, 1.6.18 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7181) RDBDocumentStore: use try-with-resources for ChangesTracker
[ https://issues.apache.org/jira/browse/OAK-7181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7181: Labels: candidate_oak_1_4 (was: candidate_oak_1_6) > RDBDocumentStore: use try-with-resources for ChangesTracker > --- > > Key: OAK-7181 > URL: https://issues.apache.org/jira/browse/OAK-7181 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Labels: candidate_oak_1_4 > Fix For: 1.9.0, 1.10.0, 1.8.4, 1.6.18 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7181) RDBDocumentStore: use try-with-resources for ChangesTracker
[ https://issues.apache.org/jira/browse/OAK-7181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7181: Fix Version/s: 1.6.18 > RDBDocumentStore: use try-with-resources for ChangesTracker > --- > > Key: OAK-7181 > URL: https://issues.apache.org/jira/browse/OAK-7181 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Labels: candidate_oak_1_6 > Fix For: 1.9.0, 1.10.0, 1.8.4, 1.6.18 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-8465) Build Jackrabbit Oak #2269 failed
Hudson created OAK-8465: --- Summary: Build Jackrabbit Oak #2269 failed Key: OAK-8465 URL: https://issues.apache.org/jira/browse/OAK-8465 Project: Jackrabbit Oak Issue Type: Bug Components: continuous integration Reporter: Hudson No description is provided The build Jackrabbit Oak #2269 has failed. First failed run: [Jackrabbit Oak #2269|https://builds.apache.org/job/Jackrabbit%20Oak/2269/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/2269/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-6083) RDBDocumentStore: implement support for VersionGCSupport extensions added for OAK-4780
[ https://issues.apache.org/jira/browse/OAK-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-6083: Labels: (was: candidate_oak_1_6) > RDBDocumentStore: implement support for VersionGCSupport extensions added for > OAK-4780 > -- > > Key: OAK-6083 > URL: https://issues.apache.org/jira/browse/OAK-6083 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: documentmk, rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Fix For: 1.7.0, 1.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-7886) Re-registering node type may corrupt registry
[
https://issues.apache.org/jira/browse/OAK-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872114#comment-16872114
]
Julian Reschke edited comment on OAK-7886 at 7/9/19 3:40 PM:
-
trunk: (1.9.11) [r1846162|http://svn.apache.org/r1846162]
[r1846057|http://svn.apache.org/r1846057]
1.8: (1.8.14) [r1862036|http://svn.apache.org/r1862036] (1.8.10)
[r1846170|http://svn.apache.org/r1846170]
1.6: [r1862820|http://svn.apache.org/r1862820] (1.6.15)
[r1846171|http://svn.apache.org/r1846171]
1.4: (1.4.24) [r1846175|http://svn.apache.org/r1846175]
1.2: (1.2.31) [r1846176|http://svn.apache.org/r1846176]
1.0: [r1846177|http://svn.apache.org/r1846177]
was (Author: reschke):
trunk: (1.9.11) [r1846162|http://svn.apache.org/r1846162]
[r1846057|http://svn.apache.org/r1846057]
1.8: [r1862036|http://svn.apache.org/r1862036] (1.8.10)
[r1846170|http://svn.apache.org/r1846170]
1.6: (1.6.15) [r1846171|http://svn.apache.org/r1846171]
1.4: (1.4.24) [r1846175|http://svn.apache.org/r1846175]
1.2: (1.2.31) [r1846176|http://svn.apache.org/r1846176]
1.0: [r1846177|http://svn.apache.org/r1846177]
> Re-registering node type may corrupt registry
> -
>
> Key: OAK-7886
> URL: https://issues.apache.org/jira/browse/OAK-7886
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Affects Versions: 1.0, 1.2, 1.4.0, 1.6.0, 1.8.0
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
> Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.10.0, 1.9.11, 1.6.18, 1.8.14
>
> Attachments: OAK-7886.patch
>
>
> Re-registering an existing node type may corrupt the registry. This happens
> for node types that are not mixins and do not extend from other primary types
> (except for the implicit {{nt:base}}). After re-registering such a node type
> the {{jcr:supertypes}} list does not have the {{nt:base}} anymore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-7886) Re-registering node type may corrupt registry
[
https://issues.apache.org/jira/browse/OAK-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-7886:
Labels: candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4 (was:
candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4 candidate_oak_1_6)
> Re-registering node type may corrupt registry
> -
>
> Key: OAK-7886
> URL: https://issues.apache.org/jira/browse/OAK-7886
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Affects Versions: 1.0, 1.2, 1.4.0, 1.6.0, 1.8.0
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
> Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.10.0, 1.9.11, 1.6.18, 1.8.14
>
> Attachments: OAK-7886.patch
>
>
> Re-registering an existing node type may corrupt the registry. This happens
> for node types that are not mixins and do not extend from other primary types
> (except for the implicit {{nt:base}}). After re-registering such a node type
> the {{jcr:supertypes}} list does not have the {{nt:base}} anymore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-7886) Re-registering node type may corrupt registry
[
https://issues.apache.org/jira/browse/OAK-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-7886:
Fix Version/s: 1.6.18
> Re-registering node type may corrupt registry
> -
>
> Key: OAK-7886
> URL: https://issues.apache.org/jira/browse/OAK-7886
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Affects Versions: 1.0, 1.2, 1.4.0, 1.6.0, 1.8.0
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
> Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4,
> candidate_oak_1_6
> Fix For: 1.10.0, 1.9.11, 1.6.18, 1.8.14
>
> Attachments: OAK-7886.patch
>
>
> Re-registering an existing node type may corrupt the registry. This happens
> for node types that are not mixins and do not extend from other primary types
> (except for the implicit {{nt:base}}). After re-registering such a node type
> the {{jcr:supertypes}} list does not have the {{nt:base}} anymore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OAK-6852) RDBDocumentStore conditional remove: check condition properly
[ https://issues.apache.org/jira/browse/OAK-6852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226538#comment-16226538 ] Julian Reschke edited comment on OAK-6852 at 7/9/19 2:46 PM: - trunk: (1.7.10) [r1812753|http://svn.apache.org/r1812753] [r1812750|http://svn.apache.org/r1812750] 1.6: (1.6.7) [r1813865|http://svn.apache.org/r1813865] was (Author: reschke): trunk: [r1812753|http://svn.apache.org/r1812753] [r1812750|http://svn.apache.org/r1812750] 1.6: [r1813865|http://svn.apache.org/r1813865] > RDBDocumentStore conditional remove: check condition properly > - > > Key: OAK-6852 > URL: https://issues.apache.org/jira/browse/OAK-6852 > Project: Jackrabbit Oak > Issue Type: Bug > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4 > Fix For: 1.7.10, 1.6.7, 1.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8453) Refactor VersionGarbageCollector to extract Recommendations class
[ https://issues.apache.org/jira/browse/OAK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881273#comment-16881273 ] Julian Reschke commented on OAK-8453: - trunk: [r1862817|http://svn.apache.org/r1862817] [r1862536|http://svn.apache.org/r1862536] [r1862499|http://svn.apache.org/r1862499] [r1862465|http://svn.apache.org/r1862465] > Refactor VersionGarbageCollector to extract Recommendations class > - > > Key: OAK-8453 > URL: https://issues.apache.org/jira/browse/OAK-8453 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.16.0 > > Attachments: OAK-8453.diff > > > ...for easier use in unit tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (OAK-8453) Refactor VersionGarbageCollector to extract Recommendations class
[ https://issues.apache.org/jira/browse/OAK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8453: Comment: was deleted (was: trunk: [r1862536|http://svn.apache.org/r1862536] [r1862499|http://svn.apache.org/r1862499] [r1862465|http://svn.apache.org/r1862465]) > Refactor VersionGarbageCollector to extract Recommendations class > - > > Key: OAK-8453 > URL: https://issues.apache.org/jira/browse/OAK-8453 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.16.0 > > Attachments: OAK-8453.diff > > > ...for easier use in unit tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-5949) XPath: string literals parsed as identifiers
[
https://issues.apache.org/jira/browse/OAK-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881267#comment-16881267
]
Julian Reschke commented on OAK-5949:
-
trunk: (1.7.0) [r1793013|http://svn.apache.org/r1793013]
1.6: (1.6.3) [r1800405|http://svn.apache.org/r1800405]
1.4: (1.4.17) [r1800422|http://svn.apache.org/r1800422]
1.2: (1.2.27) [r1800602|http://svn.apache.org/r1800602]
> XPath: string literals parsed as identifiers
>
>
> Key: OAK-5949
> URL: https://issues.apache.org/jira/browse/OAK-5949
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Critical
> Labels: candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.7.1, 1.2.27, 1.4.17, 1.6.3, 1.8.0
>
>
> The following query (for example) is not parsed correctly, as {{@}} is parsed
> as attribute prefix:
> {noformat}
> /jcr:root/home//element(*,rep:Authorizable)[jcr:like(@rep:authorizableId,'@')]
> {noformat}
> Possibly XPathToSQL2Converter should use currentTokenQuoted for this.
> Possibly a similar problem can occur in SQL2Parser (needs to be tested).
> Right now, it looks like currentTokenQuoted is never set to true; that should
> probably happen in read().
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8461) Test failure: FilterImplTest - The mock object was garbage collected
[
https://issues.apache.org/jira/browse/OAK-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881264#comment-16881264
]
Hudson commented on OAK-8461:
-
Previously failing build now is OK.
Passed run: [Jackrabbit Oak
#2268|https://builds.apache.org/job/Jackrabbit%20Oak/2268/] [console
log|https://builds.apache.org/job/Jackrabbit%20Oak/2268/console]
> Test failure: FilterImplTest - The mock object was garbage collected
>
>
> Key: OAK-8461
> URL: https://issues.apache.org/jira/browse/OAK-8461
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: continuous integration, security
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2261 has failed.
> First failed run: [Jackrabbit Oak
> #2261|https://builds.apache.org/job/Jackrabbit%20Oak/2261/] [console
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2261/console]
> {noformat}
> [ERROR]
> testGetPrincipalSupportedRootPath(org.apache.jackrabbit.oak.spi.security.authorization.principalbased.impl.FilterImplTest)
> Time elapsed: 0.113 s <<< ERROR!
> java.lang.IllegalStateException: The mock object was garbage collected. This
> should not happen in normal circumstances when using public API. Typically,
> the test class keeps strong reference to the mock object and it prevents
> getting the mock collected. Mockito internally needs to keep weak references
> to mock objects to avoid memory leaks for certain types of MockMaker
> implementations. If you see this exception using Mockito public API, please
> file a bug. For more information see issue #1313.
> at
> org.mockito.internal.invocation.mockref.MockWeakReference.get(MockWeakReference.java:32)
> at
> org.mockito.internal.invocation.InterceptedInvocation.getMock(InterceptedInvocation.java:103)
> at
> org.mockito.internal.stubbing.InvocationContainerImpl.invokedMock(InvocationContainerImpl.java:157)
> at
> org.mockito.internal.stubbing.OngoingStubbingImpl.(OngoingStubbingImpl.java:22)
> at
> org.mockito.internal.handler.MockHandlerImpl.handle(MockHandlerImpl.java:83)
> at
> org.mockito.internal.handler.NullResultGuardian.handle(NullResultGuardian.java:29)
> at
> org.mockito.internal.handler.InvocationNotifierHandler.handle(InvocationNotifierHandler.java:35)
> at
> org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:61)
> at
> org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:49)
> at
> org.mockito.internal.creation.bytebuddy.MockMethodInterceptor$DispatcherDefaultingToRealMethod.interceptAbstract(MockMethodInterceptor.java:126)
> at
> org.apache.jackrabbit.oak.spi.security.authorization.principalbased.impl.FilterProviderImpl$Configuration$MockitoMock$967171701.path(Unknown
> Source)
> at
> org.apache.jackrabbit.oak.spi.security.authorization.principalbased.impl.AbstractPrincipalBasedTest.createFilterProviderImpl(AbstractPrincipalBasedTest.java:211)
> at
> org.apache.jackrabbit.oak.spi.security.authorization.principalbased.impl.AbstractPrincipalBasedTest.getFilterProvider(AbstractPrincipalBasedTest.java:205)
> at
> org.apache.jackrabbit.oak.spi.security.authorization.principalbased.impl.FilterImplTest.before(FilterImplTest.java:60)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-5949) XPath: string literals parsed as identifiers
[
https://issues.apache.org/jira/browse/OAK-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-5949:
Labels: candidate_oak_1_2 candidate_oak_1_4 (was: candidate_oak_1_2
candidate_oak_1_4 candidate_oak_1_6)
> XPath: string literals parsed as identifiers
>
>
> Key: OAK-5949
> URL: https://issues.apache.org/jira/browse/OAK-5949
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Critical
> Labels: candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.7.1, 1.2.27, 1.4.17, 1.6.3, 1.8.0
>
>
> The following query (for example) is not parsed correctly, as {{@}} is parsed
> as attribute prefix:
> {noformat}
> /jcr:root/home//element(*,rep:Authorizable)[jcr:like(@rep:authorizableId,'@')]
> {noformat}
> Possibly XPathToSQL2Converter should use currentTokenQuoted for this.
> Possibly a similar problem can occur in SQL2Parser (needs to be tested).
> Right now, it looks like currentTokenQuoted is never set to true; that should
> probably happen in read().
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-3629) Index corruption seen with CopyOnRead when index definition is recreated
[
https://issues.apache.org/jira/browse/OAK-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-3629:
Summary: Index corruption seen with CopyOnRead when index definition is
recreated (was: Index corruption seen with CopyOnRead when index defnition is
recreated)
> Index corruption seen with CopyOnRead when index definition is recreated
>
>
> Key: OAK-3629
> URL: https://issues.apache.org/jira/browse/OAK-3629
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Blocker
> Fix For: 1.5.5, 1.6.0
>
>
> CopyOnRead logic relies on {{reindexCount}} to determine the name of
> directory in which index files would be copied. In normal flow if the index
> is reindexed then this count would get increased and newer index files would
> get copied to a new directory.
> However if the index definition node gets recreated due to some deployment
> process then this count gets reset to 0. Due to which newly created index
> files from reindexing would start getting copied to already existing
> directory and that can lead to corruption.
> So what happened here was
> # System started with index definition I1 and indexing got complete with
> index files saved under index/hash(indexpath)/1 (where 1 is current reindex
> count)
> # A new index definition package was deployed which reset the index count.
> Now reindex happened again and the CopyOnRead logic per current design reused
> the existing index directory. And it so happens that Lucene create file with
> same name and same size but different content. This trips the CopyOnRead
> defense of length based index corruption check and thus cause new lucene
> index to corrupt
> *Note that here corruption is transient i.e. persisted index is not
> corrupted*. Just that locally copied index gets corrupted. Cleaning up the
> index directory would fix the issue and that can be used as a workaround.
> *Fix*
> After discussing with [~tmueller] following approach can be used.
> Instead of relying on reindex count we can maintain a hidden randomly
> generated uuid and store it in the index config. This would be used to derive
> the name of directory on filesystem. If the index definition gets reset then
> the uuid can be regenerated.
> *Workaround*
> Clean the directory used by CopyOnRead which is /index before
> restart
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-3629) Index corruption seen with CopyOnRead when index defnition is recreated
[
https://issues.apache.org/jira/browse/OAK-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Mueller updated OAK-3629:
Labels: (was: candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4)
> Index corruption seen with CopyOnRead when index defnition is recreated
> ---
>
> Key: OAK-3629
> URL: https://issues.apache.org/jira/browse/OAK-3629
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Blocker
> Fix For: 1.5.5, 1.6.0
>
>
> CopyOnRead logic relies on {{reindexCount}} to determine the name of
> directory in which index files would be copied. In normal flow if the index
> is reindexed then this count would get increased and newer index files would
> get copied to a new directory.
> However if the index definition node gets recreated due to some deployment
> process then this count gets reset to 0. Due to which newly created index
> files from reindexing would start getting copied to already existing
> directory and that can lead to corruption.
> So what happened here was
> # System started with index definition I1 and indexing got complete with
> index files saved under index/hash(indexpath)/1 (where 1 is current reindex
> count)
> # A new index definition package was deployed which reset the index count.
> Now reindex happened again and the CopyOnRead logic per current design reused
> the existing index directory. And it so happens that Lucene create file with
> same name and same size but different content. This trips the CopyOnRead
> defense of length based index corruption check and thus cause new lucene
> index to corrupt
> *Note that here corruption is transient i.e. persisted index is not
> corrupted*. Just that locally copied index gets corrupted. Cleaning up the
> index directory would fix the issue and that can be used as a workaround.
> *Fix*
> After discussing with [~tmueller] following approach can be used.
> Instead of relying on reindex count we can maintain a hidden randomly
> generated uuid and store it in the index config. This would be used to derive
> the name of directory on filesystem. If the index definition gets reset then
> the uuid can be regenerated.
> *Workaround*
> Clean the directory used by CopyOnRead which is /index before
> restart
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-3629) Index corruption seen with CopyOnRead when index defnition is recreated
[
https://issues.apache.org/jira/browse/OAK-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881257#comment-16881257
]
Julian Reschke commented on OAK-3629:
-
trunk: (1.5.5) [r1751420|http://svn.apache.org/r1751420]
[r1751236|http://svn.apache.org/r1751236]
[r1750842|http://svn.apache.org/r1750842]
[r1750769|http://svn.apache.org/r1750769]
> Index corruption seen with CopyOnRead when index defnition is recreated
> ---
>
> Key: OAK-3629
> URL: https://issues.apache.org/jira/browse/OAK-3629
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Blocker
> Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.5.5, 1.6.0
>
>
> CopyOnRead logic relies on {{reindexCount}} to determine the name of
> directory in which index files would be copied. In normal flow if the index
> is reindexed then this count would get increased and newer index files would
> get copied to a new directory.
> However if the index definition node gets recreated due to some deployment
> process then this count gets reset to 0. Due to which newly created index
> files from reindexing would start getting copied to already existing
> directory and that can lead to corruption.
> So what happened here was
> # System started with index definition I1 and indexing got complete with
> index files saved under index/hash(indexpath)/1 (where 1 is current reindex
> count)
> # A new index definition package was deployed which reset the index count.
> Now reindex happened again and the CopyOnRead logic per current design reused
> the existing index directory. And it so happens that Lucene create file with
> same name and same size but different content. This trips the CopyOnRead
> defense of length based index corruption check and thus cause new lucene
> index to corrupt
> *Note that here corruption is transient i.e. persisted index is not
> corrupted*. Just that locally copied index gets corrupted. Cleaning up the
> index directory would fix the issue and that can be used as a workaround.
> *Fix*
> After discussing with [~tmueller] following approach can be used.
> Instead of relying on reindex count we can maintain a hidden randomly
> generated uuid and store it in the index config. This would be used to derive
> the name of directory on filesystem. If the index definition gets reset then
> the uuid can be regenerated.
> *Workaround*
> Clean the directory used by CopyOnRead which is /index before
> restart
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8351) Long running RGC remove and getmore operations
[
https://issues.apache.org/jira/browse/OAK-8351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated OAK-8351:
-
Description:
On a mongodb setup a long running revision garbage collection operation has
been witnessed. The query was running for hours. Doing a
{{planCacheSetFilter}}, which hinted mongodb to use a specific index, together
with killing the running command resolved the situation.
The problem was that mongodb generated a query plan which scored high (2.0003)
but included an index scan through the {{\_id_}} index (and the collection
contained millions of documents). It also generated other, better, plans, but
they all "only" had the same high score, so it seemed legitimate that mongodb
would choose this one.
The reason why this, problematic, query plan resulted in a high score seems to
be that it does indeed find 101 documents after entering the first "or" - but
during query execution it would also enter the other "or" parts where it has
chosen to do a {{\_id_}} index scan.
The query involved was:
{noformat}
{
"_sdType" : {
"$in" : [
50,
60,
70
]
},
"$or" : [
{
"_sdType" : 50
},
{
"_sdType" : 60
},
{
"_sdType" : 70,
"$or" : [
{
"_id" : /.*-1\/0/
},
{
"_id" : /[^-]*/,
"_path" : /.*-1\/0/
}
],
"_sdMaxRevTime" : {
"$lt" : NumberLong(1551843365)
}
},
{
"_sdType" : 70,
"$or" : [
{
"_id" : /.*-2\/0/
},
{
"_id" : /[^-]*/,
"_path" : /.*-2\/0/
}
],
"_sdMaxRevTime" : {
[jira] [Commented] (OAK-8351) Long running RGC remove and getmore operations
[
https://issues.apache.org/jira/browse/OAK-8351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881252#comment-16881252
]
Stefan Egli commented on OAK-8351:
--
Note that this was primarily caused by
[SERVER-20616|https://jira.mongodb.org/browse/SERVER-20616] and that
[SERVER-42090|https://jira.mongodb.org/browse/SERVER-42090] and
[SERVER-24396|https://jira.mongodb.org/browse/SERVER-24396] would also have
been helpful preventing this.
> Long running RGC remove and getmore operations
> --
>
> Key: OAK-8351
> URL: https://issues.apache.org/jira/browse/OAK-8351
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Affects Versions: 1.12.0
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Fix For: 1.10.3, 1.16.0, 1.8.15
>
> Attachments: OAK-8351-1.10.patch, OAK-8351-1.8.patch,
> OAK-8351-merged-1.8.patch, OAK-8351.patch
>
>
> On a mongodb setup a long running revision garbage collection operation has
> been witnessed. The query was running for hours. Doing a
> {{planCacheSetFilter}}, which hinted mongodb to use a specific index,
> together with killing the running command resolved the situation.
> The problem was that mongodb generated a query plan which scored high
> (2.0003) but included an index scan through the {{\_id_}} index (and the
> collection contained millions of documents). It also generated other, better,
> plans, but they all "only" had the same high score, so it seemed legitimate
> that mongodb would choose this one.
> The reason why this, problematic, query plan resulted in a high score seems
> to be that it does indeed find 101 documents after entering the first "or" -
> but during query execution it would also enter the other "or" parts where it
> has chosen to do a {{\_id_}} index scan.
> The query involved was:
> {noformat}
> {
> "_sdType" : {
> "$in" : [
>
> 50,
>
> 60,
>
> 70
> ]
> },
> "$or" : [
> {
>
> "_sdType" : 50
> },
> {
>
> "_sdType" : 60
> },
> {
>
> "_sdType" : 70,
>
> "$or" : [
>
> {
>
> "_id" : /.*-1\/0/
>
> },
>
> {
>
> "_id" : /[^-]*/,
>
> "_path" : /.*-1\/0/
>
> }
>
> ],
>
> "_sdMaxRevTime" : {
>
> "$lt" : NumberLong(1551843365)
>
> }
> },
> {
>
> "_sdType" : 70,
>
> "$or" : [
>
>
[jira] [Updated] (OAK-5418) Test failure: TomcatIT.testTomcat()
[ https://issues.apache.org/jira/browse/OAK-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-5418: -- Fix Version/s: (was: 1.4.25) 1.4.26 > Test failure: TomcatIT.testTomcat() > --- > > Key: OAK-5418 > URL: https://issues.apache.org/jira/browse/OAK-5418 > Project: Jackrabbit Oak > Issue Type: Test > Components: continuous integration, examples >Affects Versions: 1.4 >Reporter: Hudson >Assignee: Chetan Mehrotra >Priority: Major > Labels: test-failure, ubuntu > Fix For: 1.4.26 > > > Jenkins CI failure: > https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ > The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.7 > (latest),nsfixtures=DOCUMENT_NS,profile=unittesting #1357 has failed. > First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK > 1.7 (latest),nsfixtures=DOCUMENT_NS,profile=unittesting > #1357|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=DOCUMENT_NS,profile=unittesting/1357/] > [console > log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=DOCUMENT_NS,profile=unittesting/1357/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-5566) TestFailure: remote.http.handler.RemoteServerIT.testPatchLastRevisionAddMultiReferenceProperty
[ https://issues.apache.org/jira/browse/OAK-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-5566: -- Fix Version/s: (was: 1.4.25) 1.4.26 > TestFailure: > remote.http.handler.RemoteServerIT.testPatchLastRevisionAddMultiReferenceProperty > -- > > Key: OAK-5566 > URL: https://issues.apache.org/jira/browse/OAK-5566 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration, remoting >Reporter: Hudson >Priority: Major > Labels: test-failure, ubuntu > Fix For: 1.4.26 > > > Jenkins CI failure: > https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ > The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.8 > (latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting #1396 has failed. > First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK > 1.8 (latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting > #1396|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting/1396/] > [console > log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting/1396/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-6976) CopyOnWriteDirectory_Segment_Test failure
[
https://issues.apache.org/jira/browse/OAK-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella updated OAK-6976:
--
Fix Version/s: (was: 1.4.25)
1.4.26
> CopyOnWriteDirectory_Segment_Test failure
> -
>
> Key: OAK-6976
> URL: https://issues.apache.org/jira/browse/OAK-6976
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.4.18
>Reporter: Marcel Reutegger
>Assignee: Chetan Mehrotra
>Priority: Major
> Fix For: 1.4.26
>
>
> This test only exists in branches 1.4 and older and was introduced as part of
> OAK-5238. The test fails every now and then with (stack trace from 1.4):
> {noformat}
> java.lang.IllegalStateException: This builder does not exist: child-0
> at
> com.google.common.base.Preconditions.checkState(Preconditions.java:150)
> at
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setProperty(MemoryNodeBuilder.java:506)
> at
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setProperty(MemoryNodeBuilder.java:515)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.CopyOnWriteDirectory_Segment_Test.writeTree(CopyOnWriteDirectory_Segment_Test.java:158)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.CopyOnWriteDirectory_Segment_Test.copyOnWrite(CopyOnWriteDirectory_Segment_Test.java:111)
> {noformat}
> Please note that it fails more likely when the update.limit is set to 100,
> which is the case for the maven build.
> I also ported the test to 1.6 and running it with the new segment-tar looks
> OK. I don't know if this is because the copy-on-write or the segment-tar
> implementation is different than in 1.4.
> The affected versions are currently only set to 1.4.18, because there were no
> releases off the 1.2 and 1.0 branches since OAK-5238 was backported.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-5470) Test failure: SecurityProviderRegistrationTest.testSecurityConfigurations2
[ https://issues.apache.org/jira/browse/OAK-5470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-5470: -- Fix Version/s: (was: 1.4.25) 1.4.26 > Test failure: SecurityProviderRegistrationTest.testSecurityConfigurations2 > -- > > Key: OAK-5470 > URL: https://issues.apache.org/jira/browse/OAK-5470 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration, pojosr >Affects Versions: 1.2.23, 1.4.13 >Reporter: Hudson >Priority: Major > Labels: test-failure, windows > Fix For: 1.4.26 > > Attachments: sysout-1380.log, unit-tests-build-1371.log, > unit-tests.log > > > Jenkins CI failure: > https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ > The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.7 > (latest),nsfixtures=SEGMENT_TAR,profile=unittesting #1371 has failed. > First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK > 1.7 (latest),nsfixtures=SEGMENT_TAR,profile=unittesting > #1371|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=SEGMENT_TAR,profile=unittesting/1371/] > [console > log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=SEGMENT_TAR,profile=unittesting/1371/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-7156) CacheChangesTracker should implement Closeable
[ https://issues.apache.org/jira/browse/OAK-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881207#comment-16881207 ] Julian Reschke edited comment on OAK-7156 at 7/9/19 1:12 PM: - trunk: (1.9.0) [r1821617|http://svn.apache.org/r1821617] 1.8: (1.8.4) [r1832109|http://svn.apache.org/r1832109] 1.6: [r1862808|http://svn.apache.org/r1862808] was (Author: reschke): trunk: (1.9.0) [r1821617|http://svn.apache.org/r1821617] 1.10: (1.9.0) [r1821617|http://svn.apache.org/r1821617] 1.8: (1.8.4) [r1832109|http://svn.apache.org/r1832109] 1.6: [r1862808|http://svn.apache.org/r1862808] > CacheChangesTracker should implement Closeable > -- > > Key: OAK-7156 > URL: https://issues.apache.org/jira/browse/OAK-7156 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_4 > Fix For: 1.9.0, 1.10.0, 1.8.4, 1.6.18 > > Attachments: OAK-7156.diff > > > So it can be used with try-with-resources... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7156) CacheChangesTracker should implement Closeable
[ https://issues.apache.org/jira/browse/OAK-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881207#comment-16881207 ] Julian Reschke commented on OAK-7156: - trunk: (1.9.0) [r1821617|http://svn.apache.org/r1821617] 1.10: (1.9.0) [r1821617|http://svn.apache.org/r1821617] 1.8: (1.8.4) [r1832109|http://svn.apache.org/r1832109] 1.6: [r1862808|http://svn.apache.org/r1862808] > CacheChangesTracker should implement Closeable > -- > > Key: OAK-7156 > URL: https://issues.apache.org/jira/browse/OAK-7156 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_4 > Fix For: 1.9.0, 1.10.0, 1.8.4, 1.6.18 > > Attachments: OAK-7156.diff > > > So it can be used with try-with-resources... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7156) CacheChangesTracker should implement Closeable
[ https://issues.apache.org/jira/browse/OAK-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7156: Labels: candidate_oak_1_4 (was: candidate_oak_1_6) > CacheChangesTracker should implement Closeable > -- > > Key: OAK-7156 > URL: https://issues.apache.org/jira/browse/OAK-7156 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_4 > Fix For: 1.9.0, 1.10.0, 1.8.4, 1.6.18 > > Attachments: OAK-7156.diff > > > So it can be used with try-with-resources... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7156) CacheChangesTracker should implement Closeable
[ https://issues.apache.org/jira/browse/OAK-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7156: Fix Version/s: 1.6.18 > CacheChangesTracker should implement Closeable > -- > > Key: OAK-7156 > URL: https://issues.apache.org/jira/browse/OAK-7156 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_6 > Fix For: 1.9.0, 1.10.0, 1.8.4, 1.6.18 > > Attachments: OAK-7156.diff > > > So it can be used with try-with-resources... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (OAK-7156) CacheChangesTracker should implement Closeable
[ https://issues.apache.org/jira/browse/OAK-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7156: Comment: was deleted (was: trunk: [r1821617|http://svn.apache.org/r1821617] 1.8: [r1832109|http://svn.apache.org/r1832109] ) > CacheChangesTracker should implement Closeable > -- > > Key: OAK-7156 > URL: https://issues.apache.org/jira/browse/OAK-7156 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_4 > Fix For: 1.9.0, 1.10.0, 1.8.4, 1.6.18 > > Attachments: OAK-7156.diff > > > So it can be used with try-with-resources... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8453) Refactor VersionGarbageCollector to extract Recommendations class
[ https://issues.apache.org/jira/browse/OAK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881201#comment-16881201 ] Marcel Reutegger commented on OAK-8453: --- My preference is using a separate logger. I'm also a bit concerned about changes you mentioned, but 11 out of the 12 usages are on debug, with only one on level WARN. > Refactor VersionGarbageCollector to extract Recommendations class > - > > Key: OAK-8453 > URL: https://issues.apache.org/jira/browse/OAK-8453 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.16.0 > > Attachments: OAK-8453.diff > > > ...for easier use in unit tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-7342) RDBDocumentStore: missing rollback after delete failures
[
https://issues.apache.org/jira/browse/OAK-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685342#comment-16685342
]
Julian Reschke edited comment on OAK-7342 at 7/9/19 12:46 PM:
--
trunk: (1.9.0) [r1826833|http://svn.apache.org/r1826833]
1.8: (1.8.10) [r1846518|http://svn.apache.org/r1846518]
1.6: [r1862807|http://svn.apache.org/r1862807]
was (Author: reschke):
trunk: [r1826833|http://svn.apache.org/r1826833]
1.8: [r1846518|http://svn.apache.org/r1846518]
> RDBDocumentStore: missing rollback after delete failures
>
>
> Key: OAK-7342
> URL: https://issues.apache.org/jira/browse/OAK-7342
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: rdbmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.9.0, 1.10.0, 1.8.10, 1.6.18
>
>
> There are a few places where after an exception, the connections isn't rolled
> back (harmless, if the connection pool does it for us).
> This can be detected when running with PostgreSQL and setting
> {noformat}
> -Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandler.CHECKCONNECTIONONCLOSE=true
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-7342) RDBDocumentStore: missing rollback after delete failures
[
https://issues.apache.org/jira/browse/OAK-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-7342:
Labels: candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4 (was:
candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4 candidate_oak_1_6)
> RDBDocumentStore: missing rollback after delete failures
>
>
> Key: OAK-7342
> URL: https://issues.apache.org/jira/browse/OAK-7342
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: rdbmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.9.0, 1.10.0, 1.8.10, 1.6.18
>
>
> There are a few places where after an exception, the connections isn't rolled
> back (harmless, if the connection pool does it for us).
> This can be detected when running with PostgreSQL and setting
> {noformat}
> -Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandler.CHECKCONNECTIONONCLOSE=true
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-7342) RDBDocumentStore: missing rollback after delete failures
[
https://issues.apache.org/jira/browse/OAK-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-7342:
Fix Version/s: 1.6.18
> RDBDocumentStore: missing rollback after delete failures
>
>
> Key: OAK-7342
> URL: https://issues.apache.org/jira/browse/OAK-7342
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: rdbmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4,
> candidate_oak_1_6
> Fix For: 1.9.0, 1.10.0, 1.8.10, 1.6.18
>
>
> There are a few places where after an exception, the connections isn't rolled
> back (harmless, if the connection pool does it for us).
> This can be detected when running with PostgreSQL and setting
> {noformat}
> -Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandler.CHECKCONNECTIONONCLOSE=true
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8448) VersionGC may get stuck at 60s scope
[
https://issues.apache.org/jira/browse/OAK-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881193#comment-16881193
]
Julian Reschke commented on OAK-8448:
-
trunk: [r1862806|http://svn.apache.org/r1862806]
[r1862537|http://svn.apache.org/r1862537]
> VersionGC may get stuck at 60s scope
> -
>
> Key: OAK-8448
> URL: https://issues.apache.org/jira/browse/OAK-8448
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Labels: candidate_oak_1_10
> Fix For: 1.16.0
>
> Attachments: OAK-8448.diff, test.diff
>
>
> It seems that if the VersionGarbageCollector reduces the scope to a 60s
> interval, it'll never change it back to a bigger interval. This is because
> the collectLimit gets set to 0:
> {noformat}
> if (scope.getDurationMs() <= options.precisionMs) {
> // If we have narrowed the collect time interval down as much
> as we can, no
> // longer enforce a limit. We need to get through this.
> collectLimit = 0;
> log.debug("time interval <= precision ({} ms), disabling
> collection limits", options.precisionMs);
> }
> {noformat}
> ...and later on this is interpreted as "there were no restrictions in the
> prior run that need to be updated":
> {noformat}
> if (maxCollect <= 0) {
> log.debug("successful run without effective limit,
> keeping recommendations");
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8448) VersionGC may get stuck at 60s scope
[
https://issues.apache.org/jira/browse/OAK-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8448:
Labels: candidate_oak_1_10 (was: )
> VersionGC may get stuck at 60s scope
> -
>
> Key: OAK-8448
> URL: https://issues.apache.org/jira/browse/OAK-8448
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Labels: candidate_oak_1_10
> Fix For: 1.16.0
>
> Attachments: OAK-8448.diff, test.diff
>
>
> It seems that if the VersionGarbageCollector reduces the scope to a 60s
> interval, it'll never change it back to a bigger interval. This is because
> the collectLimit gets set to 0:
> {noformat}
> if (scope.getDurationMs() <= options.precisionMs) {
> // If we have narrowed the collect time interval down as much
> as we can, no
> // longer enforce a limit. We need to get through this.
> collectLimit = 0;
> log.debug("time interval <= precision ({} ms), disabling
> collection limits", options.precisionMs);
> }
> {noformat}
> ...and later on this is interpreted as "there were no restrictions in the
> prior run that need to be updated":
> {noformat}
> if (maxCollect <= 0) {
> log.debug("successful run without effective limit,
> keeping recommendations");
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OAK-8448) VersionGC may get stuck at 60s scope
[
https://issues.apache.org/jira/browse/OAK-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke resolved OAK-8448.
-
Resolution: Fixed
Fix Version/s: 1.16.0
> VersionGC may get stuck at 60s scope
> -
>
> Key: OAK-8448
> URL: https://issues.apache.org/jira/browse/OAK-8448
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.16.0
>
> Attachments: OAK-8448.diff, test.diff
>
>
> It seems that if the VersionGarbageCollector reduces the scope to a 60s
> interval, it'll never change it back to a bigger interval. This is because
> the collectLimit gets set to 0:
> {noformat}
> if (scope.getDurationMs() <= options.precisionMs) {
> // If we have narrowed the collect time interval down as much
> as we can, no
> // longer enforce a limit. We need to get through this.
> collectLimit = 0;
> log.debug("time interval <= precision ({} ms), disabling
> collection limits", options.precisionMs);
> }
> {noformat}
> ...and later on this is interpreted as "there were no restrictions in the
> prior run that need to be updated":
> {noformat}
> if (maxCollect <= 0) {
> log.debug("successful run without effective limit,
> keeping recommendations");
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8453) Refactor VersionGarbageCollector to extract Recommendations class
[ https://issues.apache.org/jira/browse/OAK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881192#comment-16881192 ] Julian Reschke commented on OAK-8453: - That is/was intentional, because I wanted the change to have minimal effect on outside observers. But I agree that it would be logical/more consistent to use a separate logger. Should I make this change? > Refactor VersionGarbageCollector to extract Recommendations class > - > > Key: OAK-8453 > URL: https://issues.apache.org/jira/browse/OAK-8453 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.16.0 > > Attachments: OAK-8453.diff > > > ...for easier use in unit tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8235) Upgrade Solr to version 6.6.6
[ https://issues.apache.org/jira/browse/OAK-8235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881173#comment-16881173 ] Julian Reschke commented on OAK-8235: - Updating fixVersion to 1.8.15 because of [r1862800|http://svn.apache.org/r1862800] > Upgrade Solr to version 6.6.6 > - > > Key: OAK-8235 > URL: https://issues.apache.org/jira/browse/OAK-8235 > Project: Jackrabbit Oak > Issue Type: Task > Components: solr >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili >Priority: Major > Fix For: 1.10.3, 1.14.0, 1.8.15 > > > In order to support scenarios leveraging Solr as an Oak index, it is > recommended to upgrade to a supported version. > Having Solr 8 being released just recently, we could upgrade to that or to > 7.x, however I suggest to upgrade to Solr 6.6.6 which would require a more > flawless update for people using 5.5.5, because 6.x is back compatible with > 5.x. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8453) Refactor VersionGarbageCollector to extract Recommendations class
[ https://issues.apache.org/jira/browse/OAK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881174#comment-16881174 ] Marcel Reutegger commented on OAK-8453: --- While reviewing the fix for OAK-8448, I noticed the class VersionGCRecommendations uses the logger from VersionGarbageCollector. What do you think about using a separate logger for the VersionGCRecommendations class? > Refactor VersionGarbageCollector to extract Recommendations class > - > > Key: OAK-8453 > URL: https://issues.apache.org/jira/browse/OAK-8453 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.16.0 > > Attachments: OAK-8453.diff > > > ...for easier use in unit tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8235) Upgrade Solr to version 6.6.6
[ https://issues.apache.org/jira/browse/OAK-8235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8235: Fix Version/s: (was: 1.8.14) 1.8.15 > Upgrade Solr to version 6.6.6 > - > > Key: OAK-8235 > URL: https://issues.apache.org/jira/browse/OAK-8235 > Project: Jackrabbit Oak > Issue Type: Task > Components: solr >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili >Priority: Major > Fix For: 1.10.3, 1.14.0, 1.8.15 > > > In order to support scenarios leveraging Solr as an Oak index, it is > recommended to upgrade to a supported version. > Having Solr 8 being released just recently, we could upgrade to that or to > 7.x, however I suggest to upgrade to Solr 6.6.6 which would require a more > flawless update for people using 5.5.5, because 6.x is back compatible with > 5.x. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8235) Upgrade Solr to version 6.6.6
[ https://issues.apache.org/jira/browse/OAK-8235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881172#comment-16881172 ] Julian Reschke commented on OAK-8235: - trunk: (1.14.0) [r1857634|http://svn.apache.org/r1857634] [r1857480|http://svn.apache.org/r1857480] [r1857463|http://svn.apache.org/r1857463] 1.10: (1.10.3) [r1860928|http://svn.apache.org/r1860928] 1.8: [r1862800|http://svn.apache.org/r1862800] (1.8.14) [r1860932|http://svn.apache.org/r1860932] > Upgrade Solr to version 6.6.6 > - > > Key: OAK-8235 > URL: https://issues.apache.org/jira/browse/OAK-8235 > Project: Jackrabbit Oak > Issue Type: Task > Components: solr >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili >Priority: Major > Fix For: 1.10.3, 1.14.0, 1.8.14 > > > In order to support scenarios leveraging Solr as an Oak index, it is > recommended to upgrade to a supported version. > Having Solr 8 being released just recently, we could upgrade to that or to > 7.x, however I suggest to upgrade to Solr 6.6.6 which would require a more > flawless update for people using 5.5.5, because 6.x is back compatible with > 5.x. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8448) VersionGC may get stuck at 60s scope
[
https://issues.apache.org/jira/browse/OAK-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881169#comment-16881169
]
Marcel Reutegger commented on OAK-8448:
---
Looks good to me.
> VersionGC may get stuck at 60s scope
> -
>
> Key: OAK-8448
> URL: https://issues.apache.org/jira/browse/OAK-8448
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Attachments: OAK-8448.diff, test.diff
>
>
> It seems that if the VersionGarbageCollector reduces the scope to a 60s
> interval, it'll never change it back to a bigger interval. This is because
> the collectLimit gets set to 0:
> {noformat}
> if (scope.getDurationMs() <= options.precisionMs) {
> // If we have narrowed the collect time interval down as much
> as we can, no
> // longer enforce a limit. We need to get through this.
> collectLimit = 0;
> log.debug("time interval <= precision ({} ms), disabling
> collection limits", options.precisionMs);
> }
> {noformat}
> ...and later on this is interpreted as "there were no restrictions in the
> prior run that need to be updated":
> {noformat}
> if (maxCollect <= 0) {
> log.debug("successful run without effective limit,
> keeping recommendations");
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Issue Comment Deleted] (OAK-8235) Upgrade Solr to version 6.6.6
[ https://issues.apache.org/jira/browse/OAK-8235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8235: Comment: was deleted (was: trunk: (1.14.0) [r1857634|http://svn.apache.org/r1857634] [r1857480|http://svn.apache.org/r1857480] [r1857463|http://svn.apache.org/r1857463] 1.10: [r1860928|http://svn.apache.org/r1860928] 1.8: [r1860932|http://svn.apache.org/r1860932] ) > Upgrade Solr to version 6.6.6 > - > > Key: OAK-8235 > URL: https://issues.apache.org/jira/browse/OAK-8235 > Project: Jackrabbit Oak > Issue Type: Task > Components: solr >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili >Priority: Major > Fix For: 1.10.3, 1.14.0, 1.8.14 > > > In order to support scenarios leveraging Solr as an Oak index, it is > recommended to upgrade to a supported version. > Having Solr 8 being released just recently, we could upgrade to that or to > 7.x, however I suggest to upgrade to Solr 6.6.6 which would require a more > flawless update for people using 5.5.5, because 6.x is back compatible with > 5.x. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-5455) Specify versions for maven plugins used in build for ensuring stable builds
[
https://issues.apache.org/jira/browse/OAK-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881146#comment-16881146
]
Julian Reschke commented on OAK-5455:
-
trunk: (1.7.12) [r1815458|http://svn.apache.org/r1815458]
[r1815449|http://svn.apache.org/r1815449]
1.6: [r1862804|http://svn.apache.org/r1862804]
> Specify versions for maven plugins used in build for ensuring stable builds
> ---
>
> Key: OAK-5455
> URL: https://issues.apache.org/jira/browse/OAK-5455
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: parent
>Reporter: Chetan Mehrotra
>Assignee: Julian Reschke
>Priority: Major
> Labels: candidate_oak_1_4
> Fix For: 1.7.14, 1.8.0, 1.6.18
>
> Attachments: OAK-5455-v1.patch, enforce.diff
>
>
> Running a check for plugin versions used in oak build
> {noformat}
> mvn versions:display-plugin-updates
> {noformat}
> leads to following warning
> {noformat}
> [INFO] The following plugin updates are available:
> [INFO] org.apache.felix:maven-scr-plugin .. 1.16.0 -> 1.21.0
> [INFO]
> [WARNING] The following plugins do not have their version specified:
> [WARNING] maven-compiler-plugin .. 2.0.2
> [WARNING] maven-deploy-plugin . (from super-pom) 2.4
> [WARNING] maven-failsafe-plugin . 2.12.4
> [WARNING] maven-jar-plugin . 2.1
> [WARNING] maven-javadoc-plugin . 2.0
> [WARNING] maven-release-plugin . (from super-pom) 2.0-beta-4
> [WARNING] maven-resources-plugin ... 2.2
> [WARNING] maven-surefire-plugin .. 2.4.2
> [INFO]
> [WARNING] Project does not define minimum Maven version, default is: 2.0
> [INFO] Plugins require minimum Maven version of: 3.0.5
> [INFO] Note: the super-pom from Maven 3.3.9 defines some of the plugin
> [INFO] versions and may be influencing the plugins required minimum
> Maven
> [INFO] version.
> [INFO]
> [ERROR] Project does not define required minimum version of Maven.
> [ERROR] Update the pom.xml to contain
> [ERROR]
> [ERROR] 3.0.5
> [ERROR]
> {noformat}
> As a fix we should
> # Specify version for all maven plugin in use
> # Specify minimum version of maven to be used (version used in CI is 3.2.1)
> # Configure enforcer plugin to ensure that in future no plugin is used
> without specifying the version [1]
> [1] http://maven.apache.org/enforcer/enforcer-rules/requirePluginVersions.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-5455) Specify versions for maven plugins used in build for ensuring stable builds
[
https://issues.apache.org/jira/browse/OAK-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-5455:
Fix Version/s: 1.6.18
> Specify versions for maven plugins used in build for ensuring stable builds
> ---
>
> Key: OAK-5455
> URL: https://issues.apache.org/jira/browse/OAK-5455
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: parent
>Reporter: Chetan Mehrotra
>Assignee: Julian Reschke
>Priority: Major
> Labels: candidate_oak_1_6
> Fix For: 1.7.14, 1.8.0, 1.6.18
>
> Attachments: OAK-5455-v1.patch, enforce.diff
>
>
> Running a check for plugin versions used in oak build
> {noformat}
> mvn versions:display-plugin-updates
> {noformat}
> leads to following warning
> {noformat}
> [INFO] The following plugin updates are available:
> [INFO] org.apache.felix:maven-scr-plugin .. 1.16.0 -> 1.21.0
> [INFO]
> [WARNING] The following plugins do not have their version specified:
> [WARNING] maven-compiler-plugin .. 2.0.2
> [WARNING] maven-deploy-plugin . (from super-pom) 2.4
> [WARNING] maven-failsafe-plugin . 2.12.4
> [WARNING] maven-jar-plugin . 2.1
> [WARNING] maven-javadoc-plugin . 2.0
> [WARNING] maven-release-plugin . (from super-pom) 2.0-beta-4
> [WARNING] maven-resources-plugin ... 2.2
> [WARNING] maven-surefire-plugin .. 2.4.2
> [INFO]
> [WARNING] Project does not define minimum Maven version, default is: 2.0
> [INFO] Plugins require minimum Maven version of: 3.0.5
> [INFO] Note: the super-pom from Maven 3.3.9 defines some of the plugin
> [INFO] versions and may be influencing the plugins required minimum
> Maven
> [INFO] version.
> [INFO]
> [ERROR] Project does not define required minimum version of Maven.
> [ERROR] Update the pom.xml to contain
> [ERROR]
> [ERROR] 3.0.5
> [ERROR]
> {noformat}
> As a fix we should
> # Specify version for all maven plugin in use
> # Specify minimum version of maven to be used (version used in CI is 3.2.1)
> # Configure enforcer plugin to ensure that in future no plugin is used
> without specifying the version [1]
> [1] http://maven.apache.org/enforcer/enforcer-rules/requirePluginVersions.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-5455) Specify versions for maven plugins used in build for ensuring stable builds
[
https://issues.apache.org/jira/browse/OAK-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-5455:
Labels: candidate_oak_1_4 (was: candidate_oak_1_6)
> Specify versions for maven plugins used in build for ensuring stable builds
> ---
>
> Key: OAK-5455
> URL: https://issues.apache.org/jira/browse/OAK-5455
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: parent
>Reporter: Chetan Mehrotra
>Assignee: Julian Reschke
>Priority: Major
> Labels: candidate_oak_1_4
> Fix For: 1.7.14, 1.8.0, 1.6.18
>
> Attachments: OAK-5455-v1.patch, enforce.diff
>
>
> Running a check for plugin versions used in oak build
> {noformat}
> mvn versions:display-plugin-updates
> {noformat}
> leads to following warning
> {noformat}
> [INFO] The following plugin updates are available:
> [INFO] org.apache.felix:maven-scr-plugin .. 1.16.0 -> 1.21.0
> [INFO]
> [WARNING] The following plugins do not have their version specified:
> [WARNING] maven-compiler-plugin .. 2.0.2
> [WARNING] maven-deploy-plugin . (from super-pom) 2.4
> [WARNING] maven-failsafe-plugin . 2.12.4
> [WARNING] maven-jar-plugin . 2.1
> [WARNING] maven-javadoc-plugin . 2.0
> [WARNING] maven-release-plugin . (from super-pom) 2.0-beta-4
> [WARNING] maven-resources-plugin ... 2.2
> [WARNING] maven-surefire-plugin .. 2.4.2
> [INFO]
> [WARNING] Project does not define minimum Maven version, default is: 2.0
> [INFO] Plugins require minimum Maven version of: 3.0.5
> [INFO] Note: the super-pom from Maven 3.3.9 defines some of the plugin
> [INFO] versions and may be influencing the plugins required minimum
> Maven
> [INFO] version.
> [INFO]
> [ERROR] Project does not define required minimum version of Maven.
> [ERROR] Update the pom.xml to contain
> [ERROR]
> [ERROR] 3.0.5
> [ERROR]
> {noformat}
> As a fix we should
> # Specify version for all maven plugin in use
> # Specify minimum version of maven to be used (version used in CI is 3.2.1)
> # Configure enforcer plugin to ensure that in future no plugin is used
> without specifying the version [1]
> [1] http://maven.apache.org/enforcer/enforcer-rules/requirePluginVersions.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Issue Comment Deleted] (OAK-5455) Specify versions for maven plugins used in build for ensuring stable builds
[
https://issues.apache.org/jira/browse/OAK-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-5455:
Comment: was deleted
(was: trunk: [r1815458|http://svn.apache.org/r1815458]
[r1815449|http://svn.apache.org/r1815449]
)
> Specify versions for maven plugins used in build for ensuring stable builds
> ---
>
> Key: OAK-5455
> URL: https://issues.apache.org/jira/browse/OAK-5455
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: parent
>Reporter: Chetan Mehrotra
>Assignee: Julian Reschke
>Priority: Major
> Labels: candidate_oak_1_4
> Fix For: 1.7.14, 1.8.0, 1.6.18
>
> Attachments: OAK-5455-v1.patch, enforce.diff
>
>
> Running a check for plugin versions used in oak build
> {noformat}
> mvn versions:display-plugin-updates
> {noformat}
> leads to following warning
> {noformat}
> [INFO] The following plugin updates are available:
> [INFO] org.apache.felix:maven-scr-plugin .. 1.16.0 -> 1.21.0
> [INFO]
> [WARNING] The following plugins do not have their version specified:
> [WARNING] maven-compiler-plugin .. 2.0.2
> [WARNING] maven-deploy-plugin . (from super-pom) 2.4
> [WARNING] maven-failsafe-plugin . 2.12.4
> [WARNING] maven-jar-plugin . 2.1
> [WARNING] maven-javadoc-plugin . 2.0
> [WARNING] maven-release-plugin . (from super-pom) 2.0-beta-4
> [WARNING] maven-resources-plugin ... 2.2
> [WARNING] maven-surefire-plugin .. 2.4.2
> [INFO]
> [WARNING] Project does not define minimum Maven version, default is: 2.0
> [INFO] Plugins require minimum Maven version of: 3.0.5
> [INFO] Note: the super-pom from Maven 3.3.9 defines some of the plugin
> [INFO] versions and may be influencing the plugins required minimum
> Maven
> [INFO] version.
> [INFO]
> [ERROR] Project does not define required minimum version of Maven.
> [ERROR] Update the pom.xml to contain
> [ERROR]
> [ERROR] 3.0.5
> [ERROR]
> {noformat}
> As a fix we should
> # Specify version for all maven plugin in use
> # Specify minimum version of maven to be used (version used in CI is 3.2.1)
> # Configure enforcer plugin to ensure that in future no plugin is used
> without specifying the version [1]
> [1] http://maven.apache.org/enforcer/enforcer-rules/requirePluginVersions.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-5455) Specify versions for maven plugins used in build for ensuring stable builds
[
https://issues.apache.org/jira/browse/OAK-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-5455:
Labels: candidate_oak_1_6 (was: )
> Specify versions for maven plugins used in build for ensuring stable builds
> ---
>
> Key: OAK-5455
> URL: https://issues.apache.org/jira/browse/OAK-5455
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: parent
>Reporter: Chetan Mehrotra
>Assignee: Julian Reschke
>Priority: Major
> Labels: candidate_oak_1_6
> Fix For: 1.7.14, 1.8.0
>
> Attachments: OAK-5455-v1.patch, enforce.diff
>
>
> Running a check for plugin versions used in oak build
> {noformat}
> mvn versions:display-plugin-updates
> {noformat}
> leads to following warning
> {noformat}
> [INFO] The following plugin updates are available:
> [INFO] org.apache.felix:maven-scr-plugin .. 1.16.0 -> 1.21.0
> [INFO]
> [WARNING] The following plugins do not have their version specified:
> [WARNING] maven-compiler-plugin .. 2.0.2
> [WARNING] maven-deploy-plugin . (from super-pom) 2.4
> [WARNING] maven-failsafe-plugin . 2.12.4
> [WARNING] maven-jar-plugin . 2.1
> [WARNING] maven-javadoc-plugin . 2.0
> [WARNING] maven-release-plugin . (from super-pom) 2.0-beta-4
> [WARNING] maven-resources-plugin ... 2.2
> [WARNING] maven-surefire-plugin .. 2.4.2
> [INFO]
> [WARNING] Project does not define minimum Maven version, default is: 2.0
> [INFO] Plugins require minimum Maven version of: 3.0.5
> [INFO] Note: the super-pom from Maven 3.3.9 defines some of the plugin
> [INFO] versions and may be influencing the plugins required minimum
> Maven
> [INFO] version.
> [INFO]
> [ERROR] Project does not define required minimum version of Maven.
> [ERROR] Update the pom.xml to contain
> [ERROR]
> [ERROR] 3.0.5
> [ERROR]
> {noformat}
> As a fix we should
> # Specify version for all maven plugin in use
> # Specify minimum version of maven to be used (version used in CI is 3.2.1)
> # Configure enforcer plugin to ensure that in future no plugin is used
> without specifying the version [1]
> [1] http://maven.apache.org/enforcer/enforcer-rules/requirePluginVersions.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8350) Update animal-sniffer dependency to 1.18
[ https://issues.apache.org/jira/browse/OAK-8350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8350: Labels: (was: candidate_oak_1_6) > Update animal-sniffer dependency to 1.18 > > > Key: OAK-8350 > URL: https://issues.apache.org/jira/browse/OAK-8350 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.10.3, 1.14.0, 1.8.14 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8196) Update httpclient/mime dependencies to 4.5.8
[ https://issues.apache.org/jira/browse/OAK-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8196: Labels: candidate_oak_1_4 (was: candidate_oak_1_6) > Update httpclient/mime dependencies to 4.5.8 > > > Key: OAK-8196 > URL: https://issues.apache.org/jira/browse/OAK-8196 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_4 > Fix For: 1.12.0, 1.10.3, 1.6.18, 1.8.14 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8196) Update httpclient/mime dependencies to 4.5.8
[ https://issues.apache.org/jira/browse/OAK-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8196: Fix Version/s: 1.6.18 > Update httpclient/mime dependencies to 4.5.8 > > > Key: OAK-8196 > URL: https://issues.apache.org/jira/browse/OAK-8196 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_6 > Fix For: 1.12.0, 1.10.3, 1.6.18, 1.8.14 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-8196) Update httpclient/mime dependencies to 4.5.8
[ https://issues.apache.org/jira/browse/OAK-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827509#comment-16827509 ] Julian Reschke edited comment on OAK-8196 at 7/9/19 10:26 AM: -- trunk: (1.12.0) [r1857000|http://svn.apache.org/r1857000] 1.10: (1.10.3) [r1858259|http://svn.apache.org/r1858259] 1.8: (1.8.14) [r1861868|http://svn.apache.org/r1861868] 1.6: [r1862801|http://svn.apache.org/r1862801] was (Author: reschke): trunk: (1.12.0) [r1857000|http://svn.apache.org/r1857000] 1.10: [r1858259|http://svn.apache.org/r1858259] 1.8: [r1861868|http://svn.apache.org/r1861868] > Update httpclient/mime dependencies to 4.5.8 > > > Key: OAK-8196 > URL: https://issues.apache.org/jira/browse/OAK-8196 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_4 > Fix For: 1.12.0, 1.10.3, 1.6.18, 1.8.14 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-8448) VersionGC may get stuck at 60s scope
[
https://issues.apache.org/jira/browse/OAK-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878453#comment-16878453
]
Julian Reschke edited comment on OAK-8448 at 7/9/19 10:18 AM:
--
Proposed fix: [^OAK-8448.diff]
was (Author: reschke):
Proposed fix: [^OAK-8448.diff]
> VersionGC may get stuck at 60s scope
> -
>
> Key: OAK-8448
> URL: https://issues.apache.org/jira/browse/OAK-8448
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Attachments: OAK-8448.diff, test.diff
>
>
> It seems that if the VersionGarbageCollector reduces the scope to a 60s
> interval, it'll never change it back to a bigger interval. This is because
> the collectLimit gets set to 0:
> {noformat}
> if (scope.getDurationMs() <= options.precisionMs) {
> // If we have narrowed the collect time interval down as much
> as we can, no
> // longer enforce a limit. We need to get through this.
> collectLimit = 0;
> log.debug("time interval <= precision ({} ms), disabling
> collection limits", options.precisionMs);
> }
> {noformat}
> ...and later on this is interpreted as "there were no restrictions in the
> prior run that need to be updated":
> {noformat}
> if (maxCollect <= 0) {
> log.debug("successful run without effective limit,
> keeping recommendations");
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8448) VersionGC may get stuck at 60s scope
[
https://issues.apache.org/jira/browse/OAK-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8448:
Attachment: (was: OAK-8448.diff)
> VersionGC may get stuck at 60s scope
> -
>
> Key: OAK-8448
> URL: https://issues.apache.org/jira/browse/OAK-8448
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Attachments: OAK-8448.diff, test.diff
>
>
> It seems that if the VersionGarbageCollector reduces the scope to a 60s
> interval, it'll never change it back to a bigger interval. This is because
> the collectLimit gets set to 0:
> {noformat}
> if (scope.getDurationMs() <= options.precisionMs) {
> // If we have narrowed the collect time interval down as much
> as we can, no
> // longer enforce a limit. We need to get through this.
> collectLimit = 0;
> log.debug("time interval <= precision ({} ms), disabling
> collection limits", options.precisionMs);
> }
> {noformat}
> ...and later on this is interpreted as "there were no restrictions in the
> prior run that need to be updated":
> {noformat}
> if (maxCollect <= 0) {
> log.debug("successful run without effective limit,
> keeping recommendations");
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8448) VersionGC may get stuck at 60s scope
[
https://issues.apache.org/jira/browse/OAK-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8448:
Attachment: OAK-8448.diff
> VersionGC may get stuck at 60s scope
> -
>
> Key: OAK-8448
> URL: https://issues.apache.org/jira/browse/OAK-8448
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Attachments: OAK-8448.diff, test.diff
>
>
> It seems that if the VersionGarbageCollector reduces the scope to a 60s
> interval, it'll never change it back to a bigger interval. This is because
> the collectLimit gets set to 0:
> {noformat}
> if (scope.getDurationMs() <= options.precisionMs) {
> // If we have narrowed the collect time interval down as much
> as we can, no
> // longer enforce a limit. We need to get through this.
> collectLimit = 0;
> log.debug("time interval <= precision ({} ms), disabling
> collection limits", options.precisionMs);
> }
> {noformat}
> ...and later on this is interpreted as "there were no restrictions in the
> prior run that need to be updated":
> {noformat}
> if (maxCollect <= 0) {
> log.debug("successful run without effective limit,
> keeping recommendations");
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8331) Update Tika dependency to 1.21
[ https://issues.apache.org/jira/browse/OAK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8331: Labels: (was: candidate_oak_1_6) > Update Tika dependency to 1.21 > -- > > Key: OAK-8331 > URL: https://issues.apache.org/jira/browse/OAK-8331 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.10.3, 1.14.0, 1.8.14 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8286) Update jetbrains nullability annotations to 17.0.0
[ https://issues.apache.org/jira/browse/OAK-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8286: Labels: (was: candidate_oak_1_6) > Update jetbrains nullability annotations to 17.0.0 > -- > > Key: OAK-8286 > URL: https://issues.apache.org/jira/browse/OAK-8286 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.10.3, 1.14.0, 1.8.14 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-7583) oak-examples/webapp: update jetty-maven-plugin dependency
[ https://issues.apache.org/jira/browse/OAK-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605329#comment-16605329 ] Julian Reschke edited comment on OAK-7583 at 7/9/19 9:28 AM: - trunk: (1.9.5) [r1834291|http://svn.apache.org/r1834291] 1.8: (1.8.8) [r1840183|http://svn.apache.org/r1840183] 1.6: [r1862793|http://svn.apache.org/r1862793] was (Author: reschke): trunk: [r1834291|http://svn.apache.org/r1834291] 1.8: [r1840183|http://svn.apache.org/r1840183] > oak-examples/webapp: update jetty-maven-plugin dependency > - > > Key: OAK-7583 > URL: https://issues.apache.org/jira/browse/OAK-7583 > Project: Jackrabbit Oak > Issue Type: Task > Components: examples >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_4 > Fix For: 1.10.0, 1.9.5, 1.8.8, 1.6.18 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7583) oak-examples/webapp: update jetty-maven-plugin dependency
[ https://issues.apache.org/jira/browse/OAK-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7583: Fix Version/s: 1.6.18 > oak-examples/webapp: update jetty-maven-plugin dependency > - > > Key: OAK-7583 > URL: https://issues.apache.org/jira/browse/OAK-7583 > Project: Jackrabbit Oak > Issue Type: Task > Components: examples >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_6 > Fix For: 1.10.0, 1.9.5, 1.8.8, 1.6.18 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7583) oak-examples/webapp: update jetty-maven-plugin dependency
[ https://issues.apache.org/jira/browse/OAK-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7583: Labels: candidate_oak_1_4 (was: candidate_oak_1_6) > oak-examples/webapp: update jetty-maven-plugin dependency > - > > Key: OAK-7583 > URL: https://issues.apache.org/jira/browse/OAK-7583 > Project: Jackrabbit Oak > Issue Type: Task > Components: examples >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_4 > Fix For: 1.10.0, 1.9.5, 1.8.8, 1.6.18 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8416) Oakathon August 2019
[ https://issues.apache.org/jira/browse/OAK-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-8416: -- Description: Our next Oakathon is now scheduled for August 19 - August 23, 2019. It will take place at the Adobe office at Barfüsserplatz 6 in Basel, Switzerland. Meeting rooms: Rhein (Mon, Tue), Bebbi (Wed, Thu), Rhein (Fri). All contributors to Apache Jackrabbit Oak are invited to attend, either in person or via videoconference. Details about the Oakathon including videoconferencing information will be added to this ticket over time. For those unfamiliar: Oakathons are hackathon events held to work on Apache Jackrabbit Oak. The event is used for working together on experiments, proofs-of-concept, features, technical debt, etc. as well as for having live discussions and making decisions about issues that relate to the project. We strive for an effective balance of both types of activity. As discussed in the last Oakathon, we will use this Jira issue to track submissions to the agenda and other details about the Oakathon. Contributors who plan to attend, please feel free to add your agenda submissions in the issue comments. was: Our next Oakathon is now scheduled for August 19 - August 23, 2019. It will take place at the Adobe office at Barfüsserplatz 6 in Basel, Switzerland. All contributors to Apache Jackrabbit Oak are invited to attend, either in person or via videoconference. Details about the Oakathon including videoconferencing information will be added to this ticket over time. For those unfamiliar: Oakathons are hackathon events held to work on Apache Jackrabbit Oak. The event is used for working together on experiments, proofs-of-concept, features, technical debt, etc. as well as for having live discussions and making decisions about issues that relate to the project. We strive for an effective balance of both types of activity. As discussed in the last Oakathon, we will use this Jira issue to track submissions to the agenda and other details about the Oakathon. Contributors who plan to attend, please feel free to add your agenda submissions in the issue comments. > Oakathon August 2019 > > > Key: OAK-8416 > URL: https://issues.apache.org/jira/browse/OAK-8416 > Project: Jackrabbit Oak > Issue Type: Task >Reporter: Matt Ryan >Assignee: Matt Ryan >Priority: Major > > Our next Oakathon is now scheduled for August 19 - August 23, 2019. It will > take place at the Adobe office at Barfüsserplatz 6 in Basel, Switzerland. > Meeting rooms: Rhein (Mon, Tue), Bebbi (Wed, Thu), Rhein (Fri). All > contributors to Apache Jackrabbit Oak are invited to attend, either in person > or via videoconference. Details about the Oakathon including > videoconferencing information will be added to this ticket over time. > For those unfamiliar: Oakathons are hackathon events held to work on Apache > Jackrabbit Oak. The event is used for working together on experiments, > proofs-of-concept, features, technical debt, etc. as well as for having live > discussions and making decisions about issues that relate to the project. We > strive for an effective balance of both types of activity. > As discussed in the last Oakathon, we will use this Jira issue to track > submissions to the agenda and other details about the Oakathon. Contributors > who plan to attend, please feel free to add your agenda submissions in the > issue comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8455) Memory Node store implementation of PropertyState throws Exception that is not in line with the API documentation
[ https://issues.apache.org/jira/browse/OAK-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8455: Labels: indexingPatch (was: ) > Memory Node store implementation of PropertyState throws Exception that is > not in line with the API documentation > - > > Key: OAK-8455 > URL: https://issues.apache.org/jira/browse/OAK-8455 > Project: Jackrabbit Oak > Issue Type: Bug > Components: store-spi >Reporter: Nitin Gupta >Priority: Major > Labels: indexingPatch > Attachments: OAK-8455_1.patch > > > As per the api doc here > [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-api/src/main/java/org/apache/jackrabbit/oak/api/PropertyState.java#L67#L69] > for PropertyState the getValue method should throw an IllegalStateException > if the actual Property stored is multivalued and the code calling > getValue(Type type) expects it to be single valued i.e type.isArray() == > false . > > In SegmentStore implementation , this is followed and the getValue method > throws an IllegalStateException in this scenario . > > However in case of MemoryNodeStore , the code here throws an > IllegalArgumentException > [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-spi/src/main/java/org/apache/jackrabbit/oak/plugins/memory/MultiPropertyState.java#L151#L154] > instead of IllegalStateException . > Since MemoryNodeStore is primarily used in testing , this difference in > implementation can lead to false or incomplete testing . > > For example , the fix for https://issues.apache.org/jira/browse/OAK-8328 > required to catch IllegalStateException in a use case where the property was > configured to be multi valued in the repository but the code expected it to > be single valued . Now the fix works fine on SegmentStore , but due to the > difference in implementation in MemoryNodeStore , a test written with > memorynode store fails . > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
