[jira] [Assigned] (OAK-8696) [Direct Binary Access] upload algorithm documentation should also be on the website
[ https://issues.apache.org/jira/browse/OAK-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Klimetschek reassigned OAK-8696: -- Assignee: Matt Ryan > [Direct Binary Access] upload algorithm documentation should also be on the > website > --- > > Key: OAK-8696 > URL: https://issues.apache.org/jira/browse/OAK-8696 > Project: Jackrabbit Oak > Issue Type: Bug > Components: doc >Reporter: Alexander Klimetschek >Assignee: Matt Ryan >Priority: Major > > The upload algorithm description that is currently a bit hidden in the > javadocs of > [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/binary/BinaryUpload.java] > should also be included on the documentation site: > [https://jackrabbit.apache.org/oak/docs/features/direct-binary-access.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OAK-8695) [Direct Binary Access] upload algorithm documentation should make it clear that not all URIs have to be used
[ https://issues.apache.org/jira/browse/OAK-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Klimetschek reassigned OAK-8695: -- Assignee: Matt Ryan (was: Matt Ryan) > [Direct Binary Access] upload algorithm documentation should make it clear > that not all URIs have to be used > > > Key: OAK-8695 > URL: https://issues.apache.org/jira/browse/OAK-8695 > Project: Jackrabbit Oak > Issue Type: Bug > Components: api, doc >Reporter: Alexander Klimetschek >Assignee: Matt Ryan >Priority: Major > > Regarding [BinaryUpload > javadoc|http://jackrabbit.apache.org/oak/docs/apidocs/org/apache/jackrabbit/api/binary/BinaryUpload.html] > ([code > here|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/binary/BinaryUpload.java]): > In the "Steps" section for #3, it should explicitly state that not all the > URIs need to be used. It could be inferred based on what is there, but it's > not obvious. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OAK-8695) [Direct Binary Access] upload algorithm documentation should make it clear that not all URIs have to be used
[ https://issues.apache.org/jira/browse/OAK-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Klimetschek reassigned OAK-8695: -- Assignee: Matt Ryan > [Direct Binary Access] upload algorithm documentation should make it clear > that not all URIs have to be used > > > Key: OAK-8695 > URL: https://issues.apache.org/jira/browse/OAK-8695 > Project: Jackrabbit Oak > Issue Type: Bug > Components: api, doc >Reporter: Alexander Klimetschek >Assignee: Matt Ryan >Priority: Major > > Regarding [BinaryUpload > javadoc|http://jackrabbit.apache.org/oak/docs/apidocs/org/apache/jackrabbit/api/binary/BinaryUpload.html] > ([code > here|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/binary/BinaryUpload.java]): > In the "Steps" section for #3, it should explicitly state that not all the > URIs need to be used. It could be inferred based on what is there, but it's > not obvious. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8695) [Direct Binary Access] upload algorithm documentation should make it clear that not all URIs have to be used
[ https://issues.apache.org/jira/browse/OAK-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Klimetschek updated OAK-8695: --- Component/s: doc > [Direct Binary Access] upload algorithm documentation should make it clear > that not all URIs have to be used > > > Key: OAK-8695 > URL: https://issues.apache.org/jira/browse/OAK-8695 > Project: Jackrabbit Oak > Issue Type: Bug > Components: api, doc >Reporter: Alexander Klimetschek >Priority: Major > > Regarding [BinaryUpload > javadoc|http://jackrabbit.apache.org/oak/docs/apidocs/org/apache/jackrabbit/api/binary/BinaryUpload.html] > ([code > here|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/binary/BinaryUpload.java]): > In the "Steps" section for #3, it should explicitly state that not all the > URIs need to be used. It could be inferred based on what is there, but it's > not obvious. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8696) [Direct Binary Access] upload algorithm documentation should also be on the website
Alexander Klimetschek created OAK-8696: -- Summary: [Direct Binary Access] upload algorithm documentation should also be on the website Key: OAK-8696 URL: https://issues.apache.org/jira/browse/OAK-8696 Project: Jackrabbit Oak Issue Type: Bug Components: doc Reporter: Alexander Klimetschek The upload algorithm description that is currently a bit hidden in the javadocs of [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/binary/BinaryUpload.java] should also be included on the documentation site: [https://jackrabbit.apache.org/oak/docs/features/direct-binary-access.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8695) [Direct Binary Access] upload algorithm documentation should make it clear that not all URIs have to be used
Alexander Klimetschek created OAK-8695: -- Summary: [Direct Binary Access] upload algorithm documentation should make it clear that not all URIs have to be used Key: OAK-8695 URL: https://issues.apache.org/jira/browse/OAK-8695 Project: Jackrabbit Oak Issue Type: Bug Components: api Reporter: Alexander Klimetschek Regarding [BinaryUpload javadoc|http://jackrabbit.apache.org/oak/docs/apidocs/org/apache/jackrabbit/api/binary/BinaryUpload.html] ([code here|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/binary/BinaryUpload.java]): In the "Steps" section for #3, it should explicitly state that not all the URIs need to be used. It could be inferred based on what is there, but it's not obvious. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8690) Build Jackrabbit Oak #2438 failed
[ https://issues.apache.org/jira/browse/OAK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949596#comment-16949596 ] Hudson commented on OAK-8690: - Build is still failing. Failed run: [Jackrabbit Oak #2442|https://builds.apache.org/job/Jackrabbit%20Oak/2442/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/2442/console] > Build Jackrabbit Oak #2438 failed > - > > Key: OAK-8690 > URL: https://issues.apache.org/jira/browse/OAK-8690 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit Oak #2438 has failed. > First failed run: [Jackrabbit Oak > #2438|https://builds.apache.org/job/Jackrabbit%20Oak/2438/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/2438/console] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OAK-8692) run permissionevaluation and hasgetitem benchmarks
[ https://issues.apache.org/jira/browse/OAK-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved OAK-8692. --- Resolution: Fixed > run permissionevaluation and hasgetitem benchmarks > -- > > Key: OAK-8692 > URL: https://issues.apache.org/jira/browse/OAK-8692 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: authorization-principalbased >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: 1.20.0 > > Attachments: HasItemGetItemIsModifiedTest-readable-paths.txt, > HasItemGetItemIsModifiedTest-statusquo.txt, > PermissionEvaluationTest-readable-paths.txt, > PermissionEvaluationTest-statusquo.txt > > > run benchmarks with the proposed patch to see if assess effect of (default) > readable-paths being part of permission evaluation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8692) run permissionevaluation and hasgetitem benchmarks
[ https://issues.apache.org/jira/browse/OAK-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated OAK-8692: -- Attachment: PermissionEvaluationTest-readable-paths.txt HasItemGetItemIsModifiedTest-readable-paths.txt > run permissionevaluation and hasgetitem benchmarks > -- > > Key: OAK-8692 > URL: https://issues.apache.org/jira/browse/OAK-8692 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: authorization-principalbased >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: 1.20.0 > > Attachments: HasItemGetItemIsModifiedTest-readable-paths.txt, > HasItemGetItemIsModifiedTest-statusquo.txt, > PermissionEvaluationTest-readable-paths.txt, > PermissionEvaluationTest-statusquo.txt > > > run benchmarks with the proposed patch to see if assess effect of (default) > readable-paths being part of permission evaluation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8692) run permissionevaluation and hasgetitem benchmarks
[ https://issues.apache.org/jira/browse/OAK-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated OAK-8692: -- Attachment: PermissionEvaluationTest-statusquo.txt HasItemGetItemIsModifiedTest-statusquo.txt > run permissionevaluation and hasgetitem benchmarks > -- > > Key: OAK-8692 > URL: https://issues.apache.org/jira/browse/OAK-8692 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: authorization-principalbased >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: 1.20.0 > > Attachments: HasItemGetItemIsModifiedTest-statusquo.txt, > PermissionEvaluationTest-statusquo.txt > > > run benchmarks with the proposed patch to see if assess effect of (default) > readable-paths being part of permission evaluation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8671) respect PARAM_READ_PATHS configuration option
[
https://issues.apache.org/jira/browse/OAK-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949583#comment-16949583
]
Angela Schreiber commented on OAK-8671:
---
Committed revision 1868297.
> respect PARAM_READ_PATHS configuration option
> --
>
> Key: OAK-8671
> URL: https://issues.apache.org/jira/browse/OAK-8671
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: authorization-principalbased
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Critical
> Fix For: 1.20.0
>
>
> while testing migration of default permission setup to principalbased
> permissions i noticed that the evaluation currently doesn't respect the
> {{PermissionConstants.PARAM_READ_PATHS}} configuration.
> while this could be worked around by explicitly granting read access, it
> seems more consistent to take the configuration option into account.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OAK-8607) Undo workarounds for improper Content-Disposition support
[
https://issues.apache.org/jira/browse/OAK-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948746#comment-16948746
]
Matt Ryan edited comment on OAK-8607 at 10/11/19 2:54 PM:
--
Tests were originally implemented to verify that the header is set correctly.
These tests were modified so they did not continue to fail while the workaround
is in place.
Some tests are in {{org.apache.jackrabbit.oak.jcr.binary.BinaryAccessIT}} tests
{{testGetBinaryWithSpecificFileName}},
{{testGetBinaryWithSpecificFileNameAndDispositionType}}, and
{{testGetBinarySetsAllHeaders}}. Another is in
{{org.apache.jackrabbit.oak.plugins.blob.datastore.directaccess.AbstractDataRecordAccessProviderTest.testGetDownloadURIWithCustomHeadersIT}}.
The workaround is implemented in
{{org.apache.jackrabbit.oak.plugins.blob.datastore.directaccess.DataRecordDownloadOptions}}.
See the methods {{getContentDispositionHeader}},
{{getContentDispositionHeader}}, and {{rfc8187Encode}}.
was (Author: mattvryan):
Tests were originally implemented to verify that the header is set correctly.
These tests were modified so they did not continue to fail while the workaround
is in place.
These tests are in {{org.apache.jackrabbit.oak.jcr.binary.BinaryAccessIT}}
tests {{testGetBinaryWithSpecificFileName}},
{{testGetBinaryWithSpecificFileNameAndDispositionType}}, and
{{testGetBinarySetsAllHeaders}}.
The workaround is implemented in
{{org.apache.jackrabbit.oak.plugins.blob.datastore.directaccess.DataRecordDownloadOptions}}.
See the methods {{getContentDispositionHeader}},
{{getContentDispositionHeader}}, and {{rfc8187Encode}}.
> Undo workarounds for improper Content-Disposition support
> -
>
> Key: OAK-8607
> URL: https://issues.apache.org/jira/browse/OAK-8607
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: blob-cloud, blob-cloud-azure, blob-plugins, jcr
>Reporter: Matt Ryan
>Assignee: Matt Ryan
>Priority: Major
>
> In order to move forward with a functioning signed download implementation
> (particularly on {{AzureDataStore}}) workarounds were implemented in OAK-8013
> and OAK-8601. Once Content-Disposition is properly supported again for
> signed downloads, these workarounds need to be removed and retested.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8684) oak-core-spi: remove uses of Guava from exported API
[
https://issues.apache.org/jira/browse/OAK-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949468#comment-16949468
]
Julian Reschke commented on OAK-8684:
-
So the remaining package is o.a.j.o.cache - the classes in here heavily rely on
Guava caches, in particular {{CacheLIRS}} implements Guava APIs.
As a first step, we could (a) define Oak interfaces for caches and (b) have an
implementation for them (based on the existing code, but hiding the API
dependency). We could then deprecate the old classes.
Alternatively, and more drastic, we could decide that these APIs were not meant
to be public in the first place, and try to undo it.
> oak-core-spi: remove uses of Guava from exported API
>
>
> Key: OAK-8684
> URL: https://issues.apache.org/jira/browse/OAK-8684
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: core-spi
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OAK-8694) state time of start of LeaseFailure in exception/log entry
[ https://issues.apache.org/jira/browse/OAK-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke reassigned OAK-8694: --- Assignee: Julian Reschke > state time of start of LeaseFailure in exception/log entry > -- > > Key: OAK-8694 > URL: https://issues.apache.org/jira/browse/OAK-8694 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > > ...this would make it easier to find the relevant part in the system log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8694) state time of start of LeaseFailure in exception/log entry
Julian Reschke created OAK-8694: --- Summary: state time of start of LeaseFailure in exception/log entry Key: OAK-8694 URL: https://issues.apache.org/jira/browse/OAK-8694 Project: Jackrabbit Oak Issue Type: Improvement Components: documentmk Reporter: Julian Reschke ...this would make it easier to find the relevant part in the system log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8693) update documentation
Angela Schreiber created OAK-8693: - Summary: update documentation Key: OAK-8693 URL: https://issues.apache.org/jira/browse/OAK-8693 Project: Jackrabbit Oak Issue Type: Technical task Components: authorization-principalbased, doc Reporter: Angela Schreiber Assignee: Angela Schreiber Fix For: 1.20.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8692) run permissionevaluation and hasgetitem benchmarks
[ https://issues.apache.org/jira/browse/OAK-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated OAK-8692: -- Parent: OAK-8671 Issue Type: Technical task (was: Task) > run permissionevaluation and hasgetitem benchmarks > -- > > Key: OAK-8692 > URL: https://issues.apache.org/jira/browse/OAK-8692 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: authorization-principalbased >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: 1.20.0 > > > run benchmarks with the proposed patch to see if assess effect of (default) > readable-paths being part of permission evaluation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8692) run permissionevaluation and hasgetitem benchmarks
Angela Schreiber created OAK-8692: - Summary: run permissionevaluation and hasgetitem benchmarks Key: OAK-8692 URL: https://issues.apache.org/jira/browse/OAK-8692 Project: Jackrabbit Oak Issue Type: Task Components: authorization-principalbased Reporter: Angela Schreiber Assignee: Angela Schreiber Fix For: 1.20.0 run benchmarks with the proposed patch to see if assess effect of (default) readable-paths being part of permission evaluation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
