[jira] [Commented] (OAK-8933) Build Jackrabbit Oak #2648 failed

2020-03-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050745#comment-17050745
 ] 

Hudson commented on OAK-8933:
-

Previously failing build now is OK.
 Passed run: [Jackrabbit Oak 
#2649|https://builds.apache.org/job/Jackrabbit%20Oak/2649/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2649/console]

> Build Jackrabbit Oak #2648 failed
> -
>
> Key: OAK-8933
> URL: https://issues.apache.org/jira/browse/OAK-8933
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2648 has failed.
> First failed run: [Jackrabbit Oak 
> #2648|https://builds.apache.org/job/Jackrabbit%20Oak/2648/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2648/console]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (OAK-8936) ValueImpl does not properly set domain override flag of BlobDownloadOptions

2020-03-03 Thread Matt Ryan (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Ryan resolved OAK-8936.

Resolution: Fixed

Fixed in 
[r1874770|https://svn.apache.org/viewvc?view=revision&revision=1874770].

> ValueImpl does not properly set domain override flag of BlobDownloadOptions
> ---
>
> Key: OAK-8936
> URL: https://issues.apache.org/jira/browse/OAK-8936
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Affects Versions: 1.24.0
>Reporter: Matt Ryan
>Assignee: Matt Ryan
>Priority: Critical
> Fix For: 1.26.0
>
>
> In {{org.apache.jackrabbit.oak.plugins.value.jcr.ValueImpl.getDownloadURI()}} 
> when converting a {{BinaryDownloadOptions}} to a {{BlobDownloadOptions}}, the 
> conversion does not take the domain override flag into account.  This flag 
> must be preserved in the conversion.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8936) ValueImpl does not properly set domain override flag of BlobDownloadOptions

2020-03-03 Thread Matt Ryan (Jira)
Matt Ryan created OAK-8936:
--

 Summary: ValueImpl does not properly set domain override flag of 
BlobDownloadOptions
 Key: OAK-8936
 URL: https://issues.apache.org/jira/browse/OAK-8936
 Project: Jackrabbit Oak
  Issue Type: Bug
Affects Versions: 1.24.0
Reporter: Matt Ryan
Assignee: Matt Ryan
 Fix For: 1.26.0


In {{org.apache.jackrabbit.oak.plugins.value.jcr.ValueImpl.getDownloadURI()}} 
when converting a {{BinaryDownloadOptions}} to a {{BlobDownloadOptions}}, the 
conversion does not take the domain override flag into account.  This flag must 
be preserved in the conversion.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8935) Improve ClusterNodeInfo MAC address detection

2020-03-03 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8935:

Attachment: OAK-8935.diff

> Improve ClusterNodeInfo MAC address detection 
> --
>
> Key: OAK-8935
> URL: https://issues.apache.org/jira/browse/OAK-8935
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Affects Versions: 1.12.0
>Reporter: Jorge Flórez
>Assignee: Julian Reschke
>Priority: Major
> Attachments: OAK-8935.diff
>
>
> ClusterNodeInfo is taking the lowest MAC address found in the machine. When 
> the machine has "docker0" bridge, it takes that MAC address (which may 
> change) and uses it. Resulting in errors like this one:
> Configured cluster node id 123 already in use: needs recovery and 
> machineId/instanceId do not match: mac:02421b0c73d3//home/ec2-user != 
> mac:0242a5c0c5e5//home/ec2-user   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8935) Improve ClusterNodeInfo MAC address detection

2020-03-03 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050437#comment-17050437
 ] 

Julian Reschke commented on OAK-8935:
-

Proposed patch:  [^OAK-8935.diff]  - [~mreutegg], wdyt?

> Improve ClusterNodeInfo MAC address detection 
> --
>
> Key: OAK-8935
> URL: https://issues.apache.org/jira/browse/OAK-8935
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Affects Versions: 1.12.0
>Reporter: Jorge Flórez
>Assignee: Julian Reschke
>Priority: Major
> Attachments: OAK-8935.diff
>
>
> ClusterNodeInfo is taking the lowest MAC address found in the machine. When 
> the machine has "docker0" bridge, it takes that MAC address (which may 
> change) and uses it. Resulting in errors like this one:
> Configured cluster node id 123 already in use: needs recovery and 
> machineId/instanceId do not match: mac:02421b0c73d3//home/ec2-user != 
> mac:0242a5c0c5e5//home/ec2-user   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OAK-8935) Improve ClusterNodeInfo MAC address detection

2020-03-03 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke reassigned OAK-8935:
---

Assignee: Julian Reschke

> Improve ClusterNodeInfo MAC address detection 
> --
>
> Key: OAK-8935
> URL: https://issues.apache.org/jira/browse/OAK-8935
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Affects Versions: 1.12.0
>Reporter: Jorge Flórez
>Assignee: Julian Reschke
>Priority: Major
>
> ClusterNodeInfo is taking the lowest MAC address found in the machine. When 
> the machine has "docker0" bridge, it takes that MAC address (which may 
> change) and uses it. Resulting in errors like this one:
> Configured cluster node id 123 already in use: needs recovery and 
> machineId/instanceId do not match: mac:02421b0c73d3//home/ec2-user != 
> mac:0242a5c0c5e5//home/ec2-user   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8935) Improve ClusterNodeInfo MAC address detection

2020-03-03 Thread Jira
Jorge Flórez created OAK-8935:
-

 Summary: Improve ClusterNodeInfo MAC address detection 
 Key: OAK-8935
 URL: https://issues.apache.org/jira/browse/OAK-8935
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: documentmk
Affects Versions: 1.12.0
Reporter: Jorge Flórez


ClusterNodeInfo is taking the lowest MAC address found in the machine. When the 
machine has "docker0" bridge, it takes that MAC address (which may change) and 
uses it. Resulting in errors like this one:
Configured cluster node id 123 already in use: needs recovery and 
machineId/instanceId do not match: mac:02421b0c73d3//home/ec2-user != 
mac:0242a5c0c5e5//home/ec2-user   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8934) Indexing: filter entries with a regular expression

2020-03-03 Thread Amrit Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050303#comment-17050303
 ] 

Amrit Verma edited comment on OAK-8934 at 3/3/20 3:22 PM:
--

Please review the PR - [https://github.com/apache/jackrabbit-oak/pull/193/files]

Some of the tests are failing, I have mentioned that in a 
[comment|https://github.com/apache/jackrabbit-oak/pull/193/files#r387090870] in 
the PR.


was (Author: amrverma):
Please review the PR - [https://github.com/apache/jackrabbit-oak/pull/193/files]

Some of the tests are failing, I have mentioned that in a comment in the PR.

> Indexing: filter entries with a regular expression
> --
>
> Key: OAK-8934
> URL: https://issues.apache.org/jira/browse/OAK-8934
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: indexing
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
>  Labels: amrit
>
> We should provide a way to filter the index using a regular expression. For 
> example, only index nodes that contain a reference to another node. (Not a 
> JCR reference, but a reference within the value itself). For example, index a 
> node if one of the properties contains:
> * /content/abc
> *  
> * and so on
> This will allow to run a query to find if /content/abc is referenced. The 
> index and the query will probably need to use a tag, and the cost of the 
> index needs to be high. Otherwise the query engine can't know when this index 
> should be used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8934) Indexing: filter entries with a regular expression

2020-03-03 Thread Amrit Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050303#comment-17050303
 ] 

Amrit Verma commented on OAK-8934:
--

Please review the PR - [https://github.com/apache/jackrabbit-oak/pull/193/files]

> Indexing: filter entries with a regular expression
> --
>
> Key: OAK-8934
> URL: https://issues.apache.org/jira/browse/OAK-8934
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: indexing
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
>  Labels: amrit
>
> We should provide a way to filter the index using a regular expression. For 
> example, only index nodes that contain a reference to another node. (Not a 
> JCR reference, but a reference within the value itself). For example, index a 
> node if one of the properties contains:
> * /content/abc
> *  
> * and so on
> This will allow to run a query to find if /content/abc is referenced. The 
> index and the query will probably need to use a tag, and the cost of the 
> index needs to be high. Otherwise the query engine can't know when this index 
> should be used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8934) Indexing: filter entries with a regular expression

2020-03-03 Thread Amrit Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050303#comment-17050303
 ] 

Amrit Verma edited comment on OAK-8934 at 3/3/20 3:21 PM:
--

Please review the PR - [https://github.com/apache/jackrabbit-oak/pull/193/files]

Some of the tests are failing, I have mentioned that in a comment in the PR.


was (Author: amrverma):
Please review the PR - [https://github.com/apache/jackrabbit-oak/pull/193/files]

> Indexing: filter entries with a regular expression
> --
>
> Key: OAK-8934
> URL: https://issues.apache.org/jira/browse/OAK-8934
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: indexing
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
>  Labels: amrit
>
> We should provide a way to filter the index using a regular expression. For 
> example, only index nodes that contain a reference to another node. (Not a 
> JCR reference, but a reference within the value itself). For example, index a 
> node if one of the properties contains:
> * /content/abc
> *  
> * and so on
> This will allow to run a query to find if /content/abc is referenced. The 
> index and the query will probably need to use a tag, and the cost of the 
> index needs to be high. Otherwise the query engine can't know when this index 
> should be used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-3885) enhance stability of clusterNodeInfo's machineId

2020-03-03 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050190#comment-17050190
 ] 

Julian Reschke commented on OAK-3885:
-

1.4: (1.3.14) [r1725216|http://svn.apache.org/r1725216]
1.2: (1.2.10) [r1725270|http://svn.apache.org/r1725270] 
[r1725229|http://svn.apache.org/r1725229]
1.0: (1.0.26) [r1725272|http://svn.apache.org/r1725272] 
[r1725238|http://svn.apache.org/r1725238]

> enhance stability of clusterNodeInfo's machineId
> 
>
> Key: OAK-3885
> URL: https://issues.apache.org/jira/browse/OAK-3885
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.0.25, 1.2.9, 1.3.13
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.26, 1.2.10, 1.3.14, 1.4
>
> Attachments: OAK-3885.diff
>
>
> We currently use network interface information to derive a unique machine ID 
> (ClusterNodeInfo.getMachineId()). Among the 6-byte addresses, we use the 
> "smallest".
> At least on Windows machines, connecting through a VPN inserts a new low 
> machineID into the list, causing the machineID to vary depending on whether 
> the VPN is connected or not.
> I don't see a clean way to filter these addresses. We *could* inspect the 
> names of the interfaces and treat those containing "VPN" or "Virtual" to be 
> less relevant. Of course that would be an ugly hack, but it would fix the 
> problem for now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Issue Comment Deleted] (OAK-3885) enhance stability of clusterNodeInfo's machineId

2020-03-03 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-3885:

Comment: was deleted

(was: trunk: http://svn.apache.org/r1725216
1.2: http://svn.apache.org/r1725270 http://svn.apache.org/r1725229
1.0: http://svn.apache.org/r1725272 http://svn.apache.org/r1725238
)

> enhance stability of clusterNodeInfo's machineId
> 
>
> Key: OAK-3885
> URL: https://issues.apache.org/jira/browse/OAK-3885
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.0.25, 1.2.9, 1.3.13
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.26, 1.2.10, 1.3.14, 1.4
>
> Attachments: OAK-3885.diff
>
>
> We currently use network interface information to derive a unique machine ID 
> (ClusterNodeInfo.getMachineId()). Among the 6-byte addresses, we use the 
> "smallest".
> At least on Windows machines, connecting through a VPN inserts a new low 
> machineID into the list, causing the machineID to vary depending on whether 
> the VPN is connected or not.
> I don't see a clean way to filter these addresses. We *could* inspect the 
> names of the interfaces and treat those containing "VPN" or "Virtual" to be 
> less relevant. Of course that would be an ugly hack, but it would fix the 
> problem for now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8934) Indexing: filter entries with a regular expression

2020-03-03 Thread Thomas Mueller (Jira)
Thomas Mueller created OAK-8934:
---

 Summary: Indexing: filter entries with a regular expression
 Key: OAK-8934
 URL: https://issues.apache.org/jira/browse/OAK-8934
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: indexing
Reporter: Thomas Mueller
Assignee: Thomas Mueller


We should provide a way to filter the index using a regular expression. For 
example, only index nodes that contain a reference to another node. (Not a JCR 
reference, but a reference within the value itself). For example, index a node 
if one of the properties contains:

* /content/abc
*  
* and so on

This will allow to run a query to find if /content/abc is referenced. The index 
and the query will probably need to use a tag, and the cost of the index needs 
to be high. Otherwise the query engine can't know when this index should be 
used.





--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8934) Indexing: filter entries with a regular expression

2020-03-03 Thread Thomas Mueller (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Mueller updated OAK-8934:

Labels: amrit  (was: )

> Indexing: filter entries with a regular expression
> --
>
> Key: OAK-8934
> URL: https://issues.apache.org/jira/browse/OAK-8934
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: indexing
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
>  Labels: amrit
>
> We should provide a way to filter the index using a regular expression. For 
> example, only index nodes that contain a reference to another node. (Not a 
> JCR reference, but a reference within the value itself). For example, index a 
> node if one of the properties contains:
> * /content/abc
> *  
> * and so on
> This will allow to run a query to find if /content/abc is referenced. The 
> index and the query will probably need to use a tag, and the cost of the 
> index needs to be high. Otherwise the query engine can't know when this index 
> should be used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)