[jira] [Commented] (OAK-10264) Build Jackrabbit/jackrabbit-oak-trunk #965 failed

2023-05-25 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726484#comment-17726484
 ] 

Hudson commented on OAK-10264:
--

Build is still failing.
Failed run: [Jackrabbit/jackrabbit-oak-trunk 
#968|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/968/] 
[console 
log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/968/console]

> Build Jackrabbit/jackrabbit-oak-trunk #965 failed
> -
>
> Key: OAK-10264
> URL: https://issues.apache.org/jira/browse/OAK-10264
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit/jackrabbit-oak-trunk #965 has failed.
> First failed run: [Jackrabbit/jackrabbit-oak-trunk 
> #965|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/965/]
>  [console 
> log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/965/console]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10213) Add new api in DocumentStore to handle bulk findAndUpdate operations

2023-05-25 Thread Rishabh Daim (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726483#comment-17726483
 ] 

Rishabh Daim commented on OAK-10213:


{quote}Do we have data that suggests there are many such documents with deleted 
properties and performance is a concern?
{quote}
I did a query on one of the customer's env to found out that the total no. of 
documents with deleted properties.

The deleted properties count in respect to total documents varies by huge 
margin with ranges between 1% to as high as 35%.

> Add new api in DocumentStore to handle bulk findAndUpdate operations
> 
>
> Key: OAK-10213
> URL: https://issues.apache.org/jira/browse/OAK-10213
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>Reporter: Rishabh Daim
>Assignee: Rishabh Daim
>Priority: Major
>
> Currently, we only provide support to update 1 document using 
> [findAndUpdate|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStore.java#L348]
>  with conditions.
>  
> For my ticket OAK-10199, I need to update multiple documents. However, none 
> of the existing APIs fit my use case.
> Using 
> [findAndUpdate|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStore.java#L348]
>  would be very inefficient in case of updating multiple documents.
>  
> Hence I propose adding a new API that can update multiple documents using 
> [bulkUpdate|https://www.mongodb.com/docs/drivers/java/sync/current/usage-examples/bulkWrite/]
>  of Mongo on similar lines to the 
> [createOrUpdate|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStore.java#L321]
>  API.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10264) Build Jackrabbit/jackrabbit-oak-trunk #965 failed

2023-05-25 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726360#comment-17726360
 ] 

Hudson commented on OAK-10264:
--

Build is still failing.
Failed run: [Jackrabbit/jackrabbit-oak-trunk 
#967|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/967/] 
[console 
log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/967/console]

> Build Jackrabbit/jackrabbit-oak-trunk #965 failed
> -
>
> Key: OAK-10264
> URL: https://issues.apache.org/jira/browse/OAK-10264
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit/jackrabbit-oak-trunk #965 has failed.
> First failed run: [Jackrabbit/jackrabbit-oak-trunk 
> #965|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/965/]
>  [console 
> log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/965/console]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10264) Build Jackrabbit/jackrabbit-oak-trunk #965 failed

2023-05-25 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726341#comment-17726341
 ] 

Hudson commented on OAK-10264:
--

Build is still failing.
Failed run: [Jackrabbit/jackrabbit-oak-trunk 
#966|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/966/] 
[console 
log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/966/console]

> Build Jackrabbit/jackrabbit-oak-trunk #965 failed
> -
>
> Key: OAK-10264
> URL: https://issues.apache.org/jira/browse/OAK-10264
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit/jackrabbit-oak-trunk #965 has failed.
> First failed run: [Jackrabbit/jackrabbit-oak-trunk 
> #965|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/965/]
>  [console 
> log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/965/console]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OAK-10264) Build Jackrabbit/jackrabbit-oak-trunk #965 failed

2023-05-25 Thread Hudson (Jira)
Hudson created OAK-10264:


 Summary: Build Jackrabbit/jackrabbit-oak-trunk #965 failed
 Key: OAK-10264
 URL: https://issues.apache.org/jira/browse/OAK-10264
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: continuous integration
Reporter: Hudson


No description is provided

The build Jackrabbit/jackrabbit-oak-trunk #965 has failed.
First failed run: [Jackrabbit/jackrabbit-oak-trunk 
#965|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/965/] 
[console 
log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/965/console]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (OAK-10259) oak-core tests running out of memory

2023-05-25 Thread Marcel Reutegger (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger resolved OAK-10259.

Fix Version/s: 1.54.0
   Resolution: Fixed

Merged PR.

> oak-core tests running out of memory
> 
>
> Key: OAK-10259
> URL: https://issues.apache.org/jira/browse/OAK-10259
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration, core
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.54.0
>
>
> Recently tests for oak-core were running out of memory on Jenkins. Analyzing 
> a heap dump showed majority of heap (300 MB) retained by Mockito. It looks 
> like this is related to https://github.com/mockito/mockito/pull/1619 and with 
> OAK-10173 we enabled mock-maker-inline.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OAK-10263) Inconsistent state in TarWriter when close() fails to write to Azure

2023-05-25 Thread Carlo Jelmini (Jira)
Carlo Jelmini created OAK-10263:
---

 Summary:  Inconsistent state in TarWriter when close() fails to 
write to Azure
 Key: OAK-10263
 URL: https://issues.apache.org/jira/browse/OAK-10263
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: segment-azure, segment-tar
Reporter: Carlo Jelmini


When using AzurePersistence as backend, a TarWriter can end up in an 
inconsistent state.

The root cause of this inconsistent state is the following sequence:
 * TarFiles writes a new segment
 * The current tar archive is now too large and a new tar archive needs to be 
created
 * However, first the TarWriter associated to the current archive need to be 
closed
 * In the TarWriter#close() method, first the {{closed}} flag is set, then it 
proceeds to close the archive by writing the binary references file and the 
graph file.
 * The write to Azure storage fails because of a timeout: "The client could not 
finish the operation within specified maximum execution timeout"
 * The TarWriter is now closed (because the {{closed}} flag is already set), 
but because the exception is basically ignored by FileStore#tryFlush(), the 
TarWriter is kept in use and fails all read and write operations from that 
point forward. The read operation failures cause calling code to interpret the 
exception as a SNFE.

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10213) Add new api in DocumentStore to handle bulk findAndUpdate operations

2023-05-25 Thread Marcel Reutegger (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726207#comment-17726207
 ] 

Marcel Reutegger commented on OAK-10213:


bq. The new method would be used to implement all the planned deletions in 
Detailed RGC i.e. Properties, OldRevisions, or any other property that we might 
plan to remove in the future.

As an alternative, the cleanup work could also be delegated to VersionGCSupport 
and then have an optimized implementation in MongoVersionGCSupport without 
adding a method to the DocumentStore interface. Credits to Julian Reschke, who 
mentioned this in a conversation I had with him.

> Add new api in DocumentStore to handle bulk findAndUpdate operations
> 
>
> Key: OAK-10213
> URL: https://issues.apache.org/jira/browse/OAK-10213
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>Reporter: Rishabh Daim
>Assignee: Rishabh Daim
>Priority: Major
>
> Currently, we only provide support to update 1 document using 
> [findAndUpdate|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStore.java#L348]
>  with conditions.
>  
> For my ticket OAK-10199, I need to update multiple documents. However, none 
> of the existing APIs fit my use case.
> Using 
> [findAndUpdate|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStore.java#L348]
>  would be very inefficient in case of updating multiple documents.
>  
> Hence I propose adding a new API that can update multiple documents using 
> [bulkUpdate|https://www.mongodb.com/docs/drivers/java/sync/current/usage-examples/bulkWrite/]
>  of Mongo on similar lines to the 
> [createOrUpdate|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStore.java#L321]
>  API.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OAK-10201) oak-blub-plugins: exported packages need to be marked @internal

2023-05-25 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715081#comment-17715081
 ] 

Julian Reschke edited comment on OAK-10201 at 5/25/23 12:25 PM:


trunk: (1.52) 
[2ec91f0207|https://github.com/apache/jackrabbit-oak/commit/2ec91f020791d1f17ae3b9e197b6a6c89c4dc522]
 
[2c9353c528|https://github.com/apache/jackrabbit-oak/commit/2c9353c528060e4ade211632f44fe4ff3eed10e1]
 
[838780a7aa|https://github.com/apache/jackrabbit-oak/commit/838780a7aaf9775ad0bf7b6be65c1a1619e65eb7]
 
[cb64d9a04f|https://github.com/apache/jackrabbit-oak/commit/cb64d9a04fe85c6530c18226a7b7c44498041667]



was (Author: reschke):
trunk: 
[2ec91f0207|https://github.com/apache/jackrabbit-oak/commit/2ec91f020791d1f17ae3b9e197b6a6c89c4dc522]
 
[2c9353c528|https://github.com/apache/jackrabbit-oak/commit/2c9353c528060e4ade211632f44fe4ff3eed10e1]
 
[838780a7aa|https://github.com/apache/jackrabbit-oak/commit/838780a7aaf9775ad0bf7b6be65c1a1619e65eb7]
 
[cb64d9a04f|https://github.com/apache/jackrabbit-oak/commit/cb64d9a04fe85c6530c18226a7b7c44498041667]


> oak-blub-plugins: exported packages need to be marked @internal 
> 
>
> Key: OAK-10201
> URL: https://issues.apache.org/jira/browse/OAK-10201
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: blob-plugins
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Blocker
>  Labels: candidate_oak_1_22
> Fix For: 1.52.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OAK-10201) oak-blub-plugins: exported packages need to be marked @internal

2023-05-25 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714638#comment-17714638
 ] 

Julian Reschke edited comment on OAK-10201 at 5/25/23 12:24 PM:


(I had to re-open this because it broke compat checks in a dependent project)


was (Author: reschke):
(I had to re-open this because ir broke compat checks in a dependent project)

> oak-blub-plugins: exported packages need to be marked @internal 
> 
>
> Key: OAK-10201
> URL: https://issues.apache.org/jira/browse/OAK-10201
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: blob-plugins
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Blocker
>  Labels: candidate_oak_1_22
> Fix For: 1.52.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10255) Build Jackrabbit/jackrabbit-oak-trunk #955 failed

2023-05-25 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726143#comment-17726143
 ] 

Hudson commented on OAK-10255:
--

Previously failing build now is OK.
 Passed run: [Jackrabbit/jackrabbit-oak-trunk 
#964|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/964/] 
[console 
log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/964/console]

> Build Jackrabbit/jackrabbit-oak-trunk #955 failed
> -
>
> Key: OAK-10255
> URL: https://issues.apache.org/jira/browse/OAK-10255
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit/jackrabbit-oak-trunk #955 has failed.
> First failed run: [Jackrabbit/jackrabbit-oak-trunk 
> #955|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/955/]
>  [console 
> log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/955/console]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10213) Add new api in DocumentStore to handle bulk findAndUpdate operations

2023-05-25 Thread Rishabh Daim (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726108#comment-17726108
 ] 

Rishabh Daim commented on OAK-10213:


{quote}The proposed changes are quite big and I'm wondering if they are 
justified. IIUC, the new method would be used to implement OAK-10193.
{quote}
The new method would be used to implement all the planned deletions in Detailed 
RGC i.e. Properties, OldRevisions, or any other property that we might plan to 
remove in the future.
{quote}Do we have data that suggests there are many such documents with deleted 
properties and performance is a concern?
{quote}
I will clone one of the repos from prod env and find the no. of documents with 
deleted props & also try to create a test case locally to see the performance 
gains.

 

> Add new api in DocumentStore to handle bulk findAndUpdate operations
> 
>
> Key: OAK-10213
> URL: https://issues.apache.org/jira/browse/OAK-10213
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>Reporter: Rishabh Daim
>Assignee: Rishabh Daim
>Priority: Major
>
> Currently, we only provide support to update 1 document using 
> [findAndUpdate|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStore.java#L348]
>  with conditions.
>  
> For my ticket OAK-10199, I need to update multiple documents. However, none 
> of the existing APIs fit my use case.
> Using 
> [findAndUpdate|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStore.java#L348]
>  would be very inefficient in case of updating multiple documents.
>  
> Hence I propose adding a new API that can update multiple documents using 
> [bulkUpdate|https://www.mongodb.com/docs/drivers/java/sync/current/usage-examples/bulkWrite/]
>  of Mongo on similar lines to the 
> [createOrUpdate|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStore.java#L321]
>  API.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (OAK-10262) Document ASCIIFolder and OakAnalyzer

2023-05-25 Thread Thomas Mueller (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Mueller resolved OAK-10262.
--
Fix Version/s: 1.54.0
   Resolution: Fixed

> Document ASCIIFolder and OakAnalyzer
> 
>
> Key: OAK-10262
> URL: https://issues.apache.org/jira/browse/OAK-10262
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
>  Labels: index, lucene
> Fix For: 1.54.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10255) Build Jackrabbit/jackrabbit-oak-trunk #955 failed

2023-05-25 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726085#comment-17726085
 ] 

Hudson commented on OAK-10255:
--

Previously failing build now is OK.
 Passed run: [Jackrabbit/jackrabbit-oak-trunk 
#963|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/963/] 
[console 
log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/963/console]

> Build Jackrabbit/jackrabbit-oak-trunk #955 failed
> -
>
> Key: OAK-10255
> URL: https://issues.apache.org/jira/browse/OAK-10255
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit/jackrabbit-oak-trunk #955 has failed.
> First failed run: [Jackrabbit/jackrabbit-oak-trunk 
> #955|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/955/]
>  [console 
> log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/955/console]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)