[jira] [Commented] (OAK-10779) Build Jackrabbit/jackrabbit-oak-trunk #1451 failed

2024-05-02 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843011#comment-17843011
 ] 

Hudson commented on OAK-10779:
--

Previously failing build now is OK.
 Passed run: [Jackrabbit/jackrabbit-oak-trunk 
#1455|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1455/]
 [console 
log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1455/console]

> Build Jackrabbit/jackrabbit-oak-trunk #1451 failed
> --
>
> Key: OAK-10779
> URL: https://issues.apache.org/jira/browse/OAK-10779
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit/jackrabbit-oak-trunk #1451 has failed.
> First failed run: [Jackrabbit/jackrabbit-oak-trunk 
> #1451|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1451/]
>  [console 
> log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1451/console]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10334) Node.addMixin() may overwrite existing mixins

2024-05-02 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842998#comment-17842998
 ] 

Julian Reschke commented on OAK-10334:
--

Backport to 1.22 would be tricky, because 
https://issues.apache.org/jira/browse/OAK-9868 modified the exported API 
earlier on.


> Node.addMixin() may overwrite existing mixins
> -
>
> Key: OAK-10334
> URL: https://issues.apache.org/jira/browse/OAK-10334
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
>  Labels: candidate_oak_1_22
> Fix For: 1.58.0
>
>
> A Session lacking permission to read property jcr:mixinTypes, but permission 
> to write will overwrite existing mixins when calling Node.addMixin().
> The implementation does not check if the session has permission to read 
> jcr:mixinTypes and assumes there are no existing values when the session does 
> not have permission. The result is a jcr:mixinTypes property with only a 
> single value passed to addMixin().



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (OAK-10355) Build Jackrabbit/jackrabbit-oak-trunk #1040 failed

2024-05-02 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved OAK-10355.
--
Resolution: Cannot Reproduce

> Build Jackrabbit/jackrabbit-oak-trunk #1040 failed
> --
>
> Key: OAK-10355
> URL: https://issues.apache.org/jira/browse/OAK-10355
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit/jackrabbit-oak-trunk #1040 has failed.
> First failed run: [Jackrabbit/jackrabbit-oak-trunk 
> #1040|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1040/]
>  [console 
> log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1040/console]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OAK-10334) Node.addMixin() may overwrite existing mixins

2024-05-02 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770145#comment-17770145
 ] 

Julian Reschke edited comment on OAK-10334 at 5/2/24 2:32 PM:
--

trunk: (1.58.0) 
[e91361faa5|https://github.com/apache/jackrabbit-oak/commit/e91361faa59349b0fb389c159399cc27071c0f58]
 (1.56.0) 
[46109d1d84|https://github.com/apache/jackrabbit-oak/commit/46109d1d8434aabb25f18d5c25afc0cb9414fe4f]
 
[028e8d3618|https://github.com/apache/jackrabbit-oak/commit/028e8d3618895e40031d3fe2958378a80859f5f9]
 
[cf521f072e|https://github.com/apache/jackrabbit-oak/commit/cf521f072e0006b4dc5145e6997cef868c644d45]
 (1.54.0) 
[0b8223f113|https://github.com/apache/jackrabbit-oak/commit/0b8223f11383e465dbc77bea04337e0c08f28079]
 
[2c83efbefc|https://github.com/apache/jackrabbit-oak/commit/2c83efbefc0e7dd832e598606e0f002a241f3fc4]



was (Author: reschke):
trunk: 
[e91361faa5|https://github.com/apache/jackrabbit-oak/commit/e91361faa59349b0fb389c159399cc27071c0f58]
 (1.56.0) 
[46109d1d84|https://github.com/apache/jackrabbit-oak/commit/46109d1d8434aabb25f18d5c25afc0cb9414fe4f]
 
[028e8d3618|https://github.com/apache/jackrabbit-oak/commit/028e8d3618895e40031d3fe2958378a80859f5f9]
 
[cf521f072e|https://github.com/apache/jackrabbit-oak/commit/cf521f072e0006b4dc5145e6997cef868c644d45]
 (1.54.0) 
[0b8223f113|https://github.com/apache/jackrabbit-oak/commit/0b8223f11383e465dbc77bea04337e0c08f28079]
 
[2c83efbefc|https://github.com/apache/jackrabbit-oak/commit/2c83efbefc0e7dd832e598606e0f002a241f3fc4]


> Node.addMixin() may overwrite existing mixins
> -
>
> Key: OAK-10334
> URL: https://issues.apache.org/jira/browse/OAK-10334
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
>  Labels: candidate_oak_1_22
> Fix For: 1.58.0
>
>
> A Session lacking permission to read property jcr:mixinTypes, but permission 
> to write will overwrite existing mixins when calling Node.addMixin().
> The implementation does not check if the session has permission to read 
> jcr:mixinTypes and assumes there are no existing values when the session does 
> not have permission. The result is a jcr:mixinTypes property with only a 
> single value passed to addMixin().



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OAK-10334) Node.addMixin() may overwrite existing mixins

2024-05-02 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-10334:
-
Labels: candidate_oak_1_22  (was: )

> Node.addMixin() may overwrite existing mixins
> -
>
> Key: OAK-10334
> URL: https://issues.apache.org/jira/browse/OAK-10334
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
>  Labels: candidate_oak_1_22
> Fix For: 1.58.0
>
>
> A Session lacking permission to read property jcr:mixinTypes, but permission 
> to write will overwrite existing mixins when calling Node.addMixin().
> The implementation does not check if the session has permission to read 
> jcr:mixinTypes and assumes there are no existing values when the session does 
> not have permission. The result is a jcr:mixinTypes property with only a 
> single value passed to addMixin().



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (OAK-10782) oak-search-elastic: query getSize() can lock writes when is called before an update

2024-05-02 Thread Fabrizio Fortino (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fabrizio Fortino resolved OAK-10782.

Fix Version/s: 1.64.0
   Resolution: Fixed

> oak-search-elastic: query getSize() can lock writes when is called before an 
> update
> ---
>
> Key: OAK-10782
> URL: https://issues.apache.org/jira/browse/OAK-10782
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: indexing
>Reporter: Fabrizio Fortino
>Assignee: Fabrizio Fortino
>Priority: Critical
> Fix For: 1.64.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OAK-10785) update maven-shade-plugin version to 3.5.3

2024-05-02 Thread Manfred Baedke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manfred Baedke updated OAK-10785:
-
Fix Version/s: (was: 1.62.0)

> update maven-shade-plugin version to 3.5.3
> --
>
> Key: OAK-10785
> URL: https://issues.apache.org/jira/browse/OAK-10785
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Manfred Baedke
>Priority: Minor
>
> (previously defaulted)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OAK-10785) update maven-shade-plugin version to 3.5.3

2024-05-02 Thread Manfred Baedke (Jira)
Manfred Baedke created OAK-10785:


 Summary: update maven-shade-plugin version to 3.5.3
 Key: OAK-10785
 URL: https://issues.apache.org/jira/browse/OAK-10785
 Project: Jackrabbit Oak
  Issue Type: Task
  Components: parent
Reporter: Julian Reschke
Assignee: Julian Reschke
 Fix For: 1.62.0


(previously defaulted)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OAK-10785) update maven-shade-plugin version to 3.5.3

2024-05-02 Thread Manfred Baedke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manfred Baedke reassigned OAK-10785:


Assignee: Manfred Baedke  (was: Julian Reschke)

> update maven-shade-plugin version to 3.5.3
> --
>
> Key: OAK-10785
> URL: https://issues.apache.org/jira/browse/OAK-10785
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Manfred Baedke
>Priority: Minor
> Fix For: 1.62.0
>
>
> (previously defaulted)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OAK-10784) o.a.j.o.plugins.migration.version.VersionableEditor should create the version storage node, if needed

2024-05-02 Thread Manfred Baedke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manfred Baedke updated OAK-10784:
-
Description: 
The method VersionableEditor#createEmptyHistory() is called if the migration of 
versions is disabled, but the node type of a migrated node strictly requires it 
to be versionable, because it inherits from mix:versionable (so that 
mix:versionable can't simply be removed). This may fail if the version storage 
node has not been explicitly created before the migration. Just creating the 
necessary node would be a more straightforward behavior.
Also we should change the name of that method, see OAK-10783.

  was:The method VersionableEditor#createEmptyHistory() is called if the 
migration of versions is disabled, but the node type of a migrated node 
strictly requires it to be versionable, because it inherits from 
mix:versionable (so that mix:versionable can't simply be removed). This may 
fail if the version storage node has not been explicitly created before the 
migration. Just creating the necessary node would be a more straightforward 
behavior.


> o.a.j.o.plugins.migration.version.VersionableEditor should create the version 
> storage node, if needed
> -
>
> Key: OAK-10784
> URL: https://issues.apache.org/jira/browse/OAK-10784
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: core
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Major
>
> The method VersionableEditor#createEmptyHistory() is called if the migration 
> of versions is disabled, but the node type of a migrated node strictly 
> requires it to be versionable, because it inherits from mix:versionable (so 
> that mix:versionable can't simply be removed). This may fail if the version 
> storage node has not been explicitly created before the migration. Just 
> creating the necessary node would be a more straightforward behavior.
> Also we should change the name of that method, see OAK-10783.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OAK-10784) o.a.j.o.plugins.migration.version.VersionableEditor should create the version storage node, if needed

2024-05-02 Thread Manfred Baedke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manfred Baedke updated OAK-10784:
-
Description: The method VersionableEditor#createEmptyHistory() is called if 
the migration of versions is disabled, but the node type of a migrated node 
strictly requires it to be versionable, because it inherits from 
mix:versionable (so that mix:versionable can't simply be removed). This may 
fail if the version storage node has not been explicitly created before the 
migration. Just creating the necessary node would be a more straightforward 
behavior.  (was: The method VersionableEditor#createEmptyHistory() is called if 
the migration of versions is disabled, but the node type of a migrated node 
strictly requires it to be versionable, because it inherits from 
mix:versionable (so that mix:versionable can't simple be removed). This may 
fail if the version storage node has not been explicitly created before the 
migration. Just creating the necessary node would be a more straightforward 
behavior.)

> o.a.j.o.plugins.migration.version.VersionableEditor should create the version 
> storage node, if needed
> -
>
> Key: OAK-10784
> URL: https://issues.apache.org/jira/browse/OAK-10784
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: core
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Major
>
> The method VersionableEditor#createEmptyHistory() is called if the migration 
> of versions is disabled, but the node type of a migrated node strictly 
> requires it to be versionable, because it inherits from mix:versionable (so 
> that mix:versionable can't simply be removed). This may fail if the version 
> storage node has not been explicitly created before the migration. Just 
> creating the necessary node would be a more straightforward behavior.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OAK-10784) o.a.j.o.plugins.migration.version.VersionableEditor should created the version storage node, if needed

2024-05-02 Thread Manfred Baedke (Jira)
Manfred Baedke created OAK-10784:


 Summary: o.a.j.o.plugins.migration.version.VersionableEditor 
should created the version storage node, if needed
 Key: OAK-10784
 URL: https://issues.apache.org/jira/browse/OAK-10784
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: core
Reporter: Manfred Baedke
Assignee: Manfred Baedke


The method VersionableEditor#createEmptyHistory() is called if the migration of 
versions is disabled, but the node type of a migrated node strictly requires it 
to be versionable, because it inherits from mix:versionable (so that 
mix:versionable can't simple be removed). This may fail if the version storage 
node has not been explicitly created before the migration. Just creating the 
necessary node would be a more straightforward behavior.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OAK-10784) o.a.j.o.plugins.migration.version.VersionableEditor should create the version storage node, if needed

2024-05-02 Thread Manfred Baedke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manfred Baedke updated OAK-10784:
-
Summary: o.a.j.o.plugins.migration.version.VersionableEditor should create 
the version storage node, if needed  (was: 
o.a.j.o.plugins.migration.version.VersionableEditor should created the version 
storage node, if needed)

> o.a.j.o.plugins.migration.version.VersionableEditor should create the version 
> storage node, if needed
> -
>
> Key: OAK-10784
> URL: https://issues.apache.org/jira/browse/OAK-10784
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: core
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Major
>
> The method VersionableEditor#createEmptyHistory() is called if the migration 
> of versions is disabled, but the node type of a migrated node strictly 
> requires it to be versionable, because it inherits from mix:versionable (so 
> that mix:versionable can't simple be removed). This may fail if the version 
> storage node has not been explicitly created before the migration. Just 
> creating the necessary node would be a more straightforward behavior.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OAK-10662) improve Reproducible Builds

2024-05-02 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842936#comment-17842936
 ] 

Julian Reschke edited comment on OAK-10662 at 5/2/24 11:15 AM:
---

3.5.3 was released when Oak 1.62.0 was already done.

We'll need to update again.


was (Author: reschke):
When was 3.5.3 released?

> improve Reproducible Builds
> ---
>
> Key: OAK-10662
> URL: https://issues.apache.org/jira/browse/OAK-10662
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>Affects Versions: 1.60.0
>Reporter: Herve Boutemy
>Assignee: Julian Reschke
>Priority: Major
>
> release 1.60.0 is quite good: 143 ok, 11 ko
> there are some easy fixes
> and probably harder ones later
> see
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/oak/README.md



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10662) improve Reproducible Builds

2024-05-02 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842936#comment-17842936
 ] 

Julian Reschke commented on OAK-10662:
--

When was 3.5.3 released?

> improve Reproducible Builds
> ---
>
> Key: OAK-10662
> URL: https://issues.apache.org/jira/browse/OAK-10662
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>Affects Versions: 1.60.0
>Reporter: Herve Boutemy
>Assignee: Julian Reschke
>Priority: Major
>
> release 1.60.0 is quite good: 143 ok, 11 ko
> there are some easy fixes
> and probably harder ones later
> see
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/oak/README.md



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10776) Incremental FFS should filter out changes under paths excluded by pipelinedMongoCustomExcludedPaths

2024-05-02 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842921#comment-17842921
 ] 

Nitin Gupta commented on OAK-10776:
---

[https://github.com/apache/jackrabbit-oak/pull/1437/fileshttps://github.com/apache/jackrabbit-oak/pull/1437/files]
 PR 

> Incremental FFS should filter out changes under paths excluded by 
> pipelinedMongoCustomExcludedPaths
> ---
>
> Key: OAK-10776
> URL: https://issues.apache.org/jira/browse/OAK-10776
> Project: Jackrabbit Oak
>  Issue Type: Task
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
>
> Pipelined FFS introduced changes to add ability to exclude custom paths via 
> pipelinedMongoCustomExcludedPaths. 
> This should be supported in inc ffs diff as well.
> h4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OAK-10783) VersionableEditor: misleading WARN message when creating version history

2024-05-02 Thread Julian Reschke (Jira)
Julian Reschke created OAK-10783:


 Summary: VersionableEditor: misleading WARN message when creating 
version history
 Key: OAK-10783
 URL: https://issues.apache.org/jira/browse/OAK-10783
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: core
Reporter: Julian Reschke


It currently says:

"Creating empty version history."

This is somewhat misleading because a version history really never is empty.

Maybe:

"Creating initial version history."

?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OAK-10783) VersionableEditor: misleading WARN message when creating version history

2024-05-02 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke reassigned OAK-10783:


Assignee: Manfred Baedke

> VersionableEditor: misleading WARN message when creating version history
> 
>
> Key: OAK-10783
> URL: https://issues.apache.org/jira/browse/OAK-10783
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: core
>Reporter: Julian Reschke
>Assignee: Manfred Baedke
>Priority: Major
>
> It currently says:
> "Creating empty version history."
> This is somewhat misleading because a version history really never is empty.
> Maybe:
> "Creating initial version history."
> ?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-6773) Convert oak-store-composite to OSGi R7 annotations

2024-05-02 Thread Manfred Baedke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842879#comment-17842879
 ] 

Manfred Baedke commented on OAK-6773:
-

Thx [~ngupta], that was unfortunate, I unnecessarily changed signatures here 
and was somehow under the impression that I had already reverted that in the 
PR. Sorry for that.

> Convert oak-store-composite to OSGi R7 annotations
> --
>
> Key: OAK-6773
> URL: https://issues.apache.org/jira/browse/OAK-6773
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: composite
>Reporter: Robert Munteanu
>Assignee: Manfred Baedke
>Priority: Major
> Fix For: 1.64.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)