[jira] [Commented] (OAK-9371) SegmentStoreMigrator ability to not copy the journal
[
https://issues.apache.org/jira/browse/OAK-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294385#comment-17294385
]
Ieran Draghiciu commented on OAK-9371:
--
[~adulceanu] Could you please review my patch [^OAK-9371.patch] and commit it
if it's ok?
> SegmentStoreMigrator ability to not copy the journal
>
>
> Key: OAK-9371
> URL: https://issues.apache.org/jira/browse/OAK-9371
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Ieran Draghiciu
>Priority: Major
> Attachments: OAK-9371.patch
>
>
> We need the ability to not copy the journal using the SegmentStoreMigrator.
> This will be achieved by setting {{.withRevisionCount}} to 0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-9371) SegmentStoreMigrator ability to not copy the journal
[
https://issues.apache.org/jira/browse/OAK-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ieran Draghiciu updated OAK-9371:
-
Attachment: OAK-9371.patch
> SegmentStoreMigrator ability to not copy the journal
>
>
> Key: OAK-9371
> URL: https://issues.apache.org/jira/browse/OAK-9371
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Ieran Draghiciu
>Priority: Major
> Attachments: OAK-9371.patch
>
>
> We need the ability to not copy the journal using the SegmentStoreMigrator.
> This will be achieved by setting {{.withRevisionCount}} to 0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OAK-9371) SegmentStoreMigrator ability to not copy the journal
Ieran Draghiciu created OAK-9371:
Summary: SegmentStoreMigrator ability to not copy the journal
Key: OAK-9371
URL: https://issues.apache.org/jira/browse/OAK-9371
Project: Jackrabbit Oak
Issue Type: Improvement
Reporter: Ieran Draghiciu
We need the ability to not copy the journal using the SegmentStoreMigrator.
This will be achieved by setting {{.withRevisionCount}} to 0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-9293) SegmentStoreMigrator appendMode should recopy the last archive
[ https://issues.apache.org/jira/browse/OAK-9293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242257#comment-17242257 ] Ieran Draghiciu commented on OAK-9293: -- Please find attached patch [^OAK-9293.patch] > SegmentStoreMigrator appendMode should recopy the last archive > -- > > Key: OAK-9293 > URL: https://issues.apache.org/jira/browse/OAK-9293 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Ieran Draghiciu >Priority: Major > Attachments: OAK-9293.patch > > > SegmentStoreMigrator appendMode should recopy the last archive since new > segments could be added to it since last append. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-9293) SegmentStoreMigrator appendMode should recopy the last archive
[ https://issues.apache.org/jira/browse/OAK-9293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-9293: - Attachment: OAK-9293.patch > SegmentStoreMigrator appendMode should recopy the last archive > -- > > Key: OAK-9293 > URL: https://issues.apache.org/jira/browse/OAK-9293 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Ieran Draghiciu >Priority: Major > Attachments: OAK-9293.patch > > > SegmentStoreMigrator appendMode should recopy the last archive since new > segments could be added to it since last append. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-9293) SegmentStoreMigrator appendMode should recopy the last archive
Ieran Draghiciu created OAK-9293: Summary: SegmentStoreMigrator appendMode should recopy the last archive Key: OAK-9293 URL: https://issues.apache.org/jira/browse/OAK-9293 Project: Jackrabbit Oak Issue Type: Improvement Reporter: Ieran Draghiciu SegmentStoreMigrator appendMode should recopy the last archive since new segments could be added to it since last append. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8828) Configure the maximum number of journal entries to be copied with segment-copy
[
https://issues.apache.org/jira/browse/OAK-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997119#comment-16997119
]
Ieran Draghiciu commented on OAK-8828:
--
[~adulceanu] I added the patch: [^OAK-8828.patch]. Could you please review?
> Configure the maximum number of journal entries to be copied with segment-copy
> --
>
> Key: OAK-8828
> URL: https://issues.apache.org/jira/browse/OAK-8828
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-azure, segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Attachments: OAK-8828.patch
>
>
> We need the ability to configure the maximum number of journal entries (i.e.
> revisions) to be copied by {{oak-run segment-copy}}. This way we can void
> timeout issues when transferring a large journal over the network with the
> sole purpose to compact the repository.
> For this we can add a new optional argument {{--last }}, with the
> same semantics as {{oak-run check}}. If the argument is used, but a specific
> number of revisions is not specified, the tool will copy by default only the
> last revision.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8828) Configure the maximum number of journal entries to be copied with segment-copy
[
https://issues.apache.org/jira/browse/OAK-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ieran Draghiciu updated OAK-8828:
-
Attachment: OAK-8828.patch
> Configure the maximum number of journal entries to be copied with segment-copy
> --
>
> Key: OAK-8828
> URL: https://issues.apache.org/jira/browse/OAK-8828
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-azure, segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Attachments: OAK-8828.patch
>
>
> We need the ability to configure the maximum number of journal entries (i.e.
> revisions) to be copied by {{oak-run segment-copy}}. This way we can void
> timeout issues when transferring a large journal over the network with the
> sole purpose to compact the repository.
> For this we can add a new optional argument {{--last }}, with the
> same semantics as {{oak-run check}}. If the argument is used, but a specific
> number of revisions is not specified, the tool will copy by default only the
> last revision.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8828) Configure the maximum number of journal entries to be copied with segment-copy
[
https://issues.apache.org/jira/browse/OAK-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993416#comment-16993416
]
Ieran Draghiciu commented on OAK-8828:
--
[~adulceanu] Yes. I will start working on it today.
> Configure the maximum number of journal entries to be copied with segment-copy
> --
>
> Key: OAK-8828
> URL: https://issues.apache.org/jira/browse/OAK-8828
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-azure, segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
>
> We need the ability to configure the maximum number of journal entries (i.e.
> revisions) to be copied by {{oak-run segment-copy}}. This way we can void
> timeout issues when transferring a large journal over the network with the
> sole purpose to compact the repository.
> For this we can add a new optional argument {{--last }}, with the
> same semantics as {{oak-run check}}. If the argument is used, but a specific
> number of revisions is not specified, the tool will copy by default only the
> last revision.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8719) Oak run check command must return the status of repository consistency check
[ https://issues.apache.org/jira/browse/OAK-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8719: - Attachment: OAK-8719-1.patch > Oak run check command must return the status of repository consistency check > > > Key: OAK-8719 > URL: https://issues.apache.org/jira/browse/OAK-8719 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Ieran Draghiciu >Assignee: Andrei Dulceanu >Priority: Major > Labels: oak-run, segment-tar > Attachments: OAK-8719-1.patch, OAK-8719.patch > > > Currently the consistency check reports only if the command runs successfully > (return code 0) or fails (return code 1). > Into this logic will also add the status of repository consistency: > - checking only the last revision: will return 0 if the revision is > consistent and the command runs successfully OR will return 1 if the revision > is inconsistent or job did not run successfully (some errors/exception were > encountered during the run) > - checking multiple revisions: will return 0 if at least one revision is > consistent and the job runs successfully OR will return 1 if none of the > revisions are consistent or the command did not run successfully (some > errors/exception were encounter during the run) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8719) Oak run check command must return the status of repository consistency check
[ https://issues.apache.org/jira/browse/OAK-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961121#comment-16961121 ] Ieran Draghiciu commented on OAK-8719: -- [~adulceanu] thanks for the review. Makes sense. I made the changes in this patch: [^OAK-8719-1.patch] > Oak run check command must return the status of repository consistency check > > > Key: OAK-8719 > URL: https://issues.apache.org/jira/browse/OAK-8719 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Ieran Draghiciu >Assignee: Andrei Dulceanu >Priority: Major > Labels: oak-run, segment-tar > Attachments: OAK-8719-1.patch, OAK-8719.patch > > > Currently the consistency check reports only if the command runs successfully > (return code 0) or fails (return code 1). > Into this logic will also add the status of repository consistency: > - checking only the last revision: will return 0 if the revision is > consistent and the command runs successfully OR will return 1 if the revision > is inconsistent or job did not run successfully (some errors/exception were > encountered during the run) > - checking multiple revisions: will return 0 if at least one revision is > consistent and the job runs successfully OR will return 1 if none of the > revisions are consistent or the command did not run successfully (some > errors/exception were encounter during the run) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8719) Oak run job must return the status of repository consistency
[ https://issues.apache.org/jira/browse/OAK-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8719: - Attachment: (was: OAK-8719.patch) > Oak run job must return the status of repository consistency > > > Key: OAK-8719 > URL: https://issues.apache.org/jira/browse/OAK-8719 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Ieran Draghiciu >Priority: Major > Labels: oak-run, segment-tar > Attachments: OAK-8719.patch > > > Currently the consistency check reports only if the job runs successfully > (return code 0) or fails (return code 1). > Into this logic will also add the status of repository consistency: > - checking only the last revision: will return 0 if the revision is > consistent and the job runs successfully OR will return 1 if the revision is > inconsistent or job did not run successfully (some errors/exception were > encounter during the run) > - checking multiple revisions: will return 0 if at least one revision is > consistent and the job runs successfully OR will return 1 if none of the > revisions are consistent or job did not run successfully (some > errors/exception were encounter during the run) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8719) Oak run job must return the status of repository consistency
[ https://issues.apache.org/jira/browse/OAK-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8719: - Attachment: OAK-8719.patch > Oak run job must return the status of repository consistency > > > Key: OAK-8719 > URL: https://issues.apache.org/jira/browse/OAK-8719 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Ieran Draghiciu >Priority: Major > Labels: oak-run, segment-tar > Attachments: OAK-8719.patch > > > Currently the consistency check reports only if the job runs successfully > (return code 0) or fails (return code 1). > Into this logic will also add the status of repository consistency: > - checking only the last revision: will return 0 if the revision is > consistent and the job runs successfully OR will return 1 if the revision is > inconsistent or job did not run successfully (some errors/exception were > encounter during the run) > - checking multiple revisions: will return 0 if at least one revision is > consistent and the job runs successfully OR will return 1 if none of the > revisions are consistent or job did not run successfully (some > errors/exception were encounter during the run) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8719) Oak run job must return the status of repository consistency
[ https://issues.apache.org/jira/browse/OAK-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960956#comment-16960956 ] Ieran Draghiciu commented on OAK-8719: -- [~adulceanu] could you please review the patch: [^OAK-8719.patch] > Oak run job must return the status of repository consistency > > > Key: OAK-8719 > URL: https://issues.apache.org/jira/browse/OAK-8719 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Ieran Draghiciu >Priority: Major > Labels: oak-run, segment-tar > Attachments: OAK-8719.patch > > > Currently the consistency check reports only if the job runs successfully > (return code 0) or fails (return code 1). > Into this logic will also add the status of repository consistency: > - checking only the last revision: will return 0 if the revision is > consistent and the job runs successfully OR will return 1 if the revision is > inconsistent or job did not run successfully (some errors/exception were > encounter during the run) > - checking multiple revisions: will return 0 if at least one revision is > consistent and the job runs successfully OR will return 1 if none of the > revisions are consistent or job did not run successfully (some > errors/exception were encounter during the run) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8719) Oak run job must return the status of repository consistency
[ https://issues.apache.org/jira/browse/OAK-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8719: - Attachment: OAK-8719.patch > Oak run job must return the status of repository consistency > > > Key: OAK-8719 > URL: https://issues.apache.org/jira/browse/OAK-8719 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Ieran Draghiciu >Priority: Major > Labels: oak-run, segment-tar > Attachments: OAK-8719.patch > > > Currently the consistency check reports only if the job runs successfully > (return code 0) or fails (return code 1). > Into this logic will also add the status of repository consistency: > - checking only the last revision: will return 0 if the revision is > consistent and the job runs successfully OR will return 1 if the revision is > inconsistent or job did not run successfully (some errors/exception were > encounter during the run) > - checking multiple revisions: will return 0 if at least one revision is > consistent and the job runs successfully OR will return 1 if none of the > revisions are consistent or job did not run successfully (some > errors/exception were encounter during the run) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8719) Oak run job must return the status of repository consistency
[ https://issues.apache.org/jira/browse/OAK-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8719: - Description: Currently the consistency check reports only if the job runs successfully (return code 0) or fails (return code 1). Into this logic will also add the status of repository consistency: - checking only the last revision: will return 0 if the revision is consistent and the job runs successfully OR will return 1 if the revision is inconsistent or job did not run successfully (some errors/exception were encounter during the run) - checking multiple revisions: will return 0 if at least one revision is consistent and the job runs successfully OR will return 1 if none of the revisions are consistent or job did not run successfully (some errors/exception were encounter during the run) was: Currently the consistency check reports only if the job runs successfully (return code 0) or fails (return code 1). Into this logic will also add the status of repository consistency: - checking only the last revision: will return 0 if the the revision is consistent and the job runs successfully OR will return 1 if the revision is inconsistent or job did not run successfully (some errors/exception were encounter) - checking multiple revisions: will return 0 if at least one revision is consistent and the job runs successfully OR will return 1 if none of the revisions are consistent or job did not run successfully (some errors/exception were encounter) > Oak run job must return the status of repository consistency > > > Key: OAK-8719 > URL: https://issues.apache.org/jira/browse/OAK-8719 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Ieran Draghiciu >Priority: Major > Labels: oak-run, segment-tar > > Currently the consistency check reports only if the job runs successfully > (return code 0) or fails (return code 1). > Into this logic will also add the status of repository consistency: > - checking only the last revision: will return 0 if the revision is > consistent and the job runs successfully OR will return 1 if the revision is > inconsistent or job did not run successfully (some errors/exception were > encounter during the run) > - checking multiple revisions: will return 0 if at least one revision is > consistent and the job runs successfully OR will return 1 if none of the > revisions are consistent or job did not run successfully (some > errors/exception were encounter during the run) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8719) Oak run job must return the status of repository consistency
Ieran Draghiciu created OAK-8719: Summary: Oak run job must return the status of repository consistency Key: OAK-8719 URL: https://issues.apache.org/jira/browse/OAK-8719 Project: Jackrabbit Oak Issue Type: Improvement Reporter: Ieran Draghiciu Currently the consistency check reports only if the job runs successfully (return code 0) or fails (return code 1). Into this logic will also add the status of repository consistency: - checking only the last revision: will return 0 if the the revision is consistent and the job runs successfully OR will return 1 if the revision is inconsistent or job did not run successfully (some errors/exception were encounter) - checking multiple revisions: will return 0 if at least one revision is consistent and the job runs successfully OR will return 1 if none of the revisions are consistent or job did not run successfully (some errors/exception were encounter) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[
https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ieran Draghiciu updated OAK-8703:
-
Attachment: OAK-8703-04.patch
> Configure the maximum number of revisions to be checked by consistency check
>
>
> Key: OAK-8703
> URL: https://issues.apache.org/jira/browse/OAK-8703
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: oak-run, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8703-02.patch, OAK-8703-03.patch, OAK-8703-04.patch,
> OAK-8703.patch
>
>
> We need the ability to configure the maximum number of revisions to be
> checked by {{oak-run check}}. This way we can quickly tell whether there's a
> valid revision in the last {{n}} revisions. Moreover, this comes handy when
> we want to test only the last revision (current head state) of the repository.
> For this we can add a new optional argument {{--maxRevisionsToCheck}}. If the
> argument is used, but a specific number of revisions is not specified, the
> tool will check by default only the last revision.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[
https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956832#comment-16956832
]
Ieran Draghiciu commented on OAK-8703:
--
[~adulceanu] I added the final version: [^OAK-8703-04.patch]
Could you please review
> Configure the maximum number of revisions to be checked by consistency check
>
>
> Key: OAK-8703
> URL: https://issues.apache.org/jira/browse/OAK-8703
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: oak-run, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8703-02.patch, OAK-8703-03.patch, OAK-8703-04.patch,
> OAK-8703.patch
>
>
> We need the ability to configure the maximum number of revisions to be
> checked by {{oak-run check}}. This way we can quickly tell whether there's a
> valid revision in the last {{n}} revisions. Moreover, this comes handy when
> we want to test only the last revision (current head state) of the repository.
> For this we can add a new optional argument {{--maxRevisionsToCheck}}. If the
> argument is used, but a specific number of revisions is not specified, the
> tool will check by default only the last revision.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[
https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956134#comment-16956134
]
Ieran Draghiciu commented on OAK-8703:
--
added patch: [^OAK-8703-03.patch]
> Configure the maximum number of revisions to be checked by consistency check
>
>
> Key: OAK-8703
> URL: https://issues.apache.org/jira/browse/OAK-8703
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: oak-run, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8703-02.patch, OAK-8703-03.patch, OAK-8703.patch
>
>
> We need the ability to configure the maximum number of revisions to be
> checked by {{oak-run check}}. This way we can quickly tell whether there's a
> valid revision in the last {{n}} revisions. Moreover, this comes handy when
> we want to test only the last revision (current head state) of the repository.
> For this we can add a new optional argument {{--maxRevisionsToCheck}}. If the
> argument is used, but a specific number of revisions is not specified, the
> tool will check by default only the last revision.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[
https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956132#comment-16956132
]
Ieran Draghiciu commented on OAK-8703:
--
[~adulceanu] it doesn't work:
{code:java}
git diff --no-prefix upstream-trunk > OAK-8703-03.patch
fatal: ambiguous argument 'upstream-trunk': unknown revision or path not in the
working tree.
Use '--' to separate paths from revisions, like this:
'git [...] -- [...]'
{code}
> Configure the maximum number of revisions to be checked by consistency check
>
>
> Key: OAK-8703
> URL: https://issues.apache.org/jira/browse/OAK-8703
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: oak-run, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8703-02.patch, OAK-8703.patch
>
>
> We need the ability to configure the maximum number of revisions to be
> checked by {{oak-run check}}. This way we can quickly tell whether there's a
> valid revision in the last {{n}} revisions. Moreover, this comes handy when
> we want to test only the last revision (current head state) of the repository.
> For this we can add a new optional argument {{--maxRevisionsToCheck}}. If the
> argument is used, but a specific number of revisions is not specified, the
> tool will check by default only the last revision.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[
https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ieran Draghiciu updated OAK-8703:
-
Attachment: OAK-8703-03.patch
> Configure the maximum number of revisions to be checked by consistency check
>
>
> Key: OAK-8703
> URL: https://issues.apache.org/jira/browse/OAK-8703
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: oak-run, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8703-02.patch, OAK-8703-03.patch, OAK-8703.patch
>
>
> We need the ability to configure the maximum number of revisions to be
> checked by {{oak-run check}}. This way we can quickly tell whether there's a
> valid revision in the last {{n}} revisions. Moreover, this comes handy when
> we want to test only the last revision (current head state) of the repository.
> For this we can add a new optional argument {{--maxRevisionsToCheck}}. If the
> argument is used, but a specific number of revisions is not specified, the
> tool will check by default only the last revision.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[
https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ieran Draghiciu updated OAK-8703:
-
Description:
We need the ability to configure the maximum number of request to be verify by
the ConsistencyChecker. For this we are adding a new argument
{{--maxRevisionsToCheck}} (with default value 1).
Documentation changes:
{code:java}
The check tool inspects an existing Segment Store at PATH for eventual
inconsistencies. The algorithm implemented by this tool traverses the last
revision in the journal. The actual nodes and properties are traversed,
verifying that every piece of data is reachable and undamaged. If more then 1
revision must be verified, --maxRevisionsToCheck option can be used. Moreover,
if --head and --checkpoints options are used, the scope of the traversal can be
limited to head state and/or a subset of checkpoints. A deep scan of the
content tree, traversing every node and every property will be performed by
default. The default scope includes head state and all checkpoints.
The optional --maxRevisionsToCheck [Integer] argument can be used to control
the maximum number of revisions to be verified. Default value is 1. If the
first revision is not consistent configure the argument to 2. This will verify
the last 2 revisions. However if the first revision is consistent the
verification of the second revision is skipped.
{code}
was:
Add the ability to configure the maximum number of request to be verify by the
ConsistencyChecker:
Solution:
In *Check* builder added the *withMaxRevisionsToCheck(int
maxRevisionsToCheck)*: Instruct the command to check only the last
maxRevisionsToCheck
In *CheckCommand* added the option *maxRevisionsToCheck* with default value 1.
In *ConsistencyChecker* added the limitation to check only the
@maxRevisionsToCheck:
{code:java}
if(maxRevisionsToCheck == revisionCount){
break;
}
{code}
*Notes:*
if @maxRevisionsToCheck is configured 1 will check only the last revision.
if @maxRevisionsToCheck is configured 2 will check up to 2 revisions. if the
first revision is consistent will skip the second revision.
Documentation changes:
{code:java}
The check tool inspects an existing Segment Store at PATH for eventual
inconsistencies. The algorithm implemented by this tool traverses the last
revision in the journal. The actual nodes and properties are traversed,
verifying that every piece of data is reachable and undamaged. If more then 1
revision must be verified, --maxRevisionsToCheck option can be used. Moreover,
if --head and --checkpoints options are used, the scope of the traversal can be
limited to head state and/or a subset of checkpoints. A deep scan of the
content tree, traversing every node and every property will be performed by
default. The default scope includes head state and all checkpoints.
The optional --maxRevisionsToCheck [Integer] argument can be used to control
the maximum number of revisions to be verified. Default value is 1. If the
first revision is not consistent configure the argument to 2. This will verify
the last 2 revisions. However if the first revision is consistent the
verification of the second revision is skipped.
{code}
> Configure the maximum number of revisions to be checked by consistency check
>
>
> Key: OAK-8703
> URL: https://issues.apache.org/jira/browse/OAK-8703
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: oak-run, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8703-02.patch, OAK-8703.patch
>
>
> We need the ability to configure the maximum number of request to be verify
> by the ConsistencyChecker. For this we are adding a new argument
> {{--maxRevisionsToCheck}} (with default value 1).
>
>
>
>
> Documentation changes:
> {code:java}
> The check tool inspects an existing Segment Store at PATH for eventual
> inconsistencies. The algorithm implemented by this tool traverses the last
> revision in the journal. The actual nodes and properties are traversed,
> verifying that every piece of data is reachable and undamaged. If more then 1
> revision must be verified, --maxRevisionsToCheck option can be used.
> Moreover, if --head and --checkpoints options are used, the scope of the
> traversal can be limited to head state and/or a subset of checkpoints. A deep
> scan of the content tree, traversing every node and every property will be
> performed by default. The default scope includes head state and all
> checkpoints.
> The optional --maxRevisionsToCheck [Integer] argument can be used to control
> the maximum number of revisions to be verified. Default value is 1. If the
> first
[jira] [Updated] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[
https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ieran Draghiciu updated OAK-8703:
-
Attachment: OAK-8703-02.patch
> Configure the maximum number of revisions to be checked by consistency check
>
>
> Key: OAK-8703
> URL: https://issues.apache.org/jira/browse/OAK-8703
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: oak-run, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8703-02.patch, OAK-8703.patch
>
>
> Add the ability to configure the maximum number of request to be verify by
> the ConsistencyChecker:
> Solution:
> In *Check* builder added the *withMaxRevisionsToCheck(int
> maxRevisionsToCheck)*: Instruct the command to check only the last
> maxRevisionsToCheck
> In *CheckCommand* added the option *maxRevisionsToCheck* with default value
> 1.
> In *ConsistencyChecker* added the limitation to check only the
> @maxRevisionsToCheck:
> {code:java}
> if(maxRevisionsToCheck == revisionCount){
> break;
> }
> {code}
> *Notes:*
> if @maxRevisionsToCheck is configured 1 will check only the last revision.
> if @maxRevisionsToCheck is configured 2 will check up to 2 revisions. if the
> first revision is consistent will skip the second revision.
>
> Documentation changes:
> {code:java}
> The check tool inspects an existing Segment Store at PATH for eventual
> inconsistencies. The algorithm implemented by this tool traverses the last
> revision in the journal. The actual nodes and properties are traversed,
> verifying that every piece of data is reachable and undamaged. If more then 1
> revision must be verified, --maxRevisionsToCheck option can be used.
> Moreover, if --head and --checkpoints options are used, the scope of the
> traversal can be limited to head state and/or a subset of checkpoints. A deep
> scan of the content tree, traversing every node and every property will be
> performed by default. The default scope includes head state and all
> checkpoints.
> The optional --maxRevisionsToCheck [Integer] argument can be used to control
> the maximum number of revisions to be verified. Default value is 1. If the
> first revision is not consistent configure the argument to 2. This will
> verify the last 2 revisions. However if the first revision is consistent the
> verification of the second revision is skipped.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[
https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956011#comment-16956011
]
Ieran Draghiciu commented on OAK-8703:
--
I added the documentation update in the path: [^OAK-8703-02.patch]
> Configure the maximum number of revisions to be checked by consistency check
>
>
> Key: OAK-8703
> URL: https://issues.apache.org/jira/browse/OAK-8703
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: oak-run, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8703-02.patch, OAK-8703.patch
>
>
> Add the ability to configure the maximum number of request to be verify by
> the ConsistencyChecker:
> Solution:
> In *Check* builder added the *withMaxRevisionsToCheck(int
> maxRevisionsToCheck)*: Instruct the command to check only the last
> maxRevisionsToCheck
> In *CheckCommand* added the option *maxRevisionsToCheck* with default value
> 1.
> In *ConsistencyChecker* added the limitation to check only the
> @maxRevisionsToCheck:
> {code:java}
> if(maxRevisionsToCheck == revisionCount){
> break;
> }
> {code}
> *Notes:*
> if @maxRevisionsToCheck is configured 1 will check only the last revision.
> if @maxRevisionsToCheck is configured 2 will check up to 2 revisions. if the
> first revision is consistent will skip the second revision.
>
> Documentation changes:
> {code:java}
> The check tool inspects an existing Segment Store at PATH for eventual
> inconsistencies. The algorithm implemented by this tool traverses the last
> revision in the journal. The actual nodes and properties are traversed,
> verifying that every piece of data is reachable and undamaged. If more then 1
> revision must be verified, --maxRevisionsToCheck option can be used.
> Moreover, if --head and --checkpoints options are used, the scope of the
> traversal can be limited to head state and/or a subset of checkpoints. A deep
> scan of the content tree, traversing every node and every property will be
> performed by default. The default scope includes head state and all
> checkpoints.
> The optional --maxRevisionsToCheck [Integer] argument can be used to control
> the maximum number of revisions to be verified. Default value is 1. If the
> first revision is not consistent configure the argument to 2. This will
> verify the last 2 revisions. However if the first revision is consistent the
> verification of the second revision is skipped.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[
https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ieran Draghiciu updated OAK-8703:
-
Description:
Add the ability to configure the maximum number of request to be verify by the
ConsistencyChecker:
Solution:
In *Check* builder added the *withMaxRevisionsToCheck(int
maxRevisionsToCheck)*: Instruct the command to check only the last
maxRevisionsToCheck
In *CheckCommand* added the option *maxRevisionsToCheck* with default value 1.
In *ConsistencyChecker* added the limitation to check only the
@maxRevisionsToCheck:
{code:java}
if(maxRevisionsToCheck == revisionCount){
break;
}
{code}
*Notes:*
if @maxRevisionsToCheck is configured 1 will check only the last revision.
if @maxRevisionsToCheck is configured 2 will check up to 2 revisions. if the
first revision is consistent will skip the second revision.
Documentation changes:
{code:java}
The check tool inspects an existing Segment Store at PATH for eventual
inconsistencies. The algorithm implemented by this tool traverses the last
revision in the journal. The actual nodes and properties are traversed,
verifying that every piece of data is reachable and undamaged. If more then 1
revision must be verified, --maxRevisionsToCheck option can be used. Moreover,
if --head and --checkpoints options are used, the scope of the traversal can be
limited to head state and/or a subset of checkpoints. A deep scan of the
content tree, traversing every node and every property will be performed by
default. The default scope includes head state and all checkpoints.
The optional --maxRevisionsToCheck [Integer] argument can be used to control
the maximum number of revisions to be verified. Default value is 1. If the
first revision is not consistent configure the argument to 2. This will verify
the last 2 revisions. However if the first revision is consistent the
verification of the second revision is skipped.
{code}
was:
Add the ability to configure the maximum number of request to be verify by the
ConsistencyChecker:
Solution:
In *Check* builder added the *withMaxRevisionsToCheck(int
maxRevisionsToCheck)*: Instruct the command to check only the last
maxRevisionsToCheck
In *CheckCommand* added the option *maxRevisionsToCheck* with default value 1.
In *ConsistencyChecker* added the limitation to check only the
@maxRevisionsToCheck:
{code:java}
if(maxRevisionsToCheck == revisionCount){
break;
}
{code}
*Notes:*
if @maxRevisionsToCheck is configured 1 will check only the last revision.
if @maxRevisionsToCheck is configured 2 will check up to 2 revisions. if the
first revision is consistent will skip the second revision.
> Configure the maximum number of revisions to be checked by consistency check
>
>
> Key: OAK-8703
> URL: https://issues.apache.org/jira/browse/OAK-8703
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: oak-run, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8703.patch
>
>
> Add the ability to configure the maximum number of request to be verify by
> the ConsistencyChecker:
> Solution:
> In *Check* builder added the *withMaxRevisionsToCheck(int
> maxRevisionsToCheck)*: Instruct the command to check only the last
> maxRevisionsToCheck
> In *CheckCommand* added the option *maxRevisionsToCheck* with default value
> 1.
> In *ConsistencyChecker* added the limitation to check only the
> @maxRevisionsToCheck:
> {code:java}
> if(maxRevisionsToCheck == revisionCount){
> break;
> }
> {code}
> *Notes:*
> if @maxRevisionsToCheck is configured 1 will check only the last revision.
> if @maxRevisionsToCheck is configured 2 will check up to 2 revisions. if the
> first revision is consistent will skip the second revision.
>
> Documentation changes:
> {code:java}
> The check tool inspects an existing Segment Store at PATH for eventual
> inconsistencies. The algorithm implemented by this tool traverses the last
> revision in the journal. The actual nodes and properties are traversed,
> verifying that every piece of data is reachable and undamaged. If more then 1
> revision must be verified, --maxRevisionsToCheck option can be used.
> Moreover, if --head and --checkpoints options are used, the scope of the
> traversal can be limited to head state and/or a subset of checkpoints. A deep
> scan of the content tree, traversing every node and every property will be
> performed by default. The default scope includes head state and all
> checkpoints.
> The optional --maxRevisionsToCheck [Integer] argument can be used to control
> the maximum number of revisions to be verified. Default value is 1. If the
> first revision is not consistent
[jira] [Updated] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[
https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ieran Draghiciu updated OAK-8703:
-
Description:
Add the ability to configure the maximum number of request to be verify by the
ConsistencyChecker:
Solution:
In *Check* builder added the *withMaxRevisionsToCheck(int
maxRevisionsToCheck)*: Instruct the command to check only the last
maxRevisionsToCheck
In *CheckCommand* added the option *maxRevisionsToCheck* with default value 1.
In *ConsistencyChecker* added the limitation to check only the
@maxRevisionsToCheck:
{code:java}
if(maxRevisionsToCheck == revisionCount){
break;
}
{code}
*Notes:*
if @maxRevisionsToCheck is configured 1 will check only the last revision.
if @maxRevisionsToCheck is configured 2 will check up to 2 revisions. if the
first revision is consistent will skip the second revision.
was:
Add the ability to configure the maximum number of request to be verify by the
ConsistencyChecker:
Solution:
In *Check* builder added the *withMaxRevisionsToCheck(int
maxRevisionsToCheck)*: Instruct the command to check only the last
maxRevisionsToCheck
In *CheckCommand* added the option *maxRevisionsToCheck* with default value 1.
In *ConsistencyChecker* added the limitation to check only the
@maxRevisionsToCheck:
{code:java}
if(maxRevisionsToCheck == revisionCount){
break;
}
{code}
Note: if @maxRevisionsToCheck is configured 1 will check only the last
revision.
if @maxRevisionsToCheck is configured 2 will check up to 2 revisions.
if the first revision is consistent will skip the second revision.
> Configure the maximum number of revisions to be checked by consistency check
>
>
> Key: OAK-8703
> URL: https://issues.apache.org/jira/browse/OAK-8703
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: oak-run, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8703.patch
>
>
> Add the ability to configure the maximum number of request to be verify by
> the ConsistencyChecker:
> Solution:
> In *Check* builder added the *withMaxRevisionsToCheck(int
> maxRevisionsToCheck)*: Instruct the command to check only the last
> maxRevisionsToCheck
> In *CheckCommand* added the option *maxRevisionsToCheck* with default value 1.
> In *ConsistencyChecker* added the limitation to check only the
> @maxRevisionsToCheck:
> {code:java}
> if(maxRevisionsToCheck == revisionCount){
> break;
> }
> {code}
> *Notes:*
> if @maxRevisionsToCheck is configured 1 will check only the last revision.
> if @maxRevisionsToCheck is configured 2 will check up to 2 revisions. if the
> first revision is consistent will skip the second revision.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[
https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ieran Draghiciu updated OAK-8703:
-
Description:
Add the ability to configure the maximum number of request to be verify by the
ConsistencyChecker:
Solution:
In *Check* builder added the *withMaxRevisionsToCheck(int
maxRevisionsToCheck)*: Instruct the command to check only the last
maxRevisionsToCheck
In *CheckCommand* added the option *maxRevisionsToCheck* with default value 1.
In *ConsistencyChecker* added the limitation to check only the
@maxRevisionsToCheck:
{code:java}
if(maxRevisionsToCheck == revisionCount){
break;
}
{code}
Note: if @maxRevisionsToCheck is configured 1 will check only the last
revision.
if @maxRevisionsToCheck is configured 2 will check up to 2 revisions.
if the first revision is consistent will skip the second revision.
was:Add the ability to configure the maximum number of request to be verify
by the ConsistencyChecker
> Configure the maximum number of revisions to be checked by consistency check
>
>
> Key: OAK-8703
> URL: https://issues.apache.org/jira/browse/OAK-8703
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: oak-run, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8703.patch
>
>
> Add the ability to configure the maximum number of request to be verify by
> the ConsistencyChecker:
> Solution:
> In *Check* builder added the *withMaxRevisionsToCheck(int
> maxRevisionsToCheck)*: Instruct the command to check only the last
> maxRevisionsToCheck
> In *CheckCommand* added the option *maxRevisionsToCheck* with default value 1.
> In *ConsistencyChecker* added the limitation to check only the
> @maxRevisionsToCheck:
> {code:java}
> if(maxRevisionsToCheck == revisionCount){
> break;
> }
> {code}
> Note: if @maxRevisionsToCheck is configured 1 will check only the last
> revision.
> if @maxRevisionsToCheck is configured 2 will check up to 2
> revisions. if the first revision is consistent will skip the second revision.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[ https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8703: - Attachment: OAK-8703.patch > Configure the maximum number of revisions to be checked by consistency check > > > Key: OAK-8703 > URL: https://issues.apache.org/jira/browse/OAK-8703 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: oak-run, segment-tar >Reporter: Ieran Draghiciu >Assignee: Andrei Dulceanu >Priority: Major > Attachments: OAK-8703.patch > > > Add the ability to configure the maximum number of request to be verify by > the ConsistencyChecker -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[ https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8703: - Attachment: (was: OAK-8703_-Configure_the_maximum_number_of_revisions_to_be_checked_by_consistency_check.patch) > Configure the maximum number of revisions to be checked by consistency check > > > Key: OAK-8703 > URL: https://issues.apache.org/jira/browse/OAK-8703 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: oak-run, segment-tar >Reporter: Ieran Draghiciu >Assignee: Andrei Dulceanu >Priority: Major > > Add the ability to configure the maximum number of request to be verify by > the ConsistencyChecker -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[ https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8703: - Attachment: OAK-8703_-Configure_the_maximum_number_of_revisions_to_be_checked_by_consistency_check.patch > Configure the maximum number of revisions to be checked by consistency check > > > Key: OAK-8703 > URL: https://issues.apache.org/jira/browse/OAK-8703 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: oak-run, segment-tar >Reporter: Ieran Draghiciu >Assignee: Andrei Dulceanu >Priority: Major > Attachments: > OAK-8703_-Configure_the_maximum_number_of_revisions_to_be_checked_by_consistency_check.patch > > > Add the ability to configure the maximum number of request to be verify by > the ConsistencyChecker -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8703) Configure the maximum number of revisions to be checked by consistency check
[ https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955923#comment-16955923 ] Ieran Draghiciu commented on OAK-8703: -- [~adulceanu]Could you please review the patch attached? > Configure the maximum number of revisions to be checked by consistency check > > > Key: OAK-8703 > URL: https://issues.apache.org/jira/browse/OAK-8703 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: oak-run, segment-tar >Reporter: Ieran Draghiciu >Assignee: Andrei Dulceanu >Priority: Major > Attachments: > OAK-8703_-Configure_the_maximum_number_of_revisions_to_be_checked_by_consistency_check.patch > > > Add the ability to configure the maximum number of request to be verify by > the ConsistencyChecker -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8703) Configure the maximum number of revisions to be checked by Consistency
[ https://issues.apache.org/jira/browse/OAK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8703: - Description: Add the ability to configure the maximum number of request to be verify by the ConsistencyChecker (was: Add the ability to configure the maximum number of request to be verify by the ConsistencyCheck ) > Configure the maximum number of revisions to be checked by Consistency > --- > > Key: OAK-8703 > URL: https://issues.apache.org/jira/browse/OAK-8703 > Project: Jackrabbit Oak > Issue Type: New Feature >Reporter: Ieran Draghiciu >Priority: Major > Labels: oak-run > > Add the ability to configure the maximum number of request to be verify by > the ConsistencyChecker -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8703) Configure the maximum number of revisions to be checked by Consistency
Ieran Draghiciu created OAK-8703: Summary: Configure the maximum number of revisions to be checked by Consistency Key: OAK-8703 URL: https://issues.apache.org/jira/browse/OAK-8703 Project: Jackrabbit Oak Issue Type: New Feature Reporter: Ieran Draghiciu Add the ability to configure the maximum number of request to be verify by the ConsistencyCheck -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8522) Increase the Azure Maximum Execution Time
Ieran Draghiciu created OAK-8522: Summary: Increase the Azure Maximum Execution Time Key: OAK-8522 URL: https://issues.apache.org/jira/browse/OAK-8522 Project: Jackrabbit Oak Issue Type: Bug Components: segment-azure Reporter: Ieran Draghiciu -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OAK-8482) Remove false positives of SNFE on azure execution time out
[ https://issues.apache.org/jira/browse/OAK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887131#comment-16887131 ] Ieran Draghiciu commented on OAK-8482: -- Thanks [~dulceanu] for the test. [~frm] what do you think? It's safe to commit? I also tested manually by deleting segments from azure and the SNFE was generated. When we had the timeout from Azure a RepositoryNotReachableException was thrown. > Remove false positives of SNFE on azure execution time out > -- > > Key: OAK-8482 > URL: https://issues.apache.org/jira/browse/OAK-8482 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-azure, segment-tar >Reporter: Ieran Draghiciu >Assignee: Andrei Dulceanu >Priority: Major > Attachments: OAK-8482-03.patch, OAK-8482-04.patch, > OAK-SNFE-false-positives-02.diff > > > When reading a Tar file goes in execution time out a SNFE is thrown and the > SNFE metric is't increased. > We need to not increase the metric and add extra logging to SNFE. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (OAK-8482) Remove false positives of SNFE on azure execution time out
[ https://issues.apache.org/jira/browse/OAK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885063#comment-16885063 ] Ieran Draghiciu edited comment on OAK-8482 at 7/15/19 10:35 AM: [~frm] could you please take a look on the solution from [~dulceanu]: [^OAK-SNFE-false-positives-02.diff] also if you could assign the task to you was (Author: ierandra): [~frm] could you please take a look on the solution from [~dulceanu]: [^OAK-SNFE-false-positives-02.diff] > Remove false positives of SNFE on azure execution time out > -- > > Key: OAK-8482 > URL: https://issues.apache.org/jira/browse/OAK-8482 > Project: Jackrabbit Oak > Issue Type: Bug >Reporter: Ieran Draghiciu >Priority: Major > Attachments: OAK-SNFE-false-positives-02.diff > > > When reading a Tar file goes in execution time out a SNFE is thrown and the > SNFE metric is't increased. > We need to not increase the metric and add extra logging to SNFE. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OAK-8482) Remove false positives of SNFE on azure execution time out
[ https://issues.apache.org/jira/browse/OAK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885063#comment-16885063 ] Ieran Draghiciu commented on OAK-8482: -- [~frm] could you please take a look on the solution from [~dulceanu]: [^OAK-SNFE-false-positives-02.diff] > Remove false positives of SNFE on azure execution time out > -- > > Key: OAK-8482 > URL: https://issues.apache.org/jira/browse/OAK-8482 > Project: Jackrabbit Oak > Issue Type: Bug >Reporter: Ieran Draghiciu >Priority: Major > Attachments: OAK-SNFE-false-positives-02.diff > > > When reading a Tar file goes in execution time out a SNFE is thrown and the > SNFE metric is't increased. > We need to not increase the metric and add extra logging to SNFE. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (OAK-8482) Remove false positives of SNFE on azure execution time out
[ https://issues.apache.org/jira/browse/OAK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8482: - Attachment: OAK-SNFE-false-positives-02.diff > Remove false positives of SNFE on azure execution time out > -- > > Key: OAK-8482 > URL: https://issues.apache.org/jira/browse/OAK-8482 > Project: Jackrabbit Oak > Issue Type: Bug >Reporter: Ieran Draghiciu >Priority: Major > Attachments: OAK-SNFE-false-positives-02.diff > > > When reading a Tar file goes in execution time out a SNFE is thrown and the > SNFE metric is't increased. > We need to not increase the metric and add extra logging to SNFE. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (OAK-8482) Remove false positives of SNFE on azure execution time out
Ieran Draghiciu created OAK-8482: Summary: Remove false positives of SNFE on azure execution time out Key: OAK-8482 URL: https://issues.apache.org/jira/browse/OAK-8482 Project: Jackrabbit Oak Issue Type: Bug Reporter: Ieran Draghiciu Attachments: OAK-SNFE-false-positives-02.diff When reading a Tar file goes in execution time out a SNFE is thrown and the SNFE metric is't increased. We need to not increase the metric and add extra logging to SNFE. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (OAK-8417) SNFE after adding AzurePersistence timeouts
Ieran Draghiciu created OAK-8417:
Summary: SNFE after adding AzurePersistence timeouts
Key: OAK-8417
URL: https://issues.apache.org/jira/browse/OAK-8417
Project: Jackrabbit Oak
Issue Type: Bug
Reporter: Ieran Draghiciu
Attachments:
st-skyline-azure-50-aem-golden-publish-64f8479fdb-z6zl2-20190619.log,
st-skyline-azure-50-aem-golden-publish-77d44d7f55-7b2hl.log,
st-skyline-azure-50-aem-publish-86db485b5b-4fgp9.log,
st-skyline-azure-50-aem-publish-86db485b5b-mmk45.log,
st-skyline-azure-50-aem-publish-farmer-bcb8dc8bf-q9rtf.log
After adding Azure persistance timeouts
https://issues.apache.org/jira/browse/OAK-8406 SNFE are generated by Golden
Master Publish during replication:
{code:java}
19.06.2019 12:45:13.337 *ERROR* [pool-13-thread-5]
org.apache.jackrabbit.oak.segment.azure.queue.SegmentWriteQueue Can't persist
the segment aece1873-b677-4f07-ad48-bf624d91c666
java.io.IOException: com.microsoft.azure.storage.StorageException: The client
could not finish the operation within specified maximum execution timeout.
at
org.apache.jackrabbit.oak.segment.azure.AzureSegmentArchiveWriter.doWriteEntry(AzureSegmentArchiveWriter.java:96)
[org.apache.jackrabbit.oak-segment-azure:1.14.0.20190617]
at
org.apache.jackrabbit.oak.segment.azure.queue.SegmentWriteAction.passTo(SegmentWriteAction.java:55)
[org.apache.jackrabbit.oak-segment-azure:1.14.0.20190617]
at
org.apache.jackrabbit.oak.segment.azure.queue.SegmentWriteQueue.consume(SegmentWriteQueue.java:111)
[org.apache.jackrabbit.oak-segment-azure:1.14.0.20190617]
at
org.apache.jackrabbit.oak.segment.azure.queue.SegmentWriteQueue.consume(SegmentWriteQueue.java:105)
[org.apache.jackrabbit.oak-segment-azure:1.14.0.20190617]
at
org.apache.jackrabbit.oak.segment.azure.queue.SegmentWriteQueue.mainLoop(SegmentWriteQueue.java:84)
[org.apache.jackrabbit.oak-segment-azure:1.14.0.20190617]
{code}
See full logs for golden publish attached.
SNFE are also present on publishers. See full logs attached.
During consistency check (done by publish pharmer) no SNFE are found and the
job passes. See full logs attached.
cc [~dulceanu] [~frm] [~tomek.rekawek]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8366) Add remote store monitoring for Azure
[
https://issues.apache.org/jira/browse/OAK-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865453#comment-16865453
]
Ieran Draghiciu commented on OAK-8366:
--
[~tomek.rekawek] we decided to not upgrade to a newer version with this task.
We can do it in the future.
[oak-blob-cloud-azure|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-blob-cloud-azure/pom.xml#L118]
are using version {{5.0.0}} so if we decide to upgrade we coordinate with
them.
> Add remote store monitoring for Azure
> --
>
> Key: OAK-8366
> URL: https://issues.apache.org/jira/browse/OAK-8366
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: segment-azure
>Reporter: Ieran Draghiciu
>Assignee: Francesco Mari
>Priority: Major
> Labels: TarMK
> Fix For: 1.16.0
>
> Attachments: azure_remote_store_monitor_1.patch,
> azure_remote_store_monitorv2.patch, azure_remote_store_monitorv3.patch,
> azure_remote_store_monitorv4.patch
>
>
> Add remote store monitoring
> Implement the remote store monitoring for Azure Store. This should include:
> - request_count : number of request to azure store
> - error_count : number of failed requests to azure store
> - duration : duration of a request to azure store in nanoseconds
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8366) Add remote store monitoring for Azure
[ https://issues.apache.org/jira/browse/OAK-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8366: - Attachment: azure_remote_store_monitorv4.patch > Add remote store monitoring for Azure > -- > > Key: OAK-8366 > URL: https://issues.apache.org/jira/browse/OAK-8366 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: segment-azure >Reporter: Ieran Draghiciu >Assignee: Andrei Dulceanu >Priority: Major > Labels: TarMK > Attachments: azure_remote_store_monitor_1.patch, > azure_remote_store_monitorv2.patch, azure_remote_store_monitorv3.patch, > azure_remote_store_monitorv4.patch > > > Add remote store monitoring > Implement the remote store monitoring for Azure Store. This should include: > - request_count : number of request to azure store > - error_count : number of failed requests to azure store > - duration : duration of a request to azure store in nanoseconds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8366) Add remote store monitoring for Azure
[ https://issues.apache.org/jira/browse/OAK-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8366: - Attachment: azure_remote_store_monitorv3.patch > Add remote store monitoring for Azure > -- > > Key: OAK-8366 > URL: https://issues.apache.org/jira/browse/OAK-8366 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: segment-azure >Reporter: Ieran Draghiciu >Assignee: Andrei Dulceanu >Priority: Major > Labels: TarMK > Attachments: azure_remote_store_monitor_1.patch, > azure_remote_store_monitorv2.patch, azure_remote_store_monitorv3.patch > > > Add remote store monitoring > Implement the remote store monitoring for Azure Store. This should include: > - request_count : number of request to azure store > - error_count : number of failed requests to azure store > - duration : duration of a request to azure store in nanoseconds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8366) Add remote store monitoring for Azure
[
https://issues.apache.org/jira/browse/OAK-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858718#comment-16858718
]
Ieran Draghiciu commented on OAK-8366:
--
[~frm] thanks for the review. you are correct: the upgrade should be done in an
isolated issue and measure the impact.
So, I switched back to version {{5.0.0}}, removed
{{getGlobalErrorReceivingResponseEventHandler}} and move the full logic in
{{getGlobalRequestCompletedEventHandler}}
Patch: [^azure_remote_store_monitorv3.patch]
> Add remote store monitoring for Azure
> --
>
> Key: OAK-8366
> URL: https://issues.apache.org/jira/browse/OAK-8366
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: segment-azure
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Labels: TarMK
> Attachments: azure_remote_store_monitor_1.patch,
> azure_remote_store_monitorv2.patch, azure_remote_store_monitorv3.patch
>
>
> Add remote store monitoring
> Implement the remote store monitoring for Azure Store. This should include:
> - request_count : number of request to azure store
> - error_count : number of failed requests to azure store
> - duration : duration of a request to azure store in nanoseconds
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8366) Add remote store monitoring for Azure
[
https://issues.apache.org/jira/browse/OAK-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858640#comment-16858640
]
Ieran Draghiciu commented on OAK-8366:
--
[~frm] Based on your suggestion I did the following:
- removed the {{CompositeRemoteStoreMonitor}} and change the semantics of
{{FileStoreBuilder#withRemoteStoreMonitor}} to only accept a single instance of
{{CompositeRemoteStoreMonitor}}
- used {{com.microsoft.azure.storage.OperationContext}} in measuring the 3
metrics
Patch: [^azure_remote_store_monitorv2.patch]
However {{getGlobalErrorReceivingResponseEventHandler}} is available only from
{{com.microsoft.azure-azure-storage-v8.0.0}} so I updated the version we use.
[~tomek.rekawek] do you see any issue by updating the current version 5.0.0 to
8.0.0? do you think we should use the last one?
Here are the available versions:
https://mvnrepository.com/artifact/com.microsoft.azure/azure-storage
> Add remote store monitoring for Azure
> --
>
> Key: OAK-8366
> URL: https://issues.apache.org/jira/browse/OAK-8366
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: segment-azure
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Labels: TarMK
> Attachments: azure_remote_store_monitor_1.patch,
> azure_remote_store_monitorv2.patch
>
>
> Add remote store monitoring
> Implement the remote store monitoring for Azure Store. This should include:
> - request_count : number of request to azure store
> - error_count : number of failed requests to azure store
> - duration : duration of a request to azure store in nanoseconds
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8366) Add remote store monitoring for Azure
[ https://issues.apache.org/jira/browse/OAK-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8366: - Attachment: azure_remote_store_monitorv2.patch > Add remote store monitoring for Azure > -- > > Key: OAK-8366 > URL: https://issues.apache.org/jira/browse/OAK-8366 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: segment-azure >Reporter: Ieran Draghiciu >Assignee: Andrei Dulceanu >Priority: Major > Labels: TarMK > Attachments: azure_remote_store_monitor_1.patch, > azure_remote_store_monitorv2.patch > > > Add remote store monitoring > Implement the remote store monitoring for Azure Store. This should include: > - request_count : number of request to azure store > - error_count : number of failed requests to azure store > - duration : duration of a request to azure store in nanoseconds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8366) Add remote store monitoring for Azure
[ https://issues.apache.org/jira/browse/OAK-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854642#comment-16854642 ] Ieran Draghiciu commented on OAK-8366: -- [~frm] thanks for the review. I will make the changes and will provide a new patch when I will have the final version > Add remote store monitoring for Azure > -- > > Key: OAK-8366 > URL: https://issues.apache.org/jira/browse/OAK-8366 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: segment-azure >Reporter: Ieran Draghiciu >Assignee: Andrei Dulceanu >Priority: Major > Labels: TarMK > Attachments: azure_remote_store_monitor_1.patch > > > Add remote store monitoring > Implement the remote store monitoring for Azure Store. This should include: > - request_count : number of request to azure store > - error_count : number of failed requests to azure store > - duration : duration of a request to azure store in nanoseconds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8366) Add remote store monitoring for Azure
[ https://issues.apache.org/jira/browse/OAK-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854340#comment-16854340 ] Ieran Draghiciu commented on OAK-8366: -- [~frm] Here is the patch for the 3 metrics: [^azure_remote_store_monitor_1.patch] Could you please take look and let me know if its ok? > Add remote store monitoring for Azure > -- > > Key: OAK-8366 > URL: https://issues.apache.org/jira/browse/OAK-8366 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: segment-azure >Reporter: Ieran Draghiciu >Assignee: Andrei Dulceanu >Priority: Major > Labels: TarMK > Attachments: azure_remote_store_monitor_1.patch > > > Add remote store monitoring > Implement the remote store monitoring for Azure Store. This should include: > - request_count : number of request to azure store > - error_count : number of failed requests to azure store > - duration : duration of a request to azure store in nanoseconds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8366) Add remote store monitoring for Azure
[ https://issues.apache.org/jira/browse/OAK-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ieran Draghiciu updated OAK-8366: - Attachment: azure_remote_store_monitor_1.patch > Add remote store monitoring for Azure > -- > > Key: OAK-8366 > URL: https://issues.apache.org/jira/browse/OAK-8366 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: segment-azure >Reporter: Ieran Draghiciu >Assignee: Andrei Dulceanu >Priority: Major > Labels: TarMK > Attachments: azure_remote_store_monitor_1.patch > > > Add remote store monitoring > Implement the remote store monitoring for Azure Store. This should include: > - request_count : number of request to azure store > - error_count : number of failed requests to azure store > - duration : duration of a request to azure store in nanoseconds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-8366) Add remote store monitoring for Azure
Ieran Draghiciu created OAK-8366: Summary: Add remote store monitoring for Azure Key: OAK-8366 URL: https://issues.apache.org/jira/browse/OAK-8366 Project: Jackrabbit Oak Issue Type: New Feature Components: segment-azure Reporter: Ieran Draghiciu Add remote store monitoring Implement the remote store monitoring for Azure Store. This should include: - request_count : number of request to azure store - error_count : number of failed requests to azure store - duration : duration of a request to azure store in nanoseconds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
