[ 
https://issues.apache.org/jira/browse/OAK-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844619#comment-17844619
 ] 

Manfred Baedke edited comment on OAK-10784 at 5/8/24 10:31 AM:
---------------------------------------------------------------

??Under what circumstances would there ever by an Oak repository without 
version storage? Is there some buggy initialization code out there???

No, as soon as a Repo actually gets started on the migrated NodeStore, the 
version storage will be created. The migration works on NodeStore level, so 
there is no target repository during the process, just the NodeStore.


was (Author: baedke):
??Under what circumstances would there ever by an Oak repository without 
version storage? Is there some buggy initialization code out there???

No, as soon as a Repo actually gets started in the migrated NodeStore, the 
version storage will be created. The migration works on NodeStore level, so 
there is no target repository during the process, just the NodeStore.

> o.a.j.o.plugins.migration.version.VersionableEditor should create the version 
> storage node, if needed
> -----------------------------------------------------------------------------------------------------
>
>                 Key: OAK-10784
>                 URL: https://issues.apache.org/jira/browse/OAK-10784
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Manfred Baedke
>            Assignee: Manfred Baedke
>            Priority: Major
>             Fix For: 1.64.0
>
>
> The method VersionableEditor#createEmptyHistory() is called if the migration 
> of versions is disabled, but the node type of a migrated node strictly 
> requires it to be versionable, because it inherits from mix:versionable (so 
> that mix:versionable can't simply be removed). This may fail if the version 
> storage node has not been explicitly created before the migration. Just 
> creating the necessary node would be a more straightforward behavior.
> Also we should change the name of that method, see OAK-10783.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to