[
https://issues.apache.org/jira/browse/OAK-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203176#comment-16203176
]
Alex Deparvu edited comment on OAK-6826 at 10/13/17 8:41 AM:
-------------------------------------------------------------
first try on a WIP branch [0].
Similar to the {{InitialContent}} class I introduced a {{OakDefaultComponents}}
class in oak-core that hosts all the default values for various components we
initialise by default. this only moves the reference problem to oak-core, but
at least reduces oak-jcr dependency footprint.
Not sure what to do with
{{org.apache.jackrabbit.oak.plugins.index.IndexEditorProvider}} and
{{org.apache.jackrabbit.oak.plugins.observation.CommitRateLimiter}} yet.
Also, the only {{CommitHook}} we have left here is the {{VersionHook}} which
does not look like a commit hook at all (it's more of a composite editor), so I
think it would be worthwhile to refactor this class into a proper Editor.
[~tmueller], [~anchela] thoughts?
[edit] turned this issue into a subtask of the indexing refactoring to make it
more focused.
[0] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:OAK-6826
was (Author: alex.parvulescu):
first try on a WIP branch [0].
Similar to the {{InitialContent}} class I introduced a {{OakDefaultComponents}}
class in oak-core that hosts all the default values for various components we
initialise by default. this only moves the reference problem to oak-core, but
at least reduces oak-jcr dependency footprint.
Not sure what to do with
{{org.apache.jackrabbit.oak.plugins.index.IndexEditorProvider}} and
{{org.apache.jackrabbit.oak.plugins.observation.CommitRateLimiter}} yet.
Also, the only {{CommitHook}} we have left here is the {{VersionHook}} which
does not look like a commit hook at all (it's more of a composite editor), so I
think it would be worthwhile to refactor this class into a proper Editor.
[~tmueller], [~anchela] thoughts?
[0] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:OAK-6826
> Refactor Jcr class
> ------------------
>
> Key: OAK-6826
> URL: https://issues.apache.org/jira/browse/OAK-6826
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: jcr
> Reporter: Alex Deparvu
> Assignee: Alex Deparvu
> Priority: Minor
>
> I'd like to take a look at the Jcr class, to have it rely more on api/spi
> classes and reduce if possible references to oak-core impl.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
