[jira] [Commented] (OAK-3146) ExternalLoginModuleFactory should inject SyncManager and ExternalIdentityProviderManager
[
https://issues.apache.org/jira/browse/OAK-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653193#comment-14653193
]
Tino Truppel commented on OAK-3146:
---
Hi -
Is there any chance to get this back ported to 1.0.18? Thx
ExternalLoginModuleFactory should inject SyncManager and
ExternalIdentityProviderManager
Key: OAK-3146
URL: https://issues.apache.org/jira/browse/OAK-3146
Project: Jackrabbit Oak
Issue Type: Improvement
Components: security
Reporter: Chetan Mehrotra
Priority: Minor
Labels: performance
Fix For: 1.3.5
Attachments: OAK-3146.patch
{{ExternalLoginModule}} currently performs a lookup of {{SyncManager}} and
{{ExternalIdentityProviderManager}} in initialize call which performs service
lookup using ServiceTracker. Doing a service lookup in critical path would
have adverse performance impact.
Instead of performing the lookup {{ExternalLoginModuleFactory}} should track
the two manager instances and pass them to {{ExternalLoginModule}}. This
would ensure that expensive operation like service lookup is not performed in
critical path
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3146) ExternalLoginModuleFactory should inject SyncManager and ExternalIdentityProviderManager
[
https://issues.apache.org/jira/browse/OAK-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653192#comment-14653192
]
Tino Truppel commented on OAK-3146:
---
Hi -
Is there any chance to get this back ported to 1.0.18? Thx
ExternalLoginModuleFactory should inject SyncManager and
ExternalIdentityProviderManager
Key: OAK-3146
URL: https://issues.apache.org/jira/browse/OAK-3146
Project: Jackrabbit Oak
Issue Type: Improvement
Components: security
Reporter: Chetan Mehrotra
Priority: Minor
Labels: performance
Fix For: 1.3.5
Attachments: OAK-3146.patch
{{ExternalLoginModule}} currently performs a lookup of {{SyncManager}} and
{{ExternalIdentityProviderManager}} in initialize call which performs service
lookup using ServiceTracker. Doing a service lookup in critical path would
have adverse performance impact.
Instead of performing the lookup {{ExternalLoginModuleFactory}} should track
the two manager instances and pass them to {{ExternalLoginModule}}. This
would ensure that expensive operation like service lookup is not performed in
critical path
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3146) ExternalLoginModuleFactory should inject SyncManager and ExternalIdentityProviderManager
[
https://issues.apache.org/jira/browse/OAK-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644046#comment-14644046
]
Chetan Mehrotra commented on OAK-3146:
--
bq. you filed this issue with the label 'performance' but fixed the issue
without even verifying i.e. writing a benchmark test that would prove that you
actually found/fixed a performance issue.
For me the issue was logical one as its knows that frequent lookup on
ServiceRegistry is slow and becomes a bottleneck. Reproducing such performance
issue is tricky and hence I went ahead with the proposed fix based on _logical_
understanding of the problem and from my previous experience in such issues
bq. there is not auto-backport for improvements and i want you to revert that.
Have reverted the various changes now
Unassigning the issue now as I would not have time to create a benchmark for
this issue
ExternalLoginModuleFactory should inject SyncManager and
ExternalIdentityProviderManager
Key: OAK-3146
URL: https://issues.apache.org/jira/browse/OAK-3146
Project: Jackrabbit Oak
Issue Type: Improvement
Components: security
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
Priority: Minor
Labels: performance
Fix For: 1.3.4
Attachments: OAK-3146.patch
{{ExternalLoginModule}} currently performs a lookup of {{SyncManager}} and
{{ExternalIdentityProviderManager}} in initialize call which performs service
lookup using ServiceTracker. Doing a service lookup in critical path would
have adverse performance impact.
Instead of performing the lookup {{ExternalLoginModuleFactory}} should track
the two manager instances and pass them to {{ExternalLoginModule}}. This
would ensure that expensive operation like service lookup is not performed in
critical path
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3146) ExternalLoginModuleFactory should inject SyncManager and ExternalIdentityProviderManager
[
https://issues.apache.org/jira/browse/OAK-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644806#comment-14644806
]
Tobias Bocanegra commented on OAK-3146:
---
I would just remove the performance label and fix the issue w/o benchmark. from
the description and code-flow it is obvious that it can inconsistent situations
when the login module is initialized during the logout phase. so not directly
performance related.
ExternalLoginModuleFactory should inject SyncManager and
ExternalIdentityProviderManager
Key: OAK-3146
URL: https://issues.apache.org/jira/browse/OAK-3146
Project: Jackrabbit Oak
Issue Type: Improvement
Components: security
Reporter: Chetan Mehrotra
Priority: Minor
Labels: performance
Fix For: 1.3.4
Attachments: OAK-3146.patch
{{ExternalLoginModule}} currently performs a lookup of {{SyncManager}} and
{{ExternalIdentityProviderManager}} in initialize call which performs service
lookup using ServiceTracker. Doing a service lookup in critical path would
have adverse performance impact.
Instead of performing the lookup {{ExternalLoginModuleFactory}} should track
the two manager instances and pass them to {{ExternalLoginModule}}. This
would ensure that expensive operation like service lookup is not performed in
critical path
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3146) ExternalLoginModuleFactory should inject SyncManager and ExternalIdentityProviderManager
[
https://issues.apache.org/jira/browse/OAK-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644803#comment-14644803
]
Tobias Bocanegra commented on OAK-3146:
---
bq. there is not auto-backport for improvements and i want you to revert that.
I disagree. if you already know that you need to backport the fix, you can do
this right away - since you already know what to change it is easier than
re-visit the code later.
ExternalLoginModuleFactory should inject SyncManager and
ExternalIdentityProviderManager
Key: OAK-3146
URL: https://issues.apache.org/jira/browse/OAK-3146
Project: Jackrabbit Oak
Issue Type: Improvement
Components: security
Reporter: Chetan Mehrotra
Priority: Minor
Labels: performance
Fix For: 1.3.4
Attachments: OAK-3146.patch
{{ExternalLoginModule}} currently performs a lookup of {{SyncManager}} and
{{ExternalIdentityProviderManager}} in initialize call which performs service
lookup using ServiceTracker. Doing a service lookup in critical path would
have adverse performance impact.
Instead of performing the lookup {{ExternalLoginModuleFactory}} should track
the two manager instances and pass them to {{ExternalLoginModule}}. This
would ensure that expensive operation like service lookup is not performed in
critical path
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
