[jira] [Commented] (OAK-3997) Include eviction cause to the LIRS removal callback

2016-08-08 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/OAK-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411633#comment-15411633
 ] 

Tomek Rękawek commented on OAK-3997:


Backported to 1.2.x in [r1755491|https://svn.apache.org/r1755491].

> Include eviction cause to the LIRS removal callback
> ---
>
> Key: OAK-3997
> URL: https://issues.apache.org/jira/browse/OAK-3997
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: cache
>Reporter: Tomek Rękawek
>Assignee: Marcel Reutegger
> Fix For: 1.4, 1.3.16, 1.2.18
>
> Attachments: OAK-3997-1.2.patch, OAK-3997-trunk.patch
>
>
> Enhance the {{EvictionCallback#evicted()}} method with a new argument: 
> {{cause}}. It may be a Guava {{com.google.common.cache.RemovalCause}}, even 
> though the {{COLLECTED}} and {{EXPIRED}} won't be used, as LIRS cache doesn't 
> support weak values and TTL yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-3997) Include eviction cause to the LIRS removal callback

2016-02-16 Thread Marcel Reutegger (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148350#comment-15148350
 ] 

Marcel Reutegger commented on OAK-3997:
---

See Tomek's comment regarding the oak-parent/pom.xml

> Include eviction cause to the LIRS removal callback
> ---
>
> Key: OAK-3997
> URL: https://issues.apache.org/jira/browse/OAK-3997
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: cache
>Reporter: Tomek Rękawek
>Assignee: Marcel Reutegger
>  Labels: candidate_oak_1_2
> Fix For: 1.3.16
>
> Attachments: OAK-3997-1.2.patch, OAK-3997-trunk.patch
>
>
> Enhance the {{EvictionCallback#evicted()}} method with a new argument: 
> {{cause}}. It may be a Guava {{com.google.common.cache.RemovalCause}}, even 
> though the {{COLLECTED}} and {{EXPIRED}} won't be used, as LIRS cache doesn't 
> support weak values and TTL yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-3997) Include eviction cause to the LIRS removal callback

2016-02-16 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/OAK-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148351#comment-15148351
 ] 

Tomek Rękawek commented on OAK-3997:


[~tmueller], see my comment above about the changed in {{oak-parent/pom.xml}}.

> Include eviction cause to the LIRS removal callback
> ---
>
> Key: OAK-3997
> URL: https://issues.apache.org/jira/browse/OAK-3997
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: cache
>Reporter: Tomek Rękawek
>Assignee: Marcel Reutegger
>  Labels: candidate_oak_1_2
> Fix For: 1.3.16
>
> Attachments: OAK-3997-1.2.patch, OAK-3997-trunk.patch
>
>
> Enhance the {{EvictionCallback#evicted()}} method with a new argument: 
> {{cause}}. It may be a Guava {{com.google.common.cache.RemovalCause}}, even 
> though the {{COLLECTED}} and {{EXPIRED}} won't be used, as LIRS cache doesn't 
> support weak values and TTL yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-3997) Include eviction cause to the LIRS removal callback

2016-02-16 Thread Marcel Reutegger (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148349#comment-15148349
 ] 

Marcel Reutegger commented on OAK-3997:
---

Right, thanks for the pointer.

> Include eviction cause to the LIRS removal callback
> ---
>
> Key: OAK-3997
> URL: https://issues.apache.org/jira/browse/OAK-3997
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: cache
>Reporter: Tomek Rękawek
>Assignee: Marcel Reutegger
>  Labels: candidate_oak_1_2
> Fix For: 1.3.16
>
> Attachments: OAK-3997-1.2.patch, OAK-3997-trunk.patch
>
>
> Enhance the {{EvictionCallback#evicted()}} method with a new argument: 
> {{cause}}. It may be a Guava {{com.google.common.cache.RemovalCause}}, even 
> though the {{COLLECTED}} and {{EXPIRED}} won't be used, as LIRS cache doesn't 
> support weak values and TTL yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-3997) Include eviction cause to the LIRS removal callback

2016-02-16 Thread Thomas Mueller (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148348#comment-15148348
 ] 

Thomas Mueller commented on OAK-3997:
-

Without the package-info.java, the trunk doesn't compile for me: "[ERROR] 
org.apache.jackrabbit.oak.cache: Version increase required; detected 0.0.0, 
suggested 1.0.0". But adding the file is probably not what we want for 1.4, as 
the cache is not intented to be used externally (outside of Oak).

> Include eviction cause to the LIRS removal callback
> ---
>
> Key: OAK-3997
> URL: https://issues.apache.org/jira/browse/OAK-3997
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: cache
>Reporter: Tomek Rękawek
>Assignee: Marcel Reutegger
>  Labels: candidate_oak_1_2
> Fix For: 1.3.16
>
> Attachments: OAK-3997-1.2.patch, OAK-3997-trunk.patch
>
>
> Enhance the {{EvictionCallback#evicted()}} method with a new argument: 
> {{cause}}. It may be a Guava {{com.google.common.cache.RemovalCause}}, even 
> though the {{COLLECTED}} and {{EXPIRED}} won't be used, as LIRS cache doesn't 
> support weak values and TTL yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-3997) Include eviction cause to the LIRS removal callback

2016-02-16 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/OAK-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148311#comment-15148311
 ] 

Tomek Rękawek commented on OAK-3997:


Regarding the package-info, please remember to add 
{{!org.apache.jackrabbit.oak.cache}} filter to the baseline configuration in 
{{oak-parent/pom.xml}} (otherwise there'll be baseline errors).

> Include eviction cause to the LIRS removal callback
> ---
>
> Key: OAK-3997
> URL: https://issues.apache.org/jira/browse/OAK-3997
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: cache
>Reporter: Tomek Rękawek
>Assignee: Marcel Reutegger
> Fix For: 1.4, 1.2.12
>
> Attachments: OAK-3997-1.2.patch, OAK-3997-trunk.patch
>
>
> Enhance the {{EvictionCallback#evicted()}} method with a new argument: 
> {{cause}}. It may be a Guava {{com.google.common.cache.RemovalCause}}, even 
> though the {{COLLECTED}} and {{EXPIRED}} won't be used, as LIRS cache doesn't 
> support weak values and TTL yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-3997) Include eviction cause to the LIRS removal callback

2016-02-16 Thread Marcel Reutegger (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148307#comment-15148307
 ] 

Marcel Reutegger commented on OAK-3997:
---

Patch looks good, except for the exported package as noted by Thomas. This is 
considered Oak internal and we don't want to maintain it as a public API.

> Include eviction cause to the LIRS removal callback
> ---
>
> Key: OAK-3997
> URL: https://issues.apache.org/jira/browse/OAK-3997
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: cache
>Reporter: Tomek Rękawek
> Fix For: 1.4, 1.2.12
>
> Attachments: OAK-3997-1.2.patch, OAK-3997-trunk.patch
>
>
> Enhance the {{EvictionCallback#evicted()}} method with a new argument: 
> {{cause}}. It may be a Guava {{com.google.common.cache.RemovalCause}}, even 
> though the {{COLLECTED}} and {{EXPIRED}} won't be used, as LIRS cache doesn't 
> support weak values and TTL yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-3997) Include eviction cause to the LIRS removal callback

2016-02-16 Thread Thomas Mueller (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148304#comment-15148304
 ] 

Thomas Mueller commented on OAK-3997:
-

As for 
oak-core/src/main/java/org/apache/jackrabbit/oak/cache/package-info.java: I 
think we don't want to use package-info for 1.4, see also OAK-3842 where most 
of those files where removed.

Other than that, the patches look good to me.

> Include eviction cause to the LIRS removal callback
> ---
>
> Key: OAK-3997
> URL: https://issues.apache.org/jira/browse/OAK-3997
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: cache
>Reporter: Tomek Rękawek
> Fix For: 1.4, 1.2.12
>
> Attachments: OAK-3997-1.2.patch, OAK-3997-trunk.patch
>
>
> Enhance the {{EvictionCallback#evicted()}} method with a new argument: 
> {{cause}}. It may be a Guava {{com.google.common.cache.RemovalCause}}, even 
> though the {{COLLECTED}} and {{EXPIRED}} won't be used, as LIRS cache doesn't 
> support weak values and TTL yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)