[jira] [Commented] (OAK-4103) Replace journal.log with an in place journal
[ https://issues.apache.org/jira/browse/OAK-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848150#comment-15848150 ] Michael Dürig commented on OAK-4103: Moved this to improvement as this is more involved than a technical task. > Replace journal.log with an in place journal > > > Key: OAK-4103 > URL: https://issues.apache.org/jira/browse/OAK-4103 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: segment-tar >Reporter: Michael Dürig >Assignee: Andrei Dulceanu >Priority: Minor > Labels: resilience > Fix For: 1.8 > > > Instead of writing the current head revision to the {{journal.log}} file we > could make it an integral part of the node states: as OAK-3804 demonstrates > we already have very good heuristics to reconstruct a lost journal. If we add > the right annotations to the root node states this could replace the current > approach. The latter is problematic as it relies on the flush thread properly > and timely updating {{journal.log}}. See e.g. OAK-3303. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-4103) Replace journal.log with an in place journal
[ https://issues.apache.org/jira/browse/OAK-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426101#comment-15426101 ] Michael Dürig commented on OAK-4103: The simplest way to implement this would probably be to introduce a special kind record type (e.g. {{RecordType.ROOT_NODE}}). Then we could just scan backwards through the segments until we find the first root node. However, we need to be very careful here as this could easily re-introduce OAK-4291 through the back door. > Replace journal.log with an in place journal > > > Key: OAK-4103 > URL: https://issues.apache.org/jira/browse/OAK-4103 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: segment-tar >Reporter: Michael Dürig >Assignee: Andrei Dulceanu >Priority: Minor > Labels: resilience > > Instead of writing the current head revision to the {{journal.log}} file we > could make it an integral part of the node states: as OAK-3804 demonstrates > we already have very good heuristics to reconstruct a lost journal. If we add > the right annotations to the root node states this could replace the current > approach. The latter is problematic as it relies on the flush thread properly > and timely updating {{journal.log}}. See e.g. OAK-3303. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-4103) Replace journal.log with an in place journal
[ https://issues.apache.org/jira/browse/OAK-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370618#comment-15370618 ] Andrei Dulceanu commented on OAK-4103: -- [~frm] I'd like to work on this issue. Can you please assign it to me? > Replace journal.log with an in place journal > > > Key: OAK-4103 > URL: https://issues.apache.org/jira/browse/OAK-4103 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: segment-tar >Reporter: Michael Dürig >Priority: Minor > Labels: resilience > Fix For: 1.6, Segment Tar 0.0.4 > > > Instead of writing the current head revision to the {{journal.log}} file we > could make it an integral part of the node states: as OAK-3804 demonstrates > we already have very good heuristics to reconstruct a lost journal. If we add > the right annotations to the root node states this could replace the current > approach. The latter is problematic as it relies on the flush thread properly > and timely updating {{journal.log}}. See e.g. OAK-3303. -- This message was sent by Atlassian JIRA (v6.3.4#6332)