[jira] [Commented] (OAK-4390) DocumentStoreStatsIT.update fails when RDB's append mode is disabled

2017-02-20 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874625#comment-15874625
 ] 

Julian Reschke commented on OAK-4390:
-

trunk: [r1783773|http://svn.apache.org/r1783773]


> DocumentStoreStatsIT.update fails when RDB's append mode is disabled
> 
>
> Key: OAK-4390
> URL: https://issues.apache.org/jira/browse/OAK-4390
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: rdbmk
>Affects Versions: 1.4.13, 1.6.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>  Labels: candidate_oak_1_4, candidate_oak_1_6
> Fix For: 1.7.0, 1.8
>
> Attachments: OAK-4390.diff
>
>
> When run with 
> {{-Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.NOAPPEND=true}}
>  (see OAK-4389):
> {noformat}
> update[RDBFixture: 
> RDB-Postgres](org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsIT)
>   Time elapsed: 0.008 sec  <<< FAILURE!
> Wanted but not invoked:
> documentStoreStatsCollector.doneUpdate(
> ,
> nodes,
> 2
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsIT.update(DocumentStoreStatsIT.java:128)
> However, there were other interactions with this mock:
> documentStoreStatsCollector.doneCreate(
> 1747821,
> nodes,
> [update[RDBFixture: RDB-Postgres]],
> true
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.internalCreate(RDBDocumentStore.java:1182)
> documentStoreStatsCollector.doneFindUncached(
> 845900,
> nodes,
> "update[RDBFixture: RDB-Postgres]-478ebbb3-cb70-409d-af13-f1b2c11c4103",
> false,
> false
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.readDocumentUncached(RDBDocumentStore.java:1484)
> documentStoreStatsCollector.doneFindCached(
> nodes,
> "update[RDBFixture: RDB-Postgres]"
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.readDocumentCached(RDBDocumentStore.java:1093)
> documentStoreStatsCollector.doneFindAndModify(
> 1521593,
> nodes,
> "update[RDBFixture: RDB-Postgres]",
> false,
> true,
> -1
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.internalUpdate(RDBDocumentStore.java:1299)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OAK-4390) DocumentStoreStatsIT.update fails when RDB's append mode is disabled

2017-02-20 Thread Chetan Mehrotra (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874416#comment-15874416
 ] 

Chetan Mehrotra commented on OAK-4390:
--

+1. Looks good

> DocumentStoreStatsIT.update fails when RDB's append mode is disabled
> 
>
> Key: OAK-4390
> URL: https://issues.apache.org/jira/browse/OAK-4390
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: rdbmk
>Affects Versions: 1.4.13, 1.6.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
> Attachments: OAK-4390.diff
>
>
> When run with 
> {{-Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.NOAPPEND=true}}
>  (see OAK-4389):
> {noformat}
> update[RDBFixture: 
> RDB-Postgres](org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsIT)
>   Time elapsed: 0.008 sec  <<< FAILURE!
> Wanted but not invoked:
> documentStoreStatsCollector.doneUpdate(
> ,
> nodes,
> 2
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsIT.update(DocumentStoreStatsIT.java:128)
> However, there were other interactions with this mock:
> documentStoreStatsCollector.doneCreate(
> 1747821,
> nodes,
> [update[RDBFixture: RDB-Postgres]],
> true
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.internalCreate(RDBDocumentStore.java:1182)
> documentStoreStatsCollector.doneFindUncached(
> 845900,
> nodes,
> "update[RDBFixture: RDB-Postgres]-478ebbb3-cb70-409d-af13-f1b2c11c4103",
> false,
> false
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.readDocumentUncached(RDBDocumentStore.java:1484)
> documentStoreStatsCollector.doneFindCached(
> nodes,
> "update[RDBFixture: RDB-Postgres]"
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.readDocumentCached(RDBDocumentStore.java:1093)
> documentStoreStatsCollector.doneFindAndModify(
> 1521593,
> nodes,
> "update[RDBFixture: RDB-Postgres]",
> false,
> true,
> -1
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.internalUpdate(RDBDocumentStore.java:1299)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OAK-4390) DocumentStoreStatsIT.update fails when RDB's append mode is disabled

2016-05-22 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295905#comment-15295905
 ] 

Julian Reschke commented on OAK-4390:
-

Ack.

So when I have time I'll try to find a way to fix this properly...

> DocumentStoreStatsIT.update fails when RDB's append mode is disabled
> 
>
> Key: OAK-4390
> URL: https://issues.apache.org/jira/browse/OAK-4390
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: rdbmk
>Affects Versions: 1.4.2, 1.5.2
>Reporter: Julian Reschke
>
> When run with 
> {{-Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.NOAPPEND=true}}
>  (see OAK-4389):
> {noformat}
> update[RDBFixture: 
> RDB-Postgres](org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsIT)
>   Time elapsed: 0.008 sec  <<< FAILURE!
> Wanted but not invoked:
> documentStoreStatsCollector.doneUpdate(
> ,
> nodes,
> 2
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsIT.update(DocumentStoreStatsIT.java:128)
> However, there were other interactions with this mock:
> documentStoreStatsCollector.doneCreate(
> 1747821,
> nodes,
> [update[RDBFixture: RDB-Postgres]],
> true
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.internalCreate(RDBDocumentStore.java:1182)
> documentStoreStatsCollector.doneFindUncached(
> 845900,
> nodes,
> "update[RDBFixture: RDB-Postgres]-478ebbb3-cb70-409d-af13-f1b2c11c4103",
> false,
> false
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.readDocumentUncached(RDBDocumentStore.java:1484)
> documentStoreStatsCollector.doneFindCached(
> nodes,
> "update[RDBFixture: RDB-Postgres]"
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.readDocumentCached(RDBDocumentStore.java:1093)
> documentStoreStatsCollector.doneFindAndModify(
> 1521593,
> nodes,
> "update[RDBFixture: RDB-Postgres]",
> false,
> true,
> -1
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.internalUpdate(RDBDocumentStore.java:1299)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-4390) DocumentStoreStatsIT.update fails when RDB's append mode is disabled

2016-05-22 Thread Chetan Mehrotra (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295901#comment-15295901
 ] 

Chetan Mehrotra commented on OAK-4390:
--

[~reschke] couple of reasons around doing this at low level
# Record stats only when call is made to remote and not when call gets answered 
by cache
# Ability to also record retries to see if certain code flows are resulting in 
lots of retries or not

> DocumentStoreStatsIT.update fails when RDB's append mode is disabled
> 
>
> Key: OAK-4390
> URL: https://issues.apache.org/jira/browse/OAK-4390
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: rdbmk
>Affects Versions: 1.4.2, 1.5.2
>Reporter: Julian Reschke
>
> When run with 
> {{-Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.NOAPPEND=true}}
>  (see OAK-4389):
> {noformat}
> update[RDBFixture: 
> RDB-Postgres](org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsIT)
>   Time elapsed: 0.008 sec  <<< FAILURE!
> Wanted but not invoked:
> documentStoreStatsCollector.doneUpdate(
> ,
> nodes,
> 2
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsIT.update(DocumentStoreStatsIT.java:128)
> However, there were other interactions with this mock:
> documentStoreStatsCollector.doneCreate(
> 1747821,
> nodes,
> [update[RDBFixture: RDB-Postgres]],
> true
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.internalCreate(RDBDocumentStore.java:1182)
> documentStoreStatsCollector.doneFindUncached(
> 845900,
> nodes,
> "update[RDBFixture: RDB-Postgres]-478ebbb3-cb70-409d-af13-f1b2c11c4103",
> false,
> false
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.readDocumentUncached(RDBDocumentStore.java:1484)
> documentStoreStatsCollector.doneFindCached(
> nodes,
> "update[RDBFixture: RDB-Postgres]"
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.readDocumentCached(RDBDocumentStore.java:1093)
> documentStoreStatsCollector.doneFindAndModify(
> 1521593,
> nodes,
> "update[RDBFixture: RDB-Postgres]",
> false,
> true,
> -1
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.internalUpdate(RDBDocumentStore.java:1299)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-4390) DocumentStoreStatsIT.update fails when RDB's append mode is disabled

2016-05-22 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295627#comment-15295627
 ] 

Julian Reschke commented on OAK-4390:
-

The reason being that in this case a different code path is used, and that 
creates different kinds of statistics.

[~chetanm] - is there a particular reason why the stats are taken relatively 
low-level and not closer to the API call?

> DocumentStoreStatsIT.update fails when RDB's append mode is disabled
> 
>
> Key: OAK-4390
> URL: https://issues.apache.org/jira/browse/OAK-4390
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: rdbmk
>Affects Versions: 1.4.2, 1.5.2
>Reporter: Julian Reschke
>
> When run with 
> {{-Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.NOAPPEND=true}}
>  (see OAK-4389):
> {noformat}
> update[RDBFixture: 
> RDB-Postgres](org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsIT)
>   Time elapsed: 0.008 sec  <<< FAILURE!
> Wanted but not invoked:
> documentStoreStatsCollector.doneUpdate(
> ,
> nodes,
> 2
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsIT.update(DocumentStoreStatsIT.java:128)
> However, there were other interactions with this mock:
> documentStoreStatsCollector.doneCreate(
> 1747821,
> nodes,
> [update[RDBFixture: RDB-Postgres]],
> true
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.internalCreate(RDBDocumentStore.java:1182)
> documentStoreStatsCollector.doneFindUncached(
> 845900,
> nodes,
> "update[RDBFixture: RDB-Postgres]-478ebbb3-cb70-409d-af13-f1b2c11c4103",
> false,
> false
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.readDocumentUncached(RDBDocumentStore.java:1484)
> documentStoreStatsCollector.doneFindCached(
> nodes,
> "update[RDBFixture: RDB-Postgres]"
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.readDocumentCached(RDBDocumentStore.java:1093)
> documentStoreStatsCollector.doneFindAndModify(
> 1521593,
> nodes,
> "update[RDBFixture: RDB-Postgres]",
> false,
> true,
> -1
> );
> -> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.internalUpdate(RDBDocumentStore.java:1299)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)