[jira] [Commented] (OAK-4467) Upgrade commons-io to 2.5 and remove ReversedLinesFileReader
[
https://issues.apache.org/jira/browse/OAK-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568162#comment-15568162
]
Julian Reschke commented on OAK-4467:
-
Exactly :-).
> Upgrade commons-io to 2.5 and remove ReversedLinesFileReader
>
>
> Key: OAK-4467
> URL: https://issues.apache.org/jira/browse/OAK-4467
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external, blob, commons, core, examples, parent,
> pojosr, run, segment-tar, segmentmk, webapp
>Reporter: Michael Dürig
>Assignee: Michael Dürig
> Labels: technical_debt
> Fix For: Segment Tar 0.0.16
>
> Attachments: OAK_4467.patch
>
>
> For OAK-2605 we copied the source of {{ReversedLinesFileReader}} to Oak to
> get the fix for IO-471 in. As this is now fixed in {{commons-io}} 2.5, I
> suggest we upgrade our dependency and remove that duplicated class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4467) Upgrade commons-io to 2.5 and remove ReversedLinesFileReader
[
https://issues.apache.org/jira/browse/OAK-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568141#comment-15568141
]
Michael Dürig commented on OAK-4467:
I don't think so. This would force all customer still having commons-io 2.4 in
its container to also bump it to 2.5.
> Upgrade commons-io to 2.5 and remove ReversedLinesFileReader
>
>
> Key: OAK-4467
> URL: https://issues.apache.org/jira/browse/OAK-4467
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external, blob, commons, core, examples, parent,
> pojosr, run, segment-tar, segmentmk, webapp
>Reporter: Michael Dürig
>Assignee: Michael Dürig
> Labels: technical_debt
> Fix For: Segment Tar 0.0.16
>
> Attachments: OAK_4467.patch
>
>
> For OAK-2605 we copied the source of {{ReversedLinesFileReader}} to Oak to
> get the fix for IO-471 in. As this is now fixed in {{commons-io}} 2.5, I
> suggest we upgrade our dependency and remove that duplicated class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4467) Upgrade commons-io to 2.5 and remove ReversedLinesFileReader
[
https://issues.apache.org/jira/browse/OAK-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568107#comment-15568107
]
Julian Reschke commented on OAK-4467:
-
can't we require commons-io 2.5?
(I'd like to backport so that we can get rid of the workaround in the other
branches...)
> Upgrade commons-io to 2.5 and remove ReversedLinesFileReader
>
>
> Key: OAK-4467
> URL: https://issues.apache.org/jira/browse/OAK-4467
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external, blob, commons, core, examples, parent,
> pojosr, run, segment-tar, segmentmk, webapp
>Reporter: Michael Dürig
>Assignee: Michael Dürig
> Labels: technical_debt
> Fix For: Segment Tar 0.0.16
>
> Attachments: OAK_4467.patch
>
>
> For OAK-2605 we copied the source of {{ReversedLinesFileReader}} to Oak to
> get the fix for IO-471 in. As this is now fixed in {{commons-io}} 2.5, I
> suggest we upgrade our dependency and remove that duplicated class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4467) Upgrade commons-io to 2.5 and remove ReversedLinesFileReader
[
https://issues.apache.org/jira/browse/OAK-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568097#comment-15568097
]
Michael Dürig commented on OAK-4467:
No, I wouldn't do this as this will break consumers who provide still the old
dependency (commons-io 2.4).
> Upgrade commons-io to 2.5 and remove ReversedLinesFileReader
>
>
> Key: OAK-4467
> URL: https://issues.apache.org/jira/browse/OAK-4467
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external, blob, commons, core, examples, parent,
> pojosr, run, segment-tar, segmentmk, webapp
>Reporter: Michael Dürig
>Assignee: Michael Dürig
> Labels: candidate_oak_1_2, candidate_oak_1_4, technical_debt
> Fix For: Segment Tar 0.0.16
>
> Attachments: OAK_4467.patch
>
>
> For OAK-2605 we copied the source of {{ReversedLinesFileReader}} to Oak to
> get the fix for IO-471 in. As this is now fixed in {{commons-io}} 2.5, I
> suggest we upgrade our dependency and remove that duplicated class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4467) Upgrade commons-io to 2.5 and remove ReversedLinesFileReader
[
https://issues.apache.org/jira/browse/OAK-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568065#comment-15568065
]
Julian Reschke commented on OAK-4467:
-
This should be backported, right?
> Upgrade commons-io to 2.5 and remove ReversedLinesFileReader
>
>
> Key: OAK-4467
> URL: https://issues.apache.org/jira/browse/OAK-4467
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external, blob, commons, core, examples, parent,
> pojosr, run, segment-tar, segmentmk, webapp
>Reporter: Michael Dürig
>Assignee: Michael Dürig
> Labels: candidate_oak_1_2, candidate_oak_1_4, technical_debt
> Fix For: Segment Tar 0.0.16
>
> Attachments: OAK_4467.patch
>
>
> For OAK-2605 we copied the source of {{ReversedLinesFileReader}} to Oak to
> get the fix for IO-471 in. As this is now fixed in {{commons-io}} 2.5, I
> suggest we upgrade our dependency and remove that duplicated class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4467) Upgrade commons-io to 2.5 and remove ReversedLinesFileReader
[
https://issues.apache.org/jira/browse/OAK-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413584#comment-15413584
]
angela commented on OAK-4467:
-
looks good to me.
> Upgrade commons-io to 2.5 and remove ReversedLinesFileReader
>
>
> Key: OAK-4467
> URL: https://issues.apache.org/jira/browse/OAK-4467
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external, blob, commons, core, examples, parent,
> pojosr, run, segment-tar, segmentmk, webapp
>Reporter: Michael Dürig
>Assignee: Michael Dürig
> Labels: technical_debt
> Fix For: Segment Tar 0.0.20
>
> Attachments: OAK_4467.patch
>
>
> For OAK-2605 we copied the source of {{ReversedLinesFileReader}} to Oak to
> get the fix for IO-471 in. As this is now fixed in {{commons-io}} 2.5, I
> suggest we upgrade our dependency and remove that duplicated class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
