[jira] [Commented] (OAK-4929) Clean GCMonitor#compacted method arguments

2016-10-17 Thread Alex Parvulescu (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15582216#comment-15582216
 ] 

Alex Parvulescu commented on OAK-4929:
--

to break the dependency chain I decided to disable a test and created OAK-4944 
to reenable it once all the versions are properly released & linked.

> Clean GCMonitor#compacted method arguments
> --
>
> Key: OAK-4929
> URL: https://issues.apache.org/jira/browse/OAK-4929
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: core, lucene
>Reporter: Alex Parvulescu
>Assignee: Alex Parvulescu
> Fix For: 1.5.13
>
>
> Subtask of OAK-4283, first step is to remove all arguments from the 
> {{GCMonitor#compacted}} api.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-4929) Clean GCMonitor#compacted method arguments

2016-10-17 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/OAK-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581987#comment-15581987
 ] 

Michael Dürig commented on OAK-4929:


Maybe we have to add the new noargs {{GCMonitor.compact()}} method and 
deprecate the other one in a first step. Once the implementations are all 
aligned to only use the new method we can remove the old one in a second step. 


> Clean GCMonitor#compacted method arguments
> --
>
> Key: OAK-4929
> URL: https://issues.apache.org/jira/browse/OAK-4929
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: core, lucene
>Reporter: Alex Parvulescu
>Assignee: Alex Parvulescu
> Fix For: 1.5.13
>
>
> Subtask of OAK-4283, first step is to remove all arguments from the 
> {{GCMonitor#compacted}} api.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-4929) Clean GCMonitor#compacted method arguments

2016-10-12 Thread Alex Parvulescu (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568906#comment-15568906
 ] 

Alex Parvulescu commented on OAK-4929:
--

see here for the complete change diff [0]. while not a complicated change in 
itself, it has a cyclic dependency problem where to be able to push this change 
you'd have to do a sync release of both oak and segment-tar. or at least I 
can't see how to properly split this one. fyi [~mduerig], [~frm].

[0] 
https://github.com/stillalex/jackrabbit-oak/commit/5e44b487ad59840896d0ae7aef23f4c476f6d372

> Clean GCMonitor#compacted method arguments
> --
>
> Key: OAK-4929
> URL: https://issues.apache.org/jira/browse/OAK-4929
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: core, lucene
>Reporter: Alex Parvulescu
>Assignee: Alex Parvulescu
> Fix For: 1.5.13
>
>
> Subtask of OAK-4283, first step is to remove all arguments from the 
> {{GCMonitor#compacted}} api.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)