[jira] [Commented] (OAK-6826) Refactor Jcr class to remove dependency on o.a.j.oak.plugins.index

2017-11-16 Thread Alex Deparvu (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255227#comment-16255227
 ] 

Alex Deparvu commented on OAK-6826:
---

ack. [~anchela] let me test this out against latest trunk and will apply the 
patch

> Refactor Jcr class to remove dependency on o.a.j.oak.plugins.index
> --
>
> Key: OAK-6826
> URL: https://issues.apache.org/jira/browse/OAK-6826
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: jcr
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Minor
>
> I'd like to take a look at the Jcr class, to have it rely more on api/spi 
> classes and reduce if possible references to oak-core impl.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OAK-6826) Refactor Jcr class to remove dependency on o.a.j.oak.plugins.index

2017-11-16 Thread angela (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255091#comment-16255091
 ] 

angela commented on OAK-6826:
-

[~stillalex], I would appreciate if we could get this issue resolved today, 
such that I can clean up the exports that are no longer needed in _oak-core_.

> Refactor Jcr class to remove dependency on o.a.j.oak.plugins.index
> --
>
> Key: OAK-6826
> URL: https://issues.apache.org/jira/browse/OAK-6826
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: jcr
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Minor
>
> I'd like to take a look at the Jcr class, to have it rely more on api/spi 
> classes and reduce if possible references to oak-core impl.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OAK-6826) Refactor Jcr class to remove dependency on o.a.j.oak.plugins.index

2017-11-15 Thread angela (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253420#comment-16253420
 ] 

angela commented on OAK-6826:
-

[~stillalex], I very much like the introduction of these default components as 
it also allows us to handle that as an implementation detail and adjust it 
later on. so +1 for this proposal over adding dedicated methods that would 
again leak out the impl detail of a default setup.

> Refactor Jcr class to remove dependency on o.a.j.oak.plugins.index
> --
>
> Key: OAK-6826
> URL: https://issues.apache.org/jira/browse/OAK-6826
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: jcr
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Minor
>
> I'd like to take a look at the Jcr class, to have it rely more on api/spi 
> classes and reduce if possible references to oak-core impl.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OAK-6826) Refactor Jcr class to remove dependency on o.a.j.oak.plugins.index

2017-10-26 Thread Thomas Mueller (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220172#comment-16220172
 ] 

Thomas Mueller commented on OAK-6826:
-

You have used the approach of default components, that's fine.

As an alternative, or in addition to this, what about replacing 
"with(CommitRateLimiter x)" with "withCommitRateLimiter()"? Same for other 
others maybe (withDefaultIndexEditorProviders(), withVersionHook() or so).



> Refactor Jcr class to remove dependency on o.a.j.oak.plugins.index
> --
>
> Key: OAK-6826
> URL: https://issues.apache.org/jira/browse/OAK-6826
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: jcr
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Minor
>
> I'd like to take a look at the Jcr class, to have it rely more on api/spi 
> classes and reduce if possible references to oak-core impl.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OAK-6826) Refactor Jcr class to remove dependency on o.a.j.oak.plugins.index

2017-10-13 Thread Alex Deparvu (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203205#comment-16203205
 ] 

Alex Deparvu commented on OAK-6826:
---

In {{oak-jcr}} there's an OSGi component ({{RepositoryManager}}) that 
references {{IndexEditorProvider}} and {{WhiteboardIndexEditorProvider}}.

> Refactor Jcr class to remove dependency on o.a.j.oak.plugins.index
> --
>
> Key: OAK-6826
> URL: https://issues.apache.org/jira/browse/OAK-6826
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: jcr
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Minor
>
> I'd like to take a look at the Jcr class, to have it rely more on api/spi 
> classes and reduce if possible references to oak-core impl.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OAK-6826) Refactor Jcr class

2017-10-13 Thread Alex Deparvu (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203176#comment-16203176
 ] 

Alex Deparvu commented on OAK-6826:
---

first try on a WIP branch [0].
Similar to the {{InitialContent}} class I introduced a {{OakDefaultComponents}} 
class in oak-core that hosts all the default values for various components we 
initialise by default. this only moves the reference problem to oak-core, but 
at least reduces oak-jcr dependency footprint.
Not sure what to do with 
{{org.apache.jackrabbit.oak.plugins.index.IndexEditorProvider}} and 
{{org.apache.jackrabbit.oak.plugins.observation.CommitRateLimiter}} yet.

Also, the only {{CommitHook}} we have left here is the {{VersionHook}} which 
does not look like a commit hook at all (it's more of a composite editor), so I 
think it would be worthwhile to refactor this class into a proper Editor.

[~tmueller], [~anchela] thoughts?


[0] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:OAK-6826

> Refactor Jcr class
> --
>
> Key: OAK-6826
> URL: https://issues.apache.org/jira/browse/OAK-6826
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: jcr
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Minor
>
> I'd like to take a look at the Jcr class, to have it rely more on api/spi 
> classes and reduce if possible references to oak-core impl.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)