[jira] [Commented] (OAK-6886) OffRC always logs 0 for the number of compacted nodes in gc.log
[
https://issues.apache.org/jira/browse/OAK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260688#comment-16260688
]
Francesco Mari commented on OAK-6886:
-
That's right. My bad. I will take care of this.
> OffRC always logs 0 for the number of compacted nodes in gc.log
> ---
>
> Key: OAK-6886
> URL: https://issues.apache.org/jira/browse/OAK-6886
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
> Labels: compaction, gc, tooling
> Fix For: 1.8, 1.7.13
>
>
> After an offline compaction the {{gc.log}} always contains 0 for the number
> of compacted nodes. This is caused by
> {{org.apache.jackrabbit.oak.segment.tool.Compact.compact()}} instantiating a
> new {{FileStore}} to run cleanup. That file store has new {{GCMonitor}}
> instance, which did no see any of the nodes written by the compaction that
> was run on the previous {{FileStore}} instance.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6886) OffRC always logs 0 for the number of compacted nodes in gc.log
[
https://issues.apache.org/jira/browse/OAK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260678#comment-16260678
]
Michael Dürig commented on OAK-6886:
No, the changes done on this issues have been reverted at
http://svn.apache.org/viewvc?view=revision=1813883 as they caused
OAK-6894. OAK-6909 and OAK-6910 have been identified as further prerequisites
until we can unrevert again.
> OffRC always logs 0 for the number of compacted nodes in gc.log
> ---
>
> Key: OAK-6886
> URL: https://issues.apache.org/jira/browse/OAK-6886
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
> Labels: compaction, gc, tooling
> Fix For: 1.8, 1.7.13
>
>
> After an offline compaction the {{gc.log}} always contains 0 for the number
> of compacted nodes. This is caused by
> {{org.apache.jackrabbit.oak.segment.tool.Compact.compact()}} instantiating a
> new {{FileStore}} to run cleanup. That file store has new {{GCMonitor}}
> instance, which did no see any of the nodes written by the compaction that
> was run on the previous {{FileStore}} instance.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6886) OffRC always logs 0 for the number of compacted nodes in gc.log
[
https://issues.apache.org/jira/browse/OAK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260662#comment-16260662
]
Francesco Mari commented on OAK-6886:
-
[~mduerig], can this be considered fixed, given OAK-6910?
> OffRC always logs 0 for the number of compacted nodes in gc.log
> ---
>
> Key: OAK-6886
> URL: https://issues.apache.org/jira/browse/OAK-6886
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
> Labels: compaction, gc, tooling
> Fix For: 1.8, 1.7.13
>
>
> After an offline compaction the {{gc.log}} always contains 0 for the number
> of compacted nodes. This is caused by
> {{org.apache.jackrabbit.oak.segment.tool.Compact.compact()}} instantiating a
> new {{FileStore}} to run cleanup. That file store has new {{GCMonitor}}
> instance, which did no see any of the nodes written by the compaction that
> was run on the previous {{FileStore}} instance.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6886) OffRC always logs 0 for the number of compacted nodes in gc.log
[
https://issues.apache.org/jira/browse/OAK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240534#comment-16240534
]
Michael Dürig commented on OAK-6886:
Making OAK-6909 and OAK-6910 blockers for this issue as the initial patch is
IMO still the right approach but would need these issues fixed as a
prerequisite.
> OffRC always logs 0 for the number of compacted nodes in gc.log
> ---
>
> Key: OAK-6886
> URL: https://issues.apache.org/jira/browse/OAK-6886
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
> Labels: compaction, gc
> Fix For: 1.8, 1.7.12
>
>
> After an offline compaction the {{gc.log}} always contains 0 for the number
> of compacted nodes. This is caused by
> {{org.apache.jackrabbit.oak.segment.tool.Compact.compact()}} instantiating a
> new {{FileStore}} to run cleanup. That file store has new {{GCMonitor}}
> instance, which did no see any of the nodes written by the compaction that
> was run on the previous {{FileStore}} instance.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6886) OffRC always logs 0 for the number of compacted nodes in gc.log
[
https://issues.apache.org/jira/browse/OAK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226659#comment-16226659
]
Francesco Mari commented on OAK-6886:
-
I don't see any reason why this shouldn't work better. The patch looks good to
me.
> OffRC always logs 0 for the number of compacted nodes in gc.log
> ---
>
> Key: OAK-6886
> URL: https://issues.apache.org/jira/browse/OAK-6886
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
> Labels: compaction, gc
> Fix For: 1.8, 1.7.12
>
>
> After an offline compaction the {{gc.log}} always contains 0 for the number
> of compacted nodes. This is caused by
> {{org.apache.jackrabbit.oak.segment.tool.Compact.compact()}} instantiating a
> new {{FileStore}} to run cleanup. That file store has new {{GCMonitor}}
> instance, which did no see any of the nodes written by the compaction that
> was run on the previous {{FileStore}} instance.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
