[jira] [Commented] (OAK-7156) CacheChangesTracker should implement Closeable
[ https://issues.apache.org/jira/browse/OAK-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881207#comment-16881207 ] Julian Reschke commented on OAK-7156: - trunk: (1.9.0) [r1821617|http://svn.apache.org/r1821617] 1.10: (1.9.0) [r1821617|http://svn.apache.org/r1821617] 1.8: (1.8.4) [r1832109|http://svn.apache.org/r1832109] 1.6: [r1862808|http://svn.apache.org/r1862808] > CacheChangesTracker should implement Closeable > -- > > Key: OAK-7156 > URL: https://issues.apache.org/jira/browse/OAK-7156 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_4 > Fix For: 1.9.0, 1.10.0, 1.8.4, 1.6.18 > > Attachments: OAK-7156.diff > > > So it can be used with try-with-resources... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7156) CacheChangesTracker should implement Closeable
[ https://issues.apache.org/jira/browse/OAK-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332094#comment-16332094 ] Julian Reschke commented on OAK-7156: - trunk: [r1821617|http://svn.apache.org/r1821617] > CacheChangesTracker should implement Closeable > -- > > Key: OAK-7156 > URL: https://issues.apache.org/jira/browse/OAK-7156 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Attachments: OAK-7156.diff > > > So it can be used with try-with-resources... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7156) CacheChangesTracker should implement Closeable
[ https://issues.apache.org/jira/browse/OAK-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327102#comment-16327102 ] Julian Reschke commented on OAK-7156: - Would need to be a static method, right - I guess I'll leave it in {{RDBDocumentStore}} for now... > CacheChangesTracker should implement Closeable > -- > > Key: OAK-7156 > URL: https://issues.apache.org/jira/browse/OAK-7156 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Attachments: OAK-7156.diff > > > So it can be used with try-with-resources... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7156) CacheChangesTracker should implement Closeable
[ https://issues.apache.org/jira/browse/OAK-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327089#comment-16327089 ] Vikas Saurabh commented on OAK-7156: [~reschke], maybe to {{NodeDocumentCache}}? {{CacheChangesTracker}} doesn't _feel_ right to me. > CacheChangesTracker should implement Closeable > -- > > Key: OAK-7156 > URL: https://issues.apache.org/jira/browse/OAK-7156 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Attachments: OAK-7156.diff > > > So it can be used with try-with-resources... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7156) CacheChangesTracker should implement Closeable
[ https://issues.apache.org/jira/browse/OAK-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327078#comment-16327078 ] Julian Reschke commented on OAK-7156: - [~catholicon] - do you think {{obtainTracker}} should be moved into {{CacheChangesTracker}}? > CacheChangesTracker should implement Closeable > -- > > Key: OAK-7156 > URL: https://issues.apache.org/jira/browse/OAK-7156 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Attachments: OAK-7156.diff > > > So it can be used with try-with-resources... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7156) CacheChangesTracker should implement Closeable
[ https://issues.apache.org/jira/browse/OAK-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326409#comment-16326409 ] Vikas Saurabh commented on OAK-7156: makes sense to me. Btw, I would probably want to into 2 parts: * factor out {{obtainTracker}} - this should be backported thus keeping visual changes across branches very similar * try-with-resources changes. > CacheChangesTracker should implement Closeable > -- > > Key: OAK-7156 > URL: https://issues.apache.org/jira/browse/OAK-7156 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Attachments: OAK-7156.diff > > > So it can be used with try-with-resources... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7156) CacheChangesTracker should implement Closeable
[ https://issues.apache.org/jira/browse/OAK-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326276#comment-16326276 ] Julian Reschke commented on OAK-7156: - Proposed change, plus example usage in {{RDBDocumentStore}}. [~mreutegg], [~catholicon], WDYT? > CacheChangesTracker should implement Closeable > -- > > Key: OAK-7156 > URL: https://issues.apache.org/jira/browse/OAK-7156 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Attachments: OAK-7156.diff > > > So it can be used with try-with-resources... -- This message was sent by Atlassian JIRA (v7.6.3#76005)