[jira] [Commented] (OAK-7416) Contribute a 'proc' subtree for the Segment Node Store
[ https://issues.apache.org/jira/browse/OAK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442358#comment-16442358 ] Francesco Mari commented on OAK-7416: - If there are no objections, I will commit the proc tree in trunk tomorrow. > Contribute a 'proc' subtree for the Segment Node Store > -- > > Key: OAK-7416 > URL: https://issues.apache.org/jira/browse/OAK-7416 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: segment-tar >Reporter: Francesco Mari >Assignee: Francesco Mari >Priority: Major > Labels: tooling > Fix For: 1.10 > > > With guidance from [~mduerig], I recently developed a way to expose Segment > Node Store's internal information through the NodeState API. > The concept is similar in spirit to the proc file system in Linux: the proc > subtree exposes internal information in a straightforward manner, enabling > consumers to rely on a well-understood API to access the data. This proc > subtree shelters tooling from variations of the internal APIs of the Segment > Store. As long as the data exported through the proc subtree is stable, the > same tools are going to work across different versions of the Segment Store > with minimal to no modifications. > The proc subtree has been developed in [this branch on > GitHub|https://github.com/francescomari/jackrabbit-oak/tree/proc]. I created > this issue in order to review the work done so far, and to track the > contribution of the proc subtree in Oak. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7416) Contribute a 'proc' subtree for the Segment Node Store
[ https://issues.apache.org/jira/browse/OAK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442355#comment-16442355 ] Michael Dürig commented on OAK-7416: bq. I think that this is better tackled in one or more follow-up issues. ack > Contribute a 'proc' subtree for the Segment Node Store > -- > > Key: OAK-7416 > URL: https://issues.apache.org/jira/browse/OAK-7416 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: segment-tar >Reporter: Francesco Mari >Assignee: Francesco Mari >Priority: Major > Labels: tooling > Fix For: 1.10 > > > With guidance from [~mduerig], I recently developed a way to expose Segment > Node Store's internal information through the NodeState API. > The concept is similar in spirit to the proc file system in Linux: the proc > subtree exposes internal information in a straightforward manner, enabling > consumers to rely on a well-understood API to access the data. This proc > subtree shelters tooling from variations of the internal APIs of the Segment > Store. As long as the data exported through the proc subtree is stable, the > same tools are going to work across different versions of the Segment Store > with minimal to no modifications. > The proc subtree has been developed in [this branch on > GitHub|https://github.com/francescomari/jackrabbit-oak/tree/proc]. I created > this issue in order to review the work done so far, and to track the > contribution of the proc subtree in Oak. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7416) Contribute a 'proc' subtree for the Segment Node Store
[ https://issues.apache.org/jira/browse/OAK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442345#comment-16442345 ] Francesco Mari commented on OAK-7416: - [~mduerig], I merged the PR. Not only the package lacks Javadoc, but the proc tree needs to be described in our documentation. I think that this is better tackled in one or more follow-up issues. > Contribute a 'proc' subtree for the Segment Node Store > -- > > Key: OAK-7416 > URL: https://issues.apache.org/jira/browse/OAK-7416 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: segment-tar >Reporter: Francesco Mari >Assignee: Francesco Mari >Priority: Major > Labels: tooling > Fix For: 1.10 > > > With guidance from [~mduerig], I recently developed a way to expose Segment > Node Store's internal information through the NodeState API. > The concept is similar in spirit to the proc file system in Linux: the proc > subtree exposes internal information in a straightforward manner, enabling > consumers to rely on a well-understood API to access the data. This proc > subtree shelters tooling from variations of the internal APIs of the Segment > Store. As long as the data exported through the proc subtree is stable, the > same tools are going to work across different versions of the Segment Store > with minimal to no modifications. > The proc subtree has been developed in [this branch on > GitHub|https://github.com/francescomari/jackrabbit-oak/tree/proc]. I created > this issue in order to review the work done so far, and to track the > contribution of the proc subtree in Oak. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7416) Contribute a 'proc' subtree for the Segment Node Store
[
https://issues.apache.org/jira/browse/OAK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442242#comment-16442242
]
Michael Dürig commented on OAK-7416:
[~frm], I just went to the proposed changes. This looks very good to me and I'd
be +1 to applying this in trunk.
* See [https://github.com/francescomari/jackrabbit-oak/pull/18/files] for some
proposed changes to clean up a few bits.
* The classes in {{org.apache.jackrabbit.oak.segment.file.proc}} generally
lack Javadoc. No blocker for trunk, but let's add some class level comments re.
what the structure of what the individual classes as long as our memories are
still fresh.
> Contribute a 'proc' subtree for the Segment Node Store
> --
>
> Key: OAK-7416
> URL: https://issues.apache.org/jira/browse/OAK-7416
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Reporter: Francesco Mari
>Assignee: Francesco Mari
>Priority: Major
> Labels: tooling
> Fix For: 1.10
>
>
> With guidance from [~mduerig], I recently developed a way to expose Segment
> Node Store's internal information through the NodeState API.
> The concept is similar in spirit to the proc file system in Linux: the proc
> subtree exposes internal information in a straightforward manner, enabling
> consumers to rely on a well-understood API to access the data. This proc
> subtree shelters tooling from variations of the internal APIs of the Segment
> Store. As long as the data exported through the proc subtree is stable, the
> same tools are going to work across different versions of the Segment Store
> with minimal to no modifications.
> The proc subtree has been developed in [this branch on
> GitHub|https://github.com/francescomari/jackrabbit-oak/tree/proc]. I created
> this issue in order to review the work done so far, and to track the
> contribution of the proc subtree in Oak.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7416) Contribute a 'proc' subtree for the Segment Node Store
[ https://issues.apache.org/jira/browse/OAK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440531#comment-16440531 ] Michael Dürig commented on OAK-7416: [~frm] from my perspective as a user of this feature via [https://github.com/mduerig/oak-tooling-api/commits/proc] and [https://github.com/mduerig/script-oak/commits/proc] this is tremendously useful. It eases a lot of the pain described in OAK-6584. IMO we should * care fully review your branch * contribute it to Oak trunk * resolve OAK-6584 as superseded by this issue. Will follow up with a more detailed review of your branch later today. > Contribute a 'proc' subtree for the Segment Node Store > -- > > Key: OAK-7416 > URL: https://issues.apache.org/jira/browse/OAK-7416 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: segment-tar >Reporter: Francesco Mari >Assignee: Francesco Mari >Priority: Major > Fix For: 1.10 > > > With guidance from [~mduerig], I recently developed a way to expose Segment > Node Store's internal information through the NodeState API. > The concept is similar in spirit to the proc file system in Linux: the proc > subtree exposes internal information in a straightforward manner, enabling > consumers to rely on a well-understood API to access the data. This proc > subtree shelters tooling from variations of the internal APIs of the Segment > Store. As long as the data exported through the proc subtree is stable, the > same tools are going to work across different versions of the Segment Store > with minimal to no modifications. > The proc subtree has been developed in [this branch on > GitHub|https://github.com/francescomari/jackrabbit-oak/tree/proc]. I created > this issue in order to review the work done so far, and to track the > contribution of the proc subtree in Oak. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
