[jira] [Commented] (OAK-7629) Lucene index: hide the settings COR and COW

2018-07-13 Thread Thomas Mueller (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543189#comment-16543189
 ] 

Thomas Mueller commented on OAK-7629:
-

http://svn.apache.org/r1835838
https://github.com/tteofili/jackrabbit-oak/commit/229afb3affc307d809d300e249065f5cfa9b0ef2

> Lucene index: hide the settings COR and COW 
> 
>
> Key: OAK-7629
> URL: https://issues.apache.org/jira/browse/OAK-7629
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
> Fix For: 1.10, 1.9.6
>
>
> I have seen people disabling copy-on-read or copy-on-write hoping to improve 
> performance or save space. We know about problems if those are disabled, for 
> example it can result in many open file handles, OAK-7460.
> So best if we hide these features, so that people don't change them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7629) Lucene index: hide the settings COR and COW

2018-07-12 Thread Chetan Mehrotra (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541669#comment-16541669
 ] 

Chetan Mehrotra commented on OAK-7629:
--

+1. {{propertyPrivate}} should make it hidden

> Lucene index: hide the settings COR and COW 
> 
>
> Key: OAK-7629
> URL: https://issues.apache.org/jira/browse/OAK-7629
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
> Fix For: 1.10
>
>
> I have seen people disabling copy-on-read or copy-on-write hoping to improve 
> performance or save space. We know about problems if those are disabled, for 
> example it can result in many open file handles, OAK-7460.
> So best if we hide these features, so that people don't change them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7629) Lucene index: hide the settings COR and COW

2018-07-12 Thread Vikas Saurabh (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541654#comment-16541654
 ] 

Vikas Saurabh commented on OAK-7629:


"Looks" good to me... but, I'm quite illiterate with osgi... I try and confirm 
before doing things. Maybe, double check in your run if putting the config in 
.cfg still does change the value.

> Lucene index: hide the settings COR and COW 
> 
>
> Key: OAK-7629
> URL: https://issues.apache.org/jira/browse/OAK-7629
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
> Fix For: 1.10
>
>
> I have seen people disabling copy-on-read or copy-on-write hoping to improve 
> performance or save space. We know about problems if those are disabled, for 
> example it can result in many open file handles, OAK-7460.
> So best if we hide these features, so that people don't change them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7629) Lucene index: hide the settings COR and COW

2018-07-12 Thread Thomas Mueller (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541628#comment-16541628
 ] 

Thomas Mueller commented on OAK-7629:
-

Proposed patch to make them private:

{noformat}
Index: 
src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java
===
--- 
src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java
(revision 1835714)
+++ 
src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java
(working copy)
@@ -138,7 +138,8 @@
 @Property(
 boolValue = true,
 label = "Enable CopyOnRead",
-description = "Enable copying of Lucene index to local file system 
to improve query performance"
+description = "Enable copying of Lucene index to local file system 
to improve query performance",
+propertyPrivate = true
 )
 private static final String PROP_COPY_ON_READ = "enableCopyOnReadSupport";
 
@@ -154,7 +155,8 @@
 @Property(
 boolValue = PROP_COPY_ON_WRITE_DEFAULT,
 label = "Enable CopyOnWrite",
-description = "Enable copying of Lucene index to local file system 
to improve index writer performance"
+description = "Enable copying of Lucene index to local file system 
to improve index writer performance",
+propertyPrivate = true
 )
{noformat}

[~catholicon] or [~chetanm] could you review this please? According to my test, 
the settings are then hidden in the UI.

> Lucene index: hide the settings COR and COW 
> 
>
> Key: OAK-7629
> URL: https://issues.apache.org/jira/browse/OAK-7629
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Thomas Mueller
>Priority: Major
> Fix For: 1.10
>
>
> I have seen people disabling copy-on-read or copy-on-write hoping to improve 
> performance or save space. We know about problems if those are disabled, for 
> example it can result in many open file handles, OAK-7460.
> So best if we hide these features, so that people don't change them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)