[jira] [Commented] (OAK-8898) On querying, IndexReader failed with AlreadyClosedException
[
https://issues.apache.org/jira/browse/OAK-8898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764521#comment-17764521
]
Julian Reschke commented on OAK-8898:
-
trunk: (1.26.0)
[33d9945298|https://github.com/apache/jackrabbit-oak/commit/33d99452983942cc2b849f8f276f300ae4f9ad93]
1.22: (1.22.3)
[68749725cf|https://github.com/apache/jackrabbit-oak/commit/68749725cf98c855e36aa45219493ff600edbff3]
> On querying, IndexReader failed with AlreadyClosedException
> ---
>
> Key: OAK-8898
> URL: https://issues.apache.org/jira/browse/OAK-8898
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Mohit Kataria
>Assignee: Mohit Kataria
>Priority: Major
> Labels: candidate_oak_1_22
> Fix For: 1.26.0, 1.22.3
>
> Attachments: OAK-8898-1.10.8.patch
>
>
> This is an intermittent issue, where on querying the code throws
> AlreadyClosedException.
>
> {code:java}
> Caused by: org.apache.lucene.store.AlreadyClosedException: this IndexReader
> is closed
> at org.apache.lucene.index.IndexReader.ensureOpen(IndexReader.java:262)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.lucene.index.BaseCompositeReader.document(BaseCompositeReader.java:108)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at org.apache.lucene.index.IndexReader.document(IndexReader.java:446)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getAccessibleSampleCount(StatisticalSortedSetDocValuesFacetCounts.java:169)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getTopChildren0(StatisticalSortedSetDocValuesFacetCounts.java:104)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getTopChildren(StatisticalSortedSetDocValuesFacetCounts.java:70)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.lucene.facet.MultiFacets.getTopChildren(MultiFacets.java:52)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LucenePropertyIndex$LuceneFacetProvider.getFacets(LucenePropertyIndex.java:1547)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.search.spi.query.FulltextIndex$FulltextResultRow.getFacets(FulltextIndex.java:353)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.search.spi.query.FulltextIndex$FulltextPathCursor$2.getValue(FulltextIndex.java:472)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> ... 237 common frames omitted
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OAK-8898) On querying, IndexReader failed with AlreadyClosedException
[
https://issues.apache.org/jira/browse/OAK-8898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069349#comment-17069349
]
Thomas Mueller commented on OAK-8898:
-
OAK-8898-1.10.8.patch is a patch for Oak 1.10.8 oak-lucene/src. This is _not_
the 1.10 branch, which contains further changes; it is for
https://svn.apache.org/repos/asf/jackrabbit/oak/tags/jackrabbit-oak-1.10.8
I created a diagnostic build using:
{noformat}
cd oak-parent
mvn versions:set -DnewVersion=1.10.8-OAK-8898
cd ..
mvn -DskipTests clean install
{noformat}
To verify the patch is installed, see the log file and search for
"org.apache.jackrabbit.oak.plugins.index.lucene.LucenePropertyIndex
oak.lucene.oldFacetProvider = false".
To switch to the old (buggy) behavior, set the system property
"oak.lucene.oldFacetProvider" to "true", e.g.
{noformat}
java -Doak.lucene.oldFacetProvider=true ...
{noformat}
> On querying, IndexReader failed with AlreadyClosedException
> ---
>
> Key: OAK-8898
> URL: https://issues.apache.org/jira/browse/OAK-8898
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Mohit Kataria
>Assignee: Mohit Kataria
>Priority: Major
> Fix For: 1.26.0, 1.22.3
>
>
> This is an intermittent issue, where on querying the code throws
> AlreadyClosedException.
>
> {code:java}
> Caused by: org.apache.lucene.store.AlreadyClosedException: this IndexReader
> is closed
> at org.apache.lucene.index.IndexReader.ensureOpen(IndexReader.java:262)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.lucene.index.BaseCompositeReader.document(BaseCompositeReader.java:108)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at org.apache.lucene.index.IndexReader.document(IndexReader.java:446)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getAccessibleSampleCount(StatisticalSortedSetDocValuesFacetCounts.java:169)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getTopChildren0(StatisticalSortedSetDocValuesFacetCounts.java:104)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getTopChildren(StatisticalSortedSetDocValuesFacetCounts.java:70)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.lucene.facet.MultiFacets.getTopChildren(MultiFacets.java:52)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LucenePropertyIndex$LuceneFacetProvider.getFacets(LucenePropertyIndex.java:1547)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.search.spi.query.FulltextIndex$FulltextResultRow.getFacets(FulltextIndex.java:353)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.search.spi.query.FulltextIndex$FulltextPathCursor$2.getValue(FulltextIndex.java:472)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> ... 237 common frames omitted
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8898) On querying, IndexReader failed with AlreadyClosedException
[
https://issues.apache.org/jira/browse/OAK-8898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066650#comment-17066650
]
Mohit Kataria commented on OAK-8898:
Change also backported to 1.22 branch
[http://svn.apache.org/viewvc?view=revision&revision=1875638]
> On querying, IndexReader failed with AlreadyClosedException
> ---
>
> Key: OAK-8898
> URL: https://issues.apache.org/jira/browse/OAK-8898
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Mohit Kataria
>Priority: Major
> Fix For: 1.26.0, 1.22.3
>
>
> This is an intermittent issue, where on querying the code throws
> AlreadyClosedException.
>
> {code:java}
> Caused by: org.apache.lucene.store.AlreadyClosedException: this IndexReader
> is closed
> at org.apache.lucene.index.IndexReader.ensureOpen(IndexReader.java:262)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.lucene.index.BaseCompositeReader.document(BaseCompositeReader.java:108)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at org.apache.lucene.index.IndexReader.document(IndexReader.java:446)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getAccessibleSampleCount(StatisticalSortedSetDocValuesFacetCounts.java:169)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getTopChildren0(StatisticalSortedSetDocValuesFacetCounts.java:104)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getTopChildren(StatisticalSortedSetDocValuesFacetCounts.java:70)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.lucene.facet.MultiFacets.getTopChildren(MultiFacets.java:52)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LucenePropertyIndex$LuceneFacetProvider.getFacets(LucenePropertyIndex.java:1547)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.search.spi.query.FulltextIndex$FulltextResultRow.getFacets(FulltextIndex.java:353)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.search.spi.query.FulltextIndex$FulltextPathCursor$2.getValue(FulltextIndex.java:472)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> ... 237 common frames omitted
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8898) On querying, IndexReader failed with AlreadyClosedException
[
https://issues.apache.org/jira/browse/OAK-8898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060718#comment-17060718
]
Mohit Kataria commented on OAK-8898:
Thanks [~thomasm] for providing the patch.
As discussed changes have been merged with test case as ignored, as the test is
not consistent and result may vary based on system load.
Added comment over test to depict the same.
> On querying, IndexReader failed with AlreadyClosedException
> ---
>
> Key: OAK-8898
> URL: https://issues.apache.org/jira/browse/OAK-8898
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Mohit Kataria
>Priority: Major
> Fix For: 1.8.22
>
>
> This is an intermittent issue, where on querying the code throws
> AlreadyClosedException.
>
> {code:java}
> Caused by: org.apache.lucene.store.AlreadyClosedException: this IndexReader
> is closed
> at org.apache.lucene.index.IndexReader.ensureOpen(IndexReader.java:262)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.lucene.index.BaseCompositeReader.document(BaseCompositeReader.java:108)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at org.apache.lucene.index.IndexReader.document(IndexReader.java:446)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getAccessibleSampleCount(StatisticalSortedSetDocValuesFacetCounts.java:169)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getTopChildren0(StatisticalSortedSetDocValuesFacetCounts.java:104)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getTopChildren(StatisticalSortedSetDocValuesFacetCounts.java:70)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.lucene.facet.MultiFacets.getTopChildren(MultiFacets.java:52)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LucenePropertyIndex$LuceneFacetProvider.getFacets(LucenePropertyIndex.java:1547)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.search.spi.query.FulltextIndex$FulltextResultRow.getFacets(FulltextIndex.java:353)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.search.spi.query.FulltextIndex$FulltextPathCursor$2.getValue(FulltextIndex.java:472)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> ... 237 common frames omitted
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8898) On querying, IndexReader failed with AlreadyClosedException
[
https://issues.apache.org/jira/browse/OAK-8898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060714#comment-17060714
]
Mohit Kataria commented on OAK-8898:
Changes for this merged with parent task:
Commit revision:
[http://svn.apache.org/viewvc?view=revision&revision=1875283]
> On querying, IndexReader failed with AlreadyClosedException
> ---
>
> Key: OAK-8898
> URL: https://issues.apache.org/jira/browse/OAK-8898
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Mohit Kataria
>Priority: Major
>
> This is an intermittent issue, where on querying the code throws
> AlreadyClosedException.
>
> {code:java}
> Caused by: org.apache.lucene.store.AlreadyClosedException: this IndexReader
> is closed
> at org.apache.lucene.index.IndexReader.ensureOpen(IndexReader.java:262)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.lucene.index.BaseCompositeReader.document(BaseCompositeReader.java:108)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at org.apache.lucene.index.IndexReader.document(IndexReader.java:446)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getAccessibleSampleCount(StatisticalSortedSetDocValuesFacetCounts.java:169)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getTopChildren0(StatisticalSortedSetDocValuesFacetCounts.java:104)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getTopChildren(StatisticalSortedSetDocValuesFacetCounts.java:70)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.lucene.facet.MultiFacets.getTopChildren(MultiFacets.java:52)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LucenePropertyIndex$LuceneFacetProvider.getFacets(LucenePropertyIndex.java:1547)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.search.spi.query.FulltextIndex$FulltextResultRow.getFacets(FulltextIndex.java:353)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.search.spi.query.FulltextIndex$FulltextPathCursor$2.getValue(FulltextIndex.java:472)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> ... 237 common frames omitted
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8898) On querying, IndexReader failed with AlreadyClosedException
[
https://issues.apache.org/jira/browse/OAK-8898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056052#comment-17056052
]
Thomas Mueller commented on OAK-8898:
-
[~mkataria] I created a branch here:
[https://github.com/oak-indexing/jackrabbit-oak/tree/OAK-8898]
This allows to reproduce the issue (it is based on your test case).
I also found the root cause, and a possible solution (see
LucenePropertyIndex.OLD_FACET_PROVIDER). The problem seems to be that the
reader is used after it is closed, by leaking the reference to the searcher to
the LuceneFacetProvider in loadDocs(). I created a DelayedLuceneFacetProvider
that opens acquires and releases the searcher when needed (acquireIndexNode,
release in finally).
It would be good if the test can reproduce the issue even without the delays;
we can discuss this.
> On querying, IndexReader failed with AlreadyClosedException
> ---
>
> Key: OAK-8898
> URL: https://issues.apache.org/jira/browse/OAK-8898
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Mohit Kataria
>Priority: Major
>
> This is an intermittent issue, where on querying the code throws
> AlreadyClosedException.
>
> {code:java}
> Caused by: org.apache.lucene.store.AlreadyClosedException: this IndexReader
> is closed
> at org.apache.lucene.index.IndexReader.ensureOpen(IndexReader.java:262)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.lucene.index.BaseCompositeReader.document(BaseCompositeReader.java:108)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at org.apache.lucene.index.IndexReader.document(IndexReader.java:446)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getAccessibleSampleCount(StatisticalSortedSetDocValuesFacetCounts.java:169)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getTopChildren0(StatisticalSortedSetDocValuesFacetCounts.java:104)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.StatisticalSortedSetDocValuesFacetCounts.getTopChildren(StatisticalSortedSetDocValuesFacetCounts.java:70)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.lucene.facet.MultiFacets.getTopChildren(MultiFacets.java:52)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LucenePropertyIndex$LuceneFacetProvider.getFacets(LucenePropertyIndex.java:1547)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.search.spi.query.FulltextIndex$FulltextResultRow.getFacets(FulltextIndex.java:353)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> at
> org.apache.jackrabbit.oak.plugins.index.search.spi.query.FulltextIndex$FulltextPathCursor$2.getValue(FulltextIndex.java:472)
> [org.apache.jackrabbit.oak-lucene:1.10.2]
> ... 237 common frames omitted
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
