[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-20 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041184#comment-17041184
 ] 

Julian Reschke commented on OAK-8902:
-

trunk: [r1874261|http://svn.apache.org/r1874261] 
[r1874259|http://svn.apache.org/r1874259] 
[r1874183|http://svn.apache.org/r1874183]

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
> Fix For: 1.26.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-20 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041183#comment-17041183
 ] 

Julian Reschke commented on OAK-8902:
-

[~ngupta] - is this still in progress, or resolved?

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
> Fix For: 1.26.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-20 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041079#comment-17041079
 ] 

Nitin Gupta commented on OAK-8902:
--

Committed to trunk - 
[https://svn.apache.org/viewvc?view=revision=1874259]

[https://svn.apache.org/viewvc?view=revision=1874183]

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
> Fix For: 1.26.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-20 Thread Amit Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040849#comment-17040849
 ] 

Amit Jain commented on OAK-8902:


[~ngupta] The PR looks good to me.

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
> Fix For: 1.26.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-20 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040807#comment-17040807
 ] 

Nitin Gupta commented on OAK-8902:
--

[~amitjain] - have updated the PR with the changes you suggested.

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
> Fix For: 1.26.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-19 Thread Amit Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040601#comment-17040601
 ] 

Amit Jain commented on OAK-8902:


[~ngupta]
{quote}I haven't removed DataStoreCheckCommand for now as I am not sure if that 
is being used by any teams in skyline
{quote}
There should anyways be a separate task for that and I think there already 
exists but that is later

I have added my comments to the PR

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
> Fix For: 1.26.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-19 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040002#comment-17040002
 ] 

Nitin Gupta commented on OAK-8902:
--

Fixed the test in the PR - [https://github.com/apache/jackrabbit-oak/pull/188] .

 

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
> Fix For: 1.26.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-19 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039987#comment-17039987
 ] 

Nitin Gupta commented on OAK-8902:
--

A couple of tests are failing, probably because I made both the marked- as well 
as gccand- files list backend friendly blobids if verbose option is present 
(initially only the blobids in gccand- file (missing blobids) were transformed 
into backend friendly format)

 

I think here, fixing the tests to change their expectation would be ok.

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
> Fix For: 1.26.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-19 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039970#comment-17039970
 ] 

Nitin Gupta commented on OAK-8902:
--

[~amitjain] - I have made the changes needed to support this is 
DataStoreCommand here - [https://github.com/apache/jackrabbit-oak/pull/188] . 
Can you please have a look ?

 

I haven't removed DataStoreCheckCommand for now as I am not sure if that is 
being used by any teams in skyline

 

cc : [~thomasm]

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
> Fix For: 1.26.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-18 Thread Amit Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039746#comment-17039746
 ] 

Amit Jain commented on OAK-8902:


[~ngupta] Sorry was not able to review this. But a better place to add or also 
add this would be the DataStoreCommand. And maybe we should remove 
DataStoreCheckCommand.

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
> Fix For: 1.26.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-18 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039727#comment-17039727
 ] 

Nitin Gupta commented on OAK-8902:
--

Merged in trunk - 
[https://svn.apache.org/viewvc?view=revision=1874183] .

Reviews still welcome in case someone comes up with something that needs to be 
changed.

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-18 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039089#comment-17039089
 ] 

Nitin Gupta commented on OAK-8902:
--

PR against the new repo here - 
[https://github.com/oak-indexing/jackrabbit-oak/pull/23]

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-18 Thread Thomas Mueller (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039035#comment-17039035
 ] 

Thomas Mueller commented on OAK-8902:
-

See my comments.

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8902) Add support in oak-run to list down blob ids for lucene indexes

2020-02-18 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038980#comment-17038980
 ] 

Nitin Gupta commented on OAK-8902:
--

PR here - [https://github.com/apache/jackrabbit-oak/pull/184/files] .

[~thomasm] , [~amitjain] , [~fabrizio.fort...@gmail.com] - Can you please have 
a look at the PR and provide inputs ? Idea is to list all the lucene blobs and 
the implementation in the PR handles listing down of all the blobids under a 
given list of paths(which would be /oak:index in our current case).

> Add support in oak-run to list down blob ids for lucene indexes
> ---
>
> Key: OAK-8902
> URL: https://issues.apache.org/jira/browse/OAK-8902
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)