[jira] [Commented] (OAK-8969) Ignore domain overwrite doesn't work well when presignedHttpDownloadURICacheMaxSize is set

2020-03-26 Thread Matt Ryan (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067924#comment-17067924
 ] 

Matt Ryan commented on OAK-8969:


Fixed in 1.22 in 
[r1875730|https://svn.apache.org/viewvc?view=revision=1875730].

> Ignore domain overwrite doesn't work well when 
> presignedHttpDownloadURICacheMaxSize is set
> --
>
> Key: OAK-8969
> URL: https://issues.apache.org/jira/browse/OAK-8969
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: blob-cloud-azure
>Affects Versions: 1.26.0
>Reporter: Jun Zhang
>Assignee: Matt Ryan
>Priority: Major
>  Labels: candidate_oak_1_22
> Fix For: 1.28.0
>
>
> Ignore domain overwrite doesn't work well when 
> presignedHttpDownloadURICacheMaxSize is set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8969) Ignore domain overwrite doesn't work well when presignedHttpDownloadURICacheMaxSize is set

2020-03-25 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066752#comment-17066752
 ] 

Julian Reschke commented on OAK-8969:
-

[~mattvryan] - please (a) set to "resolved" when fixed in, trunk, set label 
"candidate_..." when backport is planned, and only set fixVersion when the fix 
is actually in.

> Ignore domain overwrite doesn't work well when 
> presignedHttpDownloadURICacheMaxSize is set
> --
>
> Key: OAK-8969
> URL: https://issues.apache.org/jira/browse/OAK-8969
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: blob-cloud-azure
>Affects Versions: 1.26.0
>Reporter: Jun Zhang
>Assignee: Matt Ryan
>Priority: Major
> Fix For: 1.28.0
>
>
> Ignore domain overwrite doesn't work well when 
> presignedHttpDownloadURICacheMaxSize is set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8969) Ignore domain overwrite doesn't work well when presignedHttpDownloadURICacheMaxSize is set

2020-03-24 Thread Matt Ryan (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066396#comment-17066396
 ] 

Matt Ryan commented on OAK-8969:


Fixed in 
[r1875608|https://svn.apache.org/viewvc?view=revision=1875608].

Needs to be backported also to 1.26 and 1.22.

> Ignore domain overwrite doesn't work well when 
> presignedHttpDownloadURICacheMaxSize is set
> --
>
> Key: OAK-8969
> URL: https://issues.apache.org/jira/browse/OAK-8969
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: blob-cloud
>Affects Versions: 1.26.0
>Reporter: Jun Zhang
>Assignee: Matt Ryan
>Priority: Major
>
> Ignore domain overwrite doesn't work well when 
> presignedHttpDownloadURICacheMaxSize is set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8969) Ignore domain overwrite doesn't work well when presignedHttpDownloadURICacheMaxSize is set

2020-03-24 Thread Matt Ryan (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066218#comment-17066218
 ] 

Matt Ryan commented on OAK-8969:


If caching is enabled then there is a chance that a URI previously generated 
without ignoring a domain override will be reused out of cache when another URI 
for the same blob ID is requested again.  If the subsequent request wants to 
ignore the domain override then the wrong URI will then be pulled from the 
cache, if the URI hasn't expired yet, because the key for the cache is just the 
blob ID.

A simple solution to this would be to compute the value of the download URI 
domain beforehand, and then use that along with the blob ID for the cache key.  
The domain value will be different if the domain override ignore flag is set 
than it would be if it is not set, so this would result in a cache miss and the 
correct URI being returned.

> Ignore domain overwrite doesn't work well when 
> presignedHttpDownloadURICacheMaxSize is set
> --
>
> Key: OAK-8969
> URL: https://issues.apache.org/jira/browse/OAK-8969
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: blob-cloud
>Reporter: Jun Zhang
>Assignee: Matt Ryan
>Priority: Major
>
> Ignore domain overwrite doesn't work well when 
> presignedHttpDownloadURICacheMaxSize is set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)