[jira] [Commented] (OAK-9352) move SystemPropertySupplier from document to commons
[ https://issues.apache.org/jira/browse/OAK-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286550#comment-17286550 ] Stefan Egli commented on OAK-9352: -- * And merged above 1886665 to 1.22 branch in [188|http://svn.apache.org/viewvc?rev=188=rev] > move SystemPropertySupplier from document to commons > > > Key: OAK-9352 > URL: https://issues.apache.org/jira/browse/OAK-9352 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: commons, documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Minor > Fix For: 1.40.0, 1.22.7 > > > If we would like to reuse the SystemPropertySupplier throughout oak we could > move it from oak-store-document to oak-commons. > One such occurrence was in https://github.com/apache/jackrabbit-oak/pull/269 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-9352) move SystemPropertySupplier from document to commons
[
https://issues.apache.org/jira/browse/OAK-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286545#comment-17286545
]
Stefan Egli commented on OAK-9352:
--
* Also added {{commons.properties}} to list of exported packages in
[1886665|http://svn.apache.org/viewvc?rev=1886665=rev] in trunk
> move SystemPropertySupplier from document to commons
>
>
> Key: OAK-9352
> URL: https://issues.apache.org/jira/browse/OAK-9352
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: commons, documentmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
> Fix For: 1.40.0, 1.22.7
>
>
> If we would like to reuse the SystemPropertySupplier throughout oak we could
> move it from oak-store-document to oak-commons.
> One such occurrence was in https://github.com/apache/jackrabbit-oak/pull/269
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-9352) move SystemPropertySupplier from document to commons
[ https://issues.apache.org/jira/browse/OAK-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286350#comment-17286350 ] Stefan Egli commented on OAK-9352: -- * Also applied the moving of the test in rev [1886657|http://svn.apache.org/viewvc?rev=1886657=rev] > move SystemPropertySupplier from document to commons > > > Key: OAK-9352 > URL: https://issues.apache.org/jira/browse/OAK-9352 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: commons, documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Minor > Labels: candidate_oak_1_22 > Fix For: 1.40.0 > > > If we would like to reuse the SystemPropertySupplier throughout oak we could > move it from oak-store-document to oak-commons. > One such occurrence was in https://github.com/apache/jackrabbit-oak/pull/269 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-9352) move SystemPropertySupplier from document to commons
[ https://issues.apache.org/jira/browse/OAK-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285227#comment-17285227 ] Marcel Reutegger commented on OAK-9352: --- bq. new package +1 > move SystemPropertySupplier from document to commons > > > Key: OAK-9352 > URL: https://issues.apache.org/jira/browse/OAK-9352 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: commons, documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Minor > > If we would like to reuse the SystemPropertySupplier throughout oak we could > move it from oak-store-document to oak-commons. > One such occurrence was in https://github.com/apache/jackrabbit-oak/pull/269 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-9352) move SystemPropertySupplier from document to commons
[
https://issues.apache.org/jira/browse/OAK-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285184#comment-17285184
]
Stefan Egli commented on OAK-9352:
--
bq. ...need to be careful with API versioning...
true ..
So I have updated the [PR|https://github.com/apache/jackrabbit-oak/pull/271]
now to instead move the SystemPropertySupplier to its own, new package
{{rg.apache.jackrabbit.oak.commons.properties}} - that way we should avoid any
versioning trouble in the 1.22 branch..
/cc [~reschke], [~mreutegg]
> move SystemPropertySupplier from document to commons
>
>
> Key: OAK-9352
> URL: https://issues.apache.org/jira/browse/OAK-9352
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: commons, documentmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
>
> If we would like to reuse the SystemPropertySupplier throughout oak we could
> move it from oak-store-document to oak-commons.
> One such occurrence was in https://github.com/apache/jackrabbit-oak/pull/269
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-9352) move SystemPropertySupplier from document to commons
[ https://issues.apache.org/jira/browse/OAK-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282989#comment-17282989 ] Julian Reschke commented on OAK-9352: - ...need to be careful with API versioning... > move SystemPropertySupplier from document to commons > > > Key: OAK-9352 > URL: https://issues.apache.org/jira/browse/OAK-9352 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: commons, documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Minor > > If we would like to reuse the SystemPropertySupplier throughout oak we could > move it from oak-store-document to oak-commons. > One such occurrence was in https://github.com/apache/jackrabbit-oak/pull/269 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-9352) move SystemPropertySupplier from document to commons
[ https://issues.apache.org/jira/browse/OAK-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282977#comment-17282977 ] Stefan Egli commented on OAK-9352: -- I was going to look into the 1.22 backport next, yes > move SystemPropertySupplier from document to commons > > > Key: OAK-9352 > URL: https://issues.apache.org/jira/browse/OAK-9352 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: commons, documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Minor > > If we would like to reuse the SystemPropertySupplier throughout oak we could > move it from oak-store-document to oak-commons. > One such occurrence was in https://github.com/apache/jackrabbit-oak/pull/269 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-9352) move SystemPropertySupplier from document to commons
[ https://issues.apache.org/jira/browse/OAK-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282957#comment-17282957 ] Julian Reschke commented on OAK-9352: - ...wondering whether we can backport that to 1.22 if we need to? > move SystemPropertySupplier from document to commons > > > Key: OAK-9352 > URL: https://issues.apache.org/jira/browse/OAK-9352 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: commons, documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Minor > > If we would like to reuse the SystemPropertySupplier throughout oak we could > move it from oak-store-document to oak-commons. > One such occurrence was in https://github.com/apache/jackrabbit-oak/pull/269 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-9352) move SystemPropertySupplier from document to commons
[ https://issues.apache.org/jira/browse/OAK-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282930#comment-17282930 ] Marcel Reutegger commented on OAK-9352: --- +1 Looks good to me. > move SystemPropertySupplier from document to commons > > > Key: OAK-9352 > URL: https://issues.apache.org/jira/browse/OAK-9352 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: commons, documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Minor > > If we would like to reuse the SystemPropertySupplier throughout oak we could > move it from oak-store-document to oak-commons. > One such occurrence was in https://github.com/apache/jackrabbit-oak/pull/269 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-9352) move SystemPropertySupplier from document to commons
[ https://issues.apache.org/jira/browse/OAK-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282638#comment-17282638 ] Julian Reschke commented on OAK-9352: - That was the intention essentially. The idea was to test that in oak-s-d and see whether we're happy with the API, before making it available more widely. > move SystemPropertySupplier from document to commons > > > Key: OAK-9352 > URL: https://issues.apache.org/jira/browse/OAK-9352 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: commons, documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Minor > > If we would like to reuse the SystemPropertySupplier throughout oak we could > move it from oak-store-document to oak-commons. > One such occurrence was in https://github.com/apache/jackrabbit-oak/pull/269 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-9352) move SystemPropertySupplier from document to commons
[ https://issues.apache.org/jira/browse/OAK-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282621#comment-17282621 ] Stefan Egli commented on OAK-9352: -- * suggested [PR#271|https://github.com/apache/jackrabbit-oak/pull/271] [~reschke], [~mreutegg], wdyt? > move SystemPropertySupplier from document to commons > > > Key: OAK-9352 > URL: https://issues.apache.org/jira/browse/OAK-9352 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: commons, documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Minor > > If we would like to reuse the SystemPropertySupplier throughout oak we could > move it from oak-store-document to oak-commons. > One such occurrence was in https://github.com/apache/jackrabbit-oak/pull/269 -- This message was sent by Atlassian Jira (v8.3.4#803005)
