[jira] [Updated] (OAK-3686) Solr suggestion results should have 1 row per suggestion with appropriate column names
[
https://issues.apache.org/jira/browse/OAK-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Saurabh updated OAK-3686:
---
Fix Version/s: 1.3.12
> Solr suggestion results should have 1 row per suggestion with appropriate
> column names
> --
>
> Key: OAK-3686
> URL: https://issues.apache.org/jira/browse/OAK-3686
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: solr
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 1.3.12
>
>
> Currently suggest query returns just one row with {{rep:suggest()}} column
> containing a string that needs to be parsed.
> It'd better if each suggestion is returned as individual row with column
> names such as {{suggestion}}, {{weight}}(???), etc.
> (This is essentially the same issue as OAK-3509 but for solr)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OAK-3686) Lucene suggestion results should have 1 row per suggestion with appropriate column names
Vikas Saurabh created OAK-3686:
--
Summary: Lucene suggestion results should have 1 row per
suggestion with appropriate column names
Key: OAK-3686
URL: https://issues.apache.org/jira/browse/OAK-3686
Project: Jackrabbit Oak
Issue Type: Task
Components: solr
Reporter: Vikas Saurabh
Assignee: Vikas Saurabh
Priority: Minor
Currently suggest query returns just one row with {{rep:suggest()}} column
containing a string that needs to be parsed.
It'd better if each suggestion is returned as individual row with column names
such as {{suggestion}}, {{weight}}(???), etc.
(This is essentially the same issue as OAK-3509 but for solr)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-3686) Solr suggestion results should have 1 row per suggestion with appropriate column names
[
https://issues.apache.org/jira/browse/OAK-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Saurabh updated OAK-3686:
---
Summary: Solr suggestion results should have 1 row per suggestion with
appropriate column names (was: Lucene suggestion results should have 1 row per
suggestion with appropriate column names)
> Solr suggestion results should have 1 row per suggestion with appropriate
> column names
> --
>
> Key: OAK-3686
> URL: https://issues.apache.org/jira/browse/OAK-3686
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: solr
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
>
> Currently suggest query returns just one row with {{rep:suggest()}} column
> containing a string that needs to be parsed.
> It'd better if each suggestion is returned as individual row with column
> names such as {{suggestion}}, {{weight}}(???), etc.
> (This is essentially the same issue as OAK-3509 but for solr)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-3686) Solr suggestion results should have 1 row per suggestion with appropriate column names
[
https://issues.apache.org/jira/browse/OAK-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Saurabh updated OAK-3686:
---
Attachment: OAK-3686.patch
@teofili, I'm attaching a [patch|^OAK-3686.patch]. Current implementation uses
unique=true for path cursor while a similar issue for lucene - OAK-2754 (Use
non unique PathCursor in LucenePropertyIndex) was done for lucene property
index to use non unique path cursor. I'm not sure if we can do it safely for
solr or not (i.e. the current version of solr queries would be returning unique
nodes anyway for relevant cases)
> Solr suggestion results should have 1 row per suggestion with appropriate
> column names
> --
>
> Key: OAK-3686
> URL: https://issues.apache.org/jira/browse/OAK-3686
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: solr
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 1.3.12
>
> Attachments: OAK-3686.patch
>
>
> Currently suggest query returns just one row with {{rep:suggest()}} column
> containing a string that needs to be parsed.
> It'd better if each suggestion is returned as individual row with column
> names such as {{suggestion}}, {{weight}}(???), etc.
> (This is essentially the same issue as OAK-3509 but for solr)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3666) Add information about repeated upgrade to documentation
[ https://issues.apache.org/jira/browse/OAK-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3666. -- Bulk close for 1.3.11 > Add information about repeated upgrade to documentation > --- > > Key: OAK-3666 > URL: https://issues.apache.org/jira/browse/OAK-3666 > Project: Jackrabbit Oak > Issue Type: Documentation > Components: doc, upgrade >Reporter: Tomek Rękawek >Assignee: Stefan Egli > Fix For: 1.3.11 > > Attachments: OAK-3666.patch > > > Please add info about the OAK-2619 to the [migration documentation > page|https://jackrabbit.apache.org/oak/docs/migration.html]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3607) Enable caching of extracted text by default
[ https://issues.apache.org/jira/browse/OAK-3607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3607. -- Bulk close for 1.3.11 > Enable caching of extracted text by default > --- > > Key: OAK-3607 > URL: https://issues.apache.org/jira/browse/OAK-3607 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.3.11 > > > Followup issue for OAK-3092 meant to enable that feature by default. So by > default the cache size would be set to 20 MB and expiry set to 5 mins > Also later we should be enabling this in branches also -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3624) TypeEditor doesn't validate the required property type
[ https://issues.apache.org/jira/browse/OAK-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3624. -- Bulk close for 1.3.11 > TypeEditor doesn't validate the required property type > -- > > Key: OAK-3624 > URL: https://issues.apache.org/jira/browse/OAK-3624 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: core >Reporter: angela > Fix For: 1.3.11 > > Attachments: OAK-3624.patch > > > the type editor only validates the value constraints but doesn't enforce the > required type of properties. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3665) Oak Run TarMK revision diff
[ https://issues.apache.org/jira/browse/OAK-3665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3665. -- Bulk close for 1.3.11 > Oak Run TarMK revision diff > --- > > Key: OAK-3665 > URL: https://issues.apache.org/jira/browse/OAK-3665 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: run, segmentmk >Reporter: Alex Parvulescu >Assignee: Alex Parvulescu > Fix For: 1.3.11 > > > I'd like to add support for generating diffs between 2 given revisions, > either direct or incrementally (one by one between the 2 given limits). > Oak Explorer already has partial support for this, this issue is for the > oak-run support to generate a log with the diff output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3609) Enable CopyOnWrite by default
[ https://issues.apache.org/jira/browse/OAK-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3609. -- Bulk close for 1.3.11 > Enable CopyOnWrite by default > - > > Key: OAK-3609 > URL: https://issues.apache.org/jira/browse/OAK-3609 > Project: Jackrabbit Oak > Issue Type: Task > Components: lucene >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.3.11 > > > Task to track enabling CopyOnWrite feature (OAK-2247) by default > Later this needs to be enabled by default on branches also -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3636) Change scope of json-simple from compile to test
[ https://issues.apache.org/jira/browse/OAK-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3636. -- Bulk close for 1.3.11 > Change scope of json-simple from compile to test > > > Key: OAK-3636 > URL: https://issues.apache.org/jira/browse/OAK-3636 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: authorization-cug, core, run >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.3.11 > > > The library json-simple is only used by test code in oak-core but currently > has a compile scope dependency. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3635) DocumentStore: clarify which methods support checking conditions in UpdateOps, and enforce this in implementations
[ https://issues.apache.org/jira/browse/OAK-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3635. -- Bulk close for 1.3.11 > DocumentStore: clarify which methods support checking conditions in > UpdateOps, and enforce this in implementations > -- > > Key: OAK-3635 > URL: https://issues.apache.org/jira/browse/OAK-3635 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk, mongomk, rdbmk >Affects Versions: 1.3.10, 1.2.8, 1.0.24 >Reporter: Julian Reschke >Assignee: Julian Reschke > Fix For: 1.3.11, 1.2.9, 1.0.25 > > Attachments: OAK-3635.diff > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3657) RDBDocumentStore: cache update logic introduced for OAK-3566 should only be used for NODES collection
[ https://issues.apache.org/jira/browse/OAK-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3657. -- Bulk close for 1.3.11 > RDBDocumentStore: cache update logic introduced for OAK-3566 should only be > used for NODES collection > - > > Key: OAK-3657 > URL: https://issues.apache.org/jira/browse/OAK-3657 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Affects Versions: 1.3.10, 1.2.8, 1.0.24 >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Fix For: 1.3.11, 1.2.9, 1.0.25 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3650) Index based excerpt should be used for binaries
[ https://issues.apache.org/jira/browse/OAK-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3650. -- Bulk close for 1.3.11 > Index based excerpt should be used for binaries > --- > > Key: OAK-3650 > URL: https://issues.apache.org/jira/browse/OAK-3650 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene, query >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili > Fix For: 1.3.11, 1.2.9, 1.0.25 > > > Index provided excerpt should be used for binaries, that is the case when for > example an index excerpt exists yet the row value to be retrieved is property > specific and thus the fallback provider kicks in, however that won't work for > binary properties and therefore the excerpt provided by the index should be > used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3651) Remove HierrachialCacheInvalidator
[ https://issues.apache.org/jira/browse/OAK-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3651. -- Bulk close for 1.3.11 > Remove HierrachialCacheInvalidator > -- > > Key: OAK-3651 > URL: https://issues.apache.org/jira/browse/OAK-3651 > Project: Jackrabbit Oak > Issue Type: Task > Components: mongomk >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Labels: technical_debt > Fix For: 1.3.11 > > > As discussed in OAK-2187 and due to changes done in OAK-3002 > HierrachialCacheInvalidator is now redundant and should be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-2539) SQL2 query not working with filter (s.[stringa] = 'a' OR CONTAINS(s.[stringb], 'b'))
[ https://issues.apache.org/jira/browse/OAK-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-2539. -- Bulk close for 1.3.11 > SQL2 query not working with filter (s.[stringa] = 'a' OR > CONTAINS(s.[stringb], 'b')) > > > Key: OAK-2539 > URL: https://issues.apache.org/jira/browse/OAK-2539 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, query >Reporter: Calvin Wong >Assignee: Thomas Mueller > Fix For: 1.3.11 > > > Create node /content/usergenerated/qtest with jcr:primaryType nt:unstrucuted. > Add 2 String properties: stringa = "a", stringb = "b". > Use query tool in CRX/DE to do SQL2 search: > This search will find qtest: > SELECT * FROM [nt:base] AS s WHERE > ISDESCENDANTNODE([/content/usergenerated/]) AND (s.[stringa] = 'a' OR > CONTAINS(s.[stringb], 'b')) > This search will find qtest: > SELECT * FROM [nt:base] AS s WHERE > ISDESCENDANTNODE([/content/usergenerated/]) AND (CONTAINS(s.[stringb], 'b')) > This search will not find qtest: > SELECT * FROM [nt:base] AS s WHERE > ISDESCENDANTNODE([/content/usergenerated/]) AND (s.[stringa] = 'x' OR > CONTAINS(s.[stringb], 'b')) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3215) Solr test often fail with No such core: oak
[
https://issues.apache.org/jira/browse/OAK-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Jain closed OAK-3215.
--
Bulk close for 1.3.11
> Solr test often fail with No such core: oak
>
>
> Key: OAK-3215
> URL: https://issues.apache.org/jira/browse/OAK-3215
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: solr
>Reporter: Chetan Mehrotra
>Assignee: Tommaso Teofili
>Priority: Minor
> Labels: CI
> Fix For: 1.3.11
>
>
> Often it can be seen that all test from oak-solr module fail. And in all such
> failure following error is reported
> {noformat}
> org.apache.solr.common.SolrException: No such core: oak
> at
> org.apache.solr.client.solrj.embedded.EmbeddedSolrServer.request(EmbeddedSolrServer.java:112)
> at
> org.apache.solr.client.solrj.request.AbstractUpdateRequest.process(AbstractUpdateRequest.java:118)
> at org.apache.solr.client.solrj.SolrServer.add(SolrServer.java:116)
> at org.apache.solr.client.solrj.SolrServer.add(SolrServer.java:102)
> at
> org.apache.jackrabbit.oak.plugins.index.solr.query.SolrQueryIndexTest.testQueryOnIgnoredExistingProperty(SolrQueryIndexTest.java:330)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> {noformat}
> Most recent failure in
> https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/325/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3647) enable OAK-1617 by default in trunk
[ https://issues.apache.org/jira/browse/OAK-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3647. -- Bulk close for 1.3.11 > enable OAK-1617 by default in trunk > --- > > Key: OAK-3647 > URL: https://issues.apache.org/jira/browse/OAK-3647 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, query >Affects Versions: 1.3.10 >Reporter: Davide Giannella >Assignee: Davide Giannella > Fix For: 1.3.11 > > > When implemented the features provided with OAK-1617 were disabled by > default. This didn't introduce any regression. > Now Enable them by default in order to early catch bugs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3622) Expose sql2optimisation prop name as static final
[
https://issues.apache.org/jira/browse/OAK-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Jain closed OAK-3622.
--
Bulk close for 1.3.11
> Expose sql2optimisation prop name as static final
> -
>
> Key: OAK-3622
> URL: https://issues.apache.org/jira/browse/OAK-3622
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Affects Versions: 1.3.9
>Reporter: Davide Giannella
>Assignee: Davide Giannella
> Fix For: 1.4, 1.3.11
>
>
> make the {{oak.query.sql2optimisation}} a public static final String to ease
> reuse from client applications extending and customising the
> QueryEngineSettings
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3558) oak-core imports every package with the optional resolution policy
[
https://issues.apache.org/jira/browse/OAK-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Jain closed OAK-3558.
--
Bulk close for 1.3.11
> oak-core imports every package with the optional resolution policy
> --
>
> Key: OAK-3558
> URL: https://issues.apache.org/jira/browse/OAK-3558
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Reporter: Francesco Mari
>Assignee: Chetan Mehrotra
> Fix For: 1.3.11
>
>
> The oak-core bundle declares that every imported package has an optional
> resolution policy. Because of this, the OSGi framework will not attempt to
> resolve any imported package, but will happily resolve the bundle even if
> some dependencies are missing. This may generate {{NoClassDefFoundError}} at
> runtime.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3477) Make JMX Bean names predictable so they can be used in configurations.
[
https://issues.apache.org/jira/browse/OAK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Jain closed OAK-3477.
--
Bulk close for 1.3.11
> Make JMX Bean names predictable so they can be used in configurations.
> --
>
> Key: OAK-3477
> URL: https://issues.apache.org/jira/browse/OAK-3477
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
>Affects Versions: 1.3.7
>Reporter: Ian Boston
>Assignee: Chetan Mehrotra
> Labels: candidate_oak_1_0, candidate_oak_1_2
> Fix For: 1.3.11
>
> Attachments: OAK-3477.patch
>
>
> In Oak there are JMX beans which get names of the form [1], which can be hard
> to use in monitoring tool configuration that dont support regexes as the ID
> will change. Where possible, the ID should be removed or made static. The
> name and type should be sufficient in most cases in Oak to make the JMX
> Object name unique.
> 1
> {code}
> org.apache.jackrabbit.oak:name="Consolidated Cache
> statistics",type="ConsolidatedCacheStats",id=6
> org.apache.jackrabbit.oak:name="CopyOnRead support
> statistics",type="CopyOnReadStats",id=7
> org.apache.jackrabbit.oak:name="Oak Repository
> Statistics",type="RepositoryStats",id=16
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3618) Improve SetPropertyTest benchmark for concurrent execution
[ https://issues.apache.org/jira/browse/OAK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3618. -- Bulk close for 1.3.11 > Improve SetPropertyTest benchmark for concurrent execution > -- > > Key: OAK-3618 > URL: https://issues.apache.org/jira/browse/OAK-3618 > Project: Jackrabbit Oak > Issue Type: Test > Components: run >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.3.11 > > > The test currently runs with a single session even when executed with a > concurrency > 1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3648) Use StandardTokenizer instead of ClassicTokenizer in OakAnalyzer
[
https://issues.apache.org/jira/browse/OAK-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Jain closed OAK-3648.
--
Bulk close for 1.3.11
> Use StandardTokenizer instead of ClassicTokenizer in OakAnalyzer
>
>
> Key: OAK-3648
> URL: https://issues.apache.org/jira/browse/OAK-3648
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
> Fix For: 1.3.11
>
>
> This is related to OAK-3276 where the intent was to use {{StandardAnalyzer}}
> by default (instead of {{OakAnalyzer}}). As discussed there, we need specific
> word delimiter which isn't possible with StandardAnalyzer, so we instead
> should switch over to StandardTokenizer in OakAnalyer itself.
> A few motivations to do that:
> * Better unicode support
> * ClassicTokenizer is the old (~lucene 3.1) implementation of standard
> tokenizer
> One of the key difference between classic and standard tokenizer is the way
> they delimit words (standard analyzer follows unicode text segmentation
> rules)... but that difference gets nullified as we have our own
> WordDelimiterFilter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3644) Run tests with pedantic profile
[ https://issues.apache.org/jira/browse/OAK-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3644. -- Bulk close for 1.3.11 > Run tests with pedantic profile > --- > > Key: OAK-3644 > URL: https://issues.apache.org/jira/browse/OAK-3644 > Project: Jackrabbit Oak > Issue Type: Test > Components: parent >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger > Fix For: 1.3.11, 1.2.9, 1.0.25 > > > As discussed on the [list|http://markmail.org/message/3vrt2s2froxtztgg] the > pedantic profile currently does not run tests. This means the release checker > script does not run tests either. > This new behaviour was introduced with OAK-1855. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-1995) Improved SegmentNodeStore documentation
[ https://issues.apache.org/jira/browse/OAK-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-1995. -- Bulk close for 1.3.11 > Improved SegmentNodeStore documentation > --- > > Key: OAK-1995 > URL: https://issues.apache.org/jira/browse/OAK-1995 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: doc, segmentmk >Reporter: Thomas Mueller >Assignee: Thomas Mueller >Priority: Minor > Fix For: 1.3.11 > > > I'd like to have more documentation to understand the inner workings of the > SegmentNodeStore implementation. > * Architecture level docs > * Class level javadocs > * Field javadocs > * Method level javadocs > * More complete file format docs > Maybe it's possible to make a few things "more" private. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3387) Enable NodeLocalNameTest tests
[ https://issues.apache.org/jira/browse/OAK-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3387. -- Bulk close for 1.3.11 > Enable NodeLocalNameTest tests > -- > > Key: OAK-3387 > URL: https://issues.apache.org/jira/browse/OAK-3387 > Project: Jackrabbit Oak > Issue Type: Test > Components: jcr >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Fix For: 1.3.11 > > > Enable the tests that were disabled in OAK-3265, once Jackrabbit is released. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3619) Increase lock stripes in MongoDocumentStore
[ https://issues.apache.org/jira/browse/OAK-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3619. -- Bulk close for 1.3.11 > Increase lock stripes in MongoDocumentStore > > > Key: OAK-3619 > URL: https://issues.apache.org/jira/browse/OAK-3619 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, mongomk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.3.11 > > > The current number of lock stripes is rather low and leads to lock contention > of unrelated updates when concurrency increases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3625) Test cases using wrong property types
[
https://issues.apache.org/jira/browse/OAK-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Jain closed OAK-3625.
--
Bulk close for 1.3.11
> Test cases using wrong property types
> -
>
> Key: OAK-3625
> URL: https://issues.apache.org/jira/browse/OAK-3625
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Reporter: angela
>Assignee: angela
> Fix For: 1.3.11
>
>
> in the light of OAK-3624 i found that some test cases actually use wrong
> property types ("string" instead of "name").
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3509) Lucene suggestion results should have 1 row per suggestion with appropriate column names
[
https://issues.apache.org/jira/browse/OAK-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Jain closed OAK-3509.
--
Bulk close for 1.3.11
> Lucene suggestion results should have 1 row per suggestion with appropriate
> column names
>
>
> Key: OAK-3509
> URL: https://issues.apache.org/jira/browse/OAK-3509
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 1.3.11
>
>
> Currently suggest query returns just one row with {{rep:suggest()}} column
> containing a string that needs to be parsed.
> It'd better if each suggestion is returned as individual row with column
> names such as {{suggestion}}, {{weight}}(???), etc.
> (cc [~teofili])
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3628) baseline failures on trunk
[
https://issues.apache.org/jira/browse/OAK-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Jain closed OAK-3628.
--
Bulk close for 1.3.11
> baseline failures on trunk
> --
>
> Key: OAK-3628
> URL: https://issues.apache.org/jira/browse/OAK-3628
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Affects Versions: 1.3.10
>Reporter: Davide Giannella
>Assignee: Davide Giannella
> Fix For: 1.4, 1.3.11
>
>
> Baseline failures on trunk in oak-core as
> {noformat}
> [ERROR] org.apache.jackrabbit.oak.query: Version increase required; detected
> 2.4.0, suggested 2.5.0
> [ERROR] org.apache.jackrabbit.oak.query.fulltext: Version increase required;
> detected 1.1.0, suggested 1.2.0
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3643) ConflictResolutionTest fails occasionally
[ https://issues.apache.org/jira/browse/OAK-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain closed OAK-3643. -- Bulk close for 1.3.11 > ConflictResolutionTest fails occasionally > - > > Key: OAK-3643 > URL: https://issues.apache.org/jira/browse/OAK-3643 > Project: Jackrabbit Oak > Issue Type: Test > Components: jcr >Affects Versions: 1.2.7, 1.0.23 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.3.11, 1.2.9, 1.0.25 > > > Failed recently on travis: > https://travis-ci.org/apache/jackrabbit-oak/builds/91405008 > But failed also a couple of times on Jenkins. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OAK-3687) Oak standalone application example based on Spring Boot
Chetan Mehrotra created OAK-3687: Summary: Oak standalone application example based on Spring Boot Key: OAK-3687 URL: https://issues.apache.org/jira/browse/OAK-3687 Project: Jackrabbit Oak Issue Type: New Feature Components: examples Reporter: Chetan Mehrotra Assignee: Chetan Mehrotra Fix For: 1.4 Similar to webapp based example being provided in OAK-3185 it would be good to have an example application which demonstrates using and configuring Oak in an standalone application. The example would be based on [Spring Boot|http://projects.spring.io/spring-boot/] and would provide a standalone runnable jar like in oak-run but with full Oak stack (backed by oak-pojosr) This would enabled developers to understand how best to configure and use Oak in there application. Objectives # Executable jar allowing one to choose between Segment/Mongo/RDB # Expose the repository for various remote access like via webdav # Integrated with Felix WebConsole to enable introspection of runtime state -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OAK-3688) Provide and use a default set of bundle filters
Chetan Mehrotra created OAK-3688: Summary: Provide and use a default set of bundle filters Key: OAK-3688 URL: https://issues.apache.org/jira/browse/OAK-3688 Project: Jackrabbit Oak Issue Type: Improvement Components: pojosr Reporter: Chetan Mehrotra Assignee: Chetan Mehrotra Priority: Minor Fix For: 1.3.12 OAK-3194 enabled to control the set of bundles which need to be started while running Oak. Given that a basic default set of bundle would always be required it would be good to provide a sensible default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-3689) OakOSGiRepositoryFactory shutting down the repository twice
[ https://issues.apache.org/jira/browse/OAK-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-3689: - Summary: OakOSGiRepositoryFactory shutting down the repository twice (was: OakOSGiRepositoryFactort shutting down the repository twice) > OakOSGiRepositoryFactory shutting down the repository twice > --- > > Key: OAK-3689 > URL: https://issues.apache.org/jira/browse/OAK-3689 > Project: Jackrabbit Oak > Issue Type: Bug > Components: pojosr >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.3.12 > > > With OAK-3375 the repository instance would be shutdown by the > RepositoryManager itself. Currently OakOSGiRepositoryFactory also invokes the > shutdown method. > As the instance is owned by RepositoryManager it should not be shutdown in > OakOSGiRepositoryFactory -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OAK-3689) OakOSGiRepositoryFactort shutting down the repository twice
Chetan Mehrotra created OAK-3689: Summary: OakOSGiRepositoryFactort shutting down the repository twice Key: OAK-3689 URL: https://issues.apache.org/jira/browse/OAK-3689 Project: Jackrabbit Oak Issue Type: Bug Components: pojosr Reporter: Chetan Mehrotra Assignee: Chetan Mehrotra Priority: Minor Fix For: 1.3.12 With OAK-3375 the repository instance would be shutdown by the RepositoryManager itself. Currently OakOSGiRepositoryFactory also invokes the shutdown method. As the instance is owned by RepositoryManager it should not be shutdown in OakOSGiRepositoryFactory -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-1266) DocumentStore implementation for relational databases
[ https://issues.apache.org/jira/browse/OAK-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-1266: Component/s: (was: mongomk) documentmk > DocumentStore implementation for relational databases > - > > Key: OAK-1266 > URL: https://issues.apache.org/jira/browse/OAK-1266 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: documentmk, rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke > > There should be an alternative DocumentStore implementation that persists to > SQL databases rather than MongoDB. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-3637) Bulk document updates in RDBDocumentStore
[ https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomek Rękawek updated OAK-3637: --- Attachment: OAK-3637.patch > Bulk document updates in RDBDocumentStore > - > > Key: OAK-3637 > URL: https://issues.apache.org/jira/browse/OAK-3637 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Tomek Rękawek > Fix For: 1.4 > > Attachments: OAK-3637.patch > > > Implement the [batch createOrUpdate|OAK-3662] in the RDBDocumentStore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-3637) Bulk document updates in RDBDocumentStore
[ https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomek Rękawek updated OAK-3637: --- Attachment: (was: OAK-3637.patch) > Bulk document updates in RDBDocumentStore > - > > Key: OAK-3637 > URL: https://issues.apache.org/jira/browse/OAK-3637 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Tomek Rękawek > Fix For: 1.4 > > Attachments: OAK-3637.patch > > > Implement the [batch createOrUpdate|OAK-3662] in the RDBDocumentStore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3637) Bulk document updates in RDBDocumentStore
[ https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028383#comment-15028383 ] Tomek Rękawek commented on OAK-3637: [~julian.resc...@gmx.de], could you review the patch? It can't be merged yet (it depends on the OAK-3586 and OAK-3662), but I think we can polish it in the meantime. > Bulk document updates in RDBDocumentStore > - > > Key: OAK-3637 > URL: https://issues.apache.org/jira/browse/OAK-3637 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Tomek Rękawek > Fix For: 1.4 > > Attachments: OAK-3637.patch > > > Implement the [batch createOrUpdate|OAK-3662] in the RDBDocumentStore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OAK-3681) SegmentSizeTest.testAccessControlNodes() fails
Marcel Reutegger created OAK-3681: - Summary: SegmentSizeTest.testAccessControlNodes() fails Key: OAK-3681 URL: https://issues.apache.org/jira/browse/OAK-3681 Project: Jackrabbit Oak Issue Type: Test Components: core, segmentmk Reporter: Marcel Reutegger Assignee: Michael Dürig Priority: Trivial Failed on travis: https://travis-ci.org/apache/jackrabbit-oak/builds/93310633 and also reproduces in my local checkout. The test succeeds when I revert this commit: http://svn.apache.org/r1716472 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-3681) SegmentSizeTest.testAccessControlNodes() fails
[ https://issues.apache.org/jira/browse/OAK-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-3681: -- Environment: Oracle Java 1.8.0_65 > SegmentSizeTest.testAccessControlNodes() fails > -- > > Key: OAK-3681 > URL: https://issues.apache.org/jira/browse/OAK-3681 > Project: Jackrabbit Oak > Issue Type: Test > Components: core, segmentmk > Environment: Oracle Java 1.8.0_65 >Reporter: Marcel Reutegger >Assignee: Michael Dürig >Priority: Trivial > > Failed on travis: https://travis-ci.org/apache/jackrabbit-oak/builds/93310633 > and also reproduces in my local checkout. > The test succeeds when I revert this commit: http://svn.apache.org/r1716472 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-3681) SegmentSizeTest.testAccessControlNodes() and testNodeSize() fail
[ https://issues.apache.org/jira/browse/OAK-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-3681: -- Summary: SegmentSizeTest.testAccessControlNodes() and testNodeSize() fail (was: SegmentSizeTest.testAccessControlNodes() fails) > SegmentSizeTest.testAccessControlNodes() and testNodeSize() fail > > > Key: OAK-3681 > URL: https://issues.apache.org/jira/browse/OAK-3681 > Project: Jackrabbit Oak > Issue Type: Test > Components: core, segmentmk > Environment: Oracle Java 1.8.0_65 >Reporter: Marcel Reutegger >Assignee: Michael Dürig >Priority: Trivial > > Failed on travis: https://travis-ci.org/apache/jackrabbit-oak/builds/93310633 > and also reproduces in my local checkout. > The test succeeds when I revert this commit: http://svn.apache.org/r1716472 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3681) SegmentSizeTest.testAccessControlNodes() and testNodeSize() fail
[ https://issues.apache.org/jira/browse/OAK-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028417#comment-15028417 ] Marcel Reutegger commented on OAK-3681: --- Ignored failing test in trunk: http://svn.apache.org/r1716586 > SegmentSizeTest.testAccessControlNodes() and testNodeSize() fail > > > Key: OAK-3681 > URL: https://issues.apache.org/jira/browse/OAK-3681 > Project: Jackrabbit Oak > Issue Type: Test > Components: core, segmentmk > Environment: Oracle Java 1.8.0_65 >Reporter: Marcel Reutegger >Assignee: Michael Dürig >Priority: Trivial > > Failed on travis: https://travis-ci.org/apache/jackrabbit-oak/builds/93310633 > and also reproduces in my local checkout. > The test succeeds when I revert this commit: http://svn.apache.org/r1716472 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3678) Use stable reverse revision comparator in UpdateUtils.applyChanges()
[ https://issues.apache.org/jira/browse/OAK-3678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028423#comment-15028423 ] Marcel Reutegger commented on OAK-3678: --- Yes, I think this is very low risk and minimize differences between trunk and branches. > Use stable reverse revision comparator in UpdateUtils.applyChanges() > > > Key: OAK-3678 > URL: https://issues.apache.org/jira/browse/OAK-3678 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.3.12 > > > The method currently takes a comparator parameter, but the DocumentNodeStore > requires that a revision map is always sorted reverse. To avoid incorrect > usage of the method, the comparator parameter should be removed and the > implementation always uses the stable reverse revision comparator for a new > TreeMap. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3678) Use stable reverse revision comparator in UpdateUtils.applyChanges()
[ https://issues.apache.org/jira/browse/OAK-3678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028432#comment-15028432 ] Julian Reschke commented on OAK-3678: - OK, I'll do that. > Use stable reverse revision comparator in UpdateUtils.applyChanges() > > > Key: OAK-3678 > URL: https://issues.apache.org/jira/browse/OAK-3678 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.3.12 > > > The method currently takes a comparator parameter, but the DocumentNodeStore > requires that a revision map is always sorted reverse. To avoid incorrect > usage of the method, the comparator parameter should be removed and the > implementation always uses the stable reverse revision comparator for a new > TreeMap. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OAK-3407) Configuration to pass suggestion fields through analyzer
[
https://issues.apache.org/jira/browse/OAK-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tommaso Teofili resolved OAK-3407.
--
Resolution: Fixed
fixed in r1716588
> Configuration to pass suggestion fields through analyzer
>
>
> Key: OAK-3407
> URL: https://issues.apache.org/jira/browse/OAK-3407
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Tommaso Teofili
>Priority: Minor
> Fix For: 1.3.12
>
> Attachments: OAK-3407.0.patch
>
>
> Currently, suggested phrases are fairly long. e.g. form {{SuggestTest}} with
> nodes containing {{in 2015 my fox is red, like mike's fox and john's fox}}
> and {{in 2015 a red fox is still a fox}} a suggest query for {{in 201}} the
> result would contain 2 suggestions (both the phrase independently).
> We should probably allow passing suggestion field thorough analyzer so that
> word level suggestions are possible. Moreover, that would also for suggestion
> to be available from middle of phrases e.g. suggestions for {{ite}} should
> give suggestion as {{item}} which, in turn, can search documents containing
> {{this is the most important item in the whole agenda}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OAK-3682) Missing lucene-memory dependency in OSGi env breaks excerpt
Tommaso Teofili created OAK-3682: Summary: Missing lucene-memory dependency in OSGi env breaks excerpt Key: OAK-3682 URL: https://issues.apache.org/jira/browse/OAK-3682 Project: Jackrabbit Oak Issue Type: Bug Components: lucene Affects Versions: 1.3.11 Reporter: Tommaso Teofili Assignee: Tommaso Teofili Fix For: 1.3.12 Since _lucene-highlighter_ depends on _lucene-memory_ but the latter was not added as an explicit dependency in OAK-3580, excerpt support based on Lucene index breaks when Oak is executed in OSGi environments. To fix it _lucene-memory_ dependency should be explicitly added to the pom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-3682) Missing lucene-memory dependency in OSGi env breaks excerpt
[ https://issues.apache.org/jira/browse/OAK-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili updated OAK-3682: - Affects Version/s: 1.0.24 1.2.8 > Missing lucene-memory dependency in OSGi env breaks excerpt > --- > > Key: OAK-3682 > URL: https://issues.apache.org/jira/browse/OAK-3682 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Affects Versions: 1.3.11, 1.2.8, 1.0.24 >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili > Fix For: 1.3.12 > > > Since _lucene-highlighter_ depends on _lucene-memory_ but the latter was not > added as an explicit dependency in OAK-3580, excerpt support based on Lucene > index breaks when Oak is executed in OSGi environments. > To fix it _lucene-memory_ dependency should be explicitly added to the pom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OAK-3682) Missing lucene-memory dependency in OSGi env breaks excerpt
[ https://issues.apache.org/jira/browse/OAK-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili resolved OAK-3682. -- Resolution: Fixed Fix Version/s: 1.0.25 1.2.9 fixed in r1716595, 1716597, 1716598 > Missing lucene-memory dependency in OSGi env breaks excerpt > --- > > Key: OAK-3682 > URL: https://issues.apache.org/jira/browse/OAK-3682 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Affects Versions: 1.3.11, 1.2.8, 1.0.24 >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili > Fix For: 1.2.9, 1.0.25, 1.3.12 > > > Since _lucene-highlighter_ depends on _lucene-memory_ but the latter was not > added as an explicit dependency in OAK-3580, excerpt support based on Lucene > index breaks when Oak is executed in OSGi environments. > To fix it _lucene-memory_ dependency should be explicitly added to the pom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (OAK-3659) Stale document in RDBDocumentStore cache
[ https://issues.apache.org/jira/browse/OAK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-3659: Comment: was deleted (was: After tuning the test (expectations and diagnostics) it seems that a failed findAndUpdate will cause the cached entry to go back in time.) > Stale document in RDBDocumentStore cache > > > Key: OAK-3659 > URL: https://issues.apache.org/jira/browse/OAK-3659 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Affects Versions: 1.2.7, 1.3.10, 1.0.23 >Reporter: Julian Reschke >Assignee: Julian Reschke > Attachments: RDBCacheConsistencyIT.java > > > The problem described in OAK-3103 applies to the RDBDocumentStore as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3659) Stale document in RDBDocumentStore cache
[ https://issues.apache.org/jira/browse/OAK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028506#comment-15028506 ] Julian Reschke commented on OAK-3659: - The problem is indeed identical to the one described in OAK-3103 for MongoDocumentStore, and the fix will be to apply a similar change to the caching logic. Testing this right now. Another benefit will be that we'll have less caching-related code differences between RDBDocumentStore and MongoDocumentStore, which will make the cache refactoring less painful. > Stale document in RDBDocumentStore cache > > > Key: OAK-3659 > URL: https://issues.apache.org/jira/browse/OAK-3659 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Affects Versions: 1.2.7, 1.3.10, 1.0.23 >Reporter: Julian Reschke >Assignee: Julian Reschke > Attachments: RDBCacheConsistencyIT.java > > > The problem described in OAK-3103 applies to the RDBDocumentStore as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3672) SegmentDiscoveryLiteService does not persist clusterView.id
[
https://issues.apache.org/jira/browse/OAK-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028544#comment-15028544
]
Stefan Egli commented on OAK-3672:
--
related to OAK-3529 to some extend (there it's an instance id though, here it's
a cluster id)
> SegmentDiscoveryLiteService does not persist clusterView.id
> ---
>
> Key: OAK-3672
> URL: https://issues.apache.org/jira/browse/OAK-3672
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segmentmk
>Affects Versions: 1.3.10
>Reporter: Stefan Egli
> Fix For: 1.4
>
>
> The discovery-lite-descriptor introduced with OAK-2844 has a property {{id}}
> that uniquely and persistently identifies a cluster. However, the
> {{SegmentDiscoveryLiteService}} creates this id upon each instance restart
> (by setting {{runtimeClusterId}}).
> This should be fixed to have this {{id}} persisted somehow.
> Note that the consequences of this id changing upon each restart is that the
> corresponding presumed-to-be-persistent {{ClusterView.id}} of the
> discovery.oak will also change upon restart. Which is a violation of the
> discovery API and upper level applications might thus misbehave in this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3649) Extract node document cache from Mongo and RDB document stores
[ https://issues.apache.org/jira/browse/OAK-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028543#comment-15028543 ] Tomek Rękawek commented on OAK-3649: [~reschke], thanks for the comment. Indeed, it shouldn't be the developer responsibility to remember whether a method requires a lock or not - it should be somehow enforced. Locks are reentrant, so maybe we can just acquire a lock every time there's a destructive or complex operation which should be performed atomically? In the following branch I pass the NodeDocumentLocks to the NodeDocumentCache, so now all cache operations are thread-safe. If the DocumentStore needs synchronize a bigger part of code, it can use the same reentrant lock stripe. The side effect is that TreeLock has been re-introduced again into the RDBDocumentStore, but only the acquire() method is used, so it behaves like a normal lock stripe. I hope you don't mind this. Branch: https://github.com/trekawek/jackrabbit-oak/tree/OAK-3649-thread-safe Updated patch: https://github.com/trekawek/jackrabbit-oak/pull/3.diff Let me know what do you think. > Extract node document cache from Mongo and RDB document stores > -- > > Key: OAK-3649 > URL: https://issues.apache.org/jira/browse/OAK-3649 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk, mongomk, rdbmk >Reporter: Tomek Rękawek >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.3.12 > > > MongoDocumentStore and RDBDocumentStore contains copy & pasted methods > responsible for handling node document cache. Extract these into a new > NodeDocumentCache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OAK-3672) SegmentDiscoveryLiteService does not persist clusterView.id
[
https://issues.apache.org/jira/browse/OAK-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028544#comment-15028544
]
Stefan Egli edited comment on OAK-3672 at 11/26/15 10:54 AM:
-
related to OAK-3529 to some extend (there it's an instance id, here it's a
cluster id - for a single-instance case, so we could use OAK-3529's id perhaps)
was (Author: egli):
related to OAK-3529 to some extend (there it's an instance id though, here it's
a cluster id)
> SegmentDiscoveryLiteService does not persist clusterView.id
> ---
>
> Key: OAK-3672
> URL: https://issues.apache.org/jira/browse/OAK-3672
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segmentmk
>Affects Versions: 1.3.10
>Reporter: Stefan Egli
> Fix For: 1.4
>
>
> The discovery-lite-descriptor introduced with OAK-2844 has a property {{id}}
> that uniquely and persistently identifies a cluster. However, the
> {{SegmentDiscoveryLiteService}} creates this id upon each instance restart
> (by setting {{runtimeClusterId}}).
> This should be fixed to have this {{id}} persisted somehow.
> Note that the consequences of this id changing upon each restart is that the
> corresponding presumed-to-be-persistent {{ClusterView.id}} of the
> discovery.oak will also change upon restart. Which is a violation of the
> discovery API and upper level applications might thus misbehave in this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3672) SegmentDiscoveryLiteService does not persist clusterView.id
[
https://issues.apache.org/jira/browse/OAK-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028548#comment-15028548
]
Stefan Egli commented on OAK-3672:
--
see [discussion on list|http://oak.markmail.org/thread/r4o3evykrlafeimk]
> SegmentDiscoveryLiteService does not persist clusterView.id
> ---
>
> Key: OAK-3672
> URL: https://issues.apache.org/jira/browse/OAK-3672
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segmentmk
>Affects Versions: 1.3.10
>Reporter: Stefan Egli
> Fix For: 1.4
>
>
> The discovery-lite-descriptor introduced with OAK-2844 has a property {{id}}
> that uniquely and persistently identifies a cluster. However, the
> {{SegmentDiscoveryLiteService}} creates this id upon each instance restart
> (by setting {{runtimeClusterId}}).
> This should be fixed to have this {{id}} persisted somehow.
> Note that the consequences of this id changing upon each restart is that the
> corresponding presumed-to-be-persistent {{ClusterView.id}} of the
> discovery.oak will also change upon restart. Which is a violation of the
> discovery API and upper level applications might thus misbehave in this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3649) Extract node document cache from Mongo and RDB document stores
[ https://issues.apache.org/jira/browse/OAK-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028555#comment-15028555 ] Julian Reschke commented on OAK-3649: - I think we absolutely should avoid carrying over the TreeLocks into the RDBDocumentStore. I believe the plan is to get rid of them in MongoDocumentStore anyway. > Extract node document cache from Mongo and RDB document stores > -- > > Key: OAK-3649 > URL: https://issues.apache.org/jira/browse/OAK-3649 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk, mongomk, rdbmk >Reporter: Tomek Rękawek >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.3.12 > > > MongoDocumentStore and RDBDocumentStore contains copy & pasted methods > responsible for handling node document cache. Extract these into a new > NodeDocumentCache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OAK-3683) BasicDocumentStore.testInterestingStrings failure on MongoDB after OAK-3651
Robert Munteanu created OAK-3683:
Summary: BasicDocumentStore.testInterestingStrings failure on
MongoDB after OAK-3651
Key: OAK-3683
URL: https://issues.apache.org/jira/browse/OAK-3683
Project: Jackrabbit Oak
Issue Type: Bug
Components: mongomk
Affects Versions: 1.4
Environment: MongoDB 2.6.9, MonoDB 3.0.2
Reporter: Robert Munteanu
{noformat}Failed tests: testInterestingStrings[MongoFixture:
MongoDB](org.apache.jackrabbit.oak.plugins.document.BasicDocumentStoreTest):
failure to round-trip brokensurrogate through MongoDB expected:<[?]> but
was:<[�]>{noformat}
According to git bisect the commit which started showing this error was
[r1715092|http://svn.apache.org/viewvc?view=revision=r1715092]:
OAK-3651 - Remove HierrachialCacheInvalidator
The command I used to run the tests was {{mvn -am -pl oak-core clean package
-Dtest=BasicDocumentStoreTest -DfailIfNoTests=false}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-3683) BasicDocumentStore.testInterestingStrings failure on MongoDB after OAK-3651 with Java 8
[
https://issues.apache.org/jira/browse/OAK-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated OAK-3683:
-
Environment:
MongoDB 2.6.9, MonoDB 3.0.2
Java 8
was:MongoDB 2.6.9, MonoDB 3.0.2
> BasicDocumentStore.testInterestingStrings failure on MongoDB after OAK-3651
> with Java 8
> ---
>
> Key: OAK-3683
> URL: https://issues.apache.org/jira/browse/OAK-3683
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Affects Versions: 1.4
> Environment: MongoDB 2.6.9, MonoDB 3.0.2
> Java 8
>Reporter: Robert Munteanu
>
> {noformat}Failed tests: testInterestingStrings[MongoFixture:
> MongoDB](org.apache.jackrabbit.oak.plugins.document.BasicDocumentStoreTest):
> failure to round-trip brokensurrogate through MongoDB expected:<[?]> but
> was:<[�]>{noformat}
> According to git bisect the commit which started showing this error was
> [r1715092|http://svn.apache.org/viewvc?view=revision=r1715092]:
> OAK-3651 - Remove HierrachialCacheInvalidator
> The command I used to run the tests was {{mvn -am -pl oak-core clean package
> -Dtest=BasicDocumentStoreTest -DfailIfNoTests=false}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-3683) BasicDocumentStore.testInterestingStrings failure on MongoDB after OAK-3651 with Java 8
[
https://issues.apache.org/jira/browse/OAK-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated OAK-3683:
-
Summary: BasicDocumentStore.testInterestingStrings failure on MongoDB after
OAK-3651 with Java 8 (was: BasicDocumentStore.testInterestingStrings failure
on MongoDB after OAK-3651)
> BasicDocumentStore.testInterestingStrings failure on MongoDB after OAK-3651
> with Java 8
> ---
>
> Key: OAK-3683
> URL: https://issues.apache.org/jira/browse/OAK-3683
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Affects Versions: 1.4
> Environment: MongoDB 2.6.9, MonoDB 3.0.2
>Reporter: Robert Munteanu
>
> {noformat}Failed tests: testInterestingStrings[MongoFixture:
> MongoDB](org.apache.jackrabbit.oak.plugins.document.BasicDocumentStoreTest):
> failure to round-trip brokensurrogate through MongoDB expected:<[?]> but
> was:<[�]>{noformat}
> According to git bisect the commit which started showing this error was
> [r1715092|http://svn.apache.org/viewvc?view=revision=r1715092]:
> OAK-3651 - Remove HierrachialCacheInvalidator
> The command I used to run the tests was {{mvn -am -pl oak-core clean package
> -Dtest=BasicDocumentStoreTest -DfailIfNoTests=false}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-3683) BasicDocumentStore.testInterestingStrings failure on MongoDB after OAK-3651 with Java 8
[
https://issues.apache.org/jira/browse/OAK-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated OAK-3683:
-
Description:
On Java 8 only the following test fails:
{noformat}Failed tests: testInterestingStrings[MongoFixture:
MongoDB](org.apache.jackrabbit.oak.plugins.document.BasicDocumentStoreTest):
failure to round-trip brokensurrogate through MongoDB expected:<[?]> but
was:<[�]>{noformat}
According to git bisect the commit which started showing this error was
[r1715092|http://svn.apache.org/viewvc?view=revision=r1715092]:
OAK-3651 - Remove HierrachialCacheInvalidator
The command I used to run the tests was {{mvn -am -pl oak-core clean package
-Dtest=BasicDocumentStoreTest -DfailIfNoTests=false}}
was:
{noformat}Failed tests: testInterestingStrings[MongoFixture:
MongoDB](org.apache.jackrabbit.oak.plugins.document.BasicDocumentStoreTest):
failure to round-trip brokensurrogate through MongoDB expected:<[?]> but
was:<[�]>{noformat}
According to git bisect the commit which started showing this error was
[r1715092|http://svn.apache.org/viewvc?view=revision=r1715092]:
OAK-3651 - Remove HierrachialCacheInvalidator
The command I used to run the tests was {{mvn -am -pl oak-core clean package
-Dtest=BasicDocumentStoreTest -DfailIfNoTests=false}}
> BasicDocumentStore.testInterestingStrings failure on MongoDB after OAK-3651
> with Java 8
> ---
>
> Key: OAK-3683
> URL: https://issues.apache.org/jira/browse/OAK-3683
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Affects Versions: 1.4
> Environment: MongoDB 2.6.9, MonoDB 3.0.2
> Java 8
>Reporter: Robert Munteanu
>
> On Java 8 only the following test fails:
> {noformat}Failed tests: testInterestingStrings[MongoFixture:
> MongoDB](org.apache.jackrabbit.oak.plugins.document.BasicDocumentStoreTest):
> failure to round-trip brokensurrogate through MongoDB expected:<[?]> but
> was:<[�]>{noformat}
> According to git bisect the commit which started showing this error was
> [r1715092|http://svn.apache.org/viewvc?view=revision=r1715092]:
> OAK-3651 - Remove HierrachialCacheInvalidator
> The command I used to run the tests was {{mvn -am -pl oak-core clean package
> -Dtest=BasicDocumentStoreTest -DfailIfNoTests=false}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3683) BasicDocumentStore.testInterestingStrings failure on MongoDB after OAK-3651 with Java 8
[
https://issues.apache.org/jira/browse/OAK-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028590#comment-15028590
]
Chetan Mehrotra commented on OAK-3683:
--
Fails for me now also on Mongo 2.6.5 on JDK 8. Passes on JDK 7. So looks like
JDK specific issue
> BasicDocumentStore.testInterestingStrings failure on MongoDB after OAK-3651
> with Java 8
> ---
>
> Key: OAK-3683
> URL: https://issues.apache.org/jira/browse/OAK-3683
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Affects Versions: 1.4
> Environment: MongoDB 2.6.9, MonoDB 3.0.2
> Java 8
>Reporter: Robert Munteanu
>
> On Java 8 only the following test fails:
> {noformat}Failed tests: testInterestingStrings[MongoFixture:
> MongoDB](org.apache.jackrabbit.oak.plugins.document.BasicDocumentStoreTest):
> failure to round-trip brokensurrogate through MongoDB expected:<[?]> but
> was:<[�]>{noformat}
> According to git bisect the commit which started showing this error was
> [r1715092|http://svn.apache.org/viewvc?view=revision=r1715092]:
> OAK-3651 - Remove HierrachialCacheInvalidator
> The command I used to run the tests was {{mvn -am -pl oak-core clean package
> -Dtest=BasicDocumentStoreTest -DfailIfNoTests=false}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OAK-3683) BasicDocumentStore.testInterestingStrings failure on MongoDB after OAK-3651 with Java 8
[
https://issues.apache.org/jira/browse/OAK-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028590#comment-15028590
]
Chetan Mehrotra edited comment on OAK-3683 at 11/26/15 11:29 AM:
-
Fails for me now also on Mongo 2.6.5 on JDK 8. Passes on JDK 7. So looks like
JDK specific issue. But fails only for Mongo and passes for H2 and Memory
was (Author: chetanm):
Fails for me now also on Mongo 2.6.5 on JDK 8. Passes on JDK 7. So looks like
JDK specific issue
> BasicDocumentStore.testInterestingStrings failure on MongoDB after OAK-3651
> with Java 8
> ---
>
> Key: OAK-3683
> URL: https://issues.apache.org/jira/browse/OAK-3683
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Affects Versions: 1.4
> Environment: MongoDB 2.6.9, MonoDB 3.0.2
> Java 8
>Reporter: Robert Munteanu
>
> On Java 8 only the following test fails:
> {noformat}Failed tests: testInterestingStrings[MongoFixture:
> MongoDB](org.apache.jackrabbit.oak.plugins.document.BasicDocumentStoreTest):
> failure to round-trip brokensurrogate through MongoDB expected:<[?]> but
> was:<[�]>{noformat}
> According to git bisect the commit which started showing this error was
> [r1715092|http://svn.apache.org/viewvc?view=revision=r1715092]:
> OAK-3651 - Remove HierrachialCacheInvalidator
> The command I used to run the tests was {{mvn -am -pl oak-core clean package
> -Dtest=BasicDocumentStoreTest -DfailIfNoTests=false}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3649) Extract node document cache from Mongo and RDB document stores
[ https://issues.apache.org/jira/browse/OAK-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028604#comment-15028604 ] Tomek Rękawek commented on OAK-3649: Fair enough. I updated the branch above. Now it contains two implementations of the NodeDocumentLocks. The one used by the RDBDocumentStore is backed by a simple striped locks map. > Extract node document cache from Mongo and RDB document stores > -- > > Key: OAK-3649 > URL: https://issues.apache.org/jira/browse/OAK-3649 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk, mongomk, rdbmk >Reporter: Tomek Rękawek >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.3.12 > > > MongoDocumentStore and RDBDocumentStore contains copy & pasted methods > responsible for handling node document cache. Extract these into a new > NodeDocumentCache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-3683) BasicDocumentStore.testInterestingStrings failure on MongoDB after OAK-3651 with Java 8
[
https://issues.apache.org/jira/browse/OAK-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-3683:
Environment:
MongoDB 2.6.9, MongoDB 3.0.2
Java 8
was:
MongoDB 2.6.9, MonoDB 3.0.2
Java 8
> BasicDocumentStore.testInterestingStrings failure on MongoDB after OAK-3651
> with Java 8
> ---
>
> Key: OAK-3683
> URL: https://issues.apache.org/jira/browse/OAK-3683
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Affects Versions: 1.4
> Environment: MongoDB 2.6.9, MongoDB 3.0.2
> Java 8
>Reporter: Robert Munteanu
>
> On Java 8 only the following test fails:
> {noformat}Failed tests: testInterestingStrings[MongoFixture:
> MongoDB](org.apache.jackrabbit.oak.plugins.document.BasicDocumentStoreTest):
> failure to round-trip brokensurrogate through MongoDB expected:<[?]> but
> was:<[�]>{noformat}
> According to git bisect the commit which started showing this error was
> [r1715092|http://svn.apache.org/viewvc?view=revision=r1715092]:
> OAK-3651 - Remove HierrachialCacheInvalidator
> The command I used to run the tests was {{mvn -am -pl oak-core clean package
> -Dtest=BasicDocumentStoreTest -DfailIfNoTests=false}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-3678) Use stable reverse revision comparator in UpdateUtils.applyChanges()
[ https://issues.apache.org/jira/browse/OAK-3678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-3678: Fix Version/s: 1.0.25 1.2.9 > Use stable reverse revision comparator in UpdateUtils.applyChanges() > > > Key: OAK-3678 > URL: https://issues.apache.org/jira/browse/OAK-3678 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.2.9, 1.0.25, 1.3.12 > > > The method currently takes a comparator parameter, but the DocumentNodeStore > requires that a revision map is always sorted reverse. To avoid incorrect > usage of the method, the comparator parameter should be removed and the > implementation always uses the stable reverse revision comparator for a new > TreeMap. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3678) Use stable reverse revision comparator in UpdateUtils.applyChanges()
[ https://issues.apache.org/jira/browse/OAK-3678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028651#comment-15028651 ] Julian Reschke commented on OAK-3678: - 1.2: http://svn.apache.org/r1716600 1.0: http://svn.apache.org/r1716614 > Use stable reverse revision comparator in UpdateUtils.applyChanges() > > > Key: OAK-3678 > URL: https://issues.apache.org/jira/browse/OAK-3678 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.2.9, 1.0.25, 1.3.12 > > > The method currently takes a comparator parameter, but the DocumentNodeStore > requires that a revision map is always sorted reverse. To avoid incorrect > usage of the method, the comparator parameter should be removed and the > implementation always uses the stable reverse revision comparator for a new > TreeMap. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-3659) Stale document in RDBDocumentStore cache
[ https://issues.apache.org/jira/browse/OAK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-3659: Fix Version/s: 1.3.12 > Stale document in RDBDocumentStore cache > > > Key: OAK-3659 > URL: https://issues.apache.org/jira/browse/OAK-3659 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Affects Versions: 1.2.7, 1.3.10, 1.0.23 >Reporter: Julian Reschke >Assignee: Julian Reschke > Fix For: 1.3.12 > > Attachments: RDBCacheConsistencyIT.java > > > The problem described in OAK-3103 applies to the RDBDocumentStore as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3646) Inconsistent read of hierarchy
[ https://issues.apache.org/jira/browse/OAK-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028698#comment-15028698 ] Marcel Reutegger commented on OAK-3646: --- The name RevisionVector is inspired by [Version Vectors|https://en.wikipedia.org/wiki/Version_vector]. A revision vector works very similar to a version vector. The third update rule is a bit different with revision vectors, because a revision is bound to the local clock. In Oak the third rule is implemented by OAK-3388 where the background read waits until the local clock is passed the most recent reported external _lastRev and the timestamp of the new head revision is therefore newer than the timestamps of the most recent visible external revisions. > Inconsistent read of hierarchy > --- > > Key: OAK-3646 > URL: https://issues.apache.org/jira/browse/OAK-3646 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk >Affects Versions: 1.0, 1.2 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger > Fix For: 1.4 > > > This is similar to OAK-3388, but about hierarchy information like which child > nodes exist at a given revision of the parent node. This issue only occurs in > a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-3659) Stale document in RDBDocumentStore cache
[ https://issues.apache.org/jira/browse/OAK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-3659: Fix Version/s: 1.2.9 > Stale document in RDBDocumentStore cache > > > Key: OAK-3659 > URL: https://issues.apache.org/jira/browse/OAK-3659 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Affects Versions: 1.2.7, 1.3.10, 1.0.23 >Reporter: Julian Reschke >Assignee: Julian Reschke > Fix For: 1.2.9, 1.3.12 > > Attachments: RDBCacheConsistencyIT.java > > > The problem described in OAK-3103 applies to the RDBDocumentStore as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OAK-1940) memory cache for RDB persistence
[ https://issues.apache.org/jira/browse/OAK-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-1940. - Resolution: Fixed In the meantime, the RDBDocumentStore *does* contain a memory cache. OAK-3649 is about refactoring the code so that more is shared between MongoDocumentStore and RDBDocumentStore. > memory cache for RDB persistence > > > Key: OAK-1940 > URL: https://issues.apache.org/jira/browse/OAK-1940 > Project: Jackrabbit Oak > Issue Type: Sub-task > Components: core >Reporter: Julian Reschke >Assignee: Julian Reschke > Fix For: 1.4 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3623) backport DocumentStore time diff API back
[ https://issues.apache.org/jira/browse/OAK-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-3623. - Bulk close for 1.2.8 > backport DocumentStore time diff API back > - > > Key: OAK-3623 > URL: https://issues.apache.org/jira/browse/OAK-3623 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk, mongomk, rdbmk >Affects Versions: 1.2.7, 1.0.23 >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.2.8, 1.0.24 > > > This API was introduced as part of OAK-2682. > Not having it in older branches makes backporting unrelated changes harder; > so just include it without using it (yet). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3608) Compare of node states on branch may be incorrect
[ https://issues.apache.org/jira/browse/OAK-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-3608. - Bulk close for 1.2.8 > Compare of node states on branch may be incorrect > - > > Key: OAK-3608 > URL: https://issues.apache.org/jira/browse/OAK-3608 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk >Affects Versions: 1.0, 1.2 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.3.11, 1.2.8, 1.0.24 > > > In some cases comparing a branch node state with its base state does not > report all changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3604) RDBDocumentStore: update JDBC drivers for PostgresQL, MySQL, and Derby
[ https://issues.apache.org/jira/browse/OAK-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-3604. - Bulk close for 1.2.8 > RDBDocumentStore: update JDBC drivers for PostgresQL, MySQL, and Derby > -- > > Key: OAK-3604 > URL: https://issues.apache.org/jira/browse/OAK-3604 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Affects Versions: 1.2.7, 1.3.10, 1.0.23 >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Fix For: 1.3.11, 1.2.8, 1.0.24 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3421) RDBDocumentStore: force DB2 to use a clustered index
[ https://issues.apache.org/jira/browse/OAK-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-3421. - Bulk close for 1.2.8 > RDBDocumentStore: force DB2 to use a clustered index > > > Key: OAK-3421 > URL: https://issues.apache.org/jira/browse/OAK-3421 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Affects Versions: 1.2.7, 1.3.10, 1.0.23 >Reporter: Julian Reschke >Assignee: Julian Reschke > Fix For: 1.3.11, 1.2.8, 1.0.24 > > Attachments: OAK-3421.diff, RDBLastRevRecoveryPerfTest.java > > > DB2 by default does not create a clustered index; consider to force it to do > so. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3617) RDBDocumentStore: improve retry logic in updateDocument
[ https://issues.apache.org/jira/browse/OAK-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-3617. - Bulk close for 1.2.8 > RDBDocumentStore: improve retry logic in updateDocument > --- > > Key: OAK-3617 > URL: https://issues.apache.org/jira/browse/OAK-3617 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Affects Versions: 1.3.9, 1.2.7, 1.0.23 >Reporter: Julian Reschke >Assignee: Julian Reschke > Fix For: 1.3.11, 1.2.8, 1.0.24 > > Attachments: OAK-3617.diff > > > updateDocument currently attempts to update the document using a String > append operation, and if that fails it will retry with a full rewrite. > However, these operations may be conditional on the previous value of > MODCOUNT. If this is the case, and the append did not fail with an > SQLException, we know that a full rewrite isn't going to work either, thus we > can skip the attempt (thus, the outer retry logic will need to refetch the > document from storage before retrying). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3571) baseline failures on 1.2
[
https://issues.apache.org/jira/browse/OAK-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella closed OAK-3571.
-
Bulk close for 1.2.8
> baseline failures on 1.2
>
>
> Key: OAK-3571
> URL: https://issues.apache.org/jira/browse/OAK-3571
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Reporter: Davide Giannella
>Assignee: Davide Giannella
>Priority: Blocker
> Fix For: 1.2.8
>
> Attachments: build-1446195885.log.gz
>
>
> Running a full build with ITs fails on 1.2 branch for the baseline plugin
> {noformat}
> [ERROR] org.apache.jackrabbit.oak.api.jmx: Version increase required;
> detected 1.0.0, suggested 2.0.0
> [ERROR] org.apache.jackrabbit.oak.plugins.index: Version increase required;
> detected 1.0.0, suggested 2.0.0
> {noformat}
> [Full build logs|^build-1446195885.log.gz]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3633) Enable exclusion of relative property in aggregation
[
https://issues.apache.org/jira/browse/OAK-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella closed OAK-3633.
-
Bulk close for 1.2.8
> Enable exclusion of relative property in aggregation
>
>
> Key: OAK-3633
> URL: https://issues.apache.org/jira/browse/OAK-3633
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: 1.3.11, 1.2.8, 1.0.24
>
>
> If a Lucene index has aggregation rule defined covering any child node then
> currently its not possible to exclude any relative property from getting
> indexed.
> {noformat}
> + aggregates
> + nt:file
> + include0
> - path = "jcr:content"
> + oak:TestNode
> + include0
>- path = '*'
> + indexRules
> + oak:TestNode
> + properties
> + prop1
> - name = 'original/jcr:content/type'
> - index = false
> {noformat}
> For above index definition and below content
> {noformat}
> /testnode/a (oak:TestNode)
> + original (nt:file)
> + jcr:content
> - jcr:data = <>
> - type = "image"
> {noformat}
> 'original/jcr:content/type' property should not be include in fulltext index
> for /test/a via aggregation
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3631) RDBDocumentStore: improve logging for server time difference detection
[ https://issues.apache.org/jira/browse/OAK-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-3631. - Bulk close for 1.2.8 > RDBDocumentStore: improve logging for server time difference detection > -- > > Key: OAK-3631 > URL: https://issues.apache.org/jira/browse/OAK-3631 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Affects Versions: 1.2.7, 1.3.10, 1.0.23 >Reporter: Julian Reschke >Assignee: Julian Reschke > Fix For: 1.3.11, 1.2.8, 1.0.24 > > > Currently, when the caller decides that the reported time difference to the > server is too big to ignore, it's non-trivial to find the exact reason. Thus > add DEBUG/INFO level logging of the timestamps being compared (where the log > severity depends on the measured difference). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3605) RDBBlob/DocumentStore: reduce class complexity
[ https://issues.apache.org/jira/browse/OAK-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-3605. - Bulk close for 1.2.8 > RDBBlob/DocumentStore: reduce class complexity > -- > > Key: OAK-3605 > URL: https://issues.apache.org/jira/browse/OAK-3605 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Affects Versions: 1.2.7, 1.3.10, 1.0.23 >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.3.11, 1.2.8, 1.0.24 > > > - RDBConnectionHandler: move methods unrelated to connection handling > elsewhere > - RDBBlob/DocumentStore: extract low-level JDBC related code into separate > classes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3640) SolrIndexQueryTestIT failure on 1.2
[
https://issues.apache.org/jira/browse/OAK-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella closed OAK-3640.
-
Bulk close for 1.2.8
> SolrIndexQueryTestIT failure on 1.2
> ---
>
> Key: OAK-3640
> URL: https://issues.apache.org/jira/browse/OAK-3640
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Davide Giannella
>Assignee: Tommaso Teofili
>Priority: Blocker
> Fix For: 1.2.8
>
> Attachments: build-1447671223.log
>
>
> The build is failing with
> {noformat}
> Tests in error:
>
> sql1(org.apache.jackrabbit.oak.plugins.index.solr.query.SolrIndexQueryTestIT):
> Results in target/sql1.txt don't match expected results in
> src/test/resources/sql1.txt; compare the files for details
> {noformat}
> [build logs|^build-1447671223.log].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3092) Cache recently extracted text to avoid duplicate extraction
[
https://issues.apache.org/jira/browse/OAK-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella closed OAK-3092.
-
Bulk close for 1.2.8
> Cache recently extracted text to avoid duplicate extraction
> ---
>
> Key: OAK-3092
> URL: https://issues.apache.org/jira/browse/OAK-3092
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Labels: performance
> Fix For: 1.3.11, 1.2.8, 1.0.24
>
> Attachments: OAK-3092-v1.patch, OAK-3092-v2.patch
>
>
> It can happen that text can be extracted from same binary multiple times in a
> given indexing cycle. This can happen due to 2 reasons
> # Multiple Lucene indexes indexing same node - A system might have multiple
> Lucene indexes e.g. a global Lucene index and an index for specific nodeType.
> In a given indexing cycle same file would be picked up by both index
> definition and both would extract same text
> # Aggregation - With Index time aggregation same file get picked up multiple
> times due to aggregation rules
> To avoid the wasted effort for duplicate text extraction from same file in a
> given indexing cycle it would be better to have an expiring cache which can
> hold on to extracted text content for some time. The cache should have
> following features
> # Limit on total size
> # Way to expire the content using [Timed
> Evicition|https://code.google.com/p/guava-libraries/wiki/CachesExplained#Timed_Eviction]
> - As chances of same file getting picked up are high only for a given
> indexing cycle it would be better to expire the cache entries after some time
> to avoid hogging memory unnecessarily
> Such a cache would provide following benefit
> # Avoid duplicate text extraction - Text extraction is costly and has to be
> minimized on critical path of {{indexEditor}}
> # Avoid expensive IO specially if binary content are to be fetched from a
> remote {{BlobStore}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3630) Mixin based rules not working for relative properties
[ https://issues.apache.org/jira/browse/OAK-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-3630. - Bulk close for 1.2.8 > Mixin based rules not working for relative properties > - > > Key: OAK-3630 > URL: https://issues.apache.org/jira/browse/OAK-3630 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.3.11, 1.2.8, 1.0.24 > > > If an indexing rule is defined for mixin then it does not work as expected > for relative properties. > Issue here being that most of logic in Aggregate class (which is used for > relative property handling also) relies on nodes primaryType and does not > account for mixin type -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3591) Lucene index with 'analyzed=true' sometimes used by mistake
[
https://issues.apache.org/jira/browse/OAK-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella closed OAK-3591.
-
Bulk close for 1.2.8
> Lucene index with 'analyzed=true' sometimes used by mistake
> ---
>
> Key: OAK-3591
> URL: https://issues.apache.org/jira/browse/OAK-3591
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene, query
>Reporter: Thomas Mueller
>Assignee: Chetan Mehrotra
> Fix For: 1.3.11, 1.2.8, 1.0.24
>
>
> A Lucene index with a property that is configured as "analyzed = true" is
> sometimes used by mistake. Example:
> {noformat}
> oak:index/testLuceneIndex (oak:QueryIndexDefinition)
> compatVersion: 2
> type: lucene
> async: "async"
> indexRules (nt:unstructured)
> nt:base (nt:unstructured)
> properties (nt:unstructured)
> xyz (nt:unstructured)
> propertyIndex: true,
> analyzed: true,
> name: xyz
> query:
> /jcr:root/content//*[jcr:contains(., '1234')]
> {noformat}
> The index is used, but the result does not contain nodes with properties abc
> = '1234'.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3566) Stale documents in RDBDocumentStore cache
[ https://issues.apache.org/jira/browse/OAK-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-3566. - Bulk close for 1.2.8 > Stale documents in RDBDocumentStore cache > - > > Key: OAK-3566 > URL: https://issues.apache.org/jira/browse/OAK-3566 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: core, rdbmk >Affects Versions: 1.0, 1.2 >Reporter: Marcel Reutegger >Assignee: Julian Reschke > Fix For: 1.3.11, 1.2.8, 1.0.24 > > Attachments: OAK-3566-test.patch, OAK-3566.diff, OAK-3566.patch > > > This issue is about the same problem as described in OAK-1897 but for the > RDBDocumentStore implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3580) Make it possible to use indexes for providing excerpts
[
https://issues.apache.org/jira/browse/OAK-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella closed OAK-3580.
-
Bulk close for 1.2.8
> Make it possible to use indexes for providing excerpts
> --
>
> Key: OAK-3580
> URL: https://issues.apache.org/jira/browse/OAK-3580
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene, query, solr
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 1.3.11, 1.2.8, 1.0.24
>
> Attachments: OAK-3580.1.patch
>
>
> Currently {{SimpleExcerptProvider}} always provides excerpt, regardless of
> the underlying index used for the query, this having the limitation of not
> working with binaries.
> Because of that it'd be good to leverage existing indexes capabilities to use
> their highlighter implementations to provide excerpt support, also because
> Lucene and Solr Oak indexes already perform full text extraction from
> binaries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (OAK-3564) Release Oak 1.2.8
[ https://issues.apache.org/jira/browse/OAK-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella resolved OAK-3564. --- Resolution: Fixed > Release Oak 1.2.8 > - > > Key: OAK-3564 > URL: https://issues.apache.org/jira/browse/OAK-3564 > Project: Jackrabbit Oak > Issue Type: Task >Reporter: Davide Giannella >Assignee: Davide Giannella > Fix For: 1.4 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OAK-3638) NodeAggregator in SolrQueryIndexProviderService should be volatile
[
https://issues.apache.org/jira/browse/OAK-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella closed OAK-3638.
-
Bulk close for 1.0.24
> NodeAggregator in SolrQueryIndexProviderService should be volatile
> --
>
> Key: OAK-3638
> URL: https://issues.apache.org/jira/browse/OAK-3638
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: solr
>Affects Versions: 1.3.9
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 1.3.11, 1.0.24, 1.2.9
>
>
> {{NodeAggregator}} reference in {{SolrQueryIndexProviderService}} has
> _DYNAMIC_ policy therefore it should be volatile in order to avoid requiring
> stop/start of the QIP for the updated aggregator to be bound.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3641) testSpellcheckMultipleWords failing on 1.0
[
https://issues.apache.org/jira/browse/OAK-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella closed OAK-3641.
-
Bulk close for 1.0.24
> testSpellcheckMultipleWords failing on 1.0
> --
>
> Key: OAK-3641
> URL: https://issues.apache.org/jira/browse/OAK-3641
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Davide Giannella
>Assignee: Tommaso Teofili
>Priority: Blocker
> Fix For: 1.0.24
>
> Attachments: build-1447672168.log
>
>
> Build failing on 1.0 with the following failures:
> {noformat}
> Failed tests:
> testSpellcheckMultipleWords(org.apache.jackrabbit.oak.jcr.query.SpellcheckTest):
> expected:<[voting in ontario]> but was:<[[voting, voted, ontario]]>
> {noformat}
> [build logs|^build-1447672168.log]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3639) Wrong method name for "updated" reference in SolrServerProviderService
[
https://issues.apache.org/jira/browse/OAK-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella closed OAK-3639.
-
Bulk close for 1.0.24
> Wrong method name for "updated" reference in SolrServerProviderService
> --
>
> Key: OAK-3639
> URL: https://issues.apache.org/jira/browse/OAK-3639
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: solr
>Affects Versions: 1.3.9
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 1.3.11, 1.0.24, 1.2.9
>
>
> {{SolrServerProviderService}} method name for _updated_
> {{SolrServiceConfigurationProvider}} is wrong: it's
> _updateSolrServerConfigurationProvider_ instead of
> _updatedSolrServerConfigurationProvider_ .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OAK-3378) Test failure: SuggestTest
[
https://issues.apache.org/jira/browse/OAK-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella closed OAK-3378.
-
Bulk close for 1.0.24
> Test failure: SuggestTest
> -
>
> Key: OAK-3378
> URL: https://issues.apache.org/jira/browse/OAK-3378
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: solr
>Reporter: Chetan Mehrotra
>Assignee: Tommaso Teofili
> Labels: ci, jenkins
> Fix For: 1.0.24
>
>
> Various testcases in SuggestTest test are failing on *1.0 branch* for past
> few runs 390, 391, 394, 398
> {noformat}
> testSuggestSql(org.apache.jackrabbit.oak.jcr.query.SuggestTest) Time
> elapsed: 7.963 sec <<< FAILURE!
> junit.framework.ComparisonFailure: expected:<[[{term=in 2015 a red fox is
> still a fox,weight=1}, {term=in 2015 my fox is red, like mike's fox and
> john's fox,weight=1}]]> but was:<[]>
> at junit.framework.Assert.assertEquals(Assert.java:85)
> at junit.framework.Assert.assertEquals(Assert.java:91)
> at
> org.apache.jackrabbit.oak.jcr.query.SuggestTest.testSuggestSql(SuggestTest.java:50)
> testSuggestXPath(org.apache.jackrabbit.oak.jcr.query.SuggestTest) Time
> elapsed: 0.149 sec <<< FAILURE!
> junit.framework.ComparisonFailure: expected:<[[{term=in 2015 a red fox is
> still a fox,weight=1}, {term=in 2015 my fox is red, like mike's fox and
> john's fox,weight=1}]]> but was:<[]>
> at junit.framework.Assert.assertEquals(Assert.java:85)
> at junit.framework.Assert.assertEquals(Assert.java:91)
> at
> org.apache.jackrabbit.oak.jcr.query.SuggestTest.testSuggestXPath(SuggestTest.java:67)
>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-3659) Stale document in RDBDocumentStore cache
[ https://issues.apache.org/jira/browse/OAK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-3659: Fix Version/s: 1.0.25 > Stale document in RDBDocumentStore cache > > > Key: OAK-3659 > URL: https://issues.apache.org/jira/browse/OAK-3659 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Affects Versions: 1.2.7, 1.3.10, 1.0.23 >Reporter: Julian Reschke >Assignee: Julian Reschke > Fix For: 1.2.9, 1.0.25, 1.3.12 > > Attachments: RDBCacheConsistencyIT.java > > > The problem described in OAK-3103 applies to the RDBDocumentStore as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OAK-3659) Stale document in RDBDocumentStore cache
[ https://issues.apache.org/jira/browse/OAK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-3659. - Resolution: Fixed trunk: http://svn.apache.org/r1715346 and http://svn.apache.org/r1716616 1.2: http://svn.apache.org/r1716635 1.0: http://svn.apache.org/r1716641 > Stale document in RDBDocumentStore cache > > > Key: OAK-3659 > URL: https://issues.apache.org/jira/browse/OAK-3659 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Affects Versions: 1.2.7, 1.3.10, 1.0.23 >Reporter: Julian Reschke >Assignee: Julian Reschke > Fix For: 1.2.9, 1.0.25, 1.3.12 > > Attachments: RDBCacheConsistencyIT.java > > > The problem described in OAK-3103 applies to the RDBDocumentStore as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OAK-3575) Release Oak 1.0.24
[ https://issues.apache.org/jira/browse/OAK-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella resolved OAK-3575. --- Resolution: Fixed > Release Oak 1.0.24 > -- > > Key: OAK-3575 > URL: https://issues.apache.org/jira/browse/OAK-3575 > Project: Jackrabbit Oak > Issue Type: Task >Reporter: Davide Giannella >Assignee: Davide Giannella > Fix For: 1.4 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3649) Extract node document cache from Mongo and RDB document stores
[ https://issues.apache.org/jira/browse/OAK-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028809#comment-15028809 ] Julian Reschke commented on OAK-3649: - If the method itself gets the lock, it will also release it on exit, right? I don't see how that would work if the caller wanted to synchronize more code... > Extract node document cache from Mongo and RDB document stores > -- > > Key: OAK-3649 > URL: https://issues.apache.org/jira/browse/OAK-3649 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk, mongomk, rdbmk >Reporter: Tomek Rękawek >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.3.12 > > > MongoDocumentStore and RDBDocumentStore contains copy & pasted methods > responsible for handling node document cache. Extract these into a new > NodeDocumentCache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-3436) Prevent missing checkpoint due to unstable topology from causing complete reindexing
[
https://issues.apache.org/jira/browse/OAK-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Marth updated OAK-3436:
---
Labels: resilience (was: )
> Prevent missing checkpoint due to unstable topology from causing complete
> reindexing
>
>
> Key: OAK-3436
> URL: https://issues.apache.org/jira/browse/OAK-3436
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: query
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Labels: resilience
> Fix For: 1.2.9, 1.0.25, 1.3.12
>
> Attachments: AsyncIndexUpdateClusterTest.java, OAK-3436-0.patch
>
>
> Async indexing logic relies on embedding application to ensure that async
> indexing job is run as a singleton in a cluster. For Sling based apps it
> depends on Sling Discovery support. At times it is being seen that if
> topology is not stable then different cluster nodes can consider them as
> leader and execute the async indexing job concurrently.
> This can cause problem as both cluster node might not see same repository
> state (due to write skew and eventual consistency) and might remove the
> checkpoint which other cluster node is still relying upon. For e.g. consider
> a 2 node cluster N1 and N2 where both are performing async indexing.
> # Base state - CP1 is the checkpoint for "async" job
> # N2 starts indexing and removes changes CP1 to CP2. For Mongo the
> checkpoints are saved in {{settings}} collection
> # N1 also decides to execute indexing but has yet not seen the latest
> repository state so still thinks that CP1 is the base checkpoint and tries to
> read it. However CP1 is already removed from {{settings}} and this makes N1
> think that checkpoint is missing and it decides to reindex everything!
> To avoid this topology must be stable but at Oak level we should still handle
> such a case and avoid doing a full reindexing. So we would need to have a
> {{MissingCheckpointStrategy}} similar to {{MissingIndexEditorStrategy}} as
> done in OAK-2203
> Possible approaches
> # A1 - Fail the indexing run if checkpoint is missing - Checkpoint being
> missing can have valid reason and invalid reason. Need to see what are valid
> scenarios where a checkpoint can go missing
> # A2 - When a checkpoint is created also store the creation time. When a
> checkpoint is found to be missing and its a *recent* checkpoint then fail the
> run. For e.g. we would fail the run till checkpoint found to be missing is
> less than an hour old (for just started take startup time into account)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3649) Extract node document cache from Mongo and RDB document stores
[ https://issues.apache.org/jira/browse/OAK-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028835#comment-15028835 ] Tomek Rękawek commented on OAK-3649: The method will decrease the lock counter by one. The lock will be released when counter = 0. > Extract node document cache from Mongo and RDB document stores > -- > > Key: OAK-3649 > URL: https://issues.apache.org/jira/browse/OAK-3649 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk, mongomk, rdbmk >Reporter: Tomek Rękawek >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.3.12 > > > MongoDocumentStore and RDBDocumentStore contains copy & pasted methods > responsible for handling node document cache. Extract these into a new > NodeDocumentCache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-2859) Test failure: OrderableNodesTest
[
https://issues.apache.org/jira/browse/OAK-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-2859:
Fix Version/s: (was: 1.4)
1.3.12
> Test failure: OrderableNodesTest
>
>
> Key: OAK-2859
> URL: https://issues.apache.org/jira/browse/OAK-2859
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: rdbmk
> Environment: https://builds.apache.org/
>Reporter: Michael Dürig
>Assignee: Julian Reschke
> Labels: ci, jenkins
> Fix For: 1.3.12
>
>
> {{org.apache.jackrabbit.oak.jcr.OrderableNodesTest}} fails on Jenkins when
> running the {{DOCUMENT_RDB}} fixture.
> {noformat}
> Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 12.572 sec
> <<< FAILURE!
> orderableFolder[0](org.apache.jackrabbit.oak.jcr.OrderableNodesTest) Time
> elapsed: 3.858 sec <<< ERROR!
> javax.jcr.nodetype.ConstraintViolationException: No default node type
> available for /testdata
> at org.apache.jackrabbit.oak.util.TreeUtil.addChild(TreeUtil.java:186)
> at
> org.apache.jackrabbit.oak.jcr.delegate.NodeDelegate.addChild(NodeDelegate.java:692)
> at
> org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:296)
> at
> org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:262)
> at
> org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:202)
> at
> org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112)
> at
> org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:262)
> at
> org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:247)
> at
> org.apache.jackrabbit.oak.jcr.TestContentLoader.getOrAddNode(TestContentLoader.java:90)
> at
> org.apache.jackrabbit.oak.jcr.TestContentLoader.loadTestContent(TestContentLoader.java:57)
> at
> org.apache.jackrabbit.oak.jcr.OrderableNodesTest.orderableFolder(OrderableNodesTest.java:47)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:24)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
> at java.util.concurrent.FutureTask.run(FutureTask.java:138)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
> at java.lang.Thread.run(Thread.java:662)
> {noformat}
> Failure seen at builds: 81, 87, 92, 95, 96, 114, 120, 128, 134, 186, 243,
> 272, 292
> See e.g.
> https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/128/jdk=jdk-1.6u45,label=Ubuntu,nsfixtures=DOCUMENT_RDB,profile=unittesting/console
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (OAK-2859) Test failure: OrderableNodesTest
[
https://issues.apache.org/jira/browse/OAK-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke resolved OAK-2859.
-
Resolution: Fixed
Removing the test exclusion for now. I currently can not reproduce the issue,
and there have been quite a few changes that may have fixed this.
> Test failure: OrderableNodesTest
>
>
> Key: OAK-2859
> URL: https://issues.apache.org/jira/browse/OAK-2859
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: rdbmk
> Environment: https://builds.apache.org/
>Reporter: Michael Dürig
>Assignee: Julian Reschke
> Labels: ci, jenkins
> Fix For: 1.3.12
>
>
> {{org.apache.jackrabbit.oak.jcr.OrderableNodesTest}} fails on Jenkins when
> running the {{DOCUMENT_RDB}} fixture.
> {noformat}
> Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 12.572 sec
> <<< FAILURE!
> orderableFolder[0](org.apache.jackrabbit.oak.jcr.OrderableNodesTest) Time
> elapsed: 3.858 sec <<< ERROR!
> javax.jcr.nodetype.ConstraintViolationException: No default node type
> available for /testdata
> at org.apache.jackrabbit.oak.util.TreeUtil.addChild(TreeUtil.java:186)
> at
> org.apache.jackrabbit.oak.jcr.delegate.NodeDelegate.addChild(NodeDelegate.java:692)
> at
> org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:296)
> at
> org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:262)
> at
> org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:202)
> at
> org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112)
> at
> org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:262)
> at
> org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:247)
> at
> org.apache.jackrabbit.oak.jcr.TestContentLoader.getOrAddNode(TestContentLoader.java:90)
> at
> org.apache.jackrabbit.oak.jcr.TestContentLoader.loadTestContent(TestContentLoader.java:57)
> at
> org.apache.jackrabbit.oak.jcr.OrderableNodesTest.orderableFolder(OrderableNodesTest.java:47)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:24)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
> at java.util.concurrent.FutureTask.run(FutureTask.java:138)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
> at java.lang.Thread.run(Thread.java:662)
> {noformat}
> Failure seen at builds: 81, 87, 92, 95, 96, 114, 120, 128, 134, 186, 243,
> 272, 292
> See e.g.
> https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/128/jdk=jdk-1.6u45,label=Ubuntu,nsfixtures=DOCUMENT_RDB,profile=unittesting/console
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OAK-3684) RDBDocumentStore.finalize() does not call super.finalize()
Julian Reschke created OAK-3684: --- Summary: RDBDocumentStore.finalize() does not call super.finalize() Key: OAK-3684 URL: https://issues.apache.org/jira/browse/OAK-3684 Project: Jackrabbit Oak Issue Type: Technical task Components: rdbmk Affects Versions: 1.0.24, 1.2.8, 1.3.11 Reporter: Julian Reschke Assignee: Julian Reschke Priority: Trivial -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3649) Extract node document cache from Mongo and RDB document stores
[ https://issues.apache.org/jira/browse/OAK-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028912#comment-15028912 ] Julian Reschke commented on OAK-3649: - I see. Thanks for clarifying. > Extract node document cache from Mongo and RDB document stores > -- > > Key: OAK-3649 > URL: https://issues.apache.org/jira/browse/OAK-3649 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk, mongomk, rdbmk >Reporter: Tomek Rękawek >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.3.12 > > > MongoDocumentStore and RDBDocumentStore contains copy & pasted methods > responsible for handling node document cache. Extract these into a new > NodeDocumentCache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-3684) RDBDocumentStore.finalize() does not call super.finalize()
[ https://issues.apache.org/jira/browse/OAK-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-3684: Fix Version/s: 1.3.12 1.2.9 > RDBDocumentStore.finalize() does not call super.finalize() > -- > > Key: OAK-3684 > URL: https://issues.apache.org/jira/browse/OAK-3684 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Affects Versions: 1.3.11, 1.2.8, 1.0.24 >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Fix For: 1.2.9, 1.3.12 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
