[jira] [Commented] (OAK-8445) RDB documentation: minor fixes to documentation of "revisions" command

2019-06-28 Thread Julian Reschke (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-8445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874728#comment-16874728
 ] 

Julian Reschke commented on OAK-8445:
-

trunk: [r1862266|http://svn.apache.org/r1862266]

> RDB documentation: minor fixes to documentation of "revisions" command
> --
>
> Key: OAK-8445
> URL: https://issues.apache.org/jira/browse/OAK-8445
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: doc
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
>  Labels: candidate_oak_1_10
> Fix For: 1.16.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-8429) oak-run check should expose repository statistics for the last good revision

2019-06-28 Thread Francesco Mari (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-8429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874760#comment-16874760
 ] 

Francesco Mari commented on OAK-8429:
-

[~dulceanu], I don't think that there is a better way to do that. The patch 
looks good to me.

> oak-run check should expose repository statistics for the last good revision
> 
>
> Key: OAK-8429
> URL: https://issues.apache.org/jira/browse/OAK-8429
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run, segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
>  Labels: tooling
> Fix For: 1.16.0
>
> Attachments: OAK-8429.patch
>
>
> {{oak-run check}} should expose the head node and property counts for the 
> last good revision. Currently these are only logged at the end of the check 
> operation as
> {noformat}
> Checked X nodes and Y properties.{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-8445) RDB documentation: minor fixes to documentation of "revisions" command

2019-06-28 Thread Julian Reschke (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8445:

Labels: candidate_oak_1_10  (was: )

> RDB documentation: minor fixes to documentation of "revisions" command
> --
>
> Key: OAK-8445
> URL: https://issues.apache.org/jira/browse/OAK-8445
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: doc
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
>  Labels: candidate_oak_1_10
> Fix For: 1.16.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-8445) RDB documentation: minor fixes to documentation of "revisions" command

2019-06-28 Thread Julian Reschke (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8445:

Summary: RDB documentation: minor fixes to documentation of "revisions" 
command  (was: rdb documentation: minor fixes to documentation of "revisions" 
command)

> RDB documentation: minor fixes to documentation of "revisions" command
> --
>
> Key: OAK-8445
> URL: https://issues.apache.org/jira/browse/OAK-8445
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: doc
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OAK-8445) RDB documentation: minor fixes to documentation of "revisions" command

2019-06-28 Thread Julian Reschke (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved OAK-8445.
-
   Resolution: Fixed
Fix Version/s: 1.16.0

> RDB documentation: minor fixes to documentation of "revisions" command
> --
>
> Key: OAK-8445
> URL: https://issues.apache.org/jira/browse/OAK-8445
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: doc
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: 1.16.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OAK-8445) rdb documentation: minor fixes to documentation of "revisions" command

2019-06-28 Thread Julian Reschke (JIRA)
Julian Reschke created OAK-8445:
---

 Summary: rdb documentation: minor fixes to documentation of 
"revisions" command
 Key: OAK-8445
 URL: https://issues.apache.org/jira/browse/OAK-8445
 Project: Jackrabbit Oak
  Issue Type: Technical task
  Components: doc
Reporter: Julian Reschke
Assignee: Julian Reschke






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-8444) Build Jackrabbit Oak #2243 failed

2019-06-28 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874789#comment-16874789
 ] 

Hudson commented on OAK-8444:
-

Previously failing build now is OK.
 Passed run: [Jackrabbit Oak 
#2245|https://builds.apache.org/job/Jackrabbit%20Oak/2245/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2245/console]

> Build Jackrabbit Oak #2243 failed
> -
>
> Key: OAK-8444
> URL: https://issues.apache.org/jira/browse/OAK-8444
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2243 has failed.
> First failed run: [Jackrabbit Oak 
> #2243|https://builds.apache.org/job/Jackrabbit%20Oak/2243/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2243/console]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OAK-8447) Handle all available references in the DataStore when doing consistency check

2019-06-28 Thread Amit Jain (JIRA)
Amit Jain created OAK-8447:
--

 Summary: Handle all available references in the DataStore when 
doing consistency check
 Key: OAK-8447
 URL: https://issues.apache.org/jira/browse/OAK-8447
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: blob-plugins
Reporter: Amit Jain
Assignee: Amit Jain
 Fix For: 1.16.0


The {{checkConsistency()}} method should also handle all references file 
available in the DataStore for flagging any missing blob.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OAK-8446) Enable datastore consistency check after completion of garbage collection

2019-06-28 Thread Amit Jain (JIRA)
Amit Jain created OAK-8446:
--

 Summary: Enable datastore consistency check after completion of 
garbage collection
 Key: OAK-8446
 URL: https://issues.apache.org/jira/browse/OAK-8446
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: blob-plugins, oak-run
Reporter: Amit Jain
Assignee: Amit Jain
 Fix For: 1.16.0


Optionally run datastore {{checkConsistency()}} after completion of DSGC to 
flag possible data loss immediately.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-8444) Build Jackrabbit Oak #2243 failed

2019-06-28 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874863#comment-16874863
 ] 

Hudson commented on OAK-8444:
-

Previously failing build now is OK.
 Passed run: [Jackrabbit Oak 
#2246|https://builds.apache.org/job/Jackrabbit%20Oak/2246/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2246/console]

> Build Jackrabbit Oak #2243 failed
> -
>
> Key: OAK-8444
> URL: https://issues.apache.org/jira/browse/OAK-8444
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2243 has failed.
> First failed run: [Jackrabbit Oak 
> #2243|https://builds.apache.org/job/Jackrabbit%20Oak/2243/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2243/console]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OAK-8429) oak-run check should expose repository statistics for the last good revision

2019-06-28 Thread Andrei Dulceanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-8429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulceanu resolved OAK-8429.
--
Resolution: Fixed

> oak-run check should expose repository statistics for the last good revision
> 
>
> Key: OAK-8429
> URL: https://issues.apache.org/jira/browse/OAK-8429
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run, segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
>  Labels: tooling
> Fix For: 1.16.0
>
> Attachments: OAK-8429.patch
>
>
> {{oak-run check}} should expose the head node and property counts for the 
> last good revision. Currently these are only logged at the end of the check 
> operation as
> {noformat}
> Checked X nodes and Y properties.{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-8429) oak-run check should expose repository statistics for the last good revision

2019-06-28 Thread Andrei Dulceanu (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-8429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874819#comment-16874819
 ] 

Andrei Dulceanu commented on OAK-8429:
--

Thanks for reviewing, [~frm]!

Fixed at r1862275.

> oak-run check should expose repository statistics for the last good revision
> 
>
> Key: OAK-8429
> URL: https://issues.apache.org/jira/browse/OAK-8429
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run, segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
>  Labels: tooling
> Fix For: 1.16.0
>
> Attachments: OAK-8429.patch
>
>
> {{oak-run check}} should expose the head node and property counts for the 
> last good revision. Currently these are only logged at the end of the check 
> operation as
> {noformat}
> Checked X nodes and Y properties.{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OAK-8448) VersionGC may get stuck at 60s scope

2019-06-28 Thread Julian Reschke (JIRA)
Julian Reschke created OAK-8448:
---

 Summary: VersionGC may get stuck at 60s scope 
 Key: OAK-8448
 URL: https://issues.apache.org/jira/browse/OAK-8448
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: documentmk
Affects Versions: 1.8.9
Reporter: Julian Reschke
Assignee: Julian Reschke


It seems that if the VersionGarbageCollector reduces the scope to a 60s 
interval, it'll never change it back to a bigger interval. This is because the 
collectLimit gets set to 0:

{noformat}
if (scope.getDurationMs() <= options.precisionMs) {
// If we have narrowed the collect time interval down as much 
as we can, no
// longer enforce a limit. We need to get through this.
collectLimit = 0;
log.debug("time interval <= precision ({} ms), disabling 
collection limits", options.precisionMs);
}
{noformat}

...and later on this is interpreted as "there were no restrictions in the prior 
run that need to be updated":

{noformat}
if (maxCollect <= 0) {
log.debug("successful run without effective limit, keeping 
recommendations");
}
{noformat}




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-4780) VersionGarbageCollector should be able to run incrementally

2019-06-28 Thread Julian Reschke (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874915#comment-16874915
 ] 

Julian Reschke commented on OAK-4780:
-

trunk: (1.7.0) [r1792051|http://svn.apache.org/r1792051] 
[r1791681|http://svn.apache.org/r1791681] 
[r1790796|http://svn.apache.org/r1790796]

> VersionGarbageCollector should be able to run incrementally
> ---
>
> Key: OAK-4780
> URL: https://issues.apache.org/jira/browse/OAK-4780
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: documentmk
>Reporter: Julian Reschke
>Priority: Major
> Fix For: 1.7.0, 1.8.0
>
> Attachments: OAK-4780-core-1.patch, OAK-4780-core-2.diff, 
> OAK-4780-core-4.diff, OAK-4780-core-5.diff, OAK-4780-core.diff, 
> OAK-4780-rdb.diff, leafnodes-v2.diff, leafnodes-v3.diff, leafnodes.diff
>
>
> Right now, the documentmk's version garbage collection runs in several phases.
> It first collects the paths of candidate nodes, and only once this has been 
> successfully finished, starts actually deleting nodes.
> This can be a problem when the regularly scheduled garbage collection is 
> interrupted during the path collection phase, maybe due to other maintenance 
> tasks. On the next run, the number of paths to be collected will be even 
> bigger, thus making it even more likely to fail.
> We should think about a change in the logic that would allow the GC to run in 
> chunks; maybe by partitioning the path space by top level directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Issue Comment Deleted] (OAK-4780) VersionGarbageCollector should be able to run incrementally

2019-06-28 Thread Julian Reschke (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4780:

Comment: was deleted

(was: trunk: [r1791681|http://svn.apache.org/r1791681] 
[r1790796|http://svn.apache.org/r1790796]
)

> VersionGarbageCollector should be able to run incrementally
> ---
>
> Key: OAK-4780
> URL: https://issues.apache.org/jira/browse/OAK-4780
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: documentmk
>Reporter: Julian Reschke
>Priority: Major
> Fix For: 1.7.0, 1.8.0
>
> Attachments: OAK-4780-core-1.patch, OAK-4780-core-2.diff, 
> OAK-4780-core-4.diff, OAK-4780-core-5.diff, OAK-4780-core.diff, 
> OAK-4780-rdb.diff, leafnodes-v2.diff, leafnodes-v3.diff, leafnodes.diff
>
>
> Right now, the documentmk's version garbage collection runs in several phases.
> It first collects the paths of candidate nodes, and only once this has been 
> successfully finished, starts actually deleting nodes.
> This can be a problem when the regularly scheduled garbage collection is 
> interrupted during the path collection phase, maybe due to other maintenance 
> tasks. On the next run, the number of paths to be collected will be even 
> bigger, thus making it even more likely to fail.
> We should think about a change in the logic that would allow the GC to run in 
> chunks; maybe by partitioning the path space by top level directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)