Re: [PATCH v5b 2/3] stemodem: Create network interfaces statically

[Sjur Brændeland]

Hi Marcel.

 -     struct conn_info *conn;
 +     struct conn_info *conn = NULL;
       GSList *l;

 why do you need the conn = NULL assignment here? I haven't even looked
 into your code flow, but I prefer clearly to not have these.

I have removed this and tried to remove some of the other
initialisations at declaration as well.
New patch set on the remaining gprs-context changes is on it's way :-)

Regards,
Sjur
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

[RFC] Refactoring ISI modem support

[Aki Niemi]

Hi All,

I've been working on improving the ISI modem support in oFono, mostly
concentrating on the gisi library, but also on tweaking the drivers
and plugins. You can follow the progress of this 'gisi' branch here:

git://gitorious.org/~akiniemi/meego-cellular/ofono-aki.git

http://meego.gitorious.org/~akiniemi/meego-cellular/ofono-aki/trees/gisi

This is now shaping up enough to call for a bit wider review. Gisi is
mostly where I think it should be, and seems to work. The new
(redesigned, really) version is fixing some of the long-standing
complaints. For instance, it is now using only a single PhoNet socket,
managing indication subscriptions and reachability queries a bit more
intelligently, and is caching modem reachability status and ISI
resource versions for as long as the modem plugin is registered.

Note that not all of the drivers or the n900 plugin have yet been
adapted, but those that are seem to work.

I would really appreciate any comments you might have. Especially
if you are working with gisi or isimodem, please take a look. The plan
is to adapt the rest of the drivers and the n900 plugin in the next
couple of weeks, test some more, rebase, and apply to the
master tree.

Cheers,
Aki
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono