Re: [PATCH] doc: Assisted Satellite Navigation API and Agent API

2011-01-28 Thread Rémi Denis-Courmont
On Friday 28 January 2011 13:32:50 ext Sjur Brændeland, you wrote:
> + void RegisterPositioningRequestAgent(object path)
> +
> + Registers an agent which will be called whenever a
> + CPOSR AT response is received. The Agent must respond
> + to requests using SendPositioningControl.

Spelling is inconsistent ;)

-- 
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


[PATCH] doc: Assisted Satellite Navigation API and Agent API

2011-01-28 Thread Sjur Brændeland
From: Simon Lethbridge 

This patch introduces support for Global Satellite Navigation System (GNSS),
using the AT commands AT+CPOS and +CPOSR as specified 3GPP 27.007.
---
Hi Denis,

2010/11/30 Denis Kenzior :
>> +AssistedSatelliteNavigation hierarchy
>What do you think of naming this AssistedNavigation?  I think the
>current name might be a bit too long.
See mail previous mail on this topic, I think we'd like to keep
it as is for now.

>> +Methods  void SendPositioningControl(string xml_element)
>What do you think of SendPositioningElement?
Fixed,

>> +Methods  void PositioningRequest(string xml_element)
>I think that 'Request' will be sufficient.  Positioning is already part
>of the agent name.
Fixed,

>> + void AssistanceDataReset()
>I suggest ResetAssistanceData here.
Fixed,

>The only other change I'd make is to mark the entire interface
>'experimental', but I can take care of that as well.
Fixed,

>Otherwise the proposal looks good to me.
Sorry for taking so long before responding on this.
Let us know if you have any issues with this patch.

Regards,
Sjur and Simon.

 doc/assisted-sattelite-navigation.txt |   56 +
 1 files changed, 56 insertions(+), 0 deletions(-)
 create mode 100644 doc/assisted-sattelite-navigation.txt

diff --git a/doc/assisted-sattelite-navigation.txt 
b/doc/assisted-sattelite-navigation.txt
new file mode 100644
index 000..abacf54
--- /dev/null
+++ b/doc/assisted-sattelite-navigation.txt
@@ -0,0 +1,56 @@
+Assisted Satellite Navigation hierarchy [experimental]
+==
+
+Serviceorg.ofono
+Interface  org.ofono.AssistedSatelliteNavigation
+Object path[variable prefix]/{modem0,modem1,...}
+
+Methodsvoid SendPositioningElement(string xml_element)
+
+   Send an XML element conforming to the XML DTD for 
+   as defined in 3GPP 27.007 Table 8.55-2. This xml is
+   used for transferring data associated with positioning
+   requests received via control plane from the network.
+   This includes assistance data requests and the results
+   of positioning procedures. This method maps directly to
+   the 3GPP 27.007 AT+CPOS command.
+
+   void RegisterPositioningRequestAgent(object path)
+
+   Registers an agent which will be called whenever a
+   CPOSR AT response is received. The Agent must respond
+   to requests using SendPositioningControl.
+
+   void UnregisterPositioningRequestAgent(object path)
+
+   Un-registers the agent.
+
+PositioningRequestAgent hierarchy
+==
+
+Serviceunique name
+Interface  org.ofono.PositioningRequestAgent
+Object pathfreely definable
+
+Methodsvoid Request(string xml_element)
+
+   Receive an XML element conforming to the XML DTD for
+in 3GPP 27.007. This xml is used for transferring
+   data associated with positioning requests received, via
+   control plane, from the network. This includes
+   measurement requests and assistance data. This method
+   maps directly to the 3GPP defined +CPOSR unsolicited
+   result code.
+
+   void ResetAssistanceData()
+
+   A request has been received from the network that all
+   assistance data should be reset.  This is used for 3gpp
+   performance tests.
+
+   void Release()
+
+   Agent is being released, possibly because of oFono
+   terminating, AssistedSatelliteNavigation interface
+   is being torn down or modem off.
+   No UnregisterAgent call is needed.
-- 
1.7.0.4

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono