[PATCH] isigen: increase offline timeout
From: Pekka Pessi pekka.pe...@nokia.com The modem deregisters from network before response to MTC_STATE_REQ is returned. Deregistering can take at least 8 seconds. --- plugins/isigen.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/isigen.c b/plugins/isigen.c index 493d926..014456f 100644 --- a/plugins/isigen.c +++ b/plugins/isigen.c @@ -373,7 +373,7 @@ static void isigen_online(struct ofono_modem *modem, ofono_bool_t online, isi-online = online; - if (g_isi_send(isi-client, req, sizeof(req), MTC_TIMEOUT, + if (g_isi_send(isi-client, req, sizeof(req), 8 + MTC_TIMEOUT, mtc_state_cb, cbd, NULL)) return; -- 1.7.1 ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] isigen: increase offline timeout
Hi Pekka, The modem deregisters from network before response to MTC_STATE_REQ is returned. Deregistering can take at least 8 seconds. --- plugins/isigen.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/isigen.c b/plugins/isigen.c index 493d926..014456f 100644 --- a/plugins/isigen.c +++ b/plugins/isigen.c @@ -373,7 +373,7 @@ static void isigen_online(struct ofono_modem *modem, ofono_bool_t online, isi-online = online; - if (g_isi_send(isi-client, req, sizeof(req), MTC_TIMEOUT, + if (g_isi_send(isi-client, req, sizeof(req), 8 + MTC_TIMEOUT, mtc_state_cb, cbd, NULL)) return; are you sure you just wanna hardcode it like this and not use a proper constant for it? Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] isigen: increase offline timeout
Hi Marcel, 2010/11/3 Marcel Holtmann mar...@holtmann.org: The modem deregisters from network before response to MTC_STATE_REQ is returned. Deregistering can take at least 8 seconds. --- plugins/isigen.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/isigen.c b/plugins/isigen.c index 493d926..014456f 100644 --- a/plugins/isigen.c +++ b/plugins/isigen.c @@ -373,7 +373,7 @@ static void isigen_online(struct ofono_modem *modem, ofono_bool_t online, isi-online = online; - if (g_isi_send(isi-client, req, sizeof(req), MTC_TIMEOUT, + if (g_isi_send(isi-client, req, sizeof(req), 8 + MTC_TIMEOUT, mtc_state_cb, cbd, NULL)) return; are you sure you just wanna hardcode it like this and not use a proper constant for it? I'm not sure. It might depend on modem. Aki? -- Pekka.Pessi mail at nokia.com ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
