Re: [PATCH 00/21] Resubmit Zhenhua Zhang work on DUN server with btio

2011-01-25 Thread Gustavo F. Padovan
Hi all,

* Frédéric Dalleau frederic.dall...@intel.com [2011-01-12 18:15:43 +0100]:

 This is rebased as of head of today
 
 Zhenhua Zhang (21):
   bluetooth: Add reference count for bluetooth utils
   bluetooth: Add Btio library for DUN
   bluetooth: Add bluetooth server support for DUN
   emulator: Add emulator atom in oFono
   dun_gw: Add DUN server plugin for oFono
   gprs: Rename status_watch to netreg_status_watch
   emulator: Add status watches for ofono emulator
   emulator: Add emulator status watches in gprs atom
   emulator: Add APIs to send GAtServer result
   emulator: Implement dialing up for DUN
   gprs: Make gprs_proto_to/from_string non-static
   gprs: ignore the case of proto str when comparing
   emulator: Register mandatory AT command handlers
   gprs: Refactor to share remove_context method
   gprs: Add DUN +CGATT support in gprs atom
   gprs: Add DUN +CGDCONT support in gprs atom
   gprs: Add DUN server GPRS connect support
   gprs: Add status watch functions
   gprs: Add gprs_get_status
   emulator: Watch GPRS status changes
   emulator: Watch netreg status changes
 
  Makefile.am|   15 +-
  btio/btio.c| 1299 
 
  btio/btio.h|   97 
  configure.ac   |5 +
  include/emulator.h |   94 
  include/gprs-context.h |4 +
  include/gprs.h |   11 +
  plugins/bluetooth.c|  441 -
  plugins/bluetooth.h|   15 +
  plugins/dun_gw.c   |  115 +
  src/emulator.c | 1072 +++
  src/gprs.c |  500 +--
  src/modem.c|1 +
  src/ofono.h|   31 ++
  14 files changed, 3636 insertions(+), 64 deletions(-)
  create mode 100644 btio/btio.c
  create mode 100644 btio/btio.h
  create mode 100644 include/emulator.h
  create mode 100644 plugins/dun_gw.c
  create mode 100644 src/emulator.c

So I took this patches as a base to finish the DUN implementation on oFono.
The DUN Server is now working, it accepts a ATD*99 from the client and start
the PPP negotiation, then create the ppp interface to flow the internet
connection to the client. Code is here:

git://git.profusion.mobi/users/padovan/ofono.git dun

This not rebased upstream because I didn't touch the bluetooth patches yet,
mostly due the fact that Frédéric Danis is working on them.

The next step is to implement the packet forwarding to the ppp interface
inside ConnMan, you can follow the discussion and implementation in the
ConnMan mailing list.

http://www.mail-archive.com/connman@connman.net/msg03092.html

-- 
Gustavo F. Padovan
http://profusion.mobi
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 00/21] Resubmit Zhenhua Zhang work on DUN server with btio

2011-01-13 Thread Rémi Denis-Courmont
On Wednesday 12 January 2011 19:15:43 ext Frédéric Dalleau, you wrote:
 This is rebased as of head of today

This seems quite useless work to me.

There are a number of AT commands that are required but really do not belong 
in oFono. Consider for example AT+CKPD/AT+CTSA/AT+CMEC input emulation and 
AT+CBC* battery notifications. Those things have nothing to do with Cellular 
other than the C in the command prefix.  Then we have commands that are related 
to cellular functionality but higher-level than oFono, like AT+CPB* for 
phonebook.

Now, I recognize this patch only attempts to provide BT DUN profile, not the 
whole 27.007 set. But doing that in userspace in oFono is probably the slowest 
and most inefficient approach to the problem. And MeeGo will have to solve the 
more general problem in any case, if MeeGo cellular devices are to be 
certified.

-- 
Rémi Denis-Courmont
Nokia Devices RD, Maemo Software, Helsinki
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 00/21] Resubmit Zhenhua Zhang work on DUN server with btio

2011-01-13 Thread Rémi Denis-Courmont
On Thursday 13 January 2011 14:01:16 ext Frédéric Dalleau, you wrote:
 On 01/13/2011 10:18 AM, Rémi Denis-Courmont wrote:
  This seems quite useless work to me.
 
 This patch has been on the list for some time now. Why didn't you
 express your concern before that?

I did point out limitations on some earlier occasion.

I also pointed out the problem to Aki and Marcel privately a long time ago.

   But doing that in userspace in oFono is probably the slowest
  and most inefficient approach to the problem.
 
 Nowadays, relaying a gprs connection at 56k doesn't need to be done in a
 kernel module.

HSPA category certification is achieved with PPP over USB and using the final 
user software. So we are talking about bandwidth in the 10 Mb/s order of 
magnitude on contemporary products.

-- 
Rémi Denis-Courmont
Nokia Devices RD, Maemo Software, Helsinki
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 00/21] Resubmit Zhenhua Zhang work on DUN server with btio

2011-01-13 Thread Rémi Denis-Courmont
On Thursday 13 January 2011 16:07:06 ext Frédéric Dalleau, you wrote:
 On 01/13/2011 01:17 PM, Rémi Denis-Courmont wrote:
  HSPA category certification is achieved with PPP over USB and using the
  final user software. So we are talking about bandwidth in the 10 Mb/s
  order
 
 This is another story. The patch uses the oFono ppp layer. This is the
 author's choice and I respect this choice.
 
 Why do you think it cannot handle your requirements?

I don't know if it can. I am only pointing out that we are not talking about 
orders of magnitude higher bandwidth than V90 which you invoked.

-- 
Rémi Denis-Courmont
Nokia Devices RD, Maemo Software, Helsinki
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


[PATCH 00/21] Resubmit Zhenhua Zhang work on DUN server with btio

2011-01-12 Thread Frédéric Dalleau
This is rebased as of head of today

Zhenhua Zhang (21):
  bluetooth: Add reference count for bluetooth utils
  bluetooth: Add Btio library for DUN
  bluetooth: Add bluetooth server support for DUN
  emulator: Add emulator atom in oFono
  dun_gw: Add DUN server plugin for oFono
  gprs: Rename status_watch to netreg_status_watch
  emulator: Add status watches for ofono emulator
  emulator: Add emulator status watches in gprs atom
  emulator: Add APIs to send GAtServer result
  emulator: Implement dialing up for DUN
  gprs: Make gprs_proto_to/from_string non-static
  gprs: ignore the case of proto str when comparing
  emulator: Register mandatory AT command handlers
  gprs: Refactor to share remove_context method
  gprs: Add DUN +CGATT support in gprs atom
  gprs: Add DUN +CGDCONT support in gprs atom
  gprs: Add DUN server GPRS connect support
  gprs: Add status watch functions
  gprs: Add gprs_get_status
  emulator: Watch GPRS status changes
  emulator: Watch netreg status changes

 Makefile.am|   15 +-
 btio/btio.c| 1299 
 btio/btio.h|   97 
 configure.ac   |5 +
 include/emulator.h |   94 
 include/gprs-context.h |4 +
 include/gprs.h |   11 +
 plugins/bluetooth.c|  441 -
 plugins/bluetooth.h|   15 +
 plugins/dun_gw.c   |  115 +
 src/emulator.c | 1072 +++
 src/gprs.c |  500 +--
 src/modem.c|1 +
 src/ofono.h|   31 ++
 14 files changed, 3636 insertions(+), 64 deletions(-)
 create mode 100644 btio/btio.c
 create mode 100644 btio/btio.h
 create mode 100644 include/emulator.h
 create mode 100644 plugins/dun_gw.c
 create mode 100644 src/emulator.c

-
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: Les Montalets- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono