Re: [PATCH 1/3] qmi/discovery: remove useless code

2017-09-07 Thread Denis Kenzior 

Hi Alexander,

On 09/07/2017 02:23 PM, Alexander Couzens wrote:

---
  drivers/qmimodem/qmi.c | 5 -
  1 file changed, 5 deletions(-)

diff --git a/drivers/qmimodem/qmi.c b/drivers/qmimodem/qmi.c
index c538cb978393..1af86aaccb08 100644
--- a/drivers/qmimodem/qmi.c
+++ b/drivers/qmimodem/qmi.c
@@ -1162,11 +1162,6 @@ static void discover_callback(uint16_t message, uint16_t 
length,
  
  	service_list = ptr + *((uint8_t *) ptr) + 1;
  


Why don't you also take out that service_list assignment as well?


-   for (i = 0; i < service_list->count; i++) {
-   if (service_list->services[i].type == QMI_SERVICE_CONTROL)
-   continue;
-   }
-
  done:
device->version_list = list;
device->version_count = count;



Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono

[PATCH 1/3] qmi/discovery: remove useless code

2017-09-07 Thread Alexander Couzens 
---
 drivers/qmimodem/qmi.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/qmimodem/qmi.c b/drivers/qmimodem/qmi.c
index c538cb978393..1af86aaccb08 100644
--- a/drivers/qmimodem/qmi.c
+++ b/drivers/qmimodem/qmi.c
@@ -1162,11 +1162,6 @@ static void discover_callback(uint16_t message, uint16_t 
length,
 
service_list = ptr + *((uint8_t *) ptr) + 1;
 
-   for (i = 0; i < service_list->count; i++) {
-   if (service_list->services[i].type == QMI_SERVICE_CONTROL)
-   continue;
-   }
-
 done:
device->version_list = list;
device->version_count = count;
-- 
2.14.1

___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono