Re: [PATCH 3/4] Bearer documentation

2011-01-13 Thread Rémi Denis-Courmont
On Wednesday 12 January 2011 18:40:45 ext Marcel Holtmann, you wrote:
 that is what I thought. It is just a stupidity in the AT command
 specification that they give a CID with it.

If that's the understanding, I will rewrite the patch to expose the current 
bearer in the connection manager and keep the network access technology as it 
currently is - in the network registration.

-- 
Rémi Denis-Courmont
Nokia Devices RD, Maemo Software, Helsinki
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 3/4] Bearer documentation

2011-01-12 Thread Marcel Holtmann
Hi Aki,

  As Denis said, the vendor commands indicate that it is a global bearer
  information. If one context is on HSPA, then others will be as well. So
  how does ISI provide this information? Is it globally or per context?
 
 I doubt contexts can even be on different bearers. At least on ISI, the
 indication for HS*PA channel allocations is global, and so is cell
 supported technologies.

that is what I thought. It is just a stupidity in the AT command
specification that they give a CID with it.

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 3/4] Bearer documentation

2011-01-10 Thread Rémi Denis-Courmont
On Friday 07 January 2011 18:23:25 ext Denis Kenzior, you wrote:
 The other question I have is whether we should report this at the
 context level or at the ConnectionManager level.  Can different contexts
 truly have different bearers?

At least for 3G with HS*PA, I believe we can. In my understanding, HSPA 
channels are allocated per contexts. Correct me if I'm wrong.

-- 
Rémi Denis-Courmont
Nokia Devices RD, Maemo Software, Helsinki
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 3/4] Bearer documentation

2011-01-10 Thread Rémi Denis-Courmont
On Friday 07 January 2011 18:23:25 ext Denis Kenzior, you wrote:
 Hi Rémi,
 
 On 01/07/2011 10:02 AM, Rémi Denis-Courmont wrote:
  ---
  
   doc/connman-api.txt |   10 ++
   1 files changed, 10 insertions(+), 0 deletions(-)
  
  diff --git a/doc/connman-api.txt b/doc/connman-api.txt
  index b13efd1..18185d7 100644
  --- a/doc/connman-api.txt
  +++ b/doc/connman-api.txt
  @@ -150,6 +150,16 @@ Properties boolean Active [readwrite]
  
  Holds whether the context is activated.  This value
  can be set to activate / deactivate the context.
  
  +   string Bearer [readonly, optional]
  +
  +   Contains the current packet switched bearer of the
  +   connection context.
  +
  +   Possible values are the same as for the Technology
  +   property the NetworkRegistration object, plus
  +   none if no data activity is ongoing, or unknown
  +   if not known.
  +
 
 Please remove this unknown bit.  The property is already optional, so
 if it is never reported by the driver we shouldn't report it up, even if
 the context is active.

That would not work. We need some default value otherwise we cannot signal the 
change from known to unknown, at least not with the oFono property change 
interface.

-- 
Rémi Denis-Courmont
Nokia Devices RD, Maemo Software, Helsinki
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 3/4] Bearer documentation

2011-01-10 Thread Denis Kenzior
Hi Rémi,

On 01/10/2011 06:41 AM, Rémi Denis-Courmont wrote:
 On Friday 07 January 2011 18:23:25 ext Denis Kenzior, you wrote:
 Hi Rémi,

 On 01/07/2011 10:02 AM, Rémi Denis-Courmont wrote:
 ---

  doc/connman-api.txt |   10 ++
  1 files changed, 10 insertions(+), 0 deletions(-)

 diff --git a/doc/connman-api.txt b/doc/connman-api.txt
 index b13efd1..18185d7 100644
 --- a/doc/connman-api.txt
 +++ b/doc/connman-api.txt
 @@ -150,6 +150,16 @@ Properties boolean Active [readwrite]

 Holds whether the context is activated.  This value
 can be set to activate / deactivate the context.

 +   string Bearer [readonly, optional]
 +
 +   Contains the current packet switched bearer of the
 +   connection context.
 +
 +   Possible values are the same as for the Technology
 +   property the NetworkRegistration object, plus
 +   none if no data activity is ongoing, or unknown
 +   if not known.
 +

 Please remove this unknown bit.  The property is already optional, so
 if it is never reported by the driver we shouldn't report it up, even if
 the context is active.
 
 That would not work. We need some default value otherwise we cannot signal 
 the 
 change from known to unknown, at least not with the oFono property change 
 interface.
 

When do you think that will ever happen?

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 3/4] Bearer documentation

2011-01-10 Thread Denis Kenzior
Hi Rémi,

On 01/10/2011 05:21 AM, Rémi Denis-Courmont wrote:
 On Friday 07 January 2011 18:23:25 ext Denis Kenzior, you wrote:
 The other question I have is whether we should report this at the
 context level or at the ConnectionManager level.  Can different contexts
 truly have different bearers?
 
 At least for 3G with HS*PA, I believe we can. In my understanding, HSPA 
 channels are allocated per contexts. Correct me if I'm wrong.
 

I don't know, to me it would not make sense to allocate different
bearers per context, but I'm not an RF engineer.  Do note that at least
several vendors provide extension commands that report the global active
bearer, not per context.  For instance, see the Ericsson *CPSB command...

Someone more knowledgeable would have to weigh in here...

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 3/4] Bearer documentation

2011-01-10 Thread Rémi Denis-Courmont
On Monday 10 January 2011 18:27:33 ext Denis Kenzior, you wrote:
 Hi Rémi,
 
 On 01/10/2011 05:21 AM, Rémi Denis-Courmont wrote:
  On Friday 07 January 2011 18:23:25 ext Denis Kenzior, you wrote:
  The other question I have is whether we should report this at the
  context level or at the ConnectionManager level.  Can different contexts
  truly have different bearers?
  
  At least for 3G with HS*PA, I believe we can. In my understanding, HSPA
  channels are allocated per contexts. Correct me if I'm wrong.
 
 I don't know, to me it would not make sense to allocate different
 bearers per context, but I'm not an RF engineer.  Do note that at least
 several vendors provide extension commands that report the global active
 bearer, not per context.  For instance, see the Ericsson *CPSB command...

The UI wants to show a single icon for the number of G's. I would assume 
that's meant to address this use case. Then you don't need to iterate over all 
contexts, especially those not allocated through that this particular AT 
serial port.

-- 
Rémi Denis-Courmont
Nokia Devices RD, Maemo Software, Helsinki
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 3/4] Bearer documentation

2011-01-10 Thread Aki Niemi
Hi Marcel,

On Mon, 2011-01-10 at 16:26 -0800, ext Marcel Holtmann wrote:
 As Denis said, the vendor commands indicate that it is a global bearer
 information. If one context is on HSPA, then others will be as well. So
 how does ISI provide this information? Is it globally or per context?

I doubt contexts can even be on different bearers. At least on ISI, the
indication for HS*PA channel allocations is global, and so is cell
supported technologies.

Cheers,
Aki

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


[PATCH 3/4] Bearer documentation

2011-01-07 Thread Rémi Denis-Courmont
---
 doc/connman-api.txt |   10 ++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/doc/connman-api.txt b/doc/connman-api.txt
index b13efd1..18185d7 100644
--- a/doc/connman-api.txt
+++ b/doc/connman-api.txt
@@ -150,6 +150,16 @@ Properties boolean Active [readwrite]
Holds whether the context is activated.  This value
can be set to activate / deactivate the context.
 
+   string Bearer [readonly, optional]
+
+   Contains the current packet switched bearer of the
+   connection context.
+
+   Possible values are the same as for the Technology
+   property the NetworkRegistration object, plus
+   none if no data activity is ongoing, or unknown
+   if not known.
+
string AccessPointName [readwrite]
 
Holds the name of the access point.  This is
-- 
1.7.1

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 3/4] Bearer documentation

2011-01-07 Thread Denis Kenzior
Hi Rémi,

On 01/07/2011 10:02 AM, Rémi Denis-Courmont wrote:
 ---
  doc/connman-api.txt |   10 ++
  1 files changed, 10 insertions(+), 0 deletions(-)
 
 diff --git a/doc/connman-api.txt b/doc/connman-api.txt
 index b13efd1..18185d7 100644
 --- a/doc/connman-api.txt
 +++ b/doc/connman-api.txt
 @@ -150,6 +150,16 @@ Properties   boolean Active [readwrite]
   Holds whether the context is activated.  This value
   can be set to activate / deactivate the context.
  
 + string Bearer [readonly, optional]
 +
 + Contains the current packet switched bearer of the
 + connection context.
 +
 + Possible values are the same as for the Technology
 + property the NetworkRegistration object, plus
 + none if no data activity is ongoing, or unknown
 + if not known.
 +

Please remove this unknown bit.  The property is already optional, so
if it is never reported by the driver we shouldn't report it up, even if
the context is active.

The other question I have is whether we should report this at the
context level or at the ConnectionManager level.  Can different contexts
truly have different bearers?

   string AccessPointName [readwrite]
  
   Holds the name of the access point.  This is

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono