[PATCH v1] ifx: Selftest at command syntax fix to support latest fw

[anandx . ramakrishna]

From: Anand Ramakrishna anandx.ramakris...@intel.com

It is a fix to support the selftest at command syntax changed in latest 
IFX fw version

---
 plugins/ifx.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/plugins/ifx.c b/plugins/ifx.c
index 2a95720..a41fc36 100644
--- a/plugins/ifx.c
+++ b/plugins/ifx.c
@@ -573,7 +573,7 @@ static void rtc_gti_selftest_cb(gboolean ok, GAtResult 
*result,
if (ok)
return;
 
-   ofono_error(at@rtc:rtc_gti_test_verify_32khz()-FAILED);
+   ofono_error(at@rtc_drv:rtc_gti_test_verify_32khz()-FAILED);
 
if (data-mux_init_timeout  0) {
g_source_remove(data-mux_init_timeout);
@@ -643,7 +643,7 @@ static int ifx_enable(struct ofono_modem *modem)
NULL, NULL, NULL);
 
/* Execute modem self tests */
-   g_at_chat_send(chat, at@rtc:rtc_gti_test_verify_32khz(), NULL,
+   g_at_chat_send(chat, at@rtc_drv:rtc_gti_test_verify_32khz(), NULL,
rtc_gti_selftest_cb, modem, NULL);
 
g_at_chat_send(chat, at@vers:device_version_id(), NULL,
-- 
1.7.2.3

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: [PATCH v1] ifx: Selftest at command syntax fix to support latest fw

[Marcel Holtmann]

Hi Anand,

 It is a fix to support the selftest at command syntax changed in latest 
 IFX fw version
 
 ---
  plugins/ifx.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/plugins/ifx.c b/plugins/ifx.c
 index 2a95720..a41fc36 100644
 --- a/plugins/ifx.c
 +++ b/plugins/ifx.c
 @@ -573,7 +573,7 @@ static void rtc_gti_selftest_cb(gboolean ok, GAtResult 
 *result,
   if (ok)
   return;
  
 - ofono_error(at@rtc:rtc_gti_test_verify_32khz()-FAILED);
 + ofono_error(at@rtc_drv:rtc_gti_test_verify_32khz()-FAILED);

so I did apply this patch now, but I am really unhappy with this. Since
this clearly relies on internal naming of IFX firmware internal driver
and function names. That is not a good idea.

We need an IFX based abstraction like AT+XSELFTEST or similar for this.
Otherwise the concept of a generic IFX driver will not work out long
term.

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono