Re: [PATCH v3 1/7] plugins/ste: Include STK support from MBM driver.

2010-08-16 Thread Marcel Holtmann
Hi Sjur,

> > ... The build system builds the plugins
> > properly and you can cross reference modem drivers from your modem
> > plugin without any problems.
> 
> Simply refering to MBM driver from ste.c
> 
>  plugins/ste.c |2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/plugins/ste.c b/plugins/ste.c
> index f3ae0b2..9cb49d3 100644
> --- a/plugins/ste.c
> +++ b/plugins/ste.c
> @@ -54,6 +54,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  
>  #include 
> @@ -241,6 +242,7 @@ static void ste_post_sim(struct ofono_modem *modem)
>  
>   gprs = ofono_gprs_create(modem,
>   OFONO_VENDOR_STE, "atmodem", data->chat);
> + ofono_stk_create(modem, 0, "mbmmodem", data->chat);
>   gc = ofono_gprs_context_create(modem, 0, "stemodem", data->chat);
>  
>   if (gprs && gc)

one minor nitpick here. Can you please not squeeze this in between GPRS
and GPRS Context atoms. Put it at the same location the MBM plugin does.

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


[PATCH v3 1/7] plugins/ste: Include STK support from MBM driver.

2010-08-16 Thread Sjur Brændeland
From: Sjur Brændeland 

---
Marcel Holtmann wrote:
> ... The build system builds the plugins
> properly and you can cross reference modem drivers from your modem
> plugin without any problems.

Simply refering to MBM driver from ste.c

 plugins/ste.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/plugins/ste.c b/plugins/ste.c
index f3ae0b2..9cb49d3 100644
--- a/plugins/ste.c
+++ b/plugins/ste.c
@@ -54,6 +54,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -241,6 +242,7 @@ static void ste_post_sim(struct ofono_modem *modem)
 
gprs = ofono_gprs_create(modem,
OFONO_VENDOR_STE, "atmodem", data->chat);
+   ofono_stk_create(modem, 0, "mbmmodem", data->chat);
gc = ofono_gprs_context_create(modem, 0, "stemodem", data->chat);
 
if (gprs && gc)
-- 
1.6.3.3

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono