[RFC online/offline atoms PATCH 4/4] isigen: create sms and gprs in post_sim

2010-10-05 Thread Pekka . Pessi 
From: Pekka Pessi pekka.pe...@nokia.com

---
 plugins/isigen.c |   20 ++--
 1 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/plugins/isigen.c b/plugins/isigen.c
index db61fdb..d550a34 100644
--- a/plugins/isigen.c
+++ b/plugins/isigen.c
@@ -395,22 +395,29 @@ static void isigen_pre_sim(struct ofono_modem *modem)
 static void isigen_post_sim(struct ofono_modem *modem)
 {
struct isi_data *isi = ofono_modem_get_data(modem);
+   struct ofono_gprs *gprs;
+   struct ofono_gprs_context *gc;
 
DBG((%p) with %s, modem, isi-ifname);
 
ofono_phonebook_create(isi-modem, 0, isimodem, isi-idx);
+   ofono_sms_create(isi-modem, 0, isimodem, isi-idx);
+   gprs = ofono_gprs_create(isi-modem, 0, isimodem, isi-idx);
+   gc = ofono_gprs_context_create(isi-modem, 0, isimodem, isi-idx);
+
+   if (gprs  gc)
+   ofono_gprs_add_context(gprs, gc);
+   else
+   DBG(Failed to add context);
 }
 
 static void isigen_post_online(struct ofono_modem *modem)
 {
struct isi_data *isi = ofono_modem_get_data(modem);
-   struct ofono_gprs *gprs;
-   struct ofono_gprs_context *gc;
 
DBG((%p) with %s, modem, isi-ifname);
 
ofono_netreg_create(isi-modem, 0, isimodem, isi-idx);
-   ofono_sms_create(isi-modem, 0, isimodem, isi-idx);
ofono_cbs_create(isi-modem, 0, isimodem, isi-idx);
ofono_ssn_create(isi-modem, 0, isimodem, isi-idx);
ofono_ussd_create(isi-modem, 0, isimodem, isi-idx);
@@ -419,13 +426,6 @@ static void isigen_post_online(struct ofono_modem *modem)
ofono_call_barring_create(isi-modem, 0, isimodem, isi-idx);
ofono_call_meter_create(isi-modem, 0, isimodem, isi-idx);
ofono_radio_settings_create(isi-modem, 0, isimodem, isi-idx);
-   gprs = ofono_gprs_create(isi-modem, 0, isimodem, isi-idx);
-   gc = ofono_gprs_context_create(isi-modem, 0, isimodem, isi-idx);
-
-   if (gprs  gc)
-   ofono_gprs_add_context(gprs, gc);
-   else
-   DBG(Failed to add context);
 }
 
 static struct ofono_modem_driver driver = {
-- 
1.7.0.4

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: [RFC online/offline atoms PATCH 4/4] isigen: create sms and gprs in post_sim

2010-10-05 Thread Marcel Holtmann 
Hi Pekka,

 ---
  plugins/isigen.c |   20 ++--
  1 files changed, 10 insertions(+), 10 deletions(-)
 
 diff --git a/plugins/isigen.c b/plugins/isigen.c
 index db61fdb..d550a34 100644
 --- a/plugins/isigen.c
 +++ b/plugins/isigen.c
 @@ -395,22 +395,29 @@ static void isigen_pre_sim(struct ofono_modem *modem)
  static void isigen_post_sim(struct ofono_modem *modem)
  {
   struct isi_data *isi = ofono_modem_get_data(modem);
 + struct ofono_gprs *gprs;
 + struct ofono_gprs_context *gc;
  
   DBG((%p) with %s, modem, isi-ifname);
  
   ofono_phonebook_create(isi-modem, 0, isimodem, isi-idx);
 + ofono_sms_create(isi-modem, 0, isimodem, isi-idx);
 + gprs = ofono_gprs_create(isi-modem, 0, isimodem, isi-idx);
 + gc = ofono_gprs_context_create(isi-modem, 0, isimodem, isi-idx);

what advantage to we have from moving SMS and GPRS atom into the
post_sim state? I am trying to really understand what this is trying to
do and what is the difference of just doing it when in post_online
state.

Are we expecting SMS and GPRS to just bring the modem online if needed
or what is this about? I don't see how useful this could be.

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: [RFC online/offline atoms PATCH 4/4] isigen: create sms and gprs in post_sim

2010-10-05 Thread Denis Kenzior 
Hi Marcel,

 what advantage to we have from moving SMS and GPRS atom into the
 post_sim state? I am trying to really understand what this is trying to
 do and what is the difference of just doing it when in post_online
 state.

We'd like to be able to toggle GPRS settings even if in offline state.
There's nothing preventing us from creating / deleting / editing
contexts or setting the RoamingAllowed property for instance.

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono