RE: [PATCH] ifxmodem: Adding fast dormancy support to Infineon modem

2010-11-18 Thread Bastian, Waldo 
 According to the doc I have, modem implementation is quite close:
 
 Trigger Fast Dormancy +XFDOR
 This command triggers fast dormancy if all conditions are passed successful 
 it will be send 
 towards the network. There will be no confirmation if the request was 
 executed or not as in the 
 last extend the full execution belongs to the network.

+XFDOR triggers fast dormancy once iff conditions are suitable. oFono expects a 
mode where
fast dormancy is triggered automatically by the modem _anytime_ conditions have 
been suitable for the duration of a given timeout period. A command for such 
mode is not yet available in IFX FW as far as I know.

Cheers,
Waldo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

RE: [PATCH] ifxmodem: Adding fast dormancy support to Infineon modem

2010-11-18 Thread Marcel Holtmann 
Hi Waldo,

  Trigger Fast Dormancy +XFDOR
  This command triggers fast dormancy if all conditions are passed successful 
  it will be send 
  towards the network. There will be no confirmation if the request was 
  executed or not as in the 
  last extend the full execution belongs to the network.
 
 +XFDOR triggers fast dormancy once iff conditions are suitable. oFono expects 
 a mode where
 fast dormancy is triggered automatically by the modem _anytime_ conditions 
 have been suitable for the duration of a given timeout period. A command for 
 such mode is not yet available in IFX FW as far as I know.

that is what I remembered. Thanks for the clarification.

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: [PATCH] ifxmodem: Adding fast dormancy support to Infineon modem

2010-11-17 Thread Marcel Holtmann 
Hi Robertino,

 Initial patch to add fast dormancy to Infineon modem. Timeout is not
 supported yet.
 
 Thanks,
 -- r.
 
 ---
  drivers/ifxmodem/radio-settings.c |   40 
 -
  1 files changed, 39 insertions(+), 1 deletions(-)
 
 diff --git a/drivers/ifxmodem/radio-settings.c 
 b/drivers/ifxmodem/radio-settings.c
 index 89e97e7..68077db 100644
 --- a/drivers/ifxmodem/radio-settings.c
 +++ b/drivers/ifxmodem/radio-settings.c
 @@ -27,6 +27,7 @@
  #include string.h
  #include stdlib.h
  #include stdio.h
 +#include stdint.h
  #include errno.h
  
  #include glib.h
 @@ -45,6 +46,7 @@ static const char *xrat_prefix[] = { +XRAT:, NULL };
  
  struct radio_settings_data {
   GAtChat *chat;
 + uint16_t fast_dormancy;
  };
  
  static void xrat_query_cb(gboolean ok, GAtResult *result, gpointer user_data)
 @@ -196,12 +198,48 @@ static void ifx_radio_settings_remove(struct 
 ofono_radio_settings *rs)
   g_free(rsd);
  }
  
 +static void update_fast_dormancy(struct radio_settings_data *rsd)
 +{
 + char buf[20];
 +
 + snprintf(buf, sizeof(buf), AT+XFDOR=%u, rsd-fast_dormancy);

is this command for fast dormancy really doing exactly what is expected
according to doc/radio-settings.txt. In my last documentation from
Infineon, that is still not the case.

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono