Re: [PATCH] plugin: add plugin for Linktop/Teracom LW273 data card
Hi Amit, Just a gentle reminder that you should not top-post on this mailing list. On 02/10/2011 04:24 AM, Amit Mendapara wrote: I have have sent the patches again this morning (with cc to Denis). Would you please tell me what could be the reason here? I am sending the patches with git-send-email like this: git send-email --to ofono@ofono.org mailto:ofono@ofono.org origin I have configured `msmtp-mta` to send email through my GMail account. Your patches have now showed up (as mentioned earlier this was likely a GMail screwup.) Give us some time to review them. Thanks, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
RE: [PATCH] plugin: add plugin for Linktop/Teracom LW273 data card
Hi Amit, ofono-boun...@ofono.org wrote: Hi Amit, On 02/09/2011 10:56 AM, Amit Mendapara wrote: Hi Danis, I have submitted three patches as you suggested but no one has reviewed it. Would you tell me what else I can do to ensure it's been integrated in ofono? So it looks like GMail is losing patches again. Your patches do show up on the mailing list archives but not in my mailbox. Can you resend them again, and CC my private Email as well: denk...@gmail.com. Your patches neither showed up in my GMail nor in my company outlook. Only place it can be seen is in ofono mail archives. :( Regards, Jeevaka ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] plugin: add plugin for Linktop/Teracom LW273 data card
I have have sent the patches again this morning (with cc to Denis). Would you please tell me what could be the reason here? I am sending the patches with git-send-email like this: git send-email --to ofono@ofono.org origin I have configured `msmtp-mta` to send email through my GMail account. Regards -- Amit Mendapara On Thu, Feb 10, 2011 at 1:32 PM, jeevaka.badrap...@elektrobit.com wrote: Hi Amit, ofono-boun...@ofono.org wrote: Hi Amit, On 02/09/2011 10:56 AM, Amit Mendapara wrote: Hi Danis, I have submitted three patches as you suggested but no one has reviewed it. Would you tell me what else I can do to ensure it's been integrated in ofono? So it looks like GMail is losing patches again. Your patches do show up on the mailing list archives but not in my mailbox. Can you resend them again, and CC my private Email as well: denk...@gmail.com. Your patches neither showed up in my GMail nor in my company outlook. Only place it can be seen is in ofono mail archives. :( Regards, Jeevaka Please note: This e-mail may contain confidential information intended solely for the addressee. If you have received this e-mail in error, please do not disclose it to anyone, notify the sender promptly, and delete the message from your system. Thank you. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] plugin: add plugin for Linktop/Teracom LW273 data card
Hi Danis, I have submitted three patches as you suggested but no one has reviewed it. Would you tell me what else I can do to ensure it's been integrated in ofono? Regards -- Amit Mendapara On Mon, Feb 7, 2011 at 8:51 AM, Amit Mendapara mendapara.a...@gmail.comwrote: Hi Denis, Thanks you for your kind attention. I will resubmit as suggested. Regards -- Amit Mendapara On Fri, Feb 4, 2011 at 10:07 PM, Denis Kenzior denk...@gmail.com wrote: Hi Amit, On 02/03/2011 10:34 AM, Amit Mendapara wrote: The LW273 and LW272 devices are being distributed by BSNL in India with Teracom brand name. Both the devices have similar specs except data speed and having same usb id (230d:0001). Links: http://www.bsnl.in/service/3G/3G_files/3g.htm http://www.teracom.in/htmls/3G.html http://www.linktop.com.cn/en/Products.asp?FID=1LID=302 http://www.linktop.com.cn/en/Products.asp?FID=1LID=302 http://amit-mendapara.blogspot.com/2010/11/amazing-bsnl-3g.html Regards -- Amit Mendapara Thanks for your patch, but please resubmit it in a proper format for review. The easiest way to do that is git-send-email. Also, please have a look at the 'Submitting patches' section in the HACKING file of oFono. Ideally this should be a 3 patch series, one adding the linktop driver, one modifying udev and one modifying ofono.rules. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] plugin: add plugin for Linktop/Teracom LW273 data card
Hi Amit, On 02/09/2011 10:56 AM, Amit Mendapara wrote: Hi Danis, I have submitted three patches as you suggested but no one has reviewed it. Would you tell me what else I can do to ensure it's been integrated in ofono? So it looks like GMail is losing patches again. Your patches do show up on the mailing list archives but not in my mailbox. Can you resend them again, and CC my private Email as well: denk...@gmail.com. Thanks, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] plugin: add plugin for Linktop/Teracom LW273 data card
Hi Amit, On 02/03/2011 10:34 AM, Amit Mendapara wrote: The LW273 and LW272 devices are being distributed by BSNL in India with Teracom brand name. Both the devices have similar specs except data speed and having same usb id (230d:0001). Links: http://www.bsnl.in/service/3G/3G_files/3g.htm http://www.teracom.in/htmls/3G.html http://www.linktop.com.cn/en/Products.asp?FID=1LID=302 http://www.linktop.com.cn/en/Products.asp?FID=1LID=302 http://amit-mendapara.blogspot.com/2010/11/amazing-bsnl-3g.html Regards -- Amit Mendapara Thanks for your patch, but please resubmit it in a proper format for review. The easiest way to do that is git-send-email. Also, please have a look at the 'Submitting patches' section in the HACKING file of oFono. Ideally this should be a 3 patch series, one adding the linktop driver, one modifying udev and one modifying ofono.rules. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] plugin: add plugin for Linktop/Teracom LW273 data card
The LW273 and LW272 devices are being distributed by BSNL in India
with Teracom
brand name. Both the devices have similar specs except data speed and having
same
usb id (230d:0001).
Links:
http://www.bsnl.in/service/3G/3G_files/3g.htm
http://www.teracom.in/htmls/3G.html
http://www.linktop.com.cn/en/Products.asp?FID=1LID=302
http://amit-mendapara.blogspot.com/2010/11/amazing-bsnl-3g.html
Regards
--
Amit Mendapara
On Thu, Feb 3, 2011 at 8:33 PM, Amit Mendapara mendapara.a...@gmail.comwrote:
Signed-off-by: Amit Mendapara mendapara.a...@gmail.com
---
Makefile.am |3 +
plugins/linktop.c | 357
+++
plugins/ofono.rules |3 +
plugins/udev.c | 32 +
4 files changed, 395 insertions(+), 0 deletions(-)
create mode 100644 plugins/linktop.c
diff --git a/Makefile.am b/Makefile.am
index 758fb10..2fb8962 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -314,6 +314,9 @@ builtin_sources += plugins/nokia.c
builtin_modules += nokiacdma
builtin_sources += plugins/nokiacdma.c
+builtin_modules += linktop
+builtin_sources += plugins/linktop.c
+
if BLUETOOTH
builtin_modules += bluetooth
builtin_sources += plugins/bluetooth.c plugins/bluetooth.h
diff --git a/plugins/linktop.c b/plugins/linktop.c
new file mode 100644
index 000..7f552b5
--- /dev/null
+++ b/plugins/linktop.c
@@ -0,0 +1,357 @@
+/*
+ *
+ * oFono - Open Source Telephony
+ *
+ * Copyright (C) 2008-2010 Intel Corporation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
USA
+ *
+ */
+
+#ifdef HAVE_CONFIG_H
+#include config.h
+#endif
+
+#include stdio.h
+#include errno.h
+#include stdlib.h
+
+#include glib.h
+#include gatchat.h
+#include gattty.h
+
+#define OFONO_API_SUBJECT_TO_CHANGE
+#include ofono/plugin.h
+#include ofono/modem.h
+#include ofono/call-barring.h
+#include ofono/call-forwarding.h
+#include ofono/call-meter.h
+#include ofono/call-settings.h
+#include ofono/devinfo.h
+#include ofono/message-waiting.h
+#include ofono/netreg.h
+#include ofono/sim.h
+#include ofono/cbs.h
+#include ofono/sms.h
+#include ofono/ssn.h
+#include ofono/ussd.h
+#include ofono/call-volume.h
+#include ofono/voicecall.h
+#include ofono/gprs.h
+#include ofono/gprs-context.h
+#include ofono/phonebook.h
+#include ofono/radio-settings.h
+#include ofono/log.h
+
+#include drivers/atmodem/vendor.h
+#include drivers/atmodem/atutil.h
+
+static const char *none_prefix[] = { NULL };
+
+struct linktop_data {
+ GAtChat *modem;
+ GAtChat *control;
+ struct ofono_gprs *gprs;
+ struct ofono_gprs_context *gc;
+};
+
+static int linktop_probe(struct ofono_modem *modem)
+{
+ struct linktop_data *data;
+
+ DBG(%p, modem);
+
+ data = g_try_new0(struct linktop_data, 1);
+ if (data == NULL)
+ return -ENOMEM;
+
+ ofono_modem_set_data(modem, data);
+
+ return 0;
+}
+
+static void linktop_remove(struct ofono_modem *modem)
+{
+ struct linktop_data *data = ofono_modem_get_data(modem);
+
+ DBG(%p, modem);
+
+ ofono_modem_set_data(modem, NULL);
+
+ g_at_chat_unref(data-modem);
+ g_at_chat_unref(data-control);
+
+ g_free(data);
+}
+
+static void linktop_debug(const char *str, void *user_data)
+{
+const char *prefix = user_data;
+
+ofono_info(%s%s, prefix, str);
+}
+
+static GAtChat *open_device(struct ofono_modem *modem,
+ const char *key, char *debug)
+{
+ const char *device;
+ GAtSyntax *syntax;
+ GIOChannel *channel;
+ GAtChat *chat;
+
+ device = ofono_modem_get_string(modem, key);
+ if (device == NULL)
+ return NULL;
+
+ DBG(%s %s, key, device);
+
+ channel = g_at_tty_open(device, NULL);
+ if (channel == NULL)
+ return NULL;
+
+ syntax = g_at_syntax_new_gsm_permissive();
+ chat = g_at_chat_new(channel, syntax);
+ g_at_syntax_unref(syntax);
+ g_io_channel_unref(channel);
+
+ if (chat == NULL)
+ return NULL;
+
+ if (getenv(OFONO_AT_DEBUG))
+ g_at_chat_set_debug(chat, linktop_debug, debug);
+
+ return chat;
+}
+
+static void
