RE: [PATCH v3 2/2] plugins: add ctm create to ifx plugin

2011-01-14 Thread Predon, Frederic
Hi Marcel,

 -Original Message-
 From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On
 Behalf Of Marcel Holtmann
 Sent: Friday, January 14, 2011 1:15 AM
 To: ofono@ofono.org
 Subject: Re: [PATCH v3 2/2] plugins: add ctm create to ifx plugin
 
 Hi Jeevaka,
 
   plugins/ifx.c |2 ++
   1 files changed, 2 insertions(+), 0 deletions(-)
 
  diff --git a/plugins/ifx.c b/plugins/ifx.c
  index c0a69c2..08b0001 100644
  --- a/plugins/ifx.c
  +++ b/plugins/ifx.c
  @@ -57,6 +57,7 @@
   #include ofono/radio-settings.h
   #include ofono/audio-settings.h
   #include ofono/stk.h
  +#include ofono/ctm.h
   #include ofono/log.h
 
   #include drivers/atmodem/atutil.h
  @@ -700,6 +701,7 @@ static void ifx_post_sim(struct ofono_modem
 *modem)
 
  DBG(%p, modem);
 
  +   ofono_ctm_create(modem, 0, ifxmodem, data-dlcs[AUX_DLC]);
 
 so no emergency calls with CTM are possible? Or do we have to
 potentially also handle that?

Emergency calls with TTY are mandatory in the US so we have to handle that as 
well

Regards

Fred
-
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: Les Montalets- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


RE: [PATCH v3 2/2] plugins: add ctm create to ifx plugin

2011-01-14 Thread Kai.Vehmanen
Hi,

On 14 Jan 2011, Marcel Holtmann wrote:
  #include drivers/atmodem/atutil.h
 @@ -700,6 +701,7 @@ static void ifx_post_sim(struct ofono_modem
*modem)

  DBG(%p, modem);

 +ofono_ctm_create(modem, 0, ifxmodem, data-dlcs[AUX_DLC]);
 
 so no emergency calls with CTM are possible? Or do we have to
 potentially also handle that?

a very good point! So yes, TTY-enabled emergency calls are definitely
needed. And in fact, that's probably one of the _most_ important
use-cases for TTY there is (as you cannot send an SMS to the emergency 
center [1]).

[1] well, actually there are specs for this, and even trials, but 
it'll take ages before this gets widely deployed


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH v3 2/2] plugins: add ctm create to ifx plugin

2011-01-13 Thread Marcel Holtmann
Hi Jeevaka,

  plugins/ifx.c |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
 
 diff --git a/plugins/ifx.c b/plugins/ifx.c
 index c0a69c2..08b0001 100644
 --- a/plugins/ifx.c
 +++ b/plugins/ifx.c
 @@ -57,6 +57,7 @@
  #include ofono/radio-settings.h
  #include ofono/audio-settings.h
  #include ofono/stk.h
 +#include ofono/ctm.h
  #include ofono/log.h
  
  #include drivers/atmodem/atutil.h
 @@ -700,6 +701,7 @@ static void ifx_post_sim(struct ofono_modem *modem)
  
   DBG(%p, modem);
  
 + ofono_ctm_create(modem, 0, ifxmodem, data-dlcs[AUX_DLC]);

so no emergency calls with CTM are possible? Or do we have to
potentially also handle that?

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


RE: [PATCH v3 2/2] plugins: add ctm create to ifx plugin

2011-01-13 Thread Jeevaka.Badrappan
Hi Marcel,

ofono-boun...@ofono.org wrote:
 Hi Jeevaka,
 
  plugins/ifx.c |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
 
 diff --git a/plugins/ifx.c b/plugins/ifx.c index c0a69c2..08b0001
 100644 --- a/plugins/ifx.c
 +++ b/plugins/ifx.c
 @@ -57,6 +57,7 @@
  #include ofono/radio-settings.h
  #include ofono/audio-settings.h
  #include ofono/stk.h
 +#include ofono/ctm.h
  #include ofono/log.h
 
  #include drivers/atmodem/atutil.h
 @@ -700,6 +701,7 @@ static void ifx_post_sim(struct ofono_modem
 *modem) 
 
  DBG(%p, modem);
 
 +ofono_ctm_create(modem, 0, ifxmodem, data-dlcs[AUX_DLC]);
 
 so no emergency calls with CTM are possible? Or do we have to
 potentially also handle that? 
 

Emergency calls are possible. I'll move the ctm_create to pre_sim state.

Regards,
Jeevaka
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono