RE: [RFC PATCH 2/4] cell-info: Header file for cell-info atom

2010-12-21 Thread Bastian, Waldo
Shouldn't ofono_cell_info_results be defined here and included as an argument 
for
ofono_cell_info_query_cb_t ? 

Cheers,
Waldo 

-Original Message-
From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of 
Antti Paila
Sent: Tuesday, December 21, 2010 6:00 AM
To: ofono@ofono.org
Subject: [RFC PATCH 2/4] cell-info: Header file for cell-info atom

---
 include/cell-info.h |   66 +++
 1 files changed, 66 insertions(+), 0 deletions(-)
 create mode 100644 include/cell-info.h

diff --git a/include/cell-info.h b/include/cell-info.h
new file mode 100644
index 000..d9c7810
--- /dev/null
+++ b/include/cell-info.h
@@ -0,0 +1,66 @@
+/*
+ *
+ *  oFono - Open Source Telephony
+ *
+ *  Copyright (C) 2008-2010  Intel Corporation. All rights reserved.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License version 2 as
+ *  published by the Free Software Foundation.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program; if not, write to the Free Software
+ *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ *
+ */
+
+#ifndef __OFONO_CELL_INFO_H
+#define __OFONO_CELL_INFO_H
+
+#ifdef __cplusplus
+extern C {
+#endif
+
+#include ofono/types.h
+
+struct ofono_cell_info;
+
+typedef void (*ofono_cell_info_query_cb_t)(const struct ofono_error *error,
+   void *data);
+
+struct ofono_cell_info_driver {
+   const char *name;
+   int (*probe)(struct ofono_cell_info *ci,
+   unsigned int vendor,
+   void *data);
+   void (*remove)(struct ofono_cell_info *ci);
+   void (*query)(struct ofono_cell_info *ci,
+   ofono_cell_info_query_cb_t,
+   void *data);
+};
+
+struct ofono_cell_info *ofono_cell_info_create(struct ofono_modem *modem,
+   unsigned int vendor,
+   const char *driver,
+   void *data);
+
+void ofono_cell_info_register(struct ofono_cell_info *ci);
+void ofono_cell_info_remove(struct ofono_cell_info *ci);
+int ofono_cell_info_driver_register(struct ofono_cell_info_driver *driver);
+void ofono_cell_info_driver_unregister(struct ofono_cell_info_driver *driver);
+void *ofono_cell_info_get_data(struct ofono_cell_info *ci);
+void ofono_cell_info_set_data(struct ofono_cell_info *ci, void *cid);
+void ofono_cell_info_query_cb(const struct ofono_error *error,
+   void *data);
+
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* __OFONO_CELL_INFO_H */
-- 
1.7.1

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


RE: [RFC PATCH 2/4] cell-info: Header file for cell-info atom

2010-12-21 Thread antti.paila

 Shouldn't ofono_cell_info_results be defined here and included as an
 argument for
 ofono_cell_info_query_cb_t ?

Indeed that would make more sense. Now the ofono_cell_info_results is inside 
the ofono_cell_info, but of course if there are multiple requests sent to a 
modem the latter one will overwrite the former one.

-Antti
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono