Re: Segmentation fault on Downlink data transfer

2011-01-17 Thread Pargada, Carlos
Hi Denis,

 What is the exact setup that you're using?  Are you using GAtMux or the 
 kernel mux?

Actually the mux was the internal to oFono, Kernel MUX is planned for further 
versions.


 Can you check whether using synchronous writes to the TUN device fix your 
 problem?  E.g. in new_bytes of gatrawip.c.

Changing priority from G_PRIORITY_NORMAL to G_PRIORITY_HIGH avoid the issue of 
ring buffer overflow.
However  the ring buffer usage is at 2/3. This mean that 2 packets of 1420 are 
stored. A 3 one crash the system.

In Mobile data transfer, it is often the cases that  latency of packets can be 
much more greater that in wired network (RLC layer in Modem buffers incoming 
packet to reassemble its and deliver packet in right order of reception). In 
this case,  several packet can be delivered by the Modem in burst. If another 
packet are to closed, we get a new ring buffer overflow. This is why  I believe 
that this buffer need to be increase to avoid this situation.
Taking some logs (tcpdump, ofono and internal Modem logs) show that burst of 
packets often occurs.

So to Fix this issue 2 actions is required:


-  Set the G_PRIORITY_HIGH instead of NORMAL  in g_io_add_watch_full  
in g_io_set_write_handler function (avoid to change mechanism to synchronous 
mode)

-  Secure the ring buffer overflow increasing the size (for example to 
7100: capacity to store 5 Packets of 1420 bytes seems enough).

 For the dlc disconnection after a ring buffer overflow, I continue to suggest 
 to change the behavior. At the end user side, a shutdown of the Modem is not 
 the solution. There is not a Modem issue and  all others functionalities of 
 the Modem not need to be deactivate (ongoing Call drop if ongoing, No  
 Emergency Call available during reinitialisation, etc ...)

Give me your feedback for the fix and tell me If you want me to submit a patch 
with this proposition.

Regards

Carlos










-
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: Les Montalets- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


RE: Segmentation fault on Downlink data transfer

2011-01-13 Thread Bastian, Waldo
 Hi Marcel and Denis

 There is an issue on downlink data transfer on ifx modem.

Please note that ifx modem will switch over to in-kernel MUX for data handling 
once
the kernel MUX driver enhancements for network interface support have been 
accepted
into MeeGo.

Cheers,
Waldo

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono