Hi Jonas,
On 5/12/21 4:17 AM, Jonas Bonn wrote:
Hi Denis,
If we're going to get anywhere with this, the onus probably falls on you to do
some cleanup work on these patches. I'll write some comments on the patches and
maybe you can munge those into the commit messages...?
What now? ;)
Anyway, I am not taking this set since all patches seem to be whitespace damaged
and this needs cleanup anyway.
Bing Jupiter has been running this modem (uBlox SARA R4) for well over a year
with these patches so they are somewhat tested. That said, this modem isn't
without issues, but it appears to me that those are mostly firmware related at
this point. Yeah, not great advertising for the product; probably best to stay
away from it altogether, really...
This is driver code, so unless there's something obviously wrong I'm fine taking
it. But it should at least comply with doc/coding-style.txt and someone should
have ran checkpatch.pl against it to check for issues.
Given that a v6 is needed, do you want to work with Jupiter to make the
editorial changes to the commit descriptions?
Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org
