Re: [oi-dev] Whitespace in Makefiles in oi-userland keep causing Problems
On Mon, Oct 1, 2018 at 12:41 PM Joerg Schilling < joerg.schill...@fokus.fraunhofer.de> wrote: > Till Wegmüller wrote: > > > I managed to get it Working by hardcoding every Value with a Whitespace > > inside it in the Package manifest. > > > > Looks like the problem seems to be the way gmake passes Variables to > > pkgmogrify. It usualy does so by specifying -D $VARIABLE on the command > > line. That seems not to be working consistently. > > Well, it is obvious that you need double quotes to make this work > correctly, in > other words: you did not hit onne of the problems that are caused by > whitespace > handling in gmake. > FYI tracked down to an issue in pkg for the generation of intermediate manifests. > > Jörg > > -- > EMail:jo...@schily.net(home) Jörg Schilling D-13353 > Berlin > joerg.schill...@fokus.fraunhofer.de (work) Blog: > http://schily.blogspot.com/ > URL: http://cdrecord.org/private/ > http://sf.net/projects/schilytools/files/' > > ___ > oi-dev mailing list > oi-dev@openindiana.org > https://openindiana.org/mailman/listinfo/oi-dev > -- --- Praise the Caffeine embeddings ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Whitespace in Makefiles in oi-userland keep causing Problems
Till Wegmüller wrote: > I managed to get it Working by hardcoding every Value with a Whitespace > inside it in the Package manifest. > > Looks like the problem seems to be the way gmake passes Variables to > pkgmogrify. It usualy does so by specifying -D $VARIABLE on the command > line. That seems not to be working consistently. Well, it is obvious that you need double quotes to make this work correctly, in other words: you did not hit onne of the problems that are caused by whitespace handling in gmake. Jörg -- EMail:jo...@schily.net(home) Jörg Schilling D-13353 Berlin joerg.schill...@fokus.fraunhofer.de (work) Blog: http://schily.blogspot.com/ URL: http://cdrecord.org/private/ http://sf.net/projects/schilytools/files/' ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Whitespace in Makefiles in oi-userland keep causing Problems
On Fri, Sep 28, 2018 at 1:48 PM Till Wegmüller wrote: > I managed to get it Working by hardcoding every Value with a Whitespace > inside it in the Package manifest. > > Looks like the problem seems to be the way gmake passes Variables to > pkgmogrify. It usualy does so by specifying -D $VARIABLE on the command > line. That seems not to be working consistently. > > So lesson from that seems to be that we need to hardcode values with > whitespace into the manifest. > > Thanks for the pointers. > I am not sure this is the case, there are other instances of values with whitespaces. The way values are quoted should be influencial depending on how the recipe passes them to pkgmogrify. There is a similar problem with non-escaping dots in PKG_MACROS. > > Greetings > Till > > On 09/28/18 12:23 PM, Joerg Schilling wrote: > > Till Wegmüller wrote: > > > >> A Makefile like so: > >> > >> > >> COMPONENT_NAME=salt > >> COMPONENT_VERSION=2018.3.2 > >> COMPONENT_SUMMARY='Portable, distributed, remote execution and > >> configuration management system' > >> COMPONENT_PROJECT_URL=http://saltstack.com > >> COMPONENT_FMRI=system/management/$(COMPONENT_NAME) > >> COMPONENT_CLASSIFICATION='System/Administration and Configuration' > >> > >> > >> Something like COMPONENT_CLASSIFICATION would break pkgmogrify with: > >> pkgmogrify: File > >> > /export/home/toast/workspace/openindiana/userland/components/python/salt/build/manifest-i386-salt-27.p5m > >> line 18: Malformed action at position: 90: whitespace in key: > >> set name=info.classification > >> value=org.opensolaris.category.2008:System/Administration and > Configuration > > > > It would help if you could investigate and report on what happenes that > causes > > your problem and whether you are unhappy with "make" or with the called > > program... > > > > BTW: do you use "gmake" or make? > > gmake is known to have a buggy white space handling. > > > > Jörg > > > > ___ > oi-dev mailing list > oi-dev@openindiana.org > https://openindiana.org/mailman/listinfo/oi-dev -- --- Praise the Caffeine embeddings ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Whitespace in Makefiles in oi-userland keep causing Problems
I managed to get it Working by hardcoding every Value with a Whitespace inside it in the Package manifest. Looks like the problem seems to be the way gmake passes Variables to pkgmogrify. It usualy does so by specifying -D $VARIABLE on the command line. That seems not to be working consistently. So lesson from that seems to be that we need to hardcode values with whitespace into the manifest. Thanks for the pointers. Greetings Till On 09/28/18 12:23 PM, Joerg Schilling wrote: > Till Wegmüller wrote: > >> A Makefile like so: >> >> >> COMPONENT_NAME=salt >> COMPONENT_VERSION=2018.3.2 >> COMPONENT_SUMMARY='Portable, distributed, remote execution and >> configuration management system' >> COMPONENT_PROJECT_URL=http://saltstack.com >> COMPONENT_FMRI=system/management/$(COMPONENT_NAME) >> COMPONENT_CLASSIFICATION='System/Administration and Configuration' >> >> >> Something like COMPONENT_CLASSIFICATION would break pkgmogrify with: >> pkgmogrify: File >> /export/home/toast/workspace/openindiana/userland/components/python/salt/build/manifest-i386-salt-27.p5m >> line 18: Malformed action at position: 90: whitespace in key: >> set name=info.classification >> value=org.opensolaris.category.2008:System/Administration and Configuration > > It would help if you could investigate and report on what happenes that causes > your problem and whether you are unhappy with "make" or with the called > program... > > BTW: do you use "gmake" or make? > gmake is known to have a buggy white space handling. > > Jörg > ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Whitespace in Makefiles in oi-userland keep causing Problems
Reginald Beardsley via oi-dev wrote: > Whitespace in Makefiles has been a mess from the start. The story is that > Feldman realized that making distinctions between types of white space was a > bad idea. But he had a dozen users and didn't want to break their Makefiles. > And the Bourne shell is not much better on that score. What you can't see > can have devastating consequences, Looks like you missunderstood the concept. Some people have been unhappy with the concept that action lines need to start with an intial TAB. White space in variables is well defined: - initial whitespace is skipped - trailing whitespace is removed by SunPro Make but kept by gmake and smake, so be careful with # comment at the end of a variable assignement line. - white space in the middle is required by POSIX to be kept intact but gmake e.g. shrinks multiple white space to a single white space The reported problem does not seem to be related to these white space problems. Jörg -- EMail:jo...@schily.net(home) Jörg Schilling D-13353 Berlin joerg.schill...@fokus.fraunhofer.de (work) Blog: http://schily.blogspot.com/ URL: http://cdrecord.org/private/ http://sf.net/projects/schilytools/files/' ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Whitespace in Makefiles in oi-userland keep causing Problems
No Unfortunately not... And yes it seems to be a complete mess with whitespaces And it is pkgmogrify which complains. not Make itself On 09/28/18 10:03 AM, Alexander Pyhalov via oi-dev wrote: > Does > COMPONENT_CLASSIFICATION= System/Administration and Configuration > work? > > С уважением, > Александр Пыхалов, > программист отдела телекоммуникационной инфраструктуры > управления информационно-коммуникационной инфраструктуры ЮФУ > > > > От: Till Wegmüller > Отправлено: 27 сентября 2018 г. 22:03:14 > Кому: OpenIndiana Developer mailing list > Тема: [oi-dev] Whitespace in Makefiles in oi-userland keep causing > Problems > > Hello Fellow developers. > > I have a confusing Problem with our buildsystem. > Since today it keeps behaving Inconsistently when I have a Whitespace in > a Value of a variable. > > A Makefile like so: > > > COMPONENT_NAME=salt > COMPONENT_VERSION=2018.3.2 > COMPONENT_SUMMARY='Portable, distributed, remote execution and > configuration management system' > COMPONENT_PROJECT_URL=http://saltstack.com > COMPONENT_FMRI=system/management/$(COMPONENT_NAME) > COMPONENT_CLASSIFICATION='System/Administration and Configuration' > > > Something like COMPONENT_CLASSIFICATION would break pkgmogrify with: > pkgmogrify: File > /export/home/toast/workspace/openindiana/userland/components/python/salt/build/manifest-i386-salt-27.p5m > line 18: Malformed action at position: 90: whitespace in key: > set name=info.classification > value=org.opensolaris.category.2008:System/Administration and Configuration > > I could manage to supress this by using escape characters like " or '. > But not in all cases. And with the Classification the Whitespaces are > required as that Category has Whitespaces in their name. Thus it won't > publish. > > I remember that Whitespaces where no problem not long ago. How will we > handle this? Packages like puppet and many others have also Whitespaces > in the Makefiles. > > Greetings > Till > > ___ > oi-dev mailing list > oi-dev@openindiana.org > https://openindiana.org/mailman/listinfo/oi-dev > ___ > oi-dev mailing list > oi-dev@openindiana.org > https://openindiana.org/mailman/listinfo/oi-dev > ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Whitespace in Makefiles in oi-userland keep causing Problems
Does COMPONENT_CLASSIFICATION= System/Administration and Configuration work? С уважением, Александр Пыхалов, программист отдела телекоммуникационной инфраструктуры управления информационно-коммуникационной инфраструктуры ЮФУ От: Till Wegmüller Отправлено: 27 сентября 2018 г. 22:03:14 Кому: OpenIndiana Developer mailing list Тема: [oi-dev] Whitespace in Makefiles in oi-userland keep causing Problems Hello Fellow developers. I have a confusing Problem with our buildsystem. Since today it keeps behaving Inconsistently when I have a Whitespace in a Value of a variable. A Makefile like so: COMPONENT_NAME=salt COMPONENT_VERSION=2018.3.2 COMPONENT_SUMMARY='Portable, distributed, remote execution and configuration management system' COMPONENT_PROJECT_URL=http://saltstack.com COMPONENT_FMRI=system/management/$(COMPONENT_NAME) COMPONENT_CLASSIFICATION='System/Administration and Configuration' Something like COMPONENT_CLASSIFICATION would break pkgmogrify with: pkgmogrify: File /export/home/toast/workspace/openindiana/userland/components/python/salt/build/manifest-i386-salt-27.p5m line 18: Malformed action at position: 90: whitespace in key: set name=info.classification value=org.opensolaris.category.2008:System/Administration and Configuration I could manage to supress this by using escape characters like " or '. But not in all cases. And with the Classification the Whitespaces are required as that Category has Whitespaces in their name. Thus it won't publish. I remember that Whitespaces where no problem not long ago. How will we handle this? Packages like puppet and many others have also Whitespaces in the Makefiles. Greetings Till ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Whitespace in Makefiles in oi-userland keep causing Problems
Whitespace in Makefiles has been a mess from the start. The story is that Feldman realized that making distinctions between types of white space was a bad idea. But he had a dozen users and didn't want to break their Makefiles. And the Bourne shell is not much better on that score. What you can't see can have devastating consequences, On Thu, 9/27/18, Till Wegmüller wrote: Subject: [oi-dev] Whitespace in Makefiles in oi-userland keep causing Problems To: "OpenIndiana Developer mailing list" Date: Thursday, September 27, 2018, 2:03 PM Hello Fellow developers. I have a confusing Problem with our buildsystem. Since today it keeps behaving Inconsistently when I have a Whitespace in a Value of a variable. A Makefile like so: COMPONENT_NAME=salt COMPONENT_VERSION=2018.3.2 COMPONENT_SUMMARY='Portable, distributed, remote execution and configuration management system' COMPONENT_PROJECT_URL=http://saltstack.com COMPONENT_FMRI=system/management/$(COMPONENT_NAME) COMPONENT_CLASSIFICATION='System/Administration and Configuration' Something like COMPONENT_CLASSIFICATION would break pkgmogrify with: pkgmogrify: File /export/home/toast/workspace/openindiana/userland/components/python/salt/build/manifest-i386-salt-27.p5m line 18: Malformed action at position: 90: whitespace in key: set name=info.classification value=org.opensolaris.category.2008:System/Administration and Configuration I could manage to supress this by using escape characters like " or '. But not in all cases. And with the Classification the Whitespaces are required as that Category has Whitespaces in their name. Thus it won't publish. I remember that Whitespaces where no problem not long ago. How will we handle this? Packages like puppet and many others have also Whitespaces in the Makefiles. Greetings Till ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
[oi-dev] Whitespace in Makefiles in oi-userland keep causing Problems
Hello Fellow developers. I have a confusing Problem with our buildsystem. Since today it keeps behaving Inconsistently when I have a Whitespace in a Value of a variable. A Makefile like so: COMPONENT_NAME=salt COMPONENT_VERSION=2018.3.2 COMPONENT_SUMMARY='Portable, distributed, remote execution and configuration management system' COMPONENT_PROJECT_URL=http://saltstack.com COMPONENT_FMRI=system/management/$(COMPONENT_NAME) COMPONENT_CLASSIFICATION='System/Administration and Configuration' Something like COMPONENT_CLASSIFICATION would break pkgmogrify with: pkgmogrify: File /export/home/toast/workspace/openindiana/userland/components/python/salt/build/manifest-i386-salt-27.p5m line 18: Malformed action at position: 90: whitespace in key: set name=info.classification value=org.opensolaris.category.2008:System/Administration and Configuration I could manage to supress this by using escape characters like " or '. But not in all cases. And with the Classification the Whitespaces are required as that Category has Whitespaces in their name. Thus it won't publish. I remember that Whitespaces where no problem not long ago. How will we handle this? Packages like puppet and many others have also Whitespaces in the Makefiles. Greetings Till ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
