Re: [Okular-devel] Review Request 109009: Txt backend for okular
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109009/#review27688 --- This review has been submitted with commit 74420f1baac621f6822ed9c5212e6004711d695a by Albert Astals Cid on behalf of Azat Khuzhin to branch master. - Commit Hook On Feb. 18, 2013, 11:07 p.m., Azat Khuzhin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109009/ --- (Updated Feb. 18, 2013, 11:07 p.m.) Review request for Okular and Albert Astals Cid. Description --- Simple txt backend for okular. Development history: https://github.com/azat/okular/compare/master...add-txt-support From mailing list: http://comments.gmane.org/gmane.comp.kde.devel.okular/13279 Diffs - generators/txt/document.cpp PRE-CREATION generators/txt/generator_txt.h PRE-CREATION generators/txt/generator_txt.cpp PRE-CREATION generators/txt/libokularGenerator_txt.desktop PRE-CREATION generators/txt/okularApplication_txt.desktop PRE-CREATION generators/txt/okularTxt.desktop PRE-CREATION generators/CMakeLists.txt 5a101bf generators/txt/CMakeLists.txt PRE-CREATION generators/txt/active-documentviewer_txt.desktop PRE-CREATION generators/txt/converter.h PRE-CREATION generators/txt/converter.cpp PRE-CREATION generators/txt/document.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109009/diff/ Testing --- Tested manually. Thanks, Azat Khuzhin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 108958: Use cached KStatefulBrushes in sidebar list delegate
On Feb. 15, 2013, 8:34 a.m., Frank Reininghaus wrote: Just found the link to this review request in bug 315061. I can't comment on whether this approach is suitable for Okular, but here is one idea: Couldn't one make it a bit simpler by using QScopedPointer? This would remove the need to delete manually. You would just have to use QScopedPointer::reset() to assign the pointers in SidebarDelegate::updateBrushCache(). Yep, sounds good. - Eike --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108958/#review27500 --- On Feb. 14, 2013, 1:20 p.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108958/ --- (Updated Feb. 14, 2013, 1:20 p.m.) Review request for Okular. Description --- Port the sidebar list delegate to using cached KStatefulBrushes. The cache is invalidated on global color scheme changes. This avoids instanciating a KColorScheme on every paint. Diffs - ui/sidebar.h f3f5ebd ui/sidebar.cpp a73779d Diff: http://git.reviewboard.kde.org/r/108958/diff/ Testing --- Thanks, Eike Hein ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 108958: Use cached KStatefulBrushes in sidebar list delegate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108958/#review27713 --- This review has been submitted with commit db1eb41171bf3ae5ddf2c1ad2e6ac1f459c33c65 by Eike Hein to branch master. - Commit Hook On Feb. 14, 2013, 1:20 p.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108958/ --- (Updated Feb. 14, 2013, 1:20 p.m.) Review request for Okular. Description --- Port the sidebar list delegate to using cached KStatefulBrushes. The cache is invalidated on global color scheme changes. This avoids instanciating a KColorScheme on every paint. Diffs - ui/sidebar.h f3f5ebd ui/sidebar.cpp a73779d Diff: http://git.reviewboard.kde.org/r/108958/diff/ Testing --- Thanks, Eike Hein ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found
On Feb. 19, 2013, 8:59 p.m., Albert Astals Cid wrote: You prefer this over the TryExec solution? Works for me. Please make sure you commit this to KDE/4.10 first and then merge to master (you'll have to take care the txt backend is only in master) hmm, yeah, in this case in distributions if they are packaged separately then only okular desktop is installed the same problem would still occur will convert to TryExec. however iirc i think okular active was merged shortly after 4.10, at least i don't have it in KDE/4.10 branch - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/#review27744 --- On Feb. 19, 2013, 8:04 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/ --- (Updated Feb. 19, 2013, 8:04 p.m.) Review request for Okular. Description --- this should solve https://bugs.kde.org/show_bug.cgi?id=314981 when the active app is not compiled the active desktop files don't get installed Diffs - CMakeLists.txt e40cfd6 active/CMakeLists.txt 1a8ff74 generators/chm/CMakeLists.txt e54affc generators/comicbook/CMakeLists.txt 4df23a6 generators/djvu/CMakeLists.txt 8ca545c generators/dvi/CMakeLists.txt 30b7394 generators/epub/CMakeLists.txt f076ed9 generators/fax/CMakeLists.txt f3a321c generators/fictionbook/CMakeLists.txt 4fe3877 generators/kimgio/CMakeLists.txt b0a61eb generators/ooo/CMakeLists.txt 5d11daf generators/plucker/CMakeLists.txt c376467 generators/poppler/CMakeLists.txt 0964fff generators/spectre/CMakeLists.txt 617047a generators/tiff/CMakeLists.txt bab056f generators/txt/CMakeLists.txt 5a126b7 generators/xps/CMakeLists.txt 6bd8e58 Diff: http://git.reviewboard.kde.org/r/109047/diff/ Testing --- tried to install both with and without active_found Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found
On Feb. 19, 2013, 8:59 p.m., Albert Astals Cid wrote: You prefer this over the TryExec solution? Works for me. Please make sure you commit this to KDE/4.10 first and then merge to master (you'll have to take care the txt backend is only in master) Marco Martin wrote: hmm, yeah, in this case in distributions if they are packaged separately then only okular desktop is installed the same problem would still occur will convert to TryExec. however iirc i think okular active was merged shortly after 4.10, at least i don't have it in KDE/4.10 branch Albert Astals Cid wrote: okular active is definitely there in the KDE/4.10 branch, see http://quickgit.kde.org/?p=okular.gita=treehb=fd22b42b264f6f8e35934eb8fb5a6a0e1d1313ae ah, yeah, i see, okular active was there, but all the mimetypes were in the only desktop file of the app, were moved to different desktop files for generators afterwards. do i port 4.10 to separate desktop files as well, or leave only master? - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/#review27744 --- On Feb. 19, 2013, 8:04 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/ --- (Updated Feb. 19, 2013, 8:04 p.m.) Review request for Okular. Description --- this should solve https://bugs.kde.org/show_bug.cgi?id=314981 when the active app is not compiled the active desktop files don't get installed Diffs - CMakeLists.txt e40cfd6 active/CMakeLists.txt 1a8ff74 generators/chm/CMakeLists.txt e54affc generators/comicbook/CMakeLists.txt 4df23a6 generators/djvu/CMakeLists.txt 8ca545c generators/dvi/CMakeLists.txt 30b7394 generators/epub/CMakeLists.txt f076ed9 generators/fax/CMakeLists.txt f3a321c generators/fictionbook/CMakeLists.txt 4fe3877 generators/kimgio/CMakeLists.txt b0a61eb generators/ooo/CMakeLists.txt 5d11daf generators/plucker/CMakeLists.txt c376467 generators/poppler/CMakeLists.txt 0964fff generators/spectre/CMakeLists.txt 617047a generators/tiff/CMakeLists.txt bab056f generators/txt/CMakeLists.txt 5a126b7 generators/xps/CMakeLists.txt 6bd8e58 Diff: http://git.reviewboard.kde.org/r/109047/diff/ Testing --- tried to install both with and without active_found Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found
On Feb. 19, 2013, 8:59 p.m., Albert Astals Cid wrote: You prefer this over the TryExec solution? Works for me. Please make sure you commit this to KDE/4.10 first and then merge to master (you'll have to take care the txt backend is only in master) Marco Martin wrote: hmm, yeah, in this case in distributions if they are packaged separately then only okular desktop is installed the same problem would still occur will convert to TryExec. however iirc i think okular active was merged shortly after 4.10, at least i don't have it in KDE/4.10 branch Albert Astals Cid wrote: okular active is definitely there in the KDE/4.10 branch, see http://quickgit.kde.org/?p=okular.gita=treehb=fd22b42b264f6f8e35934eb8fb5a6a0e1d1313ae Marco Martin wrote: ah, yeah, i see, okular active was there, but all the mimetypes were in the only desktop file of the app, were moved to different desktop files for generators afterwards. do i port 4.10 to separate desktop files as well, or leave only master? Ah right, sure, master fix only then, sorry - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/#review27744 --- On Feb. 19, 2013, 8:04 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/ --- (Updated Feb. 19, 2013, 8:04 p.m.) Review request for Okular. Description --- this should solve https://bugs.kde.org/show_bug.cgi?id=314981 when the active app is not compiled the active desktop files don't get installed Diffs - CMakeLists.txt e40cfd6 active/CMakeLists.txt 1a8ff74 generators/chm/CMakeLists.txt e54affc generators/comicbook/CMakeLists.txt 4df23a6 generators/djvu/CMakeLists.txt 8ca545c generators/dvi/CMakeLists.txt 30b7394 generators/epub/CMakeLists.txt f076ed9 generators/fax/CMakeLists.txt f3a321c generators/fictionbook/CMakeLists.txt 4fe3877 generators/kimgio/CMakeLists.txt b0a61eb generators/ooo/CMakeLists.txt 5d11daf generators/plucker/CMakeLists.txt c376467 generators/poppler/CMakeLists.txt 0964fff generators/spectre/CMakeLists.txt 617047a generators/tiff/CMakeLists.txt bab056f generators/txt/CMakeLists.txt 5a126b7 generators/xps/CMakeLists.txt 6bd8e58 Diff: http://git.reviewboard.kde.org/r/109047/diff/ Testing --- tried to install both with and without active_found Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 314981] active-documentviewer desktop files are installed even if app is not built
https://bugs.kde.org/show_bug.cgi?id=314981 Marco Martin notm...@gmail.com changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/okul ||ar/27c37c1fd1b87e8db40bfb3c ||46f1489559749286 --- Comment #2 from Marco Martin notm...@gmail.com --- Git commit 27c37c1fd1b87e8db40bfb3c46f1489559749286 by Marco Martin. Committed on 20/02/2013 at 11:14. Pushed by mart into branch 'master'. use TryExec to not appear when not installed when okular active is not installed, it should not appear in the open with menu, so add TryExec to see if the executable exists this is used instead of conditional install to make easier for distributions to package the desktop and active versions separately REVIEW:109047 M +1-0generators/chm/active-documentviewer_chm.desktop M +1-0generators/comicbook/active-documentviewer_comicbook.desktop M +1-0generators/djvu/active-documentviewer_djvu.desktop M +1-0generators/dvi/active-documentviewer_dvi.desktop M +1-0generators/epub/active-documentviewer_epub.desktop M +1-0generators/fax/active-documentviewer_fax.desktop M +1-0generators/fictionbook/active-documentviewer_fb.desktop M +1-0generators/kimgio/active-documentviewer_kimgio.desktop M +1-0generators/ooo/active-documentviewer_ooo.desktop M +1-0generators/plucker/active-documentviewer_plucker.desktop M +1-0generators/poppler/active-documentviewer_pdf.desktop M +1-0generators/spectre/active-documentviewer_ghostview.desktop M +1-0generators/tiff/active-documentviewer_tiff.desktop M +1-0generators/txt/active-documentviewer_txt.desktop M +1-0generators/xps/active-documentviewer_xps.desktop http://commits.kde.org/okular/27c37c1fd1b87e8db40bfb3c46f1489559749286 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 314981] active-documentviewer desktop files are installed even if app is not built
https://bugs.kde.org/show_bug.cgi?id=314981 --- Comment #3 from Marco Martin notm...@gmail.com --- i added tryexec in the end so distributions can't include all that is in generators in the same package without having to worry to move out the files of active, if they want to make separate packages of both -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315504] New: Formular content is not printed anymore
https://bugs.kde.org/show_bug.cgi?id=315504 Bug ID: 315504 Summary: Formular content is not printed anymore Classification: Unclassified Product: okular Version: 0.16.0 Platform: Ubuntu Packages OS: Linux Status: CONFIRMED Severity: normal Priority: NOR Component: PDF backend Assignee: okular-devel@kde.org Reporter: earthwi...@gentoo.org I remember okular printing formular content (the text you filled in) fine. That does not seem to work anymore in KDE 4.10.0. Reproducible: Always -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315432] Okular crash when opening pdf file (kde 4.10)
https://bugs.kde.org/show_bug.cgi?id=315432 --- Comment #6 from vyacheslav galdra...@bk.ru --- While running through valrgind okular does not crash. But without valrgind it does. I think crash conditions depends on CPU speed on fast CPU (core i7) crash happen after 1-2 seconds, on slower CPU crash happen after 5-10 seconds. When running valrgind execution very slow so it does not crash -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315432] Okular crash when opening pdf file (kde 4.10)
https://bugs.kde.org/show_bug.cgi?id=315432 --- Comment #7 from Albert Astals Cid aa...@kde.org --- Attach the output of valgrind please -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315432] Okular crash when opening pdf file (kde 4.10)
https://bugs.kde.org/show_bug.cgi?id=315432 --- Comment #8 from vyacheslav galdra...@bk.ru --- ==7948== Memcheck, a memory error detector ==7948== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al. ==7948== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info ==7948== Command: okular okular_crash.pdf ==7948== okular(7948)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: okular(7948)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: okular(7948)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: okular(7948)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: ==7948== Conditional jump or move depends on uninitialised value(s) ==7948==at 0x1782A0D7: ??? (in /usr/lib/kde4/okularpart.so) ==7948==by 0x5FD6C14: QWidget::event(QEvent*) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x6381D35: QFrame::event(QEvent*) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x1782833C: ??? (in /usr/lib/kde4/okularpart.so) ==7948==by 0x70A5815: QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) (in /usr/lib/libQtCore.so.4.8.4) ==7948==by 0x5F8715B: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x5F8B609: QApplication::notify(QObject*, QEvent*) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x5997425: KApplication::notify(QObject*, QEvent*) (in /usr/lib/libkdeui.so.5.10.0) ==7948==by 0x70A56AD: QCoreApplication::notifyInternal(QObject*, QEvent*) (in /usr/lib/libQtCore.so.4.8.4) ==7948==by 0x601A9D3: QWidgetPrivate::setGeometry_sys(int, int, int, int, bool) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x5FD1534: QWidget::setGeometry(QRect const) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x6400BAD: QAbstractScrollAreaPrivate::layoutChildren() (in /usr/lib/libQtGui.so.4.8.4) ==7948== ==7948== Invalid read of size 8 ==7948==at 0x5F7F39A: ??? (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x614941C: ??? (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x6152EB5: ??? (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x60D584C: QPainter::drawPixmap(QPointF const, QPixmap const) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x121B680B: ??? (in /usr/lib/kde4/plugins/styles/qtcurve.so) ==7948==by 0x121B7353: ??? (in /usr/lib/kde4/plugins/styles/qtcurve.so) ==7948==by 0x121CDE62: ??? (in /usr/lib/kde4/plugins/styles/qtcurve.so) ==7948==by 0x121C7545: ??? (in /usr/lib/kde4/plugins/styles/qtcurve.so) ==7948==by 0x63D02C6: QScrollBar::paintEvent(QPaintEvent*) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x5FD69FD: QWidget::event(QEvent*) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x63D01CA: QScrollBar::event(QEvent*) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x5F8718B: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/libQtGui.so.4.8.4) ==7948== Address 0x1c20d870 is 416 bytes inside a block of size 420 alloc'd ==7948==at 0x4C2C04B: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==7948==by 0x603D7C5: QImageData::create(QSize const, QImage::Format, int) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x603DCFA: QImage::QImage(int, int, QImage::Format) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x603ECBA: QImage::copy(QRect const) const (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x60649C8: QRasterPixmapData::copy(QPixmapData const*, QRect const) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x6057259: QPixmap::copy(QRect const) const (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x121B67DE: ??? (in /usr/lib/kde4/plugins/styles/qtcurve.so) ==7948==by 0x121B7353: ??? (in /usr/lib/kde4/plugins/styles/qtcurve.so) ==7948==by 0x121CDE62: ??? (in /usr/lib/kde4/plugins/styles/qtcurve.so) ==7948==by 0x121C7545: ??? (in /usr/lib/kde4/plugins/styles/qtcurve.so) ==7948==by 0x63D02C6: QScrollBar::paintEvent(QPaintEvent*) (in /usr/lib/libQtGui.so.4.8.4) ==7948==by 0x5FD69FD: QWidget::event(QEvent*) (in /usr/lib/libQtGui.so.4.8.4) ==7948== ==7948== Thread 3: ==7948== Mismatched free() / delete / delete [] ==7948==at 0x4C2A86C: operator delete(void*) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==7948==by 0x1D1230FC: TextStringToUCS4(GooString*, unsigned int**) (in /usr/lib/libpoppler.so.34.0.0) ==7948==by 0x1D147409: ActualText::end(GfxState*) (in /usr/lib/libpoppler.so.34.0.0) ==7948==by 0x1D0CEF00: Gfx::opEndMarkedContent(Object*, int) (in /usr/lib/libpoppler.so.34.0.0) ==7948==by 0x1D0D06D3: Gfx::go(bool) (in /usr/lib/libpoppler.so.34.0.0) ==7948==by 0x1D0D0B3F: Gfx::display(Object*, bool) (in /usr/lib/libpoppler.so.34.0.0) ==7948==by 0x1D11221B: Page::displaySlice(OutputDev*, double, double, int, bool, bool, int, int, int, int, bool, bool (*)(void*), void*, bool (*)(Annot*, void*), void*) (in /usr/lib/libpoppler.so.34.0.0) ==7948==by 0x1CDA092B: Poppler::Page::textList(Poppler::Page::Rotation) const (in /usr/lib/libpoppler-qt4.so.4.2.0)
[Okular-devel] [okular] [Bug 315432] Okular crash when opening pdf file (kde 4.10)
https://bugs.kde.org/show_bug.cgi?id=315432 --- Comment #9 from Albert Astals Cid aa...@kde.org --- Lots of bad stuff in there, that's poppler 0.22.0, right? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315432] Okular crash when opening pdf file (kde 4.10)
https://bugs.kde.org/show_bug.cgi?id=315432 --- Comment #10 from vyacheslav galdra...@bk.ru --- 0.22.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 173681] Large PDF pages cause Okular to crawl
https://bugs.kde.org/show_bug.cgi?id=173681 Stephan Burkhardt oceanofsola...@gmx.net changed: What|Removed |Added CC||oceanofsola...@gmx.net --- Comment #19 from Stephan Burkhardt oceanofsola...@gmx.net --- This looks partially fixed with okular 4.10. Looking at the pdf from comment#12 , I can at least look at the image at higher zoom levels (it's not 'blazingly' fast by any standards though, takes about at minute to render even a small part of the document). Kudos to the Okular developers for 4.10, okular got much better for me personally (finally more than 400% zoom!). -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315504] Formular content is not printed anymore
https://bugs.kde.org/show_bug.cgi?id=315504 Dennis Nienhüser earthwi...@gentoo.org changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #1 from Dennis Nienhüser earthwi...@gentoo.org --- Adobe Reader with Windows XP chokes in a similar way on the same file, so it seems more a buggy PDF than okular's fault. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 108614: Open url in browser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/ --- (Updated Feb. 20, 2013, 2:21 p.m.) Review request for Okular. Changes --- icon removed. Description --- When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser. This addresses bug 281027. http://bugs.kde.org/show_bug.cgi?id=281027 Diffs (updated) - ui/pageview.cpp 60a273d Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 173896] Sent-to menu entry or send-via-email menu-entry
https://bugs.kde.org/show_bug.cgi?id=173896 Robert Kehl robertk...@robertkehl.de changed: What|Removed |Added CC||robertk...@robertkehl.de --- Comment #18 from Robert Kehl robertk...@robertkehl.de --- A Send-As-Email functionality is very desirable. Restricting to kmail is not desirable, though; the system-wide email application should be used instead. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/#review27779 --- This review has been submitted with commit 27c37c1fd1b87e8db40bfb3c46f1489559749286 by Marco Martin to branch master. - Commit Hook On Feb. 19, 2013, 8:04 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/ --- (Updated Feb. 19, 2013, 8:04 p.m.) Review request for Okular. Description --- this should solve https://bugs.kde.org/show_bug.cgi?id=314981 when the active app is not compiled the active desktop files don't get installed Diffs - CMakeLists.txt e40cfd6 active/CMakeLists.txt 1a8ff74 generators/chm/CMakeLists.txt e54affc generators/comicbook/CMakeLists.txt 4df23a6 generators/djvu/CMakeLists.txt 8ca545c generators/dvi/CMakeLists.txt 30b7394 generators/epub/CMakeLists.txt f076ed9 generators/fax/CMakeLists.txt f3a321c generators/fictionbook/CMakeLists.txt 4fe3877 generators/kimgio/CMakeLists.txt b0a61eb generators/ooo/CMakeLists.txt 5d11daf generators/plucker/CMakeLists.txt c376467 generators/poppler/CMakeLists.txt 0964fff generators/spectre/CMakeLists.txt 617047a generators/tiff/CMakeLists.txt bab056f generators/txt/CMakeLists.txt 5a126b7 generators/xps/CMakeLists.txt 6bd8e58 Diff: http://git.reviewboard.kde.org/r/109047/diff/ Testing --- tried to install both with and without active_found Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315538] New: okular --unique *does* raise its existing window
https://bugs.kde.org/show_bug.cgi?id=315538 Bug ID: 315538 Summary: okular --unique *does* raise its existing window Classification: Unclassified Product: okular Version: 0.16.60 Platform: Archlinux Packages OS: Linux Status: UNCONFIRMED Severity: minor Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: tho...@t-8ch.de When controlling an existing instance of okular with okular --remote the exising instance will become the focused window. This has been requested in bugreport 304526. As there are usecases for both behaviours a config option or a commandline switch to okular --unique would be nice to have. Usecase: When using okular as previewer for synctex and forward search is triggered via an editor shortcut, okular claims focus which is taken from the editor. Thanks in advance! Reproducible: Always Steps to Reproduce: 1. Start okular with okular --unique 2. Call okular --unique some_file.pdf from a terminal Actual Results: The okular window gains focus. Expected Results: The terminal from which the second call was made keeps its focus. Happens on 0.16.0 and 27c37c1fd1b87e -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315538] okular --unique *does* raise its existing window
https://bugs.kde.org/show_bug.cgi?id=315538 Albert Astals Cid aa...@kde.org changed: What|Removed |Added CC||aa...@kde.org --- Comment #1 from Albert Astals Cid aa...@kde.org --- You are asking me to revert what we did because someone asked me to do what i did. How do we solve this? A --noraise param? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315552] New: Allow save annotations directly to original pdf file
https://bugs.kde.org/show_bug.cgi?id=315552 Bug ID: 315552 Summary: Allow save annotations directly to original pdf file Classification: Unclassified Product: okular Version: 0.16.0 Platform: Archlinux Packages OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: xgd...@msn.com Wish it can save with menu or ctrl+s directly to original file without file dialog. Reproducible: Always Steps to Reproduce: 1.annotate 2.try to save it Actual Results: have to use save as/save a copy as to save. Expected Results: allow directly save to original file by ctrl+s/FIle-Save/Toolbar-Save -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315538] okular --unique *does* raise its existing window
https://bugs.kde.org/show_bug.cgi?id=315538 --- Comment #2 from Thomas Weißschuh tho...@t-8ch.de --- I certainly do not want you to plain revert it. After all there is a usecase for the current behaviour. I only wanted to make you aware of a usecase for the behaviour before the change. A --noraise param would be perfect. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315538] okular --unique *does* raise its existing window
https://bugs.kde.org/show_bug.cgi?id=315538 Thomas Weißschuh tho...@t-8ch.de changed: What|Removed |Added CC||tho...@t-8ch.de -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
