Re: [Okular-devel] Review Request 111036: Add option to show table of contents in sidebar on startup (if present) instead of thumbnails
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111036/ --- (Updated July 22, 2013, 9:04 a.m.) Review request for Okular. Changes --- Updated diff not to use a checkbox. (For the record, I may not have been clear with my alternate suggestion. The suggested idea was inverting my previous checkbox logic, so the checkbox would read Show thumbnails instead on table of contents on startup, that could be activated by users that prefer the current behavior. However, not using a checkbox at all is OK, too.) Description --- This is a proposed implementation of the feature request I made in bug report #321169. This addresses bug 321169. http://bugs.kde.org/show_bug.cgi?id=321169 Diffs (updated) - part.h 4b3aafd part.cpp 138f755 Diff: http://git.reviewboard.kde.org/r/111036/diff/ Testing --- Thanks, Stefan Radermacher ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 111036: Add option to show table of contents in sidebar on startup (if present) instead of thumbnails
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111036/#review36280 --- part.cpp http://git.reviewboard.kde.org/r/111036/#comment26826 We are connecting hasTOC 13 lines up, do we need to connect it twice? - Albert Astals Cid On July 22, 2013, 9:04 a.m., Stefan Radermacher wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111036/ --- (Updated July 22, 2013, 9:04 a.m.) Review request for Okular. Description --- This is a proposed implementation of the feature request I made in bug report #321169. This addresses bug 321169. http://bugs.kde.org/show_bug.cgi?id=321169 Diffs - part.h 4b3aafd part.cpp 138f755 Diff: http://git.reviewboard.kde.org/r/111036/diff/ Testing --- Thanks, Stefan Radermacher ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 111036: Add option to show table of contents in sidebar on startup (if present) instead of thumbnails
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111036/ --- (Updated July 22, 2013, 10:12 a.m.) Review request for Okular. Changes --- You are correct. After the check for the eliminated checkbox has been removed, the connected methods can be combined, which actually reduces this patch to a single line. Description --- This is a proposed implementation of the feature request I made in bug report #321169. This addresses bug 321169. http://bugs.kde.org/show_bug.cgi?id=321169 Diffs (updated) - part.cpp 138f755 Diff: http://git.reviewboard.kde.org/r/111036/diff/ Testing --- Thanks, Stefan Radermacher ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 111640: Remove Magic Stuff from Epub Generator
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111640/ --- Review request for Okular. Description --- Guess this is more proper implementation. Diffs - generators/epub/converter.h 969dc9f generators/epub/converter.cpp 74df151 Diff: http://git.reviewboard.kde.org/r/111640/diff/ Testing --- Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 111554: SVG support for Epubs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111554/ --- (Updated July 22, 2013, 11:30 a.m.) Review request for Okular. Changes --- Now we don't need that mysterious 42. Description --- Epubs use the below syntax to load svg images svg image width=592 height=900 xlink:href=images/cover.svg / /svg I just replace that with img tags add QImage as a resource. Diffs (updated) - generators/epub/CMakeLists.txt 9442f61 generators/epub/converter.cpp 74df151 generators/epub/epubdocument.h 714ede6 Diff: http://git.reviewboard.kde.org/r/111554/diff/ Testing --- The below link contains two epub files having svg images as cover. https://www.dropbox.com/sh/xcqfwn8khbqac0d/vDRuFRw9vq Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 111410: Selection tool: copy/extract as vector graphic by calling pdftocairo
On July 7, 2013, 10:31 p.m., Albert Astals Cid wrote: The location of the code in pageview.cpp is therefore justified as the image and text extract code is located in the same class. However, I agree that pageview.cpp is rather large and should be refactored. That is not true, the the extraction of images and text is properly abstracted in the generator class and each file-type backend implements it in its own, or do you see the code that handles pdf text extraction in pageview.cpp? Albert Astals Cid wrote: So at Akademy we did a BoF about Okular, the decision about this feature was: * It is acceptable to call pdftocairo * The current way of organizing the code is not acceptable, it needs to be a generator supported feature, i.e. there needs to be API in generators so that they can say if they support this feature or not and if they do the code has to be in the generator side * The one second time limit needs to be removed and instead a dialog saying Exporting with a cancel button in case the process decides to run forever Do you think you can work in these improvements? Any question on how to proceed? I agree that the current code isn't really well-integrated. I will look into how to refactor the code to follow the generator structure. The exporting dialog can be added in a second step. I haven't looked into the details yet, but I'll contact you if I have problems. - Thomas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111410/#review35702 --- On July 7, 2013, 10:22 p.m., Thomas Fischer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111410/ --- (Updated July 7, 2013, 10:22 p.m.) Review request for Okular. Description --- This patch implements the feature request of bug 321350: if a PDF file is viewed, the selection tool offers the new extraction method vector which allows to save to a file (PDF, SVG, EPS, PostScript). The crop operation is performed by calling pdftocairo with matching arguments. The resulting file contains the original PDF file's content without rendering it to a pixmap. I am not sure if calling an external program is an acceptable solution for this problem. However, it is tested if the program is available before showing the new option. Alternatively, the code of pdftocairo (as part of poppler) would had to be copied and integrated into Okular increasing the solution's complexity. I am not aware of a similar solution available using poppler-qt4 only. Maybe using a QPrinter printing to PDF would have been an alternative, but again this seemed to be too complex. Diffs - ui/pageview.cpp 16b00ab Diff: http://git.reviewboard.kde.org/r/111410/diff/ Testing --- Thanks, Thomas Fischer ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 318798] Open PDF from command line with focus on annotation
https://bugs.kde.org/show_bug.cgi?id=318798 --- Comment #11 from Stephen Ewen stephen.e...@gmail.com --- - automatically copy the contents of highlighted text into a note annotation, so that Docear can read it and the user can modify it, e.g. by adding additional data or explanations. (This is a very useful feature in the PDF X-Change viewer) We don't do that, what's the use case for a standalone user? Why would someone need to create a note with the exact contents of the text he is highlighting? Specifically, the use case scenario is that other programmers can hook in to the highlighted text via the note annotation. In academic literature suites, users can then search their highlighted text, manipulate it in various ways, or add to it. For example, in Docear, when it is used with a PDF viewer that supports the standard way of handling highlighted, imports the highlighted text and automagically makes it part of a mind map. See the attached for a visual implementation of copying highlighted text in to a note. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322704] New: Okular crashes when opening epub document
https://bugs.kde.org/show_bug.cgi?id=322704 Bug ID: 322704 Summary: Okular crashes when opening epub document Classification: Unclassified Product: okular Version: 0.15.5 Platform: Ubuntu Packages OS: Linux Status: UNCONFIRMED Severity: crash Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: rhdi...@yahoo.com Application: okular (0.15.5) KDE Platform Version: 4.9.5 Qt Version: 4.8.3 Operating System: Linux 3.5.0-36-generic x86_64 Distribution: Ubuntu 12.10 -- Information about the crash: - What I was doing when the application crashed: I opened the document. Each time I open it it produces what appears to be an identical crash. The crash can be reproduced every time. -- Backtrace: Application: Okular (okular), signal: Segmentation fault Using host libthread_db library /lib/x86_64-linux-gnu/libthread_db.so.1. [Current thread is 1 (Thread 0x7ffd46922780 (LWP 5168))] Thread 2 (Thread 0x7ffd31462700 (LWP 5172)): #0 0x7ffd43b72313 in poll () from /lib/x86_64-linux-gnu/libc.so.6 #1 0x7ffd40771d84 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #2 0x7ffd407721e2 in g_main_loop_run () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #3 0x7ffd398804a6 in ?? () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0 #4 0x7ffd40795645 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #5 0x7ffd40c40e9a in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0 #6 0x7ffd43b7dccd in clone () from /lib/x86_64-linux-gnu/libc.so.6 #7 0x in ?? () Thread 1 (Thread 0x7ffd46922780 (LWP 5168)): [KCrash Handler] #5 0x7ffd43b13111 in ?? () from /lib/x86_64-linux-gnu/libc.so.6 #6 0x7ffd43b12d76 in strdup () from /lib/x86_64-linux-gnu/libc.so.6 #7 0x7ffd200fe378 in Epub::Converter::convert (this=0xf5efc0, fileName=...) at ../../../generators/epub/converter.cpp:183 #8 0x7ffd2342fdf4 in Okular::TextDocumentGenerator::loadDocument (this=optimized out, fileName=..., pagesVector=...) at ../core/textdocumentgenerator.cpp:255 #9 0x7ffd23415c27 in Okular::DocumentPrivate::openDocumentInternal (this=0xae6b10, offer=..., isstdin=isstdin@entry=false, docFile=..., filedata=...) at ../core/document.cpp:766 #10 0x7ffd2341e313 in Okular::Document::openDocument (this=0xac9190, docFile=..., url=..., _mime=...) at ../core/document.cpp:1770 #11 0x7ffd236d3096 in Okular::Part::openFile (this=0xaa23d0) at ../part.cpp:1194 #12 0x7ffd4650aae0 in ?? () from /usr/lib/libkparts.so.4 #13 0x7ffd4650b074 in KParts::ReadOnlyPart::openUrl(KUrl const) () from /usr/lib/libkparts.so.4 #14 0x7ffd236c6205 in openUrl (_url=..., this=0xaa23d0) at ../part.cpp:1321 #15 Okular::Part::openUrl (this=0xaa23d0, _url=...) at ../part.cpp:1292 #16 0x00408cd4 in Shell::openUrl (this=0xa7c810, url=...) at ../../shell/shell.cpp:141 #17 0x7ffd4455443e in QObject::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #18 0x7ffd44f710da in QWidget::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4 #19 0x7ffd4533a1cb in QMainWindow::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4 #20 0x7ffd45d1b7c8 in KXmlGuiWindow::event(QEvent*) () from /usr/lib/libkdeui.so.5 #21 0x7ffd44f21e9c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4 #22 0x7ffd44f2630a in QApplication::notify(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4 #23 0x7ffd45c2a1f6 in KApplication::notify(QObject*, QEvent*) () from /usr/lib/libkdeui.so.5 #24 0x7ffd4453f56e in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #25 0x7ffd445433f1 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #26 0x7ffd4456da63 in ?? () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #27 0x7ffd40771ab5 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #28 0x7ffd40771de8 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #29 0x7ffd40771ea4 in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #30 0x7ffd4456dbf6 in QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #31 0x7ffd44fc6c1e in ?? () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4 #32 0x7ffd4453e2bf in QEventLoop::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #33 0x7ffd4453e548 in QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #34 0x7ffd44543708 in QCoreApplication::exec() () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #35 0x004079ce in main (argc=optimized out, argv=optimized out) at
[Okular-devel] [okular] [Bug 322704] Okular crashes when opening epub document
https://bugs.kde.org/show_bug.cgi?id=322704 Albert Astals Cid aa...@kde.org changed: What|Removed |Added CC||aa...@kde.org, ||j.solank...@yahoo.com -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322704] Okular crashes when opening epub document
https://bugs.kde.org/show_bug.cgi?id=322704 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #1 from Albert Astals Cid aa...@kde.org --- Please attach the epub file Also, which libepub are you using? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322704] Okular crashes when opening epub document
https://bugs.kde.org/show_bug.cgi?id=322704 --- Comment #2 from Robert Dinah rhdi...@yahoo.com --- Created attachment 81278 -- https://bugs.kde.org/attachment.cgi?id=81278action=edit User Guide by Sony Corporation Please attach the epub file -- Done Also, which libepub are you using? -- The one provided by Ubuntu 12.10 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322704] Okular crashes when opening epub document
https://bugs.kde.org/show_bug.cgi?id=322704 --- Comment #3 from Albert Astals Cid aa...@kde.org --- The one provided by Ubuntu 12.10 is not an answer, please give us a version number. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322662] Okular freezes when trying to print PDF
https://bugs.kde.org/show_bug.cgi?id=322662 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |UPSTREAM --- Comment #4 from Albert Astals Cid aa...@kde.org --- Seems something changed in the expense pdf file that makes poppler unhappy, as you can see it has nothing to do with okular, just call pdftops on the original expenses file (without filing anything) and you'll see it also takes ages. Please open a bug at poppler bugzilla about this (i think i have a patch but still need to make sure it doesn't regress). https://bugs.freedesktop.org -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322547] Using a Dark Colorscheme frequently leads to unreadable text.
https://bugs.kde.org/show_bug.cgi?id=322547 --- Comment #3 from Wyatt Gosling wyatt.gosl...@gmail.com --- Here is a link (to be safe on copyright issues). http://library.mises.org/books/Murray%20N%20Rothbard/Man,%20Economy,%20and%20State,%20with%20Power%20and%20Market.epub -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 293109] Enable form filling in presentation mode
https://bugs.kde.org/show_bug.cgi?id=293109 --- Comment #4 from ree...@gmail.com --- Created attachment 81280 -- https://bugs.kde.org/attachment.cgi?id=81280action=edit Schematic: use of form elements of different kinds within a beamer slide set -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 293109] Enable form filling in presentation mode
https://bugs.kde.org/show_bug.cgi?id=293109 ree...@gmail.com changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|WONTFIX |--- --- Comment #5 from ree...@gmail.com --- Eek! Adding an attachment deletes unsaved comments?! OK. I just wrote a very detailed explanation of why full screen mode isn't right here. Short version: it does not treat the document as consisting of slides to be presented one after another, uncovered incrementally and so on. Instead, it treats them as pages of a document. I don't want to scroll through my slides when I'm presenting. All the usual presentation conventions apply - my slides are just more interactive than most. Moreover, presentation mode automatically adjusts the slide to the display dimensions; full screen mode just cuts stuff off. Presentation mode hides menu bars, tools etc. automatically; full screen mode does not. Presentation mode does not alter the default viewing set up of all my other pdfs; full screen mode apparently does. Basically, full screen mode is not suitable for a presentation and presentation mode is. These are presentations - slides - and not regular documents. Even if I adjusted the page dimensions to exactly scale, it would render my slides hardware specific and that's no good. (Not even sure you can do this with the beamer package.) Perhaps an example will help. Please find a schematic attached which I created for another developer working on a different viewer. This was created with the beamer latex package and features various form elements. It is also very clearly a set of slides designed as a presentation. (At least, it would be if it were not so schematic.) If you cannot or choose not to implement this feature, that's fine. But please do not tell me that what I really want is full screen mode. It is not. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322704] Okular crashes when opening epub document
https://bugs.kde.org/show_bug.cgi?id=322704 --- Comment #4 from Robert Dinah rhdi...@yahoo.com --- The one provided by Ubuntu 12.10 is not an answer, please give us a version number. What kind of unprofessional, rude remark are you making to me? Who do you think you are? Why is it not an answer? It most definititely is an answer to the question: Also, which libepub are you using? Do you think I'm going to pull the version number out of a hat? Rather than giving a smart aleck smack in the face to a user ... it would rather be more polite, professional AND ADULT to tell me where and how to get the information you need in the first place. Consider yourself fortunate I went to the bother to even report this. I'm trying to do you a favour and improve the product. Instead you throw smart aleck remarks. You should be ashamed of yourself. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322704] Okular crashes when opening epub document
https://bugs.kde.org/show_bug.cgi?id=322704 Yuri Chornoivan yurc...@ukr.net changed: What|Removed |Added CC||yurc...@ukr.net --- Comment #5 from Yuri Chornoivan yurc...@ukr.net --- (In reply to comment #4) The one provided by Ubuntu 12.10 is not an answer, please give us a version number. What kind of unprofessional, rude remark are you making to me? Who do you think you are? Why is it not an answer? It most definititely is an answer to the question: Also, which libepub are you using? Do you think I'm going to pull the version number out of a hat? Sorry, but Ubuntu is not the only one distribution with just one version. Moreover, Ubuntu 12.10-version can be anything from this list for QQ (at least 2 versions): https://launchpad.net/ubuntu/+source/okular it can be something from backports, it can be something from PPA. So the remark was very professional, concise and direct. Rather than giving a smart aleck smack in the face to a user ... it would rather be more polite, professional AND ADULT to tell me where and how to get the information you need in the first place. Consider yourself fortunate I went to the bother to even report this. I'm trying to do you a favour and improve the product. Instead you throw smart aleck remarks. You should be ashamed of yourself. Please start your package manager (it is not very hard to do) and spend some 20 seconds of your precious time by typing okular, then remembering the version and libepub and remembering the version. Then just copy and paste version numbers here. Thanks in advance for your hard work. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322704] Okular crashes when opening epub document
https://bugs.kde.org/show_bug.cgi?id=322704 --- Comment #6 from Robert Dinah rhdi...@yahoo.com --- Another wise guy? and spend some 20 seconds of your precious time ... Why should I bother with this ... in fact I won't ... keep your bug ... you have the file ... now spend some of your precious time and open the debugger ... and figure it out ... or don't ... -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322704] Okular crashes when opening epub document
https://bugs.kde.org/show_bug.cgi?id=322704 --- Comment #7 from Yuri Chornoivan yurc...@ukr.net --- This file does not crash Okular 0.17.60 with libepub 0.2.2 in Mageia 3 (x86-64). -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
