[Okular-devel] [okular] [Bug 325876] Loading of a 4.7 pdf takes too long

2013-10-16 Thread Martin Tlustos
https://bugs.kde.org/show_bug.cgi?id=325876

--- Comment #4 from Martin Tlustos martin.tlus...@gmail.com ---
Well, the package manager says libpoppler28, version 0.20.5-1ubuntu3 (whatever
that means). I installed qpdfview which also uses poppler, and it takes long as
well (although not as long as okular).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 326087] New: Wishlist: forward search and line highlighting

2013-10-16 Thread ioewe-mail
https://bugs.kde.org/show_bug.cgi?id=326087

Bug ID: 326087
   Summary: Wishlist: forward search and line highlighting
Classification: Unclassified
   Product: okular
   Version: unspecified
  Platform: unspecified
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: ioewe-m...@yahoo.de

When using forward search with Latex (e.g. from Auctex), Okular just opens the
correct page. It would be tremendously helpful if additionally the correct line
could be marked or highlighted. Not sure where I have seen that feature, but
some PDF viewers (i think) have it implemented so it may be theoretically
possible.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 326055] Okular crashed while searching and reloading a file

2013-10-16 Thread moritz89
https://bugs.kde.org/show_bug.cgi?id=326055

--- Comment #2 from morit...@gmail.com ---
It is not clear, in trying to reproduce the bug i hold the enter button pressed
to continuously search for the next term in a document ~30 pages long. I have
tried reproducing the bug by replacing a different much longer (~300 page)
document while it was searching, but with no success. After automatically
reloading the document and then searching, doesn't seem to be casing any
problems.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 326105] New: Review-Highlight/Note feature

2013-10-16 Thread cinaljess
https://bugs.kde.org/show_bug.cgi?id=326105

Bug ID: 326105
   Summary: Review-Highlight/Note feature
Classification: Unclassified
   Product: okular
   Version: 0.16.5
  Platform: Ubuntu Packages
OS: Linux
Status: UNCONFIRMED
  Keywords: drkonqi
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: cinalj...@gmail.com

Application: okular (0.16.5)
KDE Platform Version: 4.10.5
Qt Version: 4.8.4
Operating System: Linux 3.8.0-31-generic x86_64
Distribution: Ubuntu 13.04

-- Information about the crash:
- What I was doing when the application crashed:
Deleting a Review-created yellow highlighted region over text. Also to remove a
Review-created Note
These were preformed in a pdf document that originally was created using Google
Docs
Running most recent version of ubuntu on a 1 month young System76 Galago-pro
laptop

-- Backtrace:
Application: Okular (okular), signal: Aborted
Using host libthread_db library /lib/x86_64-linux-gnu/libthread_db.so.1.
[Current thread is 1 (Thread 0x7fe371a8b7c0 (LWP 15780))]

Thread 3 (Thread 0x7fe35e421700 (LWP 15783)):
#0  0x7fe36bbc3f90 in pthread_mutex_lock () from
/lib/x86_64-linux-gnu/libpthread.so.0
#1  0x7fe36b72e5c1 in g_mutex_lock () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7fe36b6ef1c2 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7fe36b6ef6ba in g_main_loop_run () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x7fe3648174f6 in ?? () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#5  0x7fe36b712eb5 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#6  0x7fe36bbc1f8e in start_thread () from
/lib/x86_64-linux-gnu/libpthread.so.0
#7  0x7fe36eab9e1d in clone () from /lib/x86_64-linux-gnu/libc.so.6

Thread 2 (Thread 0x7fe3479d6700 (LWP 15816)):
#0  0x7fe36eaad3cd in poll () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x7fe36b6ef1dc in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7fe36b6ef304 in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7fe36f4ad036 in QEventDispatcherGlib::processEvents
(this=0x7fe348c0, flags=...) at kernel/qeventdispatcher_glib.cpp:426
#4  0x7fe36f47d38f in QEventLoop::processEvents
(this=this@entry=0x7fe3479d5d90, flags=...) at kernel/qeventloop.cpp:149
#5  0x7fe36f47d618 in QEventLoop::exec (this=this@entry=0x7fe3479d5d90,
flags=...) at kernel/qeventloop.cpp:204
#6  0x7fe36f37f410 in QThread::exec (this=this@entry=0x13e8ee0) at
thread/qthread.cpp:542
#7  0x7fe36f45eedf in QInotifyFileSystemWatcherEngine::run (this=0x13e8ee0)
at io/qfilesystemwatcher_inotify.cpp:256
#8  0x7fe36f381bec in QThreadPrivate::start (arg=0x13e8ee0) at
thread/qthread_unix.cpp:338
#9  0x7fe36bbc1f8e in start_thread () from
/lib/x86_64-linux-gnu/libpthread.so.0
#10 0x7fe36eab9e1d in clone () from /lib/x86_64-linux-gnu/libc.so.6

Thread 1 (Thread 0x7fe371a8b7c0 (LWP 15780)):
[KCrash Handler]
#5  0x7fe36e9f7037 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#6  0x7fe36e9fa698 in abort () from /lib/x86_64-linux-gnu/libc.so.6
#7  0x7fe34684c8f3 in getRef (this=optimized out) at Object.h:200
#8  Page::removeAnnot (this=this@entry=0x166c590, annot=0x1a3e280) at
Page.cc:408
#9  0x7fe346b93e4f in Poppler::AnnotationPrivate::removeAnnotationFromPage
(pdfPage=optimized out, ann=0x1309720) at poppler-annotation.cc:534
#10 0x7fe346b8dbdc in Poppler::Page::removeAnnotation (this=optimized
out, ann=optimized out) at poppler-page.cc:586
#11 0x7fe346de2111 in PopplerAnnotationProxy::notifyRemoval
(this=optimized out, okl_ann=0x12a3bd0, page=0) at
../../../generators/poppler/annots.cpp:260
#12 0x7fe35451dfc5 in Okular::Document::removePageAnnotation
(this=0x1a74d90, page=0, annotation=0x12a3bd0) at ../core/document.cpp:2793
#13 0x7fe3547e2b61 in AnnotationPopup::exec
(this=this@entry=0x774523c0, point=...) at ../ui/annotationpopup.cpp:137
#14 0x7fe35481c52b in PageView::mousePressEvent (this=0x1adb010,
e=0x77452d10) at ../ui/pageview.cpp:2070
#15 0x7fe36feb5a70 in QWidget::event (this=this@entry=0x1adb010,
event=event@entry=0x77452d10) at kernel/qwidget.cpp:8371
#16 0x7fe370268486 in QFrame::event (this=0x1adb010, e=0x77452d10) at
widgets/qframe.cpp:557
#17 0x7fe35481d7fd in PageView::viewportEvent (this=0x1adb010,
e=0x77452d10) at ../ui/pageview.cpp:3053
#18 0x7fe36f47e7a6 in
QCoreApplicationPrivate::sendThroughObjectEventFilters
(this=this@entry=0xc5e520, receiver=receiver@entry=0x1ad9cb0,
event=event@entry=0x77452d10) at kernel/qcoreapplication.cpp:1056
#19 0x7fe36fe688bc in QApplicationPrivate::notify_helper
(this=this@entry=0xc5e520, receiver=receiver@entry=0x1ad9cb0,
e=e@entry=0x77452d10) at kernel/qapplication.cpp:4563
#20 0x7fe36fe6ba33 in QApplication::notify (this=optimized out,

[Okular-devel] [okular] [Bug 324427] Okular 4.11.00 (KDE 4.11.0) has crashed while refreshing a PDF file

2013-10-16 Thread auxsvr
https://bugs.kde.org/show_bug.cgi?id=324427

--- Comment #4 from aux...@gmail.com ---
Created attachment 82887
  -- https://bugs.kde.org/attachment.cgi?id=82887action=edit
New crash information added by DrKonqi

okular (0.17.2) on KDE Platform 4.11.2 using Qt 4.8.5

- What I was doing when the application crashed:

Okular was searching for a word, when I recompiled the tex document that
corresponds to the PDF file. Okular continued to search, even though the
document was not visible. After the compilation finished, it crashed with the
attached backtrace.

-- Backtrace (Reduced):
#6  0xb34b52f6 in Okular::Page::width (this=0xaf2b318) at
/usr/src/debug/okular-4.11.2/core/page.cpp:182
#7  0xb35d1c55 in PageView::updateItemSize (this=this@entry=0x8804410,
item=item@entry=0x9c73c00, colWidth=685, rowHeight=rowHeight@entry=459) at
/usr/src/debug/okular-4.11.2/ui/pageview.cpp:3263
#8  0xb35dc8de in PageView::slotRelayoutPages (this=this@entry=0x8804410) at
/usr/src/debug/okular-4.11.2/ui/pageview.cpp:3922
#9  0xb35e7ae8 in qt_static_metacall (_a=0xa342dd0, _id=15, _o=0x8804410,
_c=optimized out) at /usr/src/debug/okular-4.11.2/build/pageview.moc:168
#10 PageView::qt_static_metacall (_o=0x8804410,
_c=QMetaObject::InvokeMetaMethod, _id=15, _a=0xa342dd0) at
/usr/src/debug/okular-4.11.2/build/pageview.moc:147

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 324427] Okular 4.11.00 (KDE 4.11.0) has crashed while refreshing a PDF file

2013-10-16 Thread auxsvr
https://bugs.kde.org/show_bug.cgi?id=324427

aux...@gmail.com changed:

   What|Removed |Added

 CC||aux...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-10-16 Thread Jonathan Doman


 On Oct. 1, 2013, 6:57 p.m., Fabio D'Urso wrote:
  Hi! :)
  I have neither tested nor read the whole patch in depth, I've only had a 
  look at your description and made a few tests.
  
  We had a discussion at the okular BOF this summer, and we decided that it's 
  better to avoid having multiple open copies of the same document, because 
  this creates consistency issues if you are annotating (while saving, the 
  two instances will overwrite each other's changes). In the light of this, 
  I'm not sure Duplicate tab makes sense the way it is now. In my opinion, 
  a better approach would be to tie multiple PageViews to the same Document. 
  However, as the Document class currently assumes that there is only one 
  PageView, this requires significant changes, so we had better leave this 
  feature for a different patch.
  
  I see a lighter issue with the way Detach tab works: if you create a new 
  process you will 1) loose all cached pixmaps, 2) cause the 
  Part::queryClose() message to show up if there are unsaved annotations. (If 
  you want to reproduce this issue annotate a PDF, click save as, open the 
  file you saved, detach its tab).
  
  Both Duplicate tab and Detach tab fail at handling input from - 
  (standard input)
cat somePdfFile.pdf | okular -
  because, by definition, you can't read it twice.
  
  About the issue with moving menu items, I see that all you need to do is to 
  add the confirm_tabs_close checkbox, right? Maybe you can just add it to 
  the configuration dialog instead or drop it at all (for example the 
  warnings from document.cpp warnLimitedAnnotSupport() cannot be reactivated).

So should I remove the duplicate tab feature? It's possible in the master code 
to open the same document in two windows, and it would still be possible in 
this code to manually open the same document to get it in another tab. Is that 
going to be blocked in the future? If not, I don't see how duplication causes 
any additional problems.

Do you agree with the logic to open new documents in the MRU existing window? 
No one has given their opinion on this yet. If not, then it's easy to keep 
documents in the same process and I'll do that.

I'll take a look at the other stuff and upload a new diff when I get some time.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110914/#review41071
---


On Aug. 23, 2013, 8:06 p.m., Jonathan Doman wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/110914/
 ---
 
 (Updated Aug. 23, 2013, 8:06 p.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 155515
 http://bugs.kde.org/show_bug.cgi?id=155515
 
 
 Repository: okular
 
 
 Description
 ---
 
 This patch adds support for a tabbed interface (multiple documents in one 
 window). The core work just adds a tab bar that switches between multiple 
 embedded okularparts, but there are many other considerations:
  - Tab context menu allows for duplicating or detaching (detached tabs start 
 in new okular process)
  - `okular file.pdf` will open file in existing window if possible, unless 
 --new flag is used. It also selects the most recently raised/activated window 
 to use. This mirrors behavior I expect from browsers and other tabbed 
 interfaces.
  - Warns when closing window with multiple tabs
  - No warning is given when opening an already open file. This is the 
 behavior I strongly prefer (and observe in other programs), but will change 
 if there is consensus otherwise.
 
 When selecting different tools in one part, the tool selection propagates to 
 all parts, but the GUI does not reflect that. This bug is present in other 
 programs (e.g. multiple okularparts in Konqueror), so I made no attempt to 
 diagnose or fix.
 
 One menu item was added for the multiple tab warning option. When testing 
 this, I noticed that items in the Settings menu seem to move around when 
 switching tabs, and I cannot diagnose or fix this. It seems to be related to 
 XMLGUI bug #64754. 
 
 My development branch is also hosted at 
 https://github.com/jrmrjnck/okular-tabbed
 
 
 Diffs
 -
 
   part.h 4b3aafdb637080ae81eb0e45742f53a34738984d 
   part.cpp 71c3d0f5d908969ffcf18aba327297ccd2e1c8e1 
   shell/main.cpp e0ca587ba167c4020d5af5bd33a2dc1b4923cac4 
   shell/shell.h c065c560fb4ddfcf181601cf35e9ca14581731f6 
   shell/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983 
   shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 
 
 Diff: http://git.reviewboard.kde.org/r/110914/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jonathan Doman
 


___
Okular-devel mailing list
Okular-devel@kde.org

[Okular-devel] [okular] [Bug 325876] Loading of a 4.7 pdf takes too long

2013-10-16 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=325876

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #5 from Albert Astals Cid aa...@kde.org ---
I'm on poppler 0.24.1 so probably something that was fixed between 0.20.5 and
0.24.1

Please if you update to poppler 0.24.1 or newer and still have this problem
reopen the bug.

Thanks for caring about Okular :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] Mentorship at Google Code-In

2013-10-16 Thread Jaydeep Solanki
Hi,

I would like to know if anyone of you is going to be a mentor for Google
Code-In.

Also, can I be a mentor ? I was a GSoC 2013 student under KDE, Okular.

Cheers,
Jaydeep
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 326087] Wishlist: forward search and line highlighting

2013-10-16 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=326087

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid aa...@kde.org ---
You should probably try the kile with okular embedded that puts a line in the
preview inside the okular part.

I don't see how you would do it with a standalone okular since basically it
would mean that a third party thing would change your view, which is not so
cool.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Mentorship at Google Code-In

2013-10-16 Thread Albert Astals Cid
El Dijous, 17 d'octubre de 2013, a les 02:27:27, Jaydeep Solanki va escriure:
 Hi,

Hi

 I would like to know if anyone of you is going to be a mentor for Google
 Code-In.

I'm not planning to get involved.

 Also, can I be a mentor ? I was a GSoC 2013 student under KDE, Okular.

Sure, why not?

Cheers,
  Albert

P.S: We should find a day to try to go through your work and get it merged 
upstream before the 4.12 freeze date in 2 weeks.

Cheers,
  Albert

 
 Cheers,
 Jaydeep

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-10-16 Thread Albert Astals Cid
El Dimecres, 16 d'octubre de 2013, a les 18:36:52, Jonathan Doman va escriure:
  On Oct. 1, 2013, 6:57 p.m., Fabio D'Urso wrote:
   Hi! :)
   I have neither tested nor read the whole patch in depth, I've only had a
   look at your description and made a few tests.
   
   We had a discussion at the okular BOF this summer, and we decided that
   it's better to avoid having multiple open copies of the same document,
   because this creates consistency issues if you are annotating (while
   saving, the two instances will overwrite each other's changes). In the
   light of this, I'm not sure Duplicate tab makes sense the way it is
   now. In my opinion, a better approach would be to tie multiple
   PageViews to the same Document. However, as the Document class
   currently assumes that there is only one PageView, this requires
   significant changes, so we had better leave this feature for a
   different patch.
   
   I see a lighter issue with the way Detach tab works: if you create a
   new process you will 1) loose all cached pixmaps, 2) cause the
   Part::queryClose() message to show up if there are unsaved annotations.
   (If you want to reproduce this issue annotate a PDF, click save as,
   open the file you saved, detach its tab).
   
   Both Duplicate tab and Detach tab fail at handling input from -
   (standard input)  
 cat somePdfFile.pdf | okular -
   
   because, by definition, you can't read it twice.
   
   About the issue with moving menu items, I see that all you need to do is
   to add the confirm_tabs_close checkbox, right? Maybe you can just add
   it to the configuration dialog instead or drop it at all (for example
   the warnings from document.cpp warnLimitedAnnotSupport() cannot be
   reactivated).
 So should I remove the duplicate tab feature? It's possible in the master
 code to open the same document in two windows, and it would still be
 possible in this code to manually open the same document to get it in
 another tab. Is that going to be blocked in the future? If not, I don't see
 how duplication causes any additional problems.
 
 Do you agree with the logic to open new documents in the MRU existing
 window? No one has given their opinion on this yet. If not, then it's easy
 to keep documents in the same process and I'll do that.
 
 I'll take a look at the other stuff and upload a new diff when I get some
 time.

Can you please put this comment in reviewboard instead of directly to the 
list? It makes it easier to have stuff centralized in one place.

Thanks,
  Albert

 
 
 - Jonathan
 
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/110914/#review41071
 ---
 
 On Aug. 23, 2013, 8:06 p.m., Jonathan Doman wrote:
  ---
  This is an automatically generated e-mail. To reply, visit:
  http://git.reviewboard.kde.org/r/110914/
  ---
  
  (Updated Aug. 23, 2013, 8:06 p.m.)
  
  
  Review request for Okular.
  
  
  Bugs: 155515
  
  http://bugs.kde.org/show_bug.cgi?id=155515
  
  Repository: okular
  
  
  Description
  ---
  
  This patch adds support for a tabbed interface (multiple documents in one 
window). The core work just adds a tab bar that switches between multiple 
embedded okularparts, but there are many other considerations:
   - Tab context menu allows for duplicating or detaching (detached tabs
   start in new okular process) - `okular file.pdf` will open file in
   existing window if possible, unless --new flag is used. It also selects
   the most recently raised/activated window to use. This mirrors behavior
   I expect from browsers and other tabbed interfaces. - Warns when closing
   window with multiple tabs
   - No warning is given when opening an already open file. This is the
   behavior I strongly prefer (and observe in other programs), but will
   change if there is consensus otherwise. 
  When selecting different tools in one part, the tool selection propagates
  to all parts, but the GUI does not reflect that. This bug is present in
  other programs (e.g. multiple okularparts in Konqueror), so I made no
  attempt to diagnose or fix.
  
  One menu item was added for the multiple tab warning option. When testing
  this, I noticed that items in the Settings menu seem to move around when
  switching tabs, and I cannot diagnose or fix this. It seems to be related
  to XMLGUI bug #64754.
  
  My development branch is also hosted at
  https://github.com/jrmrjnck/okular-tabbed
  
  
  Diffs
  -
  
part.h 4b3aafdb637080ae81eb0e45742f53a34738984d
part.cpp 71c3d0f5d908969ffcf18aba327297ccd2e1c8e1
shell/main.cpp e0ca587ba167c4020d5af5bd33a2dc1b4923cac4
shell/shell.h c065c560fb4ddfcf181601cf35e9ca14581731f6
shell/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-10-16 Thread Albert Astals Cid
El Dimecres, 16 d'octubre de 2013, a les 23:19:51, Albert Astals Cid va 
escriure:
 El Dimecres, 16 d'octubre de 2013, a les 18:36:52, Jonathan Doman va 
escriure:
   On Oct. 1, 2013, 6:57 p.m., Fabio D'Urso wrote:
Hi! :)
I have neither tested nor read the whole patch in depth, I've only had
a
look at your description and made a few tests.

We had a discussion at the okular BOF this summer, and we decided that
it's better to avoid having multiple open copies of the same document,
because this creates consistency issues if you are annotating (while
saving, the two instances will overwrite each other's changes). In the
light of this, I'm not sure Duplicate tab makes sense the way it is
now. In my opinion, a better approach would be to tie multiple
PageViews to the same Document. However, as the Document class
currently assumes that there is only one PageView, this requires
significant changes, so we had better leave this feature for a
different patch.

I see a lighter issue with the way Detach tab works: if you create a
new process you will 1) loose all cached pixmaps, 2) cause the
Part::queryClose() message to show up if there are unsaved
annotations.
(If you want to reproduce this issue annotate a PDF, click save as,
open the file you saved, detach its tab).

Both Duplicate tab and Detach tab fail at handling input from -
(standard input) 

  cat somePdfFile.pdf | okular -

because, by definition, you can't read it twice.

About the issue with moving menu items, I see that all you need to do
is
to add the confirm_tabs_close checkbox, right? Maybe you can just add
it to the configuration dialog instead or drop it at all (for example
the warnings from document.cpp warnLimitedAnnotSupport() cannot be
reactivated).
  
  So should I remove the duplicate tab feature? It's possible in the master
  code to open the same document in two windows, and it would still be
  possible in this code to manually open the same document to get it in
  another tab. Is that going to be blocked in the future? If not, I don't
  see
  how duplication causes any additional problems.
  
  Do you agree with the logic to open new documents in the MRU existing
  window? No one has given their opinion on this yet. If not, then it's easy
  to keep documents in the same process and I'll do that.
  
  I'll take a look at the other stuff and upload a new diff when I get some
  time.
 
 Can you please put this comment in reviewboard instead of directly to the
 list? It makes it easier to have stuff centralized in one place.

Silly me, this was on the reviewboard, just could not find it ^_^

Sorry,
  Albert

 
 Thanks,
   Albert
 
  - Jonathan
  
  
  ---
  This is an automatically generated e-mail. To reply, visit:
  http://git.reviewboard.kde.org/r/110914/#review41071
  ---
  
  On Aug. 23, 2013, 8:06 p.m., Jonathan Doman wrote:
   ---
   This is an automatically generated e-mail. To reply, visit:
   http://git.reviewboard.kde.org/r/110914/
   ---
   
   (Updated Aug. 23, 2013, 8:06 p.m.)
   
   
   Review request for Okular.
   
   
   Bugs: 155515
   
   http://bugs.kde.org/show_bug.cgi?id=155515
   
   Repository: okular
   
   
   Description
   ---
   
   This patch adds support for a tabbed interface (multiple documents in
   one
 
 window). The core work just adds a tab bar that switches between multiple
 
 embedded okularparts, but there are many other considerations:
- Tab context menu allows for duplicating or detaching (detached tabs
start in new okular process) - `okular file.pdf` will open file in
existing window if possible, unless --new flag is used. It also selects
the most recently raised/activated window to use. This mirrors behavior
I expect from browsers and other tabbed interfaces. - Warns when
closing
window with multiple tabs
- No warning is given when opening an already open file. This is the
behavior I strongly prefer (and observe in other programs), but will
change if there is consensus otherwise.
   
   When selecting different tools in one part, the tool selection
   propagates
   to all parts, but the GUI does not reflect that. This bug is present in
   other programs (e.g. multiple okularparts in Konqueror), so I made no
   attempt to diagnose or fix.
   
   One menu item was added for the multiple tab warning option. When
   testing
   this, I noticed that items in the Settings menu seem to move around when
   switching tabs, and I cannot diagnose or fix this. It seems to be
   related
   to XMLGUI bug #64754.
   
   My development branch is also hosted at
   https://github.com/jrmrjnck/okular-tabbed
  

[Okular-devel] [okular] [Bug 326055] Okular crashed while searching and reloading a file

2013-10-16 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=326055

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|NEEDSINFO   |UNCONFIRMED
 Resolution|WAITINGFORINFO  |---

--- Comment #3 from Albert Astals Cid aa...@kde.org ---
Ok, so not easy to repro then. Will try looking at the backtrace and see if we
can get it to make any sense.

Thank for the report :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 326105] Review-Highlight/Note feature

2013-10-16 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=326105

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid aa...@kde.org ---
Hi there, thanks for the report, some questions:

* Which version of poppler are you running?

* Can you reproduce the crash all the time?

* When you say Deleting a Review-created yellow highlighted region over text.
Also to remove a Review-created Note
   You mean:
 A)  it crashes Removing a Review-created yellow highlighted region over
text or Removing a Review-created Note
 B) it crashes if you Remove a Review-created yellow highlighted region
over text and then Remove a Review-created Note
 C) Something else i didn't understand :D

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 326105] Review-Highlight/Note feature

2013-10-16 Thread cinaljess
https://bugs.kde.org/show_bug.cgi?id=326105

--- Comment #2 from cinalj...@gmail.com ---
Poppler-dbg version 0.20.5-1ubuntu3
Poppler-utils version 0.20.05-1ubuntu3
Poppler-data version 0.4.6-2

Unable to recreate crash at current attempts

The program crashed as soon as I right clicked on a highlighted region and
selected Delete. The crash also occurred upon Deleting a Note after
re-loading Okular. Both instances were using a .pdf


On Wed, Oct 16, 2013 at 5:41 PM, Albert Astals Cid aa...@kde.org wrote:

 https://bugs.kde.org/show_bug.cgi?id=326105

 Albert Astals Cid aa...@kde.org changed:

What|Removed |Added

 
  Status|UNCONFIRMED |NEEDSINFO
  CC||aa...@kde.org
  Resolution|--- |WAITINGFORINFO

 --- Comment #1 from Albert Astals Cid aa...@kde.org ---
 Hi there, thanks for the report, some questions:

 * Which version of poppler are you running?

 * Can you reproduce the crash all the time?

 * When you say Deleting a Review-created yellow highlighted region over
 text.
 Also to remove a Review-created Note
You mean:
  A)  it crashes Removing a Review-created yellow highlighted region
 over
 text or Removing a Review-created Note
  B) it crashes if you Remove a Review-created yellow highlighted
 region
 over text and then Remove a Review-created Note
  C) Something else i didn't understand :D

 --
 You are receiving this mail because:
 You reported the bug.


-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 317073] Request to add fade transition to presentation mode

2013-10-16 Thread Yassine SAKOUM
https://bugs.kde.org/show_bug.cgi?id=317073

--- Comment #6 from Yassine SAKOUM karayta...@hotmail.fr ---
(In reply to comment #1)
 Hi. I would like to take up this bug. How to go about it

@Prakhar Mohan
Did you make any progress on the fade transition ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 325876] Loading of a 4.7 pdf takes too long

2013-10-16 Thread Yuri Chornoivan
https://bugs.kde.org/show_bug.cgi?id=325876

Yuri Chornoivan yurc...@ukr.net changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||yurc...@ukr.net
 Resolution|WORKSFORME  |---
 Ever confirmed|0   |1

--- Comment #6 from Yuri Chornoivan yurc...@ukr.net ---
Same long loading with poppler 0.24.2 (git/master now) and Okular git/master.

All configuration files were moved before the file loading to avoid changed
settings influence.

qpdfview loads the document in a same time as Okular, so it is likely that it
can be a problem with poppler.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 317073] Request to add fade transition to presentation mode

2013-10-16 Thread Prakhar Mohan
https://bugs.kde.org/show_bug.cgi?id=317073

--- Comment #7 from Prakhar Mohan prakhar.0...@gmail.com ---
No, sadly I did not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel