Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular

2014-03-20 Thread Saheb Preet Singh

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/
---

(Updated March 20, 2014, 9:55 a.m.)


Review request for Okular.


Bugs: 317073
http://bugs.kde.org/show_bug.cgi?id=317073


Repository: okular


Description
---

implemented fade in and fade out transition for presentation mode in okular.


Diffs (updated)
-

  ui/presentationwidget.h a99b8ce 
  ui/presentationwidget.cpp 4aaec2a 

Diff: https://git.reviewboard.kde.org/r/115532/diff/


Testing
---

It works fine on my system accept for the first time in case of fade out 
transition.


Thanks,

Saheb Preet Singh

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 332331] PDF margins are incorrect when printing because of fit-to-page option

2014-03-20 Thread richardlm
https://bugs.kde.org/show_bug.cgi?id=332331

--- Comment #3 from richardlm richard.l...@gmail.com ---
(In reply to comment #2)
 Oddly enough, setting the printer margins to 0 seems to fix it. I could have
 sworn it had no effect when I tried it earlier. The issue now is the margins
 are not saved, so I have to adjust it everytime I need to print something. 
 
Sadly, this a well known bug:
bug 198172 - printer margin settings are forgotten at restart

 I also see no options within CUPS or hplip to override this (or set the
 hardware margins to 0). The option fit to page exists in hplip, but it's
 already disabled by default.
 
I think if you edit the ppd file by hand it should be possible:
/etc/cups/ppd/yourpostscriptprinter.ppd

but I never tried this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 332372] New: Edit and save (PDF) Document Information

2014-03-20 Thread florian.bw
https://bugs.kde.org/show_bug.cgi?id=332372

Bug ID: 332372
   Summary: Edit and save (PDF) Document Information
Classification: Unclassified
   Product: okular
   Version: 0.18.2
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: florian...@gmail.com

Hi, thanks for the great viewer. 

Okular reads out document information and displays it under properties
(Okular::DocumentInfo). It would be nice if it was possible to edit the
document metadata, and save it back to the document.

For PDFs (and possibly other formats), there are two places to store meta
information: In its document info node, and (starting from version 1.4) in a
XMP metadata node, which allows for more entries, and is mandated by the ISO
standards for PDFs. The info and XMP node should comply about what is written
in Title, and the other properties.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 116700: Launch documents from external sources in new tabs

2014-03-20 Thread Jonathan Doman

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116700/
---

(Updated March 20, 2014, 2:33 p.m.)


Review request for Okular.


Changes
---

Handle multiple command line arguments when there is no existing window. And 
accept DD on the tab bar.


Bugs: 331872 and 332238
http://bugs.kde.org/show_bug.cgi?id=331872
http://bugs.kde.org/show_bug.cgi?id=332238


Repository: okular


Description
---

Currently, tabs can only be created by opening files through okular's file 
dialog. This patch allows external sources (e.g. file browsers) to open 
documents in tabs of existing windows.

Basically, whenever okular is launched it uses D-Bus to search for existing 
okular instances that are capable of handling its documents. An eligible window 
will have enough space for all the documents (space depends on whether tabs are 
allowed or not), and be located on the current desktop. If there are multiple 
eligible windows, one is chosen at random (the first one in the D-Bus 
listing). This metric can be changed in the future, but is the simplest for now.

To facilitate the D-Bus interaction, two methods were added: canOpenDocs is 
used to find an eligible window, openDocument is used to actually open a 
single document. Additionally, tryRaise was modified to work on non-unique 
windows.

I previously thought that okular should behave similar to a web browser, but 
now I think they are very different. Most people open a web browser and then 
search and open links completely within it. However, most people will use 
okular by clicking on files in a file browser. Therefore, I don't think okular 
should ever open tabs in a window on a different desktop.

One shortcoming occurs when one wants to open a document in its own window, but 
instead gets put into a tab. There is no way to detach a tab, so it's 
necessary to then open an empty okular instance and use the file dialog. 
Detaching tabs should be possible, but I guess there are concerns about how to 
do so efficiently.


Diffs (updated)
-

  shell/shell.cpp 01a9f1b1dc1992a4aa1c87330940b27b727608e5 
  shell/shell.h 3b9aae061cd6be0c7a86c885fc06d00d9275bd50 
  part.h 010e9de1f2b5c27531a48b943d821ccc3f3f7205 
  part.cpp 4ce7e28e1071772921e6292e61a88c905a62d7f6 
  shell/main.cpp e0ca587ba167c4020d5af5bd33a2dc1b4923cac4 
  ui/thumbnaillist.h 61601c228512772fd46abc27468523aef562c3fa 
  ui/sidebar.cpp 2474db8c357f6bfd1a9b6bd75091f2eb7b7b7693 
  ui/pageview.cpp dd4199450672c18ebfa146327d8e9b7eb034ddc8 
  ui/sidebar.h 036d7788096366d6bab7d7f2a41d55b7a31d303a 
  ui/pageview.h 577b908633bd0778df33d0a15961ab16071a1500 
  ui/thumbnaillist.cpp 72b557e6624e8229cf1e5e4c5dc69ed77fec54cb 

Diff: https://git.reviewboard.kde.org/r/116700/diff/


Testing
---


Thanks,

Jonathan Doman

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [kdelibs] [Bug 332331] PDF margins are incorrect when printing because of fit-to-page option

2014-03-20 Thread pres1234
https://bugs.kde.org/show_bug.cgi?id=332331

pres1...@teewars.org changed:

   What|Removed |Added

  Component|general |print-dialog
Version|0.18.3  |4.12.3
Product|okular  |kdelibs

--- Comment #4 from pres1...@teewars.org ---
 I think if you edit the ppd file by hand it should be possible:
 /etc/cups/ppd/yourpostscriptprinter.ppd
 
 but I never tried this.

Thanks for pointing that out. I set the hardware margins to 0 0 612 792
within my ppd file. Before printing, this appeared as if it would work. Under
the printer Properties in the print dialog, all of the margins had been set
to 0 (automatically) and the bounding box in the small preview next to it
exactly matched the page size, but when printing, the margins were still off as
before. Setting the margins to 0 explictly within the print dialog (with a
normal ppd) still results in the correct size being printing, so I'm not sure
what's different between the two.

I'm done fooling around with this for now (wasted too much ink/paper). The best
option would be to have a way to disable the fit-to-page option sent to CUPS.
Since that doesn't seem possible currently, I'll just print using lp from the
command line.

Also moved this under kdelibs/print-dialog, since it's a better fit there. This
isn't an issue specific to Okular.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel