Re: [Okular-devel] Review Request 118950: Use correct #include for abs(int)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118950/ --- (Updated Июль 10, 2014, 2:12 п.п.) Review request for Okular, Jon Mease, Luigi Toscano, and Tingnan Zhang. Changes --- Switch to qAbs(); this way neither cstdlib or cmath are needed. Repository: okular Description --- Both C and C++ have abs() function. C one is abs(int), declared in stdlib.h; and C++ has std::abs(int), std::abs(long) and std::abs(long long) in cstdlib.h. But C++ has even more overloaded abs() versions in cmath, that do operate on floating point values. core/utils.cpp incorrectly includes cmath while std::abs() calls near line 140 use integer versions really: std::abs(static_castint(selectedOutput-edid()-width()*10) - szMM.width()) 10 std::abs(static_castint(selectedOutput-edid()-height()*10) - szMM.height()) 10) This patch changes include to cstdlib. Diffs (updated) - core/utils.cpp 71442f0 Diff: https://git.reviewboard.kde.org/r/118950/diff/ Testing --- Tested on OpenBSD/i386. Without this patch, build fails. Thanks, Vadim Zhukov ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 118950: Use correct #include for abs(int)
On Июль 10, 2014, 12:35 д.п., Kai Uwe Broulik wrote: Same as with Review 119133: What about just using qAbs instead of std::abs? Good idea. I've updated a patch. Still works here. - Vadim --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118950/#review62017 --- On Июль 10, 2014, 2:12 п.п., Vadim Zhukov wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118950/ --- (Updated Июль 10, 2014, 2:12 п.п.) Review request for Okular, Jon Mease, Luigi Toscano, and Tingnan Zhang. Repository: okular Description --- Both C and C++ have abs() function. C one is abs(int), declared in stdlib.h; and C++ has std::abs(int), std::abs(long) and std::abs(long long) in cstdlib.h. But C++ has even more overloaded abs() versions in cmath, that do operate on floating point values. core/utils.cpp incorrectly includes cmath while std::abs() calls near line 140 use integer versions really: std::abs(static_castint(selectedOutput-edid()-width()*10) - szMM.width()) 10 std::abs(static_castint(selectedOutput-edid()-height()*10) - szMM.height()) 10) This patch changes include to cstdlib. Diffs - core/utils.cpp 71442f0 Diff: https://git.reviewboard.kde.org/r/118950/diff/ Testing --- Tested on OpenBSD/i386. Without this patch, build fails. Thanks, Vadim Zhukov ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] need guidance
Hello After few glitches I have been able to setup okular build on my system. As advised i have been following mailing list also but i am still lost on where to start. As some of the veteran members have advised to start with trying to fix rookie bugs but still code base is all circle not able to figure out where to get in. It has been repeated numerous times fix small bugs. Thanks in advance -- Regards Palash Kulshreshtha ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336381] easily transfer bookmarks between computers
https://bugs.kde.org/show_bug.cgi?id=336381 --- Comment #6 from Giovanni Triboli giovanni.trib...@gmail.com --- Thank you, Albert, for your reply meanwhile I've installed qtcreator and kdevelop and I've given a look to sources In order to browse the code I need friendly tools I think that when I'll be succeeding in debugging the code I'll start developing something useful (but next week I'll be on vacation) bye for now. Giovanni -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] need guidance
El Dijous, 10 de juliol de 2014, a les 18:24:53, Palash Kulshrestha va escriure: Hello After few glitches I have been able to setup okular build on my system. As advised i have been following mailing list also but i am still lost on where to start. As some of the veteran members have advised to start with trying to fix rookie bugs but still code base is all circle not able to figure out where to get in. It has been repeated numerous times fix small bugs. Thanks in advance Have you decided on a small bug to fix? If so what have you done to try to find where the code related this bug is? Also it's probably easier if you join us live at the #okular irc channel in irc freenode network. Cheers, Albert ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 337209] Memory protection for big pixmaps needs updating, be more smart
https://bugs.kde.org/show_bug.cgi?id=337209 --- Comment #5 from Albert Astals Cid aa...@kde.org --- It does, but does the dvjulibre library support only rendering parts of the file? Anyway that's a different feature to this, if you want to request a wish for it, please do :) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 337209] Memory protection for big pixmaps needs updating, be more smart
https://bugs.kde.org/show_bug.cgi?id=337209 --- Comment #6 from Pino Toscano p...@kde.org --- (In reply to comment #5) It does, but does the dvjulibre library support only rendering parts of the file? Yes, it does. It is even used to not make djvulibre render more than 1500x1500px-big tiles, composing the pieces in case of page sizes bigger than that. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 118950: Use correct #include for abs(int)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118950/ --- (Updated July 10, 2014, 8:37 p.m.) Status -- This change has been marked as submitted. Review request for Okular, Jon Mease, Luigi Toscano, and Tingnan Zhang. Repository: okular Description --- Both C and C++ have abs() function. C one is abs(int), declared in stdlib.h; and C++ has std::abs(int), std::abs(long) and std::abs(long long) in cstdlib.h. But C++ has even more overloaded abs() versions in cmath, that do operate on floating point values. core/utils.cpp incorrectly includes cmath while std::abs() calls near line 140 use integer versions really: std::abs(static_castint(selectedOutput-edid()-width()*10) - szMM.width()) 10 std::abs(static_castint(selectedOutput-edid()-height()*10) - szMM.height()) 10) This patch changes include to cstdlib. Diffs - core/utils.cpp 71442f0 Diff: https://git.reviewboard.kde.org/r/118950/diff/ Testing --- Tested on OpenBSD/i386. Without this patch, build fails. Thanks, Vadim Zhukov ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 335819] Zooming in doesn't work on certain documents.
https://bugs.kde.org/show_bug.cgi?id=335819 --- Comment #12 from Albert Astals Cid aa...@kde.org --- Oh damn, i was able to reproduce something similar one time and then when i went to add debug it went away :/ Do i understand that you know how to compile okular? Would you be able to add some extra debug lines and give me the output so i can try to figure out what's going on? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 118862: Fix two icons in the Tools menu and add an icon for FB backend
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118862/#review62099 --- Where do the fictionbook icons come from? Is something you did? Meanwhile i've commited the other changes for icons - Albert Astals Cid On jun. 21, 2014, 11:34 a.m., Yuri Chornoivan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118862/ --- (Updated jun. 21, 2014, 11:34 a.m.) Review request for Okular. Bugs: 336530 http://bugs.kde.org/show_bug.cgi?id=336530 Repository: okular Description --- Use the available icons from Oxygen for the Tools actions. Add official FictionBook icons for the backends configuration window. Diffs - generators/fictionbook/CMakeLists.txt 4fe3877 generators/fictionbook/generator_fb.cpp 466fb72 ui/pageview.cpp 9073139 Diff: https://git.reviewboard.kde.org/r/118862/diff/ Testing --- Works as expected for git/master. File Attachments FB2 16x16 icon https://git.reviewboard.kde.org/media/uploaded/files/2014/06/21/10e48f57-ec32-49a8-ae3f-52c757695aa2__hi16-app-okular-fb2.png FB2 32x32 icon https://git.reviewboard.kde.org/media/uploaded/files/2014/06/21/53218660-0fd5-4231-8440-e89d0f577cf5__hi32-app-okular-fb2.png FB2 48x48 icon https://git.reviewboard.kde.org/media/uploaded/files/2014/06/21/c648c801-f3b9-4caf-b3a1-fbf03050f13e__hi48-app-okular-fb2.png Thanks, Yuri Chornoivan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336530] okular fails loading the icons select-table and magnifier
https://bugs.kde.org/show_bug.cgi?id=336530 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/okul ||ar/3669e776dcd5ded5921d0c2c ||374571fb26b1a586 --- Comment #1 from Albert Astals Cid aa...@kde.org --- Git commit 3669e776dcd5ded5921d0c2c374571fb26b1a586 by Albert Astals Cid, on behalf of Yuri Chornoivan. Committed on 10/07/2014 at 21:36. Pushed by aacid into branch 'KDE/4.13'. Fix two icons in the Tools menu M +2-2ui/pageview.cpp http://commits.kde.org/okular/3669e776dcd5ded5921d0c2c374571fb26b1a586 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336530] okular fails loading the icons select-table and magnifier
https://bugs.kde.org/show_bug.cgi?id=336530 Albert Astals Cid aa...@kde.org changed: What|Removed |Added CC||aa...@kde.org Version Fixed In||4.13.3 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336133] Crash on exit
https://bugs.kde.org/show_bug.cgi?id=336133 --- Comment #3 from Albert Astals Cid aa...@kde.org --- I'll have to leave it at needsinfo since with this backtrace there's not much we can do, please if it crashes again try to attach the backtrace again and also try to remember if you were right clicking or not. If it doesn't happen for a long while we'll unfortunately have to close the bug as it happened once but we have no clue why so can't really fix it Thanks for caring :) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336388] Starts very slow after closed / closed process hangs
https://bugs.kde.org/show_bug.cgi?id=336388 --- Comment #3 from Albert Astals Cid aa...@kde.org --- well, there's some clipboard problems between qt and what you use, on your Xfce with OpenBox do you also use xfce4-clipman ? What environment are you using when it fails? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336388] Starts very slow after closed / closed process hangs
https://bugs.kde.org/show_bug.cgi?id=336388 --- Comment #4 from Ondřej Hruška on...@ondrovo.com --- It's acting weird on: Openbox, Tint2, xfce4-clipman, LXDM. It's almost vanilla ArchBang. Works good on Openbox, Xfce4-panel, Xfce except XFWM, xfce4-clipman, LXDM. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336617] Feature request: disable fit-to-page while printing.
https://bugs.kde.org/show_bug.cgi?id=336617 Albert Astals Cid aa...@kde.org changed: What|Removed |Added CC||aa...@kde.org --- Comment #1 from Albert Astals Cid aa...@kde.org --- You could also buy a printer with no unprintable areas :/ -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336388] Starts very slow after closed / closed process hangs
https://bugs.kde.org/show_bug.cgi?id=336388 --- Comment #5 from Albert Astals Cid aa...@kde.org --- Do you have this problem with any other Qt/kdelibs based software or only with okular? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336656] high cpu usage with some pdf (exported from libreoffice)
https://bugs.kde.org/show_bug.cgi?id=336656 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|CONFIRMED |RESOLVED CC||aa...@kde.org Resolution|--- |UPSTREAM --- Comment #3 from Albert Astals Cid aa...@kde.org --- This is a problem in poppler the pdf rendering library we use. Please go to https://bugs.freedesktop.org and report a bug against poppler product in the splash renderer component. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336388] Starts very slow after closed / closed process hangs
https://bugs.kde.org/show_bug.cgi?id=336388 --- Comment #6 from Ondřej Hruška on...@ondrovo.com --- Just checked, it's them all - Both Kate and Kwrite have from the same issue. After you close the app window, it hands and then complains about the QClipboard. While it's hung, the same app can't be started (well, it is started, but doesn't show window, until the old one is terminated). Interestingly, I can run Okular while Kate is hung, so it's some per-application mutex kind of thing, it's not global. Hope that helps. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336388] Starts very slow after closed / closed process hangs
https://bugs.kde.org/show_bug.cgi?id=336388 --- Comment #7 from Ondřej Hruška on...@ondrovo.com --- sorry for typos, can't edit :( I meant *have the same issue, *hangs -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336388] Starts very slow after closed / closed process hangs
https://bugs.kde.org/show_bug.cgi?id=336388 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |UPSTREAM --- Comment #8 from Albert Astals Cid aa...@kde.org --- Yes, it's something in Qt not understanding the clibpoard system you have. Unfortunately at this point all i can say is that it's either a kdelibs bug or a Qt bug. I'd vote for a Qt bug, see if you can reproduce it with a symple Qt program like assistant and if you can you can try reporting a bug against Qt upstream at https://bugreports.qt-project.org/ though don't think that they are doing much 4.8 development anymore. I am going to close this bug since it's a bit outside the okular bug realm, sorry i can't really help you more and good luck :) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336388] Starts very slow after closed / closed process hangs
https://bugs.kde.org/show_bug.cgi?id=336388 --- Comment #9 from Albert Astals Cid aa...@kde.org --- I would also suggest you talking with some of the Openbox, Tint2, xfce4-clipman, LXDM as the bug may be hiding there too. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336388] Starts very slow after closed / closed process hangs
https://bugs.kde.org/show_bug.cgi?id=336388 --- Comment #10 from Ondřej Hruška on...@ondrovo.com --- Yeah, no problem, I've already created a shortcut to killall okular, so it's really just a minor annoyance. I'll also try installing some additional kdebase packages, in case I missed something. Thanks for suport ;) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322267] Okular resizes on printing
https://bugs.kde.org/show_bug.cgi?id=322267 Albert Astals Cid aa...@kde.org changed: What|Removed |Added CC||aa...@kde.org --- Comment #29 from Albert Astals Cid aa...@kde.org --- You don't reference it, you pass the options down, not ask them up. Anyway please use reviewboard.kde.org for patches, it's much easier to discuss them there. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334881] Okular blink my screen
https://bugs.kde.org/show_bug.cgi?id=334881 --- Comment #6 from Albert Astals Cid aa...@kde.org --- I am confused, where is okular in that video? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 336617] Feature request: disable fit-to-page while printing.
https://bugs.kde.org/show_bug.cgi?id=336617 --- Comment #2 from Christoph Feck christ...@maxiom.de --- I generated several hundreds PDF documents from TeX files with two pages on a single sheet, separated by a thin line. The line, unfortunately, spans the complete page, and thus now causes the pages to print in reduced size, unless I remember to visit the printer dialog and clear all margins there. Since these settings do not stick, I have to be careful not to forget this on every document I print. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
