[Okular-devel] [okular] [Bug 334251] Tools don't work if any tab is in review mode

2014-10-13 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=334251

--- Comment #4 from Albert Astals Cid aa...@kde.org ---
1 + 2: Because it's what we use to pass around the settings change, you write
the setting and then rely on slotNewConfig to set everything correctly, if you
remove slotNewConfig and writeConfig you're going to need to rewrite lots of
stuff.

3. Because people asked for that feature ;)

People is going to hate you if you remove the features they love and use ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 334251] Tools don't work if any tab is in review mode

2014-10-13 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=334251

--- Comment #6 from Jonathan Doman jonathan.do...@gmail.com ---
So I tested an older version (tag v4.10.97) and this bug exists for multiple
windows as well. It's probably been around forever. And there are similar bugs
for other settings like continuous view mode. Basically I think the global
Settings object is very inadequate for how it's used, and should be
re-architected. I guess I'll keep trying to find a short term solution, though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel