Re: [Okular-devel] Review Request 126192: Fix mainshelltest (and as a side-effect docdata saving)

2015-11-30 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126192/#review88975
---



autotests/mainshelltest.cpp (line 294)


Please leave the single dash, we need to support that since we've supported 
for 10 years, changing the test is not good.



autotests/mainshelltest.cpp (line 339)


This doesn't look like a good thing, why is the exit status now not 0 if it 
was before. Doesn't seem like we should change the test but fix whatever makes 
the test fail, no?



autotests/mainshelltest.cpp (line 439)


Leave the single dash.



core/document.cpp (line 1479)


this change seems unrelated?



core/document.cpp (line 2248)


Is anyone taking care of migrating the old files to the new location or are 
we just losing them all? Not that i want this fixed in this RR but wondering if 
anyone of the people involved in the frameworks port thought about that or not.



core/document.cpp (line 2256)


Remove this variable since you're not using it?



shell/shell.h (line 72)


I don't really think you need the comment here, the master branch is 
correctly using QString, i just think that whoever did the port did not do it 
correctly.



shell/shell.cpp (line 499)


Why do we need this? I would sincerely prefer if the offending calls to 
setActiveTab are fixed instead of just workarounding them


- Albert Astals Cid


On nov. 30, 2015, 8:39 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126192/
> ---
> 
> (Updated nov. 30, 2015, 8:39 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> ---
> 
> Try fixing mainshelltest: one more passes now
> 
> QUrl is not automatically exposed to DBus so the DBus call would fail.
> Changed the parameter to QString instead so that DBus invocation works.
> 
> ---
> 
> Fix crash due to out of bounds list access
> 
> Probably due to differences between KTabWidget and QTabWidget
> 
> ---
> 
> mainshelltest: set QStandardPaths to test mode
> 
> ---
> 
> Parse command line flags with a single dash as a long option
> 
> Unlike KCmdLineArgs QCommandLineParser treats options starting with a
> single minus as multiple short options by default.
> 
> Previously okular -unique would fail with the following error:
> Unknown options: u, n, i, q, u, e.
> 
> Also changed mainshelltest to use two dashes in case this behaviour
> should change in the future.
> 
> mainshelltest failures have been reduced from 15 to 4 by this commit.
> 
> ---
> 
> Fix docdata saving and added a warning message if it fails
> 
> If the ~/.local/okular/docdata directory didn't exist previously
> creating the docdata file would fail as there are missing paths.
> 
> It seems that KStandardDirs used to create the okular/docdata directory
> automatically, with QStandardPaths we have to create it manually.
> 
> mainshelltest is down to one failed test now
> 
> ---
> 
> Fix final test case in mainshelltest
> 
> as we call QProcess::terminate the exit code will not be 0
> 
> 
> Diffs
> -
> 
>   autotests/mainshelltest.cpp 118cfbc1c18fdefad5f933d6de4b85820bfb7379 
>   core/document.cpp 04a29fd1be29f1c464b2d9d08ae20ba9e0b937ef 
>   shell/main.cpp 77847bacb5cdb426089626f63a0ba20c6b12bc9e 
>   shell/okular_main.cpp fdee69458baa0b111be9613e844834b7069fca00 
>   shell/shell.h c16a0b266008c3217f908aa92cc42103d62c5f4a 
>   shell/shell.cpp e69ecbb5e1bde36dbd00e5ff05cdad4e3d2a5f8d 
> 
> Diff: https://git.reviewboard.kde.org/r/126192/diff/
> 
> 
> Testing
> ---
> 
> mainshelltest now passes and documents are opened where I last viewed them
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

2015-11-30 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126193/#review88977
---



generators/chm/generator_chm.cpp (line 32)


Why have you decided to remove the createAboutData methods? We're losing 
functionality and it's not a required change, no?


- Albert Astals Cid


On nov. 28, 2015, 7:28 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126193/
> ---
> 
> (Updated nov. 28, 2015, 7:28 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Two commits:
> 
> ---
> 
> Port to new JSON plugin loading system
> 
> This means Okular can now work without ksycoca and KDELibs4Support.
> 
> ---
> 
> Bring back the about backend dialog
> 
> 
> Diffs
> -
> 
>   generators/plucker/libokularGenerator_plucker.desktop 
> 24756b323ffea2d8c2d0a478f545a00af5be8eda 
>   ui/fileprinterpreview.cpp 47035d63e2d46118eb5247a42d0ccdfacbb79767 
>   part.cpp d8f1750f33a903c1734857042b601b52d8d8e1f2 
>   generators/poppler/CMakeLists.txt 875a5cd583beb7f5457d74b153f5e942b33e4918 
>   generators/poppler/generator_pdf.cpp 
> a65487af06a221cf7faf72e108aa1f04e1b91b04 
>   generators/poppler/libokularGenerator_poppler.desktop 
> 7b7c778380742f55bcc584d9576ff93d2acb5a9f 
>   generators/poppler/libokularGenerator_poppler.json PRE-CREATION 
>   generators/poppler/okularPoppler.desktop 
> a1ef1d8aa270e3b543fdb35e776b48abc7e05de8 
>   generators/spectre/CMakeLists.txt 617047a7c480096e05c329e421283450712b8bef 
>   generators/spectre/generator_ghostview.cpp 
> b84e1e4e9d3d05d065b3e4e0ebd5fabbf6343c3e 
>   generators/spectre/libokularGenerator_ghostview.desktop 
> 552459d07928a0397b2b5d7f21ea510241ae3ff0 
>   generators/spectre/libokularGenerator_ghostview.json PRE-CREATION 
>   generators/txt/libokularGenerator_txt.desktop 
> df6b0623aee49a644a490827cd755bac1e3a39ca 
>   generators/mobipocket/okularMobi.desktop 
> 5a50a33d4c709a26703c9b24be033bdb3ab0419f 
>   generators/ooo/CMakeLists.txt 5d11daf24cb6e4c04448be856877130e72052f10 
>   generators/ooo/generator_ooo.cpp 078173060c9805f876acad5716669c9a76373740 
>   generators/ooo/libokularGenerator_ooo.desktop 
> d769da3d8c94c7035c31cf1469792c82064baede 
>   generators/ooo/okularOoo.desktop f319c8c7aad44ede0228c12461c009184ff77bfc 
>   generators/ooo/libokularGenerator_ooo.json PRE-CREATION 
>   generators/plucker/CMakeLists.txt c37646764818e9147516c696a7320c427636f6f6 
>   generators/plucker/generator_plucker.cpp 
> 3a91ae7c2dceef0e168c6d3856876b8ae2d5c6d1 
>   generators/plucker/libokularGenerator_plucker.json PRE-CREATION 
>   generators/plucker/okularPlucker.desktop 
> 17c5704d2c34eddf7be27d3e81a9c115fa5377df 
>   generators/spectre/okularGhostview.desktop 
> d5bd725d3e0fbad2517f13e83499764000adf1e9 
>   generators/tiff/CMakeLists.txt bab056f16a097e804b9ec8dfda295d4a745bd5b9 
>   generators/tiff/generator_tiff.cpp 31b2e3e09322196c3a36698ebf457b224a34d90f 
>   generators/tiff/libokularGenerator_tiff.desktop 
> 8ca968f655a4b42090e1944354b6981788319854 
>   generators/tiff/libokularGenerator_tiff.json PRE-CREATION 
>   generators/tiff/okularTiff.desktop cfc2b3943fc2c5bb93fac3c26ed75267234135ae 
>   generators/txt/generator_txt.cpp 8c3d2f60ebf12accd87ebfe1630d74e2dfd484ee 
>   generators/txt/CMakeLists.txt faae13a479bb80e507ed8e657ff66d51e391666f 
>   generators/txt/libokularGenerator_txt.json PRE-CREATION 
>   generators/txt/okularTxt.desktop e9dda9f695c474c9176a8b32b3bffcc1519222ac 
>   generators/xps/CMakeLists.txt 6bd8e58488d929ffc6f8a0cd16ef8fd2fa238587 
>   generators/xps/generator_xps.cpp d86dbcb6e0f86f582208cc4110b4980ee28e8c66 
>   generators/xps/libokularGenerator_xps.desktop 
> 173ba72ffe47a4834c5e125b32b969a4c6fac2d3 
>   generators/xps/libokularGenerator_xps.json PRE-CREATION 
>   generators/xps/okularXps.desktop 2e5a2c47cb50180edd22d2ec8b910d8708b854c2 
>   CMakeLists.txt d0b180e08085c58100c84a259de7528159c8a532 
>   core/document.h 63f58741bd6680a673945a7b7c05a10130968beb 
>   generators/mobipocket/libokularGenerator_mobi.json PRE-CREATION 
>   generators/mobipocket/libokularGenerator_mobi.desktop 
> 13a13600e976a2d617d7fb83f03ddeee4d91b738 
>   generators/mobipocket/generator_mobi.cpp 
> 3040745d1b2595d005a543d0cd2c9ecde8d53902 
>   generators/mobipocket/CMakeLists.txt 
> 910623b68ebcf60a07ebaad6d6fd554b816934f5 
>   generators/kimgio/okularKimgio.desktop 
> 983c300cb2ad019c9c98b74d896ae28fb01def2a 
>   generators/kimgio/libokularGenerator_kimgio.json PRE-CREATION 
>   generators/kimgio/libokularGenerator_kimgio.desktop 
> ea483428613943fb3bc0e0535280d4e98c196b68 
>   generators/kimgio/generator_kimgio.cpp 
> 

[Okular-devel] [okular] [Bug 356127] "Save as" dialog for "Save copy as": path editing widget and list widget out of sync

2015-11-30 Thread Luigi Toscano via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356127

Luigi Toscano  changed:

   What|Removed |Added

 CC||luigi.tosc...@tiscali.it

--- Comment #2 from Luigi Toscano  ---
Version 1.0.0 has not been released. You are using an unsupported branch
(frameworks).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

2015-11-30 Thread Alex Richardson


> On Nov. 29, 2015, 5:49 p.m., Albert Astals Cid wrote:
> > there's a few qdebugs in the code, please remove them

I've removed them locally, any other issues?


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126193/#review88927
---


On Nov. 28, 2015, 7:28 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126193/
> ---
> 
> (Updated Nov. 28, 2015, 7:28 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Two commits:
> 
> ---
> 
> Port to new JSON plugin loading system
> 
> This means Okular can now work without ksycoca and KDELibs4Support.
> 
> ---
> 
> Bring back the about backend dialog
> 
> 
> Diffs
> -
> 
>   generators/plucker/libokularGenerator_plucker.desktop 
> 24756b323ffea2d8c2d0a478f545a00af5be8eda 
>   ui/fileprinterpreview.cpp 47035d63e2d46118eb5247a42d0ccdfacbb79767 
>   part.cpp d8f1750f33a903c1734857042b601b52d8d8e1f2 
>   generators/poppler/CMakeLists.txt 875a5cd583beb7f5457d74b153f5e942b33e4918 
>   generators/poppler/generator_pdf.cpp 
> a65487af06a221cf7faf72e108aa1f04e1b91b04 
>   generators/poppler/libokularGenerator_poppler.desktop 
> 7b7c778380742f55bcc584d9576ff93d2acb5a9f 
>   generators/poppler/libokularGenerator_poppler.json PRE-CREATION 
>   generators/poppler/okularPoppler.desktop 
> a1ef1d8aa270e3b543fdb35e776b48abc7e05de8 
>   generators/spectre/CMakeLists.txt 617047a7c480096e05c329e421283450712b8bef 
>   generators/spectre/generator_ghostview.cpp 
> b84e1e4e9d3d05d065b3e4e0ebd5fabbf6343c3e 
>   generators/spectre/libokularGenerator_ghostview.desktop 
> 552459d07928a0397b2b5d7f21ea510241ae3ff0 
>   generators/spectre/libokularGenerator_ghostview.json PRE-CREATION 
>   generators/txt/libokularGenerator_txt.desktop 
> df6b0623aee49a644a490827cd755bac1e3a39ca 
>   generators/mobipocket/okularMobi.desktop 
> 5a50a33d4c709a26703c9b24be033bdb3ab0419f 
>   generators/ooo/CMakeLists.txt 5d11daf24cb6e4c04448be856877130e72052f10 
>   generators/ooo/generator_ooo.cpp 078173060c9805f876acad5716669c9a76373740 
>   generators/ooo/libokularGenerator_ooo.desktop 
> d769da3d8c94c7035c31cf1469792c82064baede 
>   generators/ooo/okularOoo.desktop f319c8c7aad44ede0228c12461c009184ff77bfc 
>   generators/ooo/libokularGenerator_ooo.json PRE-CREATION 
>   generators/plucker/CMakeLists.txt c37646764818e9147516c696a7320c427636f6f6 
>   generators/plucker/generator_plucker.cpp 
> 3a91ae7c2dceef0e168c6d3856876b8ae2d5c6d1 
>   generators/plucker/libokularGenerator_plucker.json PRE-CREATION 
>   generators/plucker/okularPlucker.desktop 
> 17c5704d2c34eddf7be27d3e81a9c115fa5377df 
>   generators/spectre/okularGhostview.desktop 
> d5bd725d3e0fbad2517f13e83499764000adf1e9 
>   generators/tiff/CMakeLists.txt bab056f16a097e804b9ec8dfda295d4a745bd5b9 
>   generators/tiff/generator_tiff.cpp 31b2e3e09322196c3a36698ebf457b224a34d90f 
>   generators/tiff/libokularGenerator_tiff.desktop 
> 8ca968f655a4b42090e1944354b6981788319854 
>   generators/tiff/libokularGenerator_tiff.json PRE-CREATION 
>   generators/tiff/okularTiff.desktop cfc2b3943fc2c5bb93fac3c26ed75267234135ae 
>   generators/txt/generator_txt.cpp 8c3d2f60ebf12accd87ebfe1630d74e2dfd484ee 
>   generators/txt/CMakeLists.txt faae13a479bb80e507ed8e657ff66d51e391666f 
>   generators/txt/libokularGenerator_txt.json PRE-CREATION 
>   generators/txt/okularTxt.desktop e9dda9f695c474c9176a8b32b3bffcc1519222ac 
>   generators/xps/CMakeLists.txt 6bd8e58488d929ffc6f8a0cd16ef8fd2fa238587 
>   generators/xps/generator_xps.cpp d86dbcb6e0f86f582208cc4110b4980ee28e8c66 
>   generators/xps/libokularGenerator_xps.desktop 
> 173ba72ffe47a4834c5e125b32b969a4c6fac2d3 
>   generators/xps/libokularGenerator_xps.json PRE-CREATION 
>   generators/xps/okularXps.desktop 2e5a2c47cb50180edd22d2ec8b910d8708b854c2 
>   CMakeLists.txt d0b180e08085c58100c84a259de7528159c8a532 
>   core/document.h 63f58741bd6680a673945a7b7c05a10130968beb 
>   generators/mobipocket/libokularGenerator_mobi.json PRE-CREATION 
>   generators/mobipocket/libokularGenerator_mobi.desktop 
> 13a13600e976a2d617d7fb83f03ddeee4d91b738 
>   generators/mobipocket/generator_mobi.cpp 
> 3040745d1b2595d005a543d0cd2c9ecde8d53902 
>   generators/mobipocket/CMakeLists.txt 
> 910623b68ebcf60a07ebaad6d6fd554b816934f5 
>   generators/kimgio/okularKimgio.desktop 
> 983c300cb2ad019c9c98b74d896ae28fb01def2a 
>   generators/kimgio/libokularGenerator_kimgio.json PRE-CREATION 
>   generators/kimgio/libokularGenerator_kimgio.desktop 
> ea483428613943fb3bc0e0535280d4e98c196b68 
>   generators/kimgio/generator_kimgio.cpp 
> 5dc9011e454e66965062baf0453bae7c6822d047 
>   generators/kimgio/CMakeLists.txt 

Re: [Okular-devel] Review Request 126192: Fix mainshelltest (and as a side-effect docdata saving)

2015-11-30 Thread Alex Richardson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126192/
---

(Updated Nov. 30, 2015, 8:39 p.m.)


Review request for Okular and Albert Astals Cid.


Repository: okular


Description (updated)
---

---

Try fixing mainshelltest: one more passes now

QUrl is not automatically exposed to DBus so the DBus call would fail.
Changed the parameter to QString instead so that DBus invocation works.

---

Fix crash due to out of bounds list access

Probably due to differences between KTabWidget and QTabWidget

---

mainshelltest: set QStandardPaths to test mode

---

Parse command line flags with a single dash as a long option

Unlike KCmdLineArgs QCommandLineParser treats options starting with a
single minus as multiple short options by default.

Previously okular -unique would fail with the following error:
Unknown options: u, n, i, q, u, e.

Also changed mainshelltest to use two dashes in case this behaviour
should change in the future.

mainshelltest failures have been reduced from 15 to 4 by this commit.

---

Fix docdata saving and added a warning message if it fails

If the ~/.local/okular/docdata directory didn't exist previously
creating the docdata file would fail as there are missing paths.

It seems that KStandardDirs used to create the okular/docdata directory
automatically, with QStandardPaths we have to create it manually.

mainshelltest is down to one failed test now

---

Fix final test case in mainshelltest

as we call QProcess::terminate the exit code will not be 0


Diffs (updated)
-

  autotests/mainshelltest.cpp 118cfbc1c18fdefad5f933d6de4b85820bfb7379 
  core/document.cpp 04a29fd1be29f1c464b2d9d08ae20ba9e0b937ef 
  shell/main.cpp 77847bacb5cdb426089626f63a0ba20c6b12bc9e 
  shell/okular_main.cpp fdee69458baa0b111be9613e844834b7069fca00 
  shell/shell.h c16a0b266008c3217f908aa92cc42103d62c5f4a 
  shell/shell.cpp e69ecbb5e1bde36dbd00e5ff05cdad4e3d2a5f8d 

Diff: https://git.reviewboard.kde.org/r/126192/diff/


Testing
---

mainshelltest now passes and documents are opened where I last viewed them


Thanks,

Alex Richardson

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 356127] New: "Save as" dialog for "Save copy as": path editing widget and list widget out of sync

2015-11-30 Thread Thomas Fischer via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356127

Bug ID: 356127
   Summary: "Save as" dialog for "Save copy as": path editing
widget and list widget out of sync
   Product: okular
   Version: unspecified
  Platform: Gentoo Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: fisc...@unix-ag.uni-kl.de

After a successful "Save copy as" operation, the next save copy as operation
will re-use the previous target directory as its base directory in the "save
as" dialog in the 'directory' path editing widget. The list widget below,
supposed to show the content of this directory (files contained) still shows
the current PDF file's directory's location

Reproducible: Always

Steps to Reproduce:
1. Create temporary directories /tmp/A and /tmp/B
2. Create example PDF files /tmp/A/a.pdf and /tmp/A/b.pdf
3. Open /tmp/A/a.pdf in Okular
4. "Save Copy as" this file as /tmp/B/a.pdf
5. Issue "Save Copy as" a second time to get a "Save as" dialog again. Observe
that the path editing widget shows "/tmp/B" (last location of a successful
"save copy as" operation), whereas the file list widget below shows the content
of "/tmp/A" (the current location of the currently open directory), as you will
see both a.pdf and b.pdf (the latter does not exist in /tmp/B).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 356127] "Save as" dialog for "Save copy as": path editing widget and list widget out of sync

2015-11-30 Thread Thomas Fischer via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356127

--- Comment #1 from Thomas Fischer  ---
When reporting this bug in KDE's Bugzilla, version 1.0.0 was not in the list of
available versions. This should be fixed as well.

I am using Okular 1.0.0 on KDE Frameworks 5.16.0 using Qt 5.5.1 on X11/xcb.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 267350] filling out a PDF form saves data to some file i ~/.kde/share/apps/okular/docdata/

2015-11-30 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=267350

g...@kloss.nz changed:

   What|Removed |Added

 CC||g...@kloss.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

2015-11-30 Thread Alex Richardson


> On Nov. 30, 2015, 9:35 p.m., Albert Astals Cid wrote:
> > generators/chm/generator_chm.cpp, line 32
> > 
> >
> > Why have you decided to remove the createAboutData methods? We're 
> > losing functionality and it's not a required change, no?

They are no longer used in KF5 (K_EXPORT_PLUGIN is a noop) and the information 
there is in the JSON file now


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126193/#review88977
---


On Nov. 28, 2015, 7:28 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126193/
> ---
> 
> (Updated Nov. 28, 2015, 7:28 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Two commits:
> 
> ---
> 
> Port to new JSON plugin loading system
> 
> This means Okular can now work without ksycoca and KDELibs4Support.
> 
> ---
> 
> Bring back the about backend dialog
> 
> 
> Diffs
> -
> 
>   generators/plucker/libokularGenerator_plucker.desktop 
> 24756b323ffea2d8c2d0a478f545a00af5be8eda 
>   ui/fileprinterpreview.cpp 47035d63e2d46118eb5247a42d0ccdfacbb79767 
>   part.cpp d8f1750f33a903c1734857042b601b52d8d8e1f2 
>   generators/poppler/CMakeLists.txt 875a5cd583beb7f5457d74b153f5e942b33e4918 
>   generators/poppler/generator_pdf.cpp 
> a65487af06a221cf7faf72e108aa1f04e1b91b04 
>   generators/poppler/libokularGenerator_poppler.desktop 
> 7b7c778380742f55bcc584d9576ff93d2acb5a9f 
>   generators/poppler/libokularGenerator_poppler.json PRE-CREATION 
>   generators/poppler/okularPoppler.desktop 
> a1ef1d8aa270e3b543fdb35e776b48abc7e05de8 
>   generators/spectre/CMakeLists.txt 617047a7c480096e05c329e421283450712b8bef 
>   generators/spectre/generator_ghostview.cpp 
> b84e1e4e9d3d05d065b3e4e0ebd5fabbf6343c3e 
>   generators/spectre/libokularGenerator_ghostview.desktop 
> 552459d07928a0397b2b5d7f21ea510241ae3ff0 
>   generators/spectre/libokularGenerator_ghostview.json PRE-CREATION 
>   generators/txt/libokularGenerator_txt.desktop 
> df6b0623aee49a644a490827cd755bac1e3a39ca 
>   generators/mobipocket/okularMobi.desktop 
> 5a50a33d4c709a26703c9b24be033bdb3ab0419f 
>   generators/ooo/CMakeLists.txt 5d11daf24cb6e4c04448be856877130e72052f10 
>   generators/ooo/generator_ooo.cpp 078173060c9805f876acad5716669c9a76373740 
>   generators/ooo/libokularGenerator_ooo.desktop 
> d769da3d8c94c7035c31cf1469792c82064baede 
>   generators/ooo/okularOoo.desktop f319c8c7aad44ede0228c12461c009184ff77bfc 
>   generators/ooo/libokularGenerator_ooo.json PRE-CREATION 
>   generators/plucker/CMakeLists.txt c37646764818e9147516c696a7320c427636f6f6 
>   generators/plucker/generator_plucker.cpp 
> 3a91ae7c2dceef0e168c6d3856876b8ae2d5c6d1 
>   generators/plucker/libokularGenerator_plucker.json PRE-CREATION 
>   generators/plucker/okularPlucker.desktop 
> 17c5704d2c34eddf7be27d3e81a9c115fa5377df 
>   generators/spectre/okularGhostview.desktop 
> d5bd725d3e0fbad2517f13e83499764000adf1e9 
>   generators/tiff/CMakeLists.txt bab056f16a097e804b9ec8dfda295d4a745bd5b9 
>   generators/tiff/generator_tiff.cpp 31b2e3e09322196c3a36698ebf457b224a34d90f 
>   generators/tiff/libokularGenerator_tiff.desktop 
> 8ca968f655a4b42090e1944354b6981788319854 
>   generators/tiff/libokularGenerator_tiff.json PRE-CREATION 
>   generators/tiff/okularTiff.desktop cfc2b3943fc2c5bb93fac3c26ed75267234135ae 
>   generators/txt/generator_txt.cpp 8c3d2f60ebf12accd87ebfe1630d74e2dfd484ee 
>   generators/txt/CMakeLists.txt faae13a479bb80e507ed8e657ff66d51e391666f 
>   generators/txt/libokularGenerator_txt.json PRE-CREATION 
>   generators/txt/okularTxt.desktop e9dda9f695c474c9176a8b32b3bffcc1519222ac 
>   generators/xps/CMakeLists.txt 6bd8e58488d929ffc6f8a0cd16ef8fd2fa238587 
>   generators/xps/generator_xps.cpp d86dbcb6e0f86f582208cc4110b4980ee28e8c66 
>   generators/xps/libokularGenerator_xps.desktop 
> 173ba72ffe47a4834c5e125b32b969a4c6fac2d3 
>   generators/xps/libokularGenerator_xps.json PRE-CREATION 
>   generators/xps/okularXps.desktop 2e5a2c47cb50180edd22d2ec8b910d8708b854c2 
>   CMakeLists.txt d0b180e08085c58100c84a259de7528159c8a532 
>   core/document.h 63f58741bd6680a673945a7b7c05a10130968beb 
>   generators/mobipocket/libokularGenerator_mobi.json PRE-CREATION 
>   generators/mobipocket/libokularGenerator_mobi.desktop 
> 13a13600e976a2d617d7fb83f03ddeee4d91b738 
>   generators/mobipocket/generator_mobi.cpp 
> 3040745d1b2595d005a543d0cd2c9ecde8d53902 
>   generators/mobipocket/CMakeLists.txt 
> 910623b68ebcf60a07ebaad6d6fd554b816934f5 
>   generators/kimgio/okularKimgio.desktop 
> 983c300cb2ad019c9c98b74d896ae28fb01def2a 
>