Re: [Okular-devel] Review Request 127351: Added ability to view embedded files

[Daniel Lichtenberger]

> On March 14, 2016, 12:28 a.m., Albert Astals Cid wrote:
> > Could you please fix all the indentation to be like the one in the file?
> 
> Daniel Lichtenberger wrote:
> ui/embeddedfilesdialog.{h,cpp} use both tabs and spaces (even within the 
> same method). Should I just convert them to spaces-only?

The indentation should now match the style used in the method. For better 
maintainability it might still be a good idea to switch ui/embeddedfilesdialog 
completely to Okular's code style (4 spaces per level?).


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127351/#review93500
---


On March 16, 2016, 4:59 p.m., Daniel Lichtenberger wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127351/
> ---
> 
> (Updated March 16, 2016, 4:59 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 295567
> http://bugs.kde.org/show_bug.cgi?id=295567
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> The selected embedded file(s) are extracted to QDir::tempPath() and the
> default application associated with the file type is launched with KRun.
> 
> Double-click on an embedded file also launches the view action.
> 
> The temporary files are cleaned up automatically when the dialog is
> closed.
> 
> 
> Diffs
> -
> 
>   ui/embeddedfilesdialog.h f3e2d038f4ffe2b64af15c94c7ec0cfb8a68834c 
>   ui/embeddedfilesdialog.cpp b400e879b2849a931e069669c984a6b578ffd536 
>   ui/guiutils.h fffe04488b27d92d9a7bc623da653d0c1df87ae8 
>   ui/guiutils.cpp 3bf3ad64b57396792c3aa33298265561ee35ed1a 
> 
> Diff: https://git.reviewboard.kde.org/r/127351/diff/
> 
> 
> Testing
> ---
> 
> Tested with 
> 
> http://www.opf-labs.org/format-corpus/pdfCabinetOfHorrors/fileAttachment.pdf 
> 
> and the PDF file in
> 
> http://www.sdbtransfer.de/app/download/10536876499/SuperSauber1_EDASXbau.zip?t=1453751464
> 
> 
> Thanks,
> 
> Daniel Lichtenberger
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 357626] Please add "Remove bookmark" in popup menu

[Christian Kalkhoff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357626

--- Comment #9 from Christian Kalkhoff  ---
I will try to create a patch for this and add it to this issue before the next
weekend.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 357626] Please add "Remove bookmark" in popup menu

[Basti via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357626

--- Comment #8 from Basti  ---
Ahh sorry. now I understand what you want. You're right, the button doesn't
exist. Sorry for that :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 357626] Please add "Remove bookmark" in popup menu

[Christian Kalkhoff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357626

--- Comment #7 from Christian Kalkhoff  ---
Basti I cannot tell from your screenshot. Is the menu created from main menu ->
Some Bookark -> right click or from the side panel -> Some Bookmark -> right
click.

I get "Delete Bookmark" in the latter but nor the former.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 357626] Please add "Remove bookmark" in popup menu

[Christian Kalkhoff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357626

--- Comment #5 from Christian Kalkhoff  ---
Created attachment 97985
  --> https://bugs.kde.org/attachment.cgi?id=97985=edit
screenshot of the bookmarks context menu

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 357626] Please add "Remove bookmark" in popup menu

[Basti via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357626

--- Comment #6 from Basti  ---
Created attachment 97986
  --> https://bugs.kde.org/attachment.cgi?id=97986=edit
bookmark context menu

Isn't that the menu you want?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 357626] Please add "Remove bookmark" in popup menu

[Christian Kalkhoff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357626

Christian Kalkhoff  changed:

   What|Removed |Added

 CC||e...@softmetz.de

--- Comment #4 from Christian Kalkhoff  ---
Basti, nope there is a context menu for each book mark (right click on it)
which offers to rename the bookmark but not to delete it.

I would like to create a patch for this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Jenkins-kde-ci: okular frameworks kf5-qt5 » Linux,gcc - Build # 89 - Unstable!

[Thomas Friedrichsmeier]

On Thu, 17 Mar 2016 00:41:37 +0100
Albert Astals Cid  wrote:
> The log is at 
> https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/testReport/
> 
> Seems something is very wrong and the pdf plugin can't be found (even
> if it's build)

Yes. The "root symptom" is shown in this test:

---
10:05:35   Start 13: generatorstest
10:05:35 13/14 Test #13: generatorstest ...***Failed
0.51 sec 10:05:35 * Start testing of GeneratorsTest *
10:05:35 Config: Using QtTest library 5.5.1, Qt 5.5.1
(x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 4.9.2)
10:05:35 PASS   : GeneratorsTest::initTestCase() 10:05:35 QWARN  :
GeneratorsTest::testLoadsCorrectly() Could not get KPluginFactory for
"/home/jenkins/builds/okular/kf5-qt5/build/generators/poppler/okularGenerator_poppler.so"
10:05:35 QDEBUG : GeneratorsTest::testLoadsCorrectly() Successfully
loaded 11 generators 10:05:35 FAIL!  :
GeneratorsTest::testLoadsCorrectly() Compared values are not the same
10:05:35Actual   (failures): 1 10:05:35Expected (0)   : 0
10:05:35Loc:
[/home/jenkins/builds/okular/kf5-qt5/autotests/generatorstest.cpp(69)]
10:05:35 PASS   : GeneratorsTest::cleanupTestCase() 10:05:35 Totals: 2
passed, 1 failed, 0 skipped, 0 blacklisted 10:05:35 * Finished
testing of GeneratorsTest *
---

All other failures are essentially a consequence of that.

> https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/consoleFull
> 
> Can you guys make sure that didn't break somehow?

I'm trying to, and I believe it's "not my fault":

1) Failure is limited specifically to the poppler generator, and I did
not even touch that. All other generators apparently continue to load.
2) The libpoppler-qt5 version has changed between builds 88 and 89 (from
0.34.0 to 0.41.0), and this _might_ provide an alternative explanation
for the breakage.
3) Locally (linux; after having fixed my build-dependencies), I cannot
reproduce the failures. PDF plugin loads fine and functions, with and
without my commit. (libpoppler-qt5 0.33.0)

Regards
Thomas


pgpLQrolUF8iR.pgp
Description: OpenPGP digital signature
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127013: Properly show marker for current section in TOC

[Albert Astals Cid]

> On March 10, 2016, 12:28 a.m., Albert Astals Cid wrote:
> > This will put triangles in the whole chain of parent, child, child when the 
> > list is not a treeview, maybe we can also check somewhere else so that the 
> > behaviour does not change when it's not a treeview (i.e. onyl the last one 
> > has the triangle)?
> 
> Miklós Máté wrote:
> Without information about the expanded nodes the best we can do is to put 
> triangles at every containing node. Using only the last node is not good, 
> because it may be hidden within a collapsed parent node.
> 
> Albert Astals Cid wrote:
> I disagree, please change it so that it behaves as it used to behave if 
> it's not a qtreeview.
> 
> Miklós Máté wrote:
> Is it acceptable that only the last highlighted node gets a triangle?

Not sure I understand what you mean with that


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127013/#review93378
---


On March 9, 2016, 8:41 p.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127013/
> ---
> 
> (Updated March 9, 2016, 8:41 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> fixes bug #342076
> 
> 
> Diffs
> -
> 
>   ui/tocmodel.cpp ce93366 
> 
> Diff: https://git.reviewboard.kde.org/r/127013/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 360603] New: Markdown (.md) support

[Thomas Fischer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360603

Bug ID: 360603
   Summary: Markdown (.md) support
   Product: okular
   Version: unspecified
  Platform: unspecified
   URL: https://en.wikipedia.org/wiki/Markdown
OS: All
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: New backend wishes
  Assignee: okular-devel@kde.org
  Reporter: fisc...@unix-ag.uni-kl.de

From Wikipedia: "Markdown is a lightweight markup language with plain text
formatting syntax designed so that it can be converted to HTML and many other
formats using a tool by the same name. Markdown is often used to format readme
files, for writing messages in online discussion forums, and to create rich
text using a plain text editor."

Relevance: Markdown is getting increasingly popular, especially in
Web-base/supported development such as done on Github.

Code: Numerous libraries to convert Markdown into other formats like HTML. As
an example how Markdown is rendered in a Qt application, please see CuteMarkEd
(https://github.com/cloose/CuteMarkEd).

Implementation: In KDE4 times, I would have suggested a KPart which makes use
of an existing third-party library for the Markdown-to-HTML process and then
rendering the result in a KHTML part (or just QTextDocument). However, as
Konqueror for KF5 doesn't seem to happen, Okular is the next best choice as a
viewer.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 314943] Visibility of "This document has embedded files" should be configurable, or at least remembered across sessions

[Daniel Lichtenberger via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=314943

Daniel Lichtenberger  changed:

   What|Removed |Added

 CC||daniel.lichtenber...@gmx.ne
   ||t

--- Comment #1 from Daniel Lichtenberger  ---
These message boxes can be turned off globally via Settings -> Configure Okular
-> General -> Show hints and info messages. It would still be nice to remember
the setting per document, though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Jenkins-kde-ci: okular frameworks kf5-qt5 » Linux,gcc - Build # 89 - Unstable!

[Albert Astals Cid]

El dimecres, 16 de març de 2016, a les 13:50:45 CET, Thomas Friedrichsmeier va 
escriure:
> Hi,
> 
> On Wed, 16 Mar 2016 10:05:57 + (UTC)
> 
> no-re...@kde.org wrote:
> > GENERAL INFO
> > 
> > BUILD UNSTABLE
> > Build URL:
> > https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,com
> > piler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16
> > Mar 2016 09:58:31 + Build duration: 7 min 19 sec
> > 
> > CHANGE SET
> > Revision df0c41212fad2ade6f73b103e57062f99ae20de9 by
> > thomas.friedrichsmeier: (Fix build with MinGW on Windows.) change:
> > edit CMakeLists.txt change: edit mobile/components/CMakeLists.txt
> > 
> >   change: edit interfaces/viewerinterface.h
> 
> Urghs! Sorry.
> 
> I am currently trying to understand what's happening. Unfortunately, I
> can't access the long on Jenkins (503), and locally I see test failures
> even after reverting my commit. Is this really my mess-up?

The log is at 
https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/testReport/

Seems something is very wrong and the pdf plugin can't be found (even if it's 
build)

https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/consoleFull

Can you guys make sure that didn't break somehow?

Cheers,
  Albert

> 
> Regards
> Thomas


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 341043] Highlighting exceeds the margins of the line

[Germano Massullo via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=341043

Germano Massullo  changed:

   What|Removed |Added

Version|0.20.2  |0.24.0

--- Comment #2 from Germano Massullo  ---
Confirming on Plasma desktop 5.5.5

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127366: Resize annotations

[Tobias Deiminger]

> On März 14, 2016, 12:46 vorm., Albert Astals Cid wrote:
> > Looks very nice for a start, congratulations.
> > 
> > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the 
> > > KDE HIG about it?
> > 
> > It's not too bad, i think it would be ok, but if you awnt to try asking in 
> > the kde-usability mailing list it may help (sometimes it does not though, 
> > so be prepared :D)
> > 
> > 
> > > Improve handling when annotation gets so small that resize handles 
> > > overlap.
> > 
> > I guess in that case one could try to always default to one of the corner 
> > ones, so you're forced to make it bigger by 2 dimensions?
> > 
> > 
> > > Find approach how to handle "resize to negative geometry".
> > 
> > I think not letting people go negative is what makes more sense
> > 
> > 
> > > Known Bug: In the thumbnail list, resize handles are drawn too big, and 
> > > not refreshed correctly.
> > 
> > I'd say it makes more sense to not draw the handles at all

Fixed with Revision 2:
-set correct resize mode if page is rotated
-don't allow resize to smaller than 0 x 0
-don't draw resize handles in thumbnail list

Changed:
-resize handles are filled slightly transparent

Drawing the handles is now optional, and only enabled in 
PageView::drawDocumentOnPainter.
Should it be done somewhere else, too? E.g., there is 
active/components/pageitem.cpp, but sadly I don't have a clue when/by whom this 
is used.

Regarding kde-usability mailing list, I think before posting there I'll try to 
find some good KDE reference application and check what they do. I'd consider 
Okular as a good reference app, but it won't help me in this case :-) Some 
ideas come already from gwenview.

Is there something that you think should be done soon, or as next change? If 
not I'll just go on with what comes to my mind, and will probably update here 
in 1..2 weeks.

Btw., sorry, I don't know how inline quote here (using the reviewboard 
webinterface).


- Tobias


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127366/#review93501
---


On März 18, 2016, 8:06 nachm., Tobias Deiminger wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127366/
> ---
> 
> (Updated März 18, 2016, 8:06 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This diff adds a first version of an annotation resize feature to okular (see 
> Bug 18). Do you think the approach is worth carrying on? If so, I'm 
> looking forward to read your comments on everything below, esp. the TODO 
> items.
> 
> Usage:
> If you press Ctrl while mouse cursor is over an annotation, you'll get focus 
> on that annotation. Now keep Ctrl pressed, and move mouse cursor over one of 
> the 8 resize handles (each 10x10 pixels) on the corners/edges. The cursor 
> will change shape to indicate resize mode. Clicking somewhere else on the 
> annotation means "move", just as it was before resize feature was added.
> 
> Notable changes:
> It works by eventually changing AnnotationPrivate::m_boundary and notifying 
> generator (i.e. poppler) about that change, similar to the existing move 
> functionality.
> -Separated annotation state handling out of PageView into a new class 
> MouseAnnotation (ui/pageviewmouseannotation.cpp).
> -Added method Document::resizePageAnnotation, backed by a QUndoCommand class 
> Okular::ResizeAnnotationCommand.
> -Added method Annotation::resize functions and new Annotation flags 
> BeingResized and BeingFocused.
> -Draw resize handles in PagePainter::paintCroppedPageOnPainter
> -Draw only a bounding rectangle during resize, if annotation is rendered 
> externally
> 
> TODO:
> -Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the KDE 
> HIG about it?
> -Feature is currently limited to annotation of type AText and AStamp => 
> extend to all types where applicable.
> -Improve handling when annotation gets so small that resize handles overlap.
> -Reconsider name of class MouseAnnotation. What does it do, and what's a good 
> name for that?
> -Reconsider interface between PageView and MouseAnnotation (currently it's 
> just forwarding UI events together with PageViewItem and event positions).
> -Add test cases once requirements are fixed.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 97e8db6e4a704fd34331fad7b7628ca2248b62d8 
>   core/annotations.h 4f107440dc824fd9049a30082befd18642e63895 
>   core/annotations.cpp e02994688414bdf485b308d6ef122ee2eff3fbaf 
>   core/annotations_p.h 07b124a4fae40b7a983aa382ae824125e6d25746 
>   core/document.h 63f58741bd6680a673945a7b7c05a10130968beb 
>   core/document.cpp 6953b1fb0dc29a375be7ff331a2a2bccce975366 
>   

Re: [Okular-devel] Review Request 127013: Properly show marker for current section in TOC

[Miklós Máté]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127013/
---

(Updated March 17, 2016, 8:12 p.m.)


Review request for Okular.


Changes
---

v4: only show 1 triangle in mobile version


Repository: okular


Description
---

fixes bug #342076


Diffs (updated)
-

  ui/tocmodel.cpp ce93366 

Diff: https://git.reviewboard.kde.org/r/127013/diff/


Testing
---


Thanks,

Miklós Máté

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 341043] Highlighting exceeds the margins of the line

[Germano Massullo via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=341043

--- Comment #4 from Germano Massullo  ---
(In reply to Albert Astals Cid from comment #3)
> The fact that you use plasma desktop or not is unrelated to okular at all,
> and since they are not released together the versioning you gave doesn't
> help either.

Yes but I have also updated the component version

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127351: Added ability to view embedded files

[Daniel Lichtenberger]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127351/
---

(Updated March 16, 2016, 4:59 p.m.)


Review request for Okular.


Changes
---

Made indentation consistent (within methods).


Bugs: 295567
http://bugs.kde.org/show_bug.cgi?id=295567


Repository: okular


Description
---

The selected embedded file(s) are extracted to QDir::tempPath() and the
default application associated with the file type is launched with KRun.

Double-click on an embedded file also launches the view action.

The temporary files are cleaned up automatically when the dialog is
closed.


Diffs (updated)
-

  ui/embeddedfilesdialog.h f3e2d038f4ffe2b64af15c94c7ec0cfb8a68834c 
  ui/embeddedfilesdialog.cpp b400e879b2849a931e069669c984a6b578ffd536 
  ui/guiutils.h fffe04488b27d92d9a7bc623da653d0c1df87ae8 
  ui/guiutils.cpp 3bf3ad64b57396792c3aa33298265561ee35ed1a 

Diff: https://git.reviewboard.kde.org/r/127351/diff/


Testing
---

Tested with 

http://www.opf-labs.org/format-corpus/pdfCabinetOfHorrors/fileAttachment.pdf 

and the PDF file in

http://www.sdbtransfer.de/app/download/10536876499/SuperSauber1_EDASXbau.zip?t=1453751464


Thanks,

Daniel Lichtenberger

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Jenkins-kde-ci: okular frameworks kf5-qt5 » Linux,gcc - Build # 89 - Unstable!

[Thomas Friedrichsmeier]

Hi,

On Wed, 16 Mar 2016 10:05:57 + (UTC)
no-re...@kde.org wrote:
> GENERAL INFO
> 
> BUILD UNSTABLE
> Build URL:
> https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/
> Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Mar 2016
> 09:58:31 + Build duration: 7 min 19 sec
> 
> CHANGE SET
> Revision df0c41212fad2ade6f73b103e57062f99ae20de9 by
> thomas.friedrichsmeier: (Fix build with MinGW on Windows.) change:
> edit CMakeLists.txt change: edit mobile/components/CMakeLists.txt
>   change: edit interfaces/viewerinterface.h

Urghs! Sorry.

I am currently trying to understand what's happening. Unfortunately, I
can't access the long on Jenkins (503), and locally I see test failures
even after reverting my commit. Is this really my mess-up?

Regards
Thomas


pgphD_nArBybb.pgp
Description: OpenPGP digital signature
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel